* [PATCH] Staging: vt6655: Replace byVT3253InitTab_RFMD with byvt3253inittab_rfmd
@ 2016-10-08 18:03 Varsha Rao
0 siblings, 0 replies; 4+ messages in thread
From: Varsha Rao @ 2016-10-08 18:03 UTC (permalink / raw)
To: outreachy-kernel, forest, gregkh; +Cc: rvarsha016
This patch fixes the patchcheck issue of CamelCase.This
is done by replacing byVT3253InitTab_RFMD with
byvt3253inittab_rfmd.
Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
---
drivers/staging/vt6655/baseband.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c
index e739ecc..ff96c5e 100644
--- a/drivers/staging/vt6655/baseband.c
+++ b/drivers/staging/vt6655/baseband.c
@@ -68,7 +68,7 @@
/*--------------------- Static Variables --------------------------*/
#define CB_VT3253_INIT_FOR_RFMD 446
-static const unsigned char byVT3253InitTab_RFMD[CB_VT3253_INIT_FOR_RFMD][2] = {
+static const unsigned char byvt3253inittab_rfmd[CB_VT3253_INIT_FOR_RFMD][2] = {
{0x00, 0x30},
{0x01, 0x00},
{0x02, 0x00},
@@ -2022,8 +2022,8 @@ bool BBbVT3253Init(struct vnt_private *priv)
if (byLocalID <= REV_ID_VT3253_A1) {
for (ii = 0; ii < CB_VT3253_INIT_FOR_RFMD; ii++)
bResult &= BBbWriteEmbedded(priv,
- byVT3253InitTab_RFMD[ii][0],
- byVT3253InitTab_RFMD[ii][1]);
+ byvt3253inittab_rfmd[ii][0],
+ byvt3253inittab_rfmd[ii][1]);
} else {
for (ii = 0; ii < CB_VT3253B0_INIT_FOR_RFMD; ii++)
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Staging: vt6655: Replace byVT3253InitTab_RFMD with BYVT3253INITTAB_RFMD
2016-10-08 14:36 ` Greg KH
@ 2016-10-08 14:50 ` Varsha Rao
0 siblings, 0 replies; 4+ messages in thread
From: Varsha Rao @ 2016-10-08 14:50 UTC (permalink / raw)
To: outreachy-kernel; +Cc: rvarsha016, forest
[-- Attachment #1.1: Type: text/plain, Size: 750 bytes --]
On Saturday, October 8, 2016 at 8:06:51 PM UTC+5:30, gregkh wrote:
>
> On Sat, Oct 08, 2016 at 08:03:43PM +0530, Varsha Rao wrote:
> > This patch fixes the checkpatch issue of CamelCase by replacing
> byVT3253InitTab_RFMD with BYVT3253INITTAB_RFMD.
>
> Please wrap your changelog comments at 72 columns.
>
> And why uppercase this variable? That's horrid to read now, right?
> Please read Documentation/CodingStyle for how to properly name variables
> (hint, upper-case-only is for #defines, not variables.
>
Yeah, it is.Sorry I will rectify it.
>
> >
> > Avoid CamelCase: <byVT3253InitTab_RFMD>
>
> What does that mean?
>
This tells about the checkpatch check which is fixed by this patch.
>
> thanks,
>
> greg k-h
>
[-- Attachment #1.2: Type: text/html, Size: 1257 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Staging: vt6655: Replace byVT3253InitTab_RFMD with BYVT3253INITTAB_RFMD
2016-10-08 14:33 [PATCH] Staging: vt6655: Replace byVT3253InitTab_RFMD with BYVT3253INITTAB_RFMD Varsha Rao
@ 2016-10-08 14:36 ` Greg KH
2016-10-08 14:50 ` Varsha Rao
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2016-10-08 14:36 UTC (permalink / raw)
To: Varsha Rao; +Cc: outreachy-kernel, forest
On Sat, Oct 08, 2016 at 08:03:43PM +0530, Varsha Rao wrote:
> This patch fixes the checkpatch issue of CamelCase by replacing byVT3253InitTab_RFMD with BYVT3253INITTAB_RFMD.
Please wrap your changelog comments at 72 columns.
And why uppercase this variable? That's horrid to read now, right?
Please read Documentation/CodingStyle for how to properly name variables
(hint, upper-case-only is for #defines, not variables.
>
> Avoid CamelCase: <byVT3253InitTab_RFMD>
What does that mean?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Staging: vt6655: Replace byVT3253InitTab_RFMD with BYVT3253INITTAB_RFMD
@ 2016-10-08 14:33 Varsha Rao
2016-10-08 14:36 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Varsha Rao @ 2016-10-08 14:33 UTC (permalink / raw)
To: outreachy-kernel, forest, gregkh; +Cc: rvarsha016
This patch fixes the checkpatch issue of CamelCase by replacing byVT3253InitTab_RFMD with BYVT3253INITTAB_RFMD.
Avoid CamelCase: <byVT3253InitTab_RFMD>
Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
---
drivers/staging/vt6655/baseband.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c
index aa57cfa..b66b854 100644
--- a/drivers/staging/vt6655/baseband.c
+++ b/drivers/staging/vt6655/baseband.c
@@ -68,7 +68,7 @@
/*--------------------- Static Variables --------------------------*/
#define CB_VT3253_INIT_FOR_RFMD 446
-static const unsigned char byVT3253InitTab_RFMD[CB_VT3253_INIT_FOR_RFMD][2] = {
+static const unsigned char BYVT3253INITTAB_RFMD[CB_VT3253_INIT_FOR_RFMD][2] = {
{0x00, 0x30},
{0x01, 0x00},
{0x02, 0x00},
@@ -2022,8 +2022,8 @@ bool BBbVT3253Init(struct vnt_private *priv)
if (byLocalID <= REV_ID_VT3253_A1) {
for (ii = 0; ii < CB_VT3253_INIT_FOR_RFMD; ii++)
bResult &= BBbWriteEmbedded(priv,
- byVT3253InitTab_RFMD[ii][0],
- byVT3253InitTab_RFMD[ii][1]);
+ BYVT3253INITTAB_RFMD[ii][0],
+ BYVT3253INITTAB_RFMD[ii][1]);
} else {
for (ii = 0; ii < CB_VT3253B0_INIT_FOR_RFMD; ii++)
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-08 18:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-08 18:03 [PATCH] Staging: vt6655: Replace byVT3253InitTab_RFMD with byvt3253inittab_rfmd Varsha Rao
-- strict thread matches above, loose matches on Subject: below --
2016-10-08 14:33 [PATCH] Staging: vt6655: Replace byVT3253InitTab_RFMD with BYVT3253INITTAB_RFMD Varsha Rao
2016-10-08 14:36 ` Greg KH
2016-10-08 14:50 ` Varsha Rao
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.