All of lore.kernel.org
 help / color / mirror / Atom feed
From: Elizabeth Ferdman <gnudevliz@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] vc04_services driver question
Date: Sat, 8 Oct 2016 11:29:59 -0700	[thread overview]
Message-ID: <20161008182959.GA2175@localhost> (raw)
In-Reply-To: <20161007125608.GA1317@kroah.com>

On Fri, Oct 07, 2016 at 02:56:08PM +0200, Greg KH wrote:
> On Thu, Oct 06, 2016 at 10:30:34PM -0700, Elizabeth Ferdman wrote:
> > I noticed a new driver vc04_services was just added and that the Kconfig
> > says it depends on BROKEN. The tutorial specifically says not to work on
> > drivers that have that in the depends on line. However, I also noticed
> > that patches were being accepted for rtl8712 and greybus and those
> > have BROKEN in the Kconfig as well... so is it ok to submit patches for
> > that one or even a patchset?
> 
> Yes, but make sure your patches don't make the code worse.  You might be
> able to build BROKEN code under some conditions.
> 
> And the vc04_services code will get that option removed real soon, I
> have a patchset in my queue to fix up the obvious build issues.  Feel
> free to get them out of the driverdevel mailing list archives and apply
> them locally if you wish to start working on that code.
> 

Hey Greg,

I think I figured out how to do that but I think that you did it before
me. I downloaded them off patchwork.kernel.org and did

$ git am --patch-format=mbox path/to/file

I think it failed though since it had already been done.
Anyways, I ran make on the path/to/file.o but I can't get a .o file. Is
it because there's no Makefile in that dir? How do I compile it...?

> thanks,
> 
> greg k-h


      parent reply	other threads:[~2016-10-08 18:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-07  5:30 vc04_services driver question Elizabeth Ferdman
2016-10-07  5:32 ` [Outreachy kernel] " Julia Lawall
2016-10-07 12:56 ` Greg KH
2016-10-08  1:39   ` Elizabeth Ferdman
2016-10-09 14:42     ` Greg KH
2016-10-08 18:29   ` Elizabeth Ferdman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161008182959.GA2175@localhost \
    --to=gnudevliz@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.