All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/4] staging: rtl8188eu: core: removes unecessary parenthesis
       [not found] <cover.1475959255.git.juliana.orod@gmail.com>
@ 2016-10-08 20:48 ` Juliana Rodrigues
  2016-10-08 20:48 ` [PATCH 2/4] staging: rtl8188eu: core: formats long lines and comment blocks Juliana Rodrigues
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 8+ messages in thread
From: Juliana Rodrigues @ 2016-10-08 20:48 UTC (permalink / raw)
  To: outreachy-kernel, gregkh

Removes unecessary parenthesis from rtw_led.c file that were causing
checkpatch warnings.

Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
---
 drivers/staging/rtl8188eu/core/rtw_led.c | 68 ++++++++++++++++----------------
 1 file changed, 34 insertions(+), 34 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_led.c b/drivers/staging/rtl8188eu/core/rtw_led.c
index 14461cf..849f5f3 100644
--- a/drivers/staging/rtl8188eu/core/rtw_led.c
+++ b/drivers/staging/rtl8188eu/core/rtw_led.c
@@ -30,7 +30,7 @@ void BlinkTimerCallback(unsigned long data)
 	if ((padapter->bSurpriseRemoved) || (padapter->bDriverStopped))
 		return;
 
-	schedule_work(&(pLed->BlinkWorkItem));
+	schedule_work(&pLed->BlinkWorkItem);
 }
 
 /*  */
@@ -72,10 +72,10 @@ void InitLed871x(struct adapter *padapter, struct LED_871x *pLed)
 
 	ResetLedStatus(pLed);
 
-	setup_timer(&(pLed->BlinkTimer), BlinkTimerCallback,
+	setup_timer(&pLed->BlinkTimer, BlinkTimerCallback,
 		    (unsigned long)pLed);
 
-	INIT_WORK(&(pLed->BlinkWorkItem), BlinkWorkItemCallback);
+	INIT_WORK(&pLed->BlinkWorkItem, BlinkWorkItemCallback);
 }
 
 
@@ -85,8 +85,8 @@ void InitLed871x(struct adapter *padapter, struct LED_871x *pLed)
 /*  */
 void DeInitLed871x(struct LED_871x *pLed)
 {
-	cancel_work_sync(&(pLed->BlinkWorkItem));
-	del_timer_sync(&(pLed->BlinkTimer));
+	cancel_work_sync(&pLed->BlinkWorkItem);
+	del_timer_sync(&pLed->BlinkTimer);
 	ResetLedStatus(pLed);
 }
 
@@ -99,7 +99,7 @@ void DeInitLed871x(struct LED_871x *pLed)
 static void SwLedBlink1(struct LED_871x *pLed)
 {
 	struct adapter *padapter = pLed->padapter;
-	struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
+	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
 	u8 bStopBlinking = false;
 
 	/*  Change LED according to BlinkingLedState specified. */
@@ -247,9 +247,9 @@ static void SwLedBlink1(struct LED_871x *pLed)
  /* ALPHA, added by chiyoko, 20090106 */
 static void SwLedControlMode1(struct adapter *padapter, enum LED_CTL_MODE LedAction)
 {
-	struct led_priv *ledpriv = &(padapter->ledpriv);
-	struct LED_871x *pLed = &(ledpriv->SwLed0);
-	struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);
+	struct led_priv *ledpriv = &padapter->ledpriv;
+	struct LED_871x *pLed = &ledpriv->SwLed0;
+	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
 
 	switch (LedAction) {
 	case LED_CTL_POWER_ON:
@@ -259,11 +259,11 @@ static void SwLedControlMode1(struct adapter *padapter, enum LED_CTL_MODE LedAct
 			if (pLed->CurrLedState == LED_BLINK_SCAN || IS_LED_WPS_BLINKING(pLed))
 				return;
 			if (pLed->bLedLinkBlinkInProgress) {
-				del_timer_sync(&(pLed->BlinkTimer));
+				del_timer_sync(&pLed->BlinkTimer);
 				pLed->bLedLinkBlinkInProgress = false;
 			}
 			if (pLed->bLedBlinkInProgress) {
-				del_timer_sync(&(pLed->BlinkTimer));
+				del_timer_sync(&pLed->BlinkTimer);
 				pLed->bLedBlinkInProgress = false;
 			}
 
@@ -282,11 +282,11 @@ static void SwLedControlMode1(struct adapter *padapter, enum LED_CTL_MODE LedAct
 			if (pLed->CurrLedState == LED_BLINK_SCAN || IS_LED_WPS_BLINKING(pLed))
 				return;
 			if (pLed->bLedNoLinkBlinkInProgress) {
-				del_timer_sync(&(pLed->BlinkTimer));
+				del_timer_sync(&pLed->BlinkTimer);
 				pLed->bLedNoLinkBlinkInProgress = false;
 			}
 			if (pLed->bLedBlinkInProgress) {
-				del_timer_sync(&(pLed->BlinkTimer));
+				del_timer_sync(&pLed->BlinkTimer);
 				pLed->bLedBlinkInProgress = false;
 			}
 			pLed->bLedLinkBlinkInProgress = true;
@@ -306,15 +306,15 @@ static void SwLedControlMode1(struct adapter *padapter, enum LED_CTL_MODE LedAct
 			if (IS_LED_WPS_BLINKING(pLed))
 				return;
 			if (pLed->bLedNoLinkBlinkInProgress) {
-				del_timer_sync(&(pLed->BlinkTimer));
+				del_timer_sync(&pLed->BlinkTimer);
 				pLed->bLedNoLinkBlinkInProgress = false;
 			}
 			if (pLed->bLedLinkBlinkInProgress) {
-				del_timer_sync(&(pLed->BlinkTimer));
+				del_timer_sync(&pLed->BlinkTimer);
 				 pLed->bLedLinkBlinkInProgress = false;
 			}
 			if (pLed->bLedBlinkInProgress) {
-				del_timer_sync(&(pLed->BlinkTimer));
+				del_timer_sync(&pLed->BlinkTimer);
 				pLed->bLedBlinkInProgress = false;
 			}
 			pLed->bLedScanBlinkInProgress = true;
@@ -334,11 +334,11 @@ static void SwLedControlMode1(struct adapter *padapter, enum LED_CTL_MODE LedAct
 			if (pLed->CurrLedState == LED_BLINK_SCAN || IS_LED_WPS_BLINKING(pLed))
 				return;
 			if (pLed->bLedNoLinkBlinkInProgress) {
-				del_timer_sync(&(pLed->BlinkTimer));
+				del_timer_sync(&pLed->BlinkTimer);
 				pLed->bLedNoLinkBlinkInProgress = false;
 			}
 			if (pLed->bLedLinkBlinkInProgress) {
-				del_timer_sync(&(pLed->BlinkTimer));
+				del_timer_sync(&pLed->BlinkTimer);
 				pLed->bLedLinkBlinkInProgress = false;
 			}
 			pLed->bLedBlinkInProgress = true;
@@ -356,19 +356,19 @@ static void SwLedControlMode1(struct adapter *padapter, enum LED_CTL_MODE LedAct
 	case LED_CTL_START_WPS_BOTTON:
 		 if (!pLed->bLedWPSBlinkInProgress) {
 			if (pLed->bLedNoLinkBlinkInProgress) {
-				del_timer_sync(&(pLed->BlinkTimer));
+				del_timer_sync(&pLed->BlinkTimer);
 				pLed->bLedNoLinkBlinkInProgress = false;
 			}
 			if (pLed->bLedLinkBlinkInProgress) {
-				del_timer_sync(&(pLed->BlinkTimer));
+				del_timer_sync(&pLed->BlinkTimer);
 				 pLed->bLedLinkBlinkInProgress = false;
 			}
 			if (pLed->bLedBlinkInProgress) {
-				del_timer_sync(&(pLed->BlinkTimer));
+				del_timer_sync(&pLed->BlinkTimer);
 				pLed->bLedBlinkInProgress = false;
 			}
 			if (pLed->bLedScanBlinkInProgress) {
-				del_timer_sync(&(pLed->BlinkTimer));
+				del_timer_sync(&pLed->BlinkTimer);
 				pLed->bLedScanBlinkInProgress = false;
 			}
 			pLed->bLedWPSBlinkInProgress = true;
@@ -383,23 +383,23 @@ static void SwLedControlMode1(struct adapter *padapter, enum LED_CTL_MODE LedAct
 		break;
 	case LED_CTL_STOP_WPS:
 		if (pLed->bLedNoLinkBlinkInProgress) {
-			del_timer_sync(&(pLed->BlinkTimer));
+			del_timer_sync(&pLed->BlinkTimer);
 			pLed->bLedNoLinkBlinkInProgress = false;
 		}
 		if (pLed->bLedLinkBlinkInProgress) {
-			del_timer_sync(&(pLed->BlinkTimer));
+			del_timer_sync(&pLed->BlinkTimer);
 			 pLed->bLedLinkBlinkInProgress = false;
 		}
 		if (pLed->bLedBlinkInProgress) {
-			del_timer_sync(&(pLed->BlinkTimer));
+			del_timer_sync(&pLed->BlinkTimer);
 			pLed->bLedBlinkInProgress = false;
 		}
 		if (pLed->bLedScanBlinkInProgress) {
-			del_timer_sync(&(pLed->BlinkTimer));
+			del_timer_sync(&pLed->BlinkTimer);
 			pLed->bLedScanBlinkInProgress = false;
 		}
 		if (pLed->bLedWPSBlinkInProgress)
-			del_timer_sync(&(pLed->BlinkTimer));
+			del_timer_sync(&pLed->BlinkTimer);
 		else
 			pLed->bLedWPSBlinkInProgress = true;
 		pLed->CurrLedState = LED_BLINK_WPS_STOP;
@@ -415,7 +415,7 @@ static void SwLedControlMode1(struct adapter *padapter, enum LED_CTL_MODE LedAct
 		break;
 	case LED_CTL_STOP_WPS_FAIL:
 		if (pLed->bLedWPSBlinkInProgress) {
-			del_timer_sync(&(pLed->BlinkTimer));
+			del_timer_sync(&pLed->BlinkTimer);
 			pLed->bLedWPSBlinkInProgress = false;
 		}
 		pLed->bLedNoLinkBlinkInProgress = true;
@@ -431,23 +431,23 @@ static void SwLedControlMode1(struct adapter *padapter, enum LED_CTL_MODE LedAct
 		pLed->CurrLedState = RTW_LED_OFF;
 		pLed->BlinkingLedState = RTW_LED_OFF;
 		if (pLed->bLedNoLinkBlinkInProgress) {
-			del_timer_sync(&(pLed->BlinkTimer));
+			del_timer_sync(&pLed->BlinkTimer);
 			pLed->bLedNoLinkBlinkInProgress = false;
 		}
 		if (pLed->bLedLinkBlinkInProgress) {
-			del_timer_sync(&(pLed->BlinkTimer));
+			del_timer_sync(&pLed->BlinkTimer);
 			pLed->bLedLinkBlinkInProgress = false;
 		}
 		if (pLed->bLedBlinkInProgress) {
-			del_timer_sync(&(pLed->BlinkTimer));
+			del_timer_sync(&pLed->BlinkTimer);
 			pLed->bLedBlinkInProgress = false;
 		}
 		if (pLed->bLedWPSBlinkInProgress) {
-			del_timer_sync(&(pLed->BlinkTimer));
+			del_timer_sync(&pLed->BlinkTimer);
 			pLed->bLedWPSBlinkInProgress = false;
 		}
 		if (pLed->bLedScanBlinkInProgress) {
-			del_timer_sync(&(pLed->BlinkTimer));
+			del_timer_sync(&pLed->BlinkTimer);
 			pLed->bLedScanBlinkInProgress = false;
 		}
 		SwLedOff(padapter, pLed);
@@ -475,7 +475,7 @@ void BlinkHandler(struct LED_871x *pLed)
 
 void LedControl8188eu(struct adapter *padapter, enum LED_CTL_MODE LedAction)
 {
-	struct led_priv *ledpriv = &(padapter->ledpriv);
+	struct led_priv *ledpriv = &padapter->ledpriv;
 
 	if ((padapter->bSurpriseRemoved) || (padapter->bDriverStopped) ||
 	   (!padapter->hw_init_completed))
-- 
2.10.0



^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH 2/4] staging: rtl8188eu: core: formats long lines and comment blocks
       [not found] <cover.1475959255.git.juliana.orod@gmail.com>
  2016-10-08 20:48 ` [PATCH 1/4] staging: rtl8188eu: core: removes unecessary parenthesis Juliana Rodrigues
@ 2016-10-08 20:48 ` Juliana Rodrigues
  2016-10-09  5:55   ` [Outreachy kernel] " Julia Lawall
  2016-10-09 14:41   ` Greg KH
  2016-10-08 20:49 ` [PATCH 3/4] staging: rtl8188eu: core: removes extra blank lines Juliana Rodrigues
  2016-10-08 20:49 ` [PATCH 4/4] staging: rtl8188eu: core: fixes tabstop alignment Juliana Rodrigues
  3 siblings, 2 replies; 8+ messages in thread
From: Juliana Rodrigues @ 2016-10-08 20:48 UTC (permalink / raw)
  To: outreachy-kernel, gregkh

This patch fixes lines over 80 characters that were causing checkpatch
issues and rewrites some comment blocks to match coding style.

Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
---
 drivers/staging/rtl8188eu/core/rtw_led.c | 58 ++++++++++++++++++++------------
 1 file changed, 37 insertions(+), 21 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_led.c b/drivers/staging/rtl8188eu/core/rtw_led.c
index 849f5f3..f51a196 100644
--- a/drivers/staging/rtl8188eu/core/rtw_led.c
+++ b/drivers/staging/rtl8188eu/core/rtw_led.c
@@ -17,11 +17,11 @@
 #include <drv_types.h>
 #include "rtw_led.h"
 
-/*  */
-/*	Description: */
-/*		Callback function of LED BlinkTimer, */
-/*		it just schedules to corresponding BlinkWorkItem/led_blink_hdl */
-/*  */
+/*	Description:
+ *	Callback function of LED BlinkTimer,
+ *	it just schedules to corresponding
+ *      BlinkWorkItem/led_blink_hdl
+ */
 void BlinkTimerCallback(unsigned long data)
 {
 	struct LED_871x *pLed = (struct LED_871x *)data;
@@ -39,7 +39,9 @@ void BlinkTimerCallback(unsigned long data)
 /*  */
 void BlinkWorkItemCallback(struct work_struct *work)
 {
-	struct LED_871x *pLed = container_of(work, struct LED_871x, BlinkWorkItem);
+	struct LED_871x *pLed = container_of(work,
+					     struct LED_871x,
+					     BlinkWorkItem);
 	BlinkHandler(pLed);
 }
 
@@ -52,11 +54,18 @@ void ResetLedStatus(struct LED_871x *pLed)
 	pLed->CurrLedState = RTW_LED_OFF; /*  Current LED state. */
 	pLed->bLedOn = false; /*  true if LED is ON, false if LED is OFF. */
 
-	pLed->bLedBlinkInProgress = false; /*  true if it is blinking, false o.w.. */
+	pLed->bLedBlinkInProgress = false; /*  true if it is blinking,
+					    *  false o.w..
+					    */
 	pLed->bLedWPSBlinkInProgress = false;
 
-	pLed->BlinkTimes = 0; /*  Number of times to toggle led state for blinking. */
-	pLed->BlinkingLedState = LED_UNKNOWN; /*  Next state for blinking, either RTW_LED_ON or RTW_LED_OFF are. */
+	pLed->BlinkTimes = 0; /*  Number of times to toggle led state
+			       *  for blinking.
+			       */
+	pLed->BlinkingLedState = LED_UNKNOWN; /*  Next state for blinking,
+					       *  either RTW_LED_ON or
+					       *  RTW_LED_OFF are.
+					       */
 
 	pLed->bLedNoLinkBlinkInProgress = false;
 	pLed->bLedLinkBlinkInProgress = false;
@@ -90,11 +99,11 @@ void DeInitLed871x(struct LED_871x *pLed)
 	ResetLedStatus(pLed);
 }
 
-/*  */
-/*	Description: */
-/*		Implementation of LED blinking behavior. */
-/*		It toggle off LED and schedule corresponding timer if necessary. */
-/*  */
+/*	Description:
+ *	Implementation of LED blinking behavior.
+ *	It toggle off LED and schedule corresponding
+ *	timer if necessary.
+ */
 
 static void SwLedBlink1(struct LED_871x *pLed)
 {
@@ -105,10 +114,12 @@ static void SwLedBlink1(struct LED_871x *pLed)
 	/*  Change LED according to BlinkingLedState specified. */
 	if (pLed->BlinkingLedState == RTW_LED_ON) {
 		SwLedOn(padapter, pLed);
-		RT_TRACE(_module_rtl8712_led_c_, _drv_info_, ("Blinktimes (%d): turn on\n", pLed->BlinkTimes));
+		RT_TRACE(_module_rtl8712_led_c_, _drv_info_,
+			 ("Blinktimes (%d): turn on\n", pLed->BlinkTimes));
 	} else {
 		SwLedOff(padapter, pLed);
-		RT_TRACE(_module_rtl8712_led_c_, _drv_info_, ("Blinktimes (%d): turn off\n", pLed->BlinkTimes));
+		RT_TRACE(_module_rtl8712_led_c_, _drv_info_,
+			 ("Blinktimes (%d): turn off\n", pLed->BlinkTimes));
 	}
 
 	if (padapter->pwrctrlpriv.rf_pwrstate != rf_on) {
@@ -245,7 +256,8 @@ static void SwLedBlink1(struct LED_871x *pLed)
 }
 
  /* ALPHA, added by chiyoko, 20090106 */
-static void SwLedControlMode1(struct adapter *padapter, enum LED_CTL_MODE LedAction)
+static void SwLedControlMode1(struct adapter *padapter,
+			      enum LED_CTL_MODE LedAction)
 {
 	struct led_priv *ledpriv = &padapter->ledpriv;
 	struct LED_871x *pLed = &ledpriv->SwLed0;
@@ -256,7 +268,8 @@ static void SwLedControlMode1(struct adapter *padapter, enum LED_CTL_MODE LedAct
 	case LED_CTL_START_TO_LINK:
 	case LED_CTL_NO_LINK:
 		if (!pLed->bLedNoLinkBlinkInProgress) {
-			if (pLed->CurrLedState == LED_BLINK_SCAN || IS_LED_WPS_BLINKING(pLed))
+			if (pLed->CurrLedState == LED_BLINK_SCAN ||
+			    IS_LED_WPS_BLINKING(pLed))
 				return;
 			if (pLed->bLedLinkBlinkInProgress) {
 				del_timer_sync(&pLed->BlinkTimer);
@@ -279,7 +292,8 @@ static void SwLedControlMode1(struct adapter *padapter, enum LED_CTL_MODE LedAct
 		break;
 	case LED_CTL_LINK:
 		if (!pLed->bLedLinkBlinkInProgress) {
-			if (pLed->CurrLedState == LED_BLINK_SCAN || IS_LED_WPS_BLINKING(pLed))
+			if (pLed->CurrLedState == LED_BLINK_SCAN ||
+			    IS_LED_WPS_BLINKING(pLed))
 				return;
 			if (pLed->bLedNoLinkBlinkInProgress) {
 				del_timer_sync(&pLed->BlinkTimer);
@@ -331,7 +345,8 @@ static void SwLedControlMode1(struct adapter *padapter, enum LED_CTL_MODE LedAct
 	case LED_CTL_TX:
 	case LED_CTL_RX:
 		if (!pLed->bLedBlinkInProgress) {
-			if (pLed->CurrLedState == LED_BLINK_SCAN || IS_LED_WPS_BLINKING(pLed))
+			if (pLed->CurrLedState == LED_BLINK_SCAN ||
+			    IS_LED_WPS_BLINKING(pLed))
 				return;
 			if (pLed->bLedNoLinkBlinkInProgress) {
 				del_timer_sync(&pLed->BlinkTimer);
@@ -456,7 +471,8 @@ static void SwLedControlMode1(struct adapter *padapter, enum LED_CTL_MODE LedAct
 		break;
 	}
 
-	RT_TRACE(_module_rtl8712_led_c_, _drv_info_, ("Led %d\n", pLed->CurrLedState));
+	RT_TRACE(_module_rtl8712_led_c_, _drv_info_,
+		 ("Led %d\n", pLed->CurrLedState));
 }
 
 /*  */
-- 
2.10.0



^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH 3/4] staging: rtl8188eu: core: removes extra blank lines
       [not found] <cover.1475959255.git.juliana.orod@gmail.com>
  2016-10-08 20:48 ` [PATCH 1/4] staging: rtl8188eu: core: removes unecessary parenthesis Juliana Rodrigues
  2016-10-08 20:48 ` [PATCH 2/4] staging: rtl8188eu: core: formats long lines and comment blocks Juliana Rodrigues
@ 2016-10-08 20:49 ` Juliana Rodrigues
  2016-10-09  5:50   ` [Outreachy kernel] " Julia Lawall
  2016-10-09 14:41   ` Greg KH
  2016-10-08 20:49 ` [PATCH 4/4] staging: rtl8188eu: core: fixes tabstop alignment Juliana Rodrigues
  3 siblings, 2 replies; 8+ messages in thread
From: Juliana Rodrigues @ 2016-10-08 20:49 UTC (permalink / raw)
  To: outreachy-kernel, gregkh

Removes unecessary blank lines that were causing checkpatch issues.

Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
---
 drivers/staging/rtl8188eu/core/rtw_led.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_led.c b/drivers/staging/rtl8188eu/core/rtw_led.c
index f51a196..147eded 100644
--- a/drivers/staging/rtl8188eu/core/rtw_led.c
+++ b/drivers/staging/rtl8188eu/core/rtw_led.c
@@ -87,7 +87,6 @@ void InitLed871x(struct adapter *padapter, struct LED_871x *pLed)
 	INIT_WORK(&pLed->BlinkWorkItem, BlinkWorkItemCallback);
 }
 
-
 /*  */
 /*	Description: */
 /*		DeInitialize an LED_871x object. */
-- 
2.10.0



^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH 4/4] staging: rtl8188eu: core: fixes tabstop alignment
       [not found] <cover.1475959255.git.juliana.orod@gmail.com>
                   ` (2 preceding siblings ...)
  2016-10-08 20:49 ` [PATCH 3/4] staging: rtl8188eu: core: removes extra blank lines Juliana Rodrigues
@ 2016-10-08 20:49 ` Juliana Rodrigues
  3 siblings, 0 replies; 8+ messages in thread
From: Juliana Rodrigues @ 2016-10-08 20:49 UTC (permalink / raw)
  To: outreachy-kernel, gregkh

Fixes a tabstop alignment checkpatch issue by removing extra blank
spaces.

Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
---
 drivers/staging/rtl8188eu/core/rtw_led.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_led.c b/drivers/staging/rtl8188eu/core/rtw_led.c
index 147eded..e3924f5f 100644
--- a/drivers/staging/rtl8188eu/core/rtw_led.c
+++ b/drivers/staging/rtl8188eu/core/rtw_led.c
@@ -339,7 +339,7 @@ static void SwLedControlMode1(struct adapter *padapter,
 				pLed->BlinkingLedState = RTW_LED_ON;
 			mod_timer(&pLed->BlinkTimer, jiffies +
 				  msecs_to_jiffies(LED_BLINK_SCAN_INTERVAL_ALPHA));
-		 }
+		}
 		break;
 	case LED_CTL_TX:
 	case LED_CTL_RX:
@@ -368,7 +368,7 @@ static void SwLedControlMode1(struct adapter *padapter,
 		break;
 	case LED_CTL_START_WPS: /* wait until xinpin finish */
 	case LED_CTL_START_WPS_BOTTON:
-		 if (!pLed->bLedWPSBlinkInProgress) {
+		if (!pLed->bLedWPSBlinkInProgress) {
 			if (pLed->bLedNoLinkBlinkInProgress) {
 				del_timer_sync(&pLed->BlinkTimer);
 				pLed->bLedNoLinkBlinkInProgress = false;
@@ -393,7 +393,7 @@ static void SwLedControlMode1(struct adapter *padapter,
 				pLed->BlinkingLedState = RTW_LED_ON;
 			mod_timer(&pLed->BlinkTimer, jiffies +
 				  msecs_to_jiffies(LED_BLINK_SCAN_INTERVAL_ALPHA));
-		 }
+		}
 		break;
 	case LED_CTL_STOP_WPS:
 		if (pLed->bLedNoLinkBlinkInProgress) {
-- 
2.10.0



^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [Outreachy kernel] [PATCH 3/4] staging: rtl8188eu: core: removes extra blank lines
  2016-10-08 20:49 ` [PATCH 3/4] staging: rtl8188eu: core: removes extra blank lines Juliana Rodrigues
@ 2016-10-09  5:50   ` Julia Lawall
  2016-10-09 14:41   ` Greg KH
  1 sibling, 0 replies; 8+ messages in thread
From: Julia Lawall @ 2016-10-09  5:50 UTC (permalink / raw)
  To: Juliana Rodrigues; +Cc: outreachy-kernel, gregkh



On Sat, 8 Oct 2016, Juliana Rodrigues wrote:

> Removes unecessary blank lines that were causing checkpatch issues.
>
> Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
> ---
>  drivers/staging/rtl8188eu/core/rtw_led.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_led.c b/drivers/staging/rtl8188eu/core/rtw_led.c
> index f51a196..147eded 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_led.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_led.c
> @@ -87,7 +87,6 @@ void InitLed871x(struct adapter *padapter, struct LED_871x *pLed)
>  	INIT_WORK(&pLed->BlinkWorkItem, BlinkWorkItemCallback);
>  }
>
> -
>  /*  */
>  /*	Description: */
>  /*		DeInitialize an LED_871x object. */

It would be for another patch, but this is definitely not the proper
format for a comment describing a function definition.

julia


> --
> 2.10.0
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20161008204909.GA8819%40spock.
> For more options, visit https://groups.google.com/d/optout.
>


^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [Outreachy kernel] [PATCH 2/4] staging: rtl8188eu: core: formats long lines and comment blocks
  2016-10-08 20:48 ` [PATCH 2/4] staging: rtl8188eu: core: formats long lines and comment blocks Juliana Rodrigues
@ 2016-10-09  5:55   ` Julia Lawall
  2016-10-09 14:41   ` Greg KH
  1 sibling, 0 replies; 8+ messages in thread
From: Julia Lawall @ 2016-10-09  5:55 UTC (permalink / raw)
  To: Juliana Rodrigues; +Cc: outreachy-kernel, gregkh



On Sat, 8 Oct 2016, Juliana Rodrigues wrote:

> This patch fixes lines over 80 characters that were causing checkpatch
> issues and rewrites some comment blocks to match coding style.
>
> Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
> ---
>  drivers/staging/rtl8188eu/core/rtw_led.c | 58 ++++++++++++++++++++------------
>  1 file changed, 37 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_led.c b/drivers/staging/rtl8188eu/core/rtw_led.c
> index 849f5f3..f51a196 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_led.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_led.c
> @@ -17,11 +17,11 @@
>  #include <drv_types.h>
>  #include "rtw_led.h"
>
> -/*  */
> -/*	Description: */
> -/*		Callback function of LED BlinkTimer, */
> -/*		it just schedules to corresponding BlinkWorkItem/led_blink_hdl */
> -/*  */
> +/*	Description:
> + *	Callback function of LED BlinkTimer,
> + *	it just schedules to corresponding
> + *      BlinkWorkItem/led_blink_hdl
> + */
>  void BlinkTimerCallback(unsigned long data)
>  {
>  	struct LED_871x *pLed = (struct LED_871x *)data;
> @@ -39,7 +39,9 @@ void BlinkTimerCallback(unsigned long data)
>  /*  */
>  void BlinkWorkItemCallback(struct work_struct *work)
>  {
> -	struct LED_871x *pLed = container_of(work, struct LED_871x, BlinkWorkItem);
> +	struct LED_871x *pLed = container_of(work,
> +					     struct LED_871x,
> +					     BlinkWorkItem);
>  	BlinkHandler(pLed);
>  }
>
> @@ -52,11 +54,18 @@ void ResetLedStatus(struct LED_871x *pLed)
>  	pLed->CurrLedState = RTW_LED_OFF; /*  Current LED state. */
>  	pLed->bLedOn = false; /*  true if LED is ON, false if LED is OFF. */
>
> -	pLed->bLedBlinkInProgress = false; /*  true if it is blinking, false o.w.. */
> +	pLed->bLedBlinkInProgress = false; /*  true if it is blinking,
> +					    *  false o.w..
> +					    */
>  	pLed->bLedWPSBlinkInProgress = false;
>
> -	pLed->BlinkTimes = 0; /*  Number of times to toggle led state for blinking. */
> -	pLed->BlinkingLedState = LED_UNKNOWN; /*  Next state for blinking, either RTW_LED_ON or RTW_LED_OFF are. */
> +	pLed->BlinkTimes = 0; /*  Number of times to toggle led state
> +			       *  for blinking.
> +			       */
> +	pLed->BlinkingLedState = LED_UNKNOWN; /*  Next state for blinking,
> +					       *  either RTW_LED_ON or
> +					       *  RTW_LED_OFF are.
> +					       */
>
>  	pLed->bLedNoLinkBlinkInProgress = false;
>  	pLed->bLedLinkBlinkInProgress = false;
> @@ -90,11 +99,11 @@ void DeInitLed871x(struct LED_871x *pLed)
>  	ResetLedStatus(pLed);
>  }
>
> -/*  */
> -/*	Description: */
> -/*		Implementation of LED blinking behavior. */
> -/*		It toggle off LED and schedule corresponding timer if necessary. */
> -/*  */
> +/*	Description:
> + *	Implementation of LED blinking behavior.
> + *	It toggle off LED and schedule corresponding
> + *	timer if necessary.
> + */

Hmm, you have adjusted the comment in a smaller numbered patch in the
series.  I have the impression that the patches are numbered in the wrong
order?

In any case, the text is not appropriate for a function comment,  See
kernel-documentation.rst
and examples in other files.

julia

>
>  static void SwLedBlink1(struct LED_871x *pLed)
>  {
> @@ -105,10 +114,12 @@ static void SwLedBlink1(struct LED_871x *pLed)
>  	/*  Change LED according to BlinkingLedState specified. */
>  	if (pLed->BlinkingLedState == RTW_LED_ON) {
>  		SwLedOn(padapter, pLed);
> -		RT_TRACE(_module_rtl8712_led_c_, _drv_info_, ("Blinktimes (%d): turn on\n", pLed->BlinkTimes));
> +		RT_TRACE(_module_rtl8712_led_c_, _drv_info_,
> +			 ("Blinktimes (%d): turn on\n", pLed->BlinkTimes));
>  	} else {
>  		SwLedOff(padapter, pLed);
> -		RT_TRACE(_module_rtl8712_led_c_, _drv_info_, ("Blinktimes (%d): turn off\n", pLed->BlinkTimes));
> +		RT_TRACE(_module_rtl8712_led_c_, _drv_info_,
> +			 ("Blinktimes (%d): turn off\n", pLed->BlinkTimes));
>  	}
>
>  	if (padapter->pwrctrlpriv.rf_pwrstate != rf_on) {
> @@ -245,7 +256,8 @@ static void SwLedBlink1(struct LED_871x *pLed)
>  }
>
>   /* ALPHA, added by chiyoko, 20090106 */
> -static void SwLedControlMode1(struct adapter *padapter, enum LED_CTL_MODE LedAction)
> +static void SwLedControlMode1(struct adapter *padapter,
> +			      enum LED_CTL_MODE LedAction)
>  {
>  	struct led_priv *ledpriv = &padapter->ledpriv;
>  	struct LED_871x *pLed = &ledpriv->SwLed0;
> @@ -256,7 +268,8 @@ static void SwLedControlMode1(struct adapter *padapter, enum LED_CTL_MODE LedAct
>  	case LED_CTL_START_TO_LINK:
>  	case LED_CTL_NO_LINK:
>  		if (!pLed->bLedNoLinkBlinkInProgress) {
> -			if (pLed->CurrLedState == LED_BLINK_SCAN || IS_LED_WPS_BLINKING(pLed))
> +			if (pLed->CurrLedState == LED_BLINK_SCAN ||
> +			    IS_LED_WPS_BLINKING(pLed))
>  				return;
>  			if (pLed->bLedLinkBlinkInProgress) {
>  				del_timer_sync(&pLed->BlinkTimer);
> @@ -279,7 +292,8 @@ static void SwLedControlMode1(struct adapter *padapter, enum LED_CTL_MODE LedAct
>  		break;
>  	case LED_CTL_LINK:
>  		if (!pLed->bLedLinkBlinkInProgress) {
> -			if (pLed->CurrLedState == LED_BLINK_SCAN || IS_LED_WPS_BLINKING(pLed))
> +			if (pLed->CurrLedState == LED_BLINK_SCAN ||
> +			    IS_LED_WPS_BLINKING(pLed))
>  				return;
>  			if (pLed->bLedNoLinkBlinkInProgress) {
>  				del_timer_sync(&pLed->BlinkTimer);
> @@ -331,7 +345,8 @@ static void SwLedControlMode1(struct adapter *padapter, enum LED_CTL_MODE LedAct
>  	case LED_CTL_TX:
>  	case LED_CTL_RX:
>  		if (!pLed->bLedBlinkInProgress) {
> -			if (pLed->CurrLedState == LED_BLINK_SCAN || IS_LED_WPS_BLINKING(pLed))
> +			if (pLed->CurrLedState == LED_BLINK_SCAN ||
> +			    IS_LED_WPS_BLINKING(pLed))
>  				return;
>  			if (pLed->bLedNoLinkBlinkInProgress) {
>  				del_timer_sync(&pLed->BlinkTimer);
> @@ -456,7 +471,8 @@ static void SwLedControlMode1(struct adapter *padapter, enum LED_CTL_MODE LedAct
>  		break;
>  	}
>
> -	RT_TRACE(_module_rtl8712_led_c_, _drv_info_, ("Led %d\n", pLed->CurrLedState));
> +	RT_TRACE(_module_rtl8712_led_c_, _drv_info_,
> +		 ("Led %d\n", pLed->CurrLedState));
>  }
>
>  /*  */
> --
> 2.10.0
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20161008204844.GA8624%40spock.
> For more options, visit https://groups.google.com/d/optout.
>


^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH 2/4] staging: rtl8188eu: core: formats long lines and comment blocks
  2016-10-08 20:48 ` [PATCH 2/4] staging: rtl8188eu: core: formats long lines and comment blocks Juliana Rodrigues
  2016-10-09  5:55   ` [Outreachy kernel] " Julia Lawall
@ 2016-10-09 14:41   ` Greg KH
  1 sibling, 0 replies; 8+ messages in thread
From: Greg KH @ 2016-10-09 14:41 UTC (permalink / raw)
  To: Juliana Rodrigues; +Cc: outreachy-kernel

On Sat, Oct 08, 2016 at 05:48:44PM -0300, Juliana Rodrigues wrote:
> This patch fixes lines over 80 characters that were causing checkpatch
> issues and rewrites some comment blocks to match coding style.

Do not do multiple different things in the same patch, break it up into
one-type-of-thing-per-patch.

thanks,

greg k-h


^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH 3/4] staging: rtl8188eu: core: removes extra blank lines
  2016-10-08 20:49 ` [PATCH 3/4] staging: rtl8188eu: core: removes extra blank lines Juliana Rodrigues
  2016-10-09  5:50   ` [Outreachy kernel] " Julia Lawall
@ 2016-10-09 14:41   ` Greg KH
  1 sibling, 0 replies; 8+ messages in thread
From: Greg KH @ 2016-10-09 14:41 UTC (permalink / raw)
  To: Juliana Rodrigues; +Cc: outreachy-kernel

On Sat, Oct 08, 2016 at 05:49:09PM -0300, Juliana Rodrigues wrote:
> Removes unecessary blank lines that were causing checkpatch issues.

Only one blank line was removed :)



^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-10-09 14:41 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <cover.1475959255.git.juliana.orod@gmail.com>
2016-10-08 20:48 ` [PATCH 1/4] staging: rtl8188eu: core: removes unecessary parenthesis Juliana Rodrigues
2016-10-08 20:48 ` [PATCH 2/4] staging: rtl8188eu: core: formats long lines and comment blocks Juliana Rodrigues
2016-10-09  5:55   ` [Outreachy kernel] " Julia Lawall
2016-10-09 14:41   ` Greg KH
2016-10-08 20:49 ` [PATCH 3/4] staging: rtl8188eu: core: removes extra blank lines Juliana Rodrigues
2016-10-09  5:50   ` [Outreachy kernel] " Julia Lawall
2016-10-09 14:41   ` Greg KH
2016-10-08 20:49 ` [PATCH 4/4] staging: rtl8188eu: core: fixes tabstop alignment Juliana Rodrigues

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.