[PATCH] staging: vt6655: Replace BBvClearFOE by bbvclearfoe

[PATCH] staging: vt6655: Replace BBvClearFOE by bbvclearfoe

[Varsha Rao]

This patch fixes the checkpatch issue by replacing BBvClearFOE with bbvclearfoe.
Avoid CamelCase: <BBvClearFOE>

Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
---
 drivers/staging/vt6655/baseband.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6655/baseband.h b/drivers/staging/vt6655/baseband.h
index 6d9a936..a732fba 100644
--- a/drivers/staging/vt6655/baseband.h
+++ b/drivers/staging/vt6655/baseband.h
@@ -58,7 +58,7 @@
 #define TOP_RATE_2M         0x00200000
 #define TOP_RATE_1M         0x00100000
 
-#define BBvClearFOE(dwIoBase)				\
+#define bbvclearfoe(dwIoBase)				\
 	BBbWriteEmbedded(dwIoBase, 0xB1, 0)
 
 #define BBvSetFOE(dwIoBase)				\
-- 
2.7.4

Re: [Outreachy kernel] [PATCH] staging: vt6655: Replace BBvClearFOE by bbvclearfoe

[Julia Lawall]

On Sat, 8 Oct 2016, Varsha Rao wrote:

> This patch fixes the checkpatch issue by replacing BBvClearFOE with bbvclearfoe.
> Avoid CamelCase: <BBvClearFOE>
>
> Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
> ---
>  drivers/staging/vt6655/baseband.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6655/baseband.h b/drivers/staging/vt6655/baseband.h
> index 6d9a936..a732fba 100644
> --- a/drivers/staging/vt6655/baseband.h
> +++ b/drivers/staging/vt6655/baseband.h
> @@ -58,7 +58,7 @@
>  #define TOP_RATE_2M         0x00200000
>  #define TOP_RATE_1M         0x00100000
>
> -#define BBvClearFOE(dwIoBase)				\
> +#define bbvclearfoe(dwIoBase)				\

Is the macro never used?  It is strange to change a definition without at
least one use.  If there is no use, then the macro can be dropped.

julia

>  	BBbWriteEmbedded(dwIoBase, 0xB1, 0)
>
>  #define BBvSetFOE(dwIoBase)				\
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20161008112506.GA12694%40euri.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH] staging: vt6655: Replace BBvClearFOE by bbvclearfoe

[Varsha Rao]

[-- Attachment #1.1: Type: text/plain, Size: 249 bytes --]



> Is the macro never used?  It is strange to change a definition without at 
> least one use.  If there is no use, then the macro can be dropped. 
>

    No,it is not used anywhere else.I have checked it using grep command .
    I will remove it.

[-- Attachment #1.2: Type: text/html, Size: 430 bytes --]

Re: [Outreachy kernel] [PATCH] staging: vt6655: Replace BBvClearFOE by bbvclearfoe

[Varsha Rao]

[-- Attachment #1.1: Type: text/plain, Size: 628 bytes --]



On Saturday, October 8, 2016 at 11:39:12 PM UTC+5:30, Varsha Rao wrote:
>
>
> Is the macro never used?  It is strange to change a definition without at 
>> least one use.  If there is no use, then the macro can be dropped. 
>>
>
>     No,it is not used anywhere else.I have checked it using grep command .
>     I will remove it.
>

     On executing make command ,after it's removal  gives error.

      In file included from drivers/staging/vt6655/device_main.c:53:0:
     drivers/staging/vt6655/baseband.h:62:34: error: "0xB1" may not appear 
in 
      macro parameter list
      #define BBbWriteEmbedded(iobase, 0xB1, 0)


[-- Attachment #1.2: Type: text/html, Size: 1017 bytes --]

Re: [PATCH] staging: vt6655: Replace BBvClearFOE by bbvclearfoe

[Greg KH]

On Sat, Oct 08, 2016 at 04:55:06PM +0530, Varsha Rao wrote:
> This patch fixes the checkpatch issue by replacing BBvClearFOE with bbvclearfoe.
> Avoid CamelCase: <BBvClearFOE>
> 
> Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
> ---
>  drivers/staging/vt6655/baseband.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vt6655/baseband.h b/drivers/staging/vt6655/baseband.h
> index 6d9a936..a732fba 100644
> --- a/drivers/staging/vt6655/baseband.h
> +++ b/drivers/staging/vt6655/baseband.h
> @@ -58,7 +58,7 @@
>  #define TOP_RATE_2M         0x00200000
>  #define TOP_RATE_1M         0x00100000
>  
> -#define BBvClearFOE(dwIoBase)				\
> +#define bbvclearfoe(dwIoBase)				\
>  	BBbWriteEmbedded(dwIoBase, 0xB1, 0)

As this isn't used at all, why not just remove it?

thanks,

greg k-h

Re: [Outreachy kernel] [PATCH] staging: vt6655: Replace BBvClearFOE by bbvclearfoe

[Julia Lawall]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1435 bytes --]



On Sat, 8 Oct 2016, Varsha Rao wrote:

>
>
> On Saturday, October 8, 2016 at 11:39:12 PM UTC+5:30, Varsha Rao wrote:
>
>             Is the macro never used?  It is strange to change a
>             definition without at
>             least one use.  If there is no use, then the macro
>             can be dropped.
>
>
>           No,it is not used anywhere else.I have checked it using grep
>       command .
>           I will remove it.
>
>
>      On executing make command ,after it's removal  gives error.
>
>       In file included from drivers/staging/vt6655/device_main.c:53:0:
>      drivers/staging/vt6655/baseband.h:62:34: error: "0xB1" may not appear
> in
>       macro parameter list
>       #define BBbWriteEmbedded(iobase, 0xB1, 0)

Where did this code come from?  You should remove the whole definition of
the macro, not just the header line.

julia

>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/d15336f4-5027-4b19-b3fd-
> 52f4fac150c0%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>

Re: [Outreachy kernel] [PATCH] staging: vt6655: Replace BBvClearFOE by bbvclearfoe

[Varsha Rao]

[-- Attachment #1.1: Type: text/plain, Size: 922 bytes --]

: 

> > 
> >             Is the macro never used?  It is strange to change a 
> >             definition without at 
> >             least one use.  If there is no use, then the macro 
> >             can be dropped. 
> > 
> > 
> >           No,it is not used anywhere else.I have checked it using grep 
> >       command . 
> >           I will remove it. 
> > 
> > 
> >      On executing make command ,after it's removal  gives error. 
> > 
> >       In file included from drivers/staging/vt6655/device_main.c:53:0: 
> >      drivers/staging/vt6655/baseband.h:62:34: error: "0xB1" may not 
> appear 
> > in 
> >       macro parameter list 
> >       #define BBbWriteEmbedded(iobase, 0xB1, 0) 
>
> Where did this code come from?  You should remove the whole definition of 
> the macro, not just the header line. 
>
>
   I have tried using grep and gcc -dN -E to find the definition of it.But 
couldn't find through them.

[-- Attachment #1.2: Type: text/html, Size: 1265 bytes --]

Re: [Outreachy kernel] [PATCH] staging: vt6655: Replace BBvClearFOE by bbvclearfoe

[Julia Lawall]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1867 bytes --]



On Tue, 11 Oct 2016, Varsha Rao wrote:

> :
>       >
>       >             Is the macro never used?  It is strange to change
>       a
>       >             definition without at
>       >             least one use.  If there is no use, then the macro
>       >             can be dropped.
>       >
>       >
>       >           No,it is not used anywhere else.I have checked it
>       using grep
>       >       command .
>       >           I will remove it.
>       >
>       >
>       >      On executing make command ,after it's removal  gives
>       error.
>       >
>       >       In file included from
>       drivers/staging/vt6655/device_main.c:53:0:
>       >      drivers/staging/vt6655/baseband.h:62:34: error: "0xB1"
>       may not appear
>       > in
>       >       macro parameter list
>       >       #define BBbWriteEmbedded(iobase, 0xB1, 0)
>
>       Where did this code come from?  You should remove the whole
>       definition of
>       the macro, not just the header line.
>
>
>    I have tried using grep and gcc -dN -E to find the definition of it.But
> couldn't find through them.

The above code is not a proper macro definition.  What is the actual
change that you made?  You can see this by doing git diff on the file.

julia

>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/fd933dbe-c8ef-4f38-ae1c-
> 7f75a8bab6c7%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>

Re: [Outreachy kernel] [PATCH] staging: vt6655: Replace BBvClearFOE by bbvclearfoe

[Varsha Rao]

[-- Attachment #1.1: Type: text/plain, Size: 533 bytes --]



> The above code is not a proper macro definition.  What is the actual 
> change that you made?  You can see this by doing git diff on the file. 
>   
>

    I have posted the patch by making the changes and  but git diff won't 
give information on from where it is imported . Since it is not macro 
definition , it has to be defined    
    somewhere. My question is how to locate the definition of it to remove 
the macro completely? For that I have tried using grep and gcc -dN -E but 
could not locate using them. 

    Varsha

[-- Attachment #1.2: Type: text/html, Size: 730 bytes --]

Re: [Outreachy kernel] [PATCH] staging: vt6655: Replace BBvClearFOE by bbvclearfoe

[Julia Lawall]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1322 bytes --]



On Tue, 11 Oct 2016, Varsha Rao wrote:

>
>       The above code is not a proper macro definition.  What is the
>       actual
>       change that you made?  You can see this by doing git diff on
>       the file.
>        
>
>
>     I have posted the patch by making the changes

Posted it where?  If it is on the mailing list, I no longer have easy
access to it.  Please send it again in response to this message.

thanks,
julia

> and  but git diff won't
> give information on from where it is imported . Since it is not macro
> definition , it has to be defined   
>     somewhere. My question is how to locate the definition of it to remove
> the macro completely? For that I have tried using grep and gcc -dN -E but
> could not locate using them.
>
>     Varsha
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/5a2e45cf-903e-41c4-91d8
> -37d45aea9ce7%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>

Re: [Outreachy kernel] [PATCH] staging: vt6655: Replace BBvClearFOE by bbvclearfoe

[Varsha Rao]

[-- Attachment #1.1: Type: text/plain, Size: 789 bytes --]


This patch fixes the checkpatch issue by replacing BBvClearFOE with 
bbvclearfoe. 

Signed-off-by: Varsha Rao <rvarsha016@gmail.com> 
--- 
 drivers/staging/vt6655/
baseband.h | 2 +- 
 1 file changed, 1 insertion(+), 1 deletion(-) 

diff --git a/drivers/staging/vt6655/baseband.h 
b/drivers/staging/vt6655/baseband.h 
index 6d9a936..a732fba 100644 
--- a/drivers/staging/vt6655/baseband.h 
+++ b/drivers/staging/vt6655/baseband.h 
@@ -58,7 +58,7 @@ 
 #define TOP_RATE_2M         0x00200000 
 #define TOP_RATE_1M         0x00100000 
  
-#define BBvClearFOE(dwIoBase)                                \ 
+#define bbvclearfoe(dwIoBase)                                \ 
         BBbWriteEmbedded(dwIoBase, 0xB1, 0) 
  
 #define BBvSetFOE(dwIoBase)                                \ 
-- 
2.7.4 


[-- Attachment #1.2: Type: text/html, Size: 1163 bytes --]

Re: [Outreachy kernel] [PATCH] staging: vt6655: Replace BBvClearFOE by bbvclearfoe

[Julia Lawall]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1729 bytes --]



On Thu, 13 Oct 2016, Varsha Rao wrote:

>
> This patch fixes the checkpatch issue by replacing BBvClearFOE with
> bbvclearfoe.
>
> Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
> ---
>  drivers/staging/vt6655/baseband.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6655/baseband.h
> b/drivers/staging/vt6655/baseband.h
> index 6d9a936..a732fba 100644
> --- a/drivers/staging/vt6655/baseband.h
> +++ b/drivers/staging/vt6655/baseband.h
> @@ -58,7 +58,7 @@
>  #define TOP_RATE_2M         0x00200000
>  #define TOP_RATE_1M         0x00100000
>  
> -#define BBvClearFOE(dwIoBase)                                \
> +#define bbvclearfoe(dwIoBase)                                \
>          BBbWriteEmbedded(dwIoBase, 0xB1, 0)

I think this is what you sent before, and that the macro is never used?
I have the impression that what you did wrong is to just remove
BBvClearFOE(dwIoBase) and not the entire macro definition (both lines).

julia


>  
>  #define BBvSetFOE(dwIoBase)                                \
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/21e853d5-b5bb-4b00-b1b5-
> 7ec1a38145f6%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>

Re: [Outreachy kernel] [PATCH] staging: vt6655: Replace BBvClearFOE by bbvclearfoe

[Greg KH]

On Thu, Oct 13, 2016 at 05:18:06AM -0700, Varsha Rao wrote:
> 
> This patch fixes the checkpatch issue by replacing BBvClearFOE with
> bbvclearfoe.
> 
> Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
> ---
> �drivers/staging/vt6655/
> baseband.h | 2 +-
> �1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vt6655/baseband.h b/drivers/staging/vt6655/
> baseband.h

Patch is line-wrapped and can not be applied :(

Re: [Outreachy kernel] [PATCH] staging: vt6655: Replace BBvClearFOE by bbvclearfoe

[Greg KH]

On Thu, Oct 13, 2016 at 05:18:06AM -0700, Varsha Rao wrote:
> 
> This patch fixes the checkpatch issue by replacing BBvClearFOE with
> bbvclearfoe.
> 
> Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
> ---
> �drivers/staging/vt6655/
> baseband.h | 2 +-
> �1 file changed, 1 insertion(+), 1 deletion(-)

It's also sent in html format which does not work :(

Re: [Outreachy kernel] [PATCH] staging: vt6655: Replace BBvClearFOE by bbvclearfoe

[Varsha Rao]

[-- Attachment #1.1: Type: text/plain, Size: 115 bytes --]



> It's also sent in html format which does not work :( 
>

  Sorry it's not the patch but reply post for Julia. 

[-- Attachment #1.2: Type: text/html, Size: 293 bytes --]

Re: [Outreachy kernel] [PATCH] staging: vt6655: Replace BBvClearFOE by bbvclearfoe

[Varsha Rao]

[-- Attachment #1.1: Type: text/plain, Size: 419 bytes --]



> I think this is what you sent before, and that the macro is never used?


     Yes, this is the same.  

>
> I have the impression that what you did wrong is to just remove 
> BBvClearFOE(dwIoBase) and not the entire macro definition (both lines). 
>
>    
     I made a mistake there but my question remains the same like how to 
find in what file a macro is stored if it cannot be found by grep or gcc 
-dN -E?  

[-- Attachment #1.2: Type: text/html, Size: 747 bytes --]

Re: [Outreachy kernel] [PATCH] staging: vt6655: Replace BBvClearFOE by bbvclearfoe

[Greg KH]

On Thu, Oct 13, 2016 at 05:37:55AM -0700, Varsha Rao wrote:

Please turn off html email in your email client options.

> 
>     I think this is what you sent before, and that the macro is never used?
> 
> 
> � �� Yes, this is the same.�
> 
> 
>     I have the impression that what you did wrong is to just remove
>     BBvClearFOE(dwIoBase) and not the entire macro definition (both lines).
> 
> 
> ��
> � �� I made a mistake there but my question remains the same like how to find
> in what file a macro is stored if it cannot be found by grep or gcc -dN -E?�

In that case, it is not used, so it can be removed, right?

thanks,

greg k-h

Re: [Outreachy kernel] [PATCH] staging: vt6655: Replace BBvClearFOE by bbvclearfoe

[Vaishali Thakkar]

On Thu, Oct 13, 2016 at 6:07 PM, Varsha Rao <rvarsha016@gmail.com> wrote:
>
>> I think this is what you sent before, and that the macro is never used?
>
>
>      Yes, this is the same.
>>
>>
>> I have the impression that what you did wrong is to just remove
>> BBvClearFOE(dwIoBase) and not the entire macro definition (both lines).
>>
>
>      I made a mistake there but my question remains the same like how to
> find in what file a macro is stored if it cannot be found by grep or gcc -dN
> -E?

What Julia is trying to say, is you are supposed to remove the whole definition,
not just a single line. Which means that you need to remove these 2 lines
[which is the Macro definition] :

#define bbvclearfoe(dwIoBase)                                \
         BBbWriteEmbedded(dwIoBase, 0xB1, 0)

This can be easily seen by git grep. But Git grep shows just the first
line of the
definition. If this is the 2nd time you are sending a patch for the same issue
then the patch should come out as a v2.

Also, I think there are some other macro(s) in the same file which are not used.
They should go away as well.

On a side note, you are supposed to send the replies of mails in a
plain text as well.

> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/a2bc99d4-a161-429c-a7d6-4e9ba3a8b33b%40googlegroups.com.
>
> For more options, visit https://groups.google.com/d/optout.



-- 
Vaishali
http://vaishalithakkar.in/

Re: [Outreachy kernel] [PATCH] staging: vt6655: Replace BBvClearFOE by bbvclearfoe

[Julia Lawall]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 2210 bytes --]



On Thu, 13 Oct 2016, Varsha Rao wrote:

>
>       I think this is what you sent before, and that the macro is
>       never used?
>
>
>      Yes, this is the same. 
>
>       I have the impression that what you did wrong is to just remove
>       BBvClearFOE(dwIoBase) and not the entire macro definition (both
>       lines).
>
>   
>      I made a mistake there but my question remains the same like how to
> find in what file a macro is stored if it cannot be found by grep or gcc -dN
> -E? 

Two points:

1.  If you made the change that I guess you made, then you moved what was
in the body of the macro into the parameter list of the macro.  The
parameter list of the macro is very restricted.  It should only be a lit
of variable names, not arbitrary expressions.

2.  A macro that is never used just disappears from the preprocessed code.
It is not included in the code that is compiled.  So it causes no problem
to have a macro definition in Linux like:

#define never_used(a,b,c) Hello my name is Julia

The expansion of the macro is not valid C code, and refers to lots of
undefined variables, but since they are not used, it doesn't matter.

On the other hand, the patch you sent in the most recent message is
different than the code you were showing as erroneous.  If the patch you
sent is really the thing that you did, then it is possible that you
converted a macro that is never used to a macro that actually is used,
because it is shadowing a function of the same name.  In that case too,
you will have references to symbols that might not exist in the kernel.

In any case, the correct approach is to completely remove the definition.

julia


>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/a2bc99d4-a161-429c-a7d6-
> 4e9ba3a8b33b%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>

Re: [Outreachy kernel] [PATCH] staging: vt6655: Replace BBvClearFOE by bbvclearfoe

[Varsha Rao]

[-- Attachment #1.1: Type: text/plain, Size: 816 bytes --]




>What Julia is trying to say, is you are supposed to remove the whole 
definition, 
>not just a single line. Which means that you need to remove these 2 lines 
>[which is the Macro definition] : 

>#define bbvclearfoe(dwIoBase) \ 
>BBbWriteEmbedded(dwIoBase, 0xB1, 0) 


I understood her point.


>This can be easily seen by git grep. But Git grep shows just the first 
>line of the 
>definition. 


>If this is the 2nd time you are sending a patch for the same issue 
>then the patch should come out as a v2. 


No, it is not second time but I just posted the same patch.

>Also, I think there are some other macro(s) in the same file which are not 
used. 
>They should go away as well. 


I will remove them.


>On a side note, you are supposed to send the replies of mails in a 
>plain text as well. 

       

[-- Attachment #1.2: Type: text/html, Size: 1061 bytes --]

Re: [Outreachy kernel] [PATCH] staging: vt6655: Replace BBvClearFOE by bbvclearfoe

[Varsha Rao]

[-- Attachment #1.1: Type: text/plain, Size: 71 bytes --]


Thanks for your explanation. I will post the new patch with changes. 

[-- Attachment #1.2: Type: text/html, Size: 98 bytes --]