[Qemu-devel] [Bug 1631773] [NEW] hw/dma/pl080.c:354: possible typo ?

[Qemu-devel] [Bug 1631773] [NEW] hw/dma/pl080.c:354: possible typo ?

[dcb]

Public bug reported:

hw/dma/pl080.c:354:1: warning: V578 An odd bitwise operation detected:
s->conf & (0x2 | 0x2). Consider verifying it.

Source code is

       if (s->conf & (PL080_CONF_M1 | PL080_CONF_M1)) {

Maybe better code

       if (s->conf & (PL080_CONF_M1 | PL080_CONF_M2)) {

** Affects: qemu
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1631773

Title:
  hw/dma/pl080.c:354: possible typo ?

Status in QEMU:
  New

Bug description:
  hw/dma/pl080.c:354:1: warning: V578 An odd bitwise operation detected:
  s->conf & (0x2 | 0x2). Consider verifying it.

  Source code is

         if (s->conf & (PL080_CONF_M1 | PL080_CONF_M1)) {

  Maybe better code

         if (s->conf & (PL080_CONF_M1 | PL080_CONF_M2)) {

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1631773/+subscriptions

[Qemu-devel] [Bug 1631773] Re: hw/dma/pl080.c:354: possible typo ?

[T. Huth]

Thanks for reporting the issue, patch has now been included here:
http://git.qemu.org/?p=qemu.git;a=commitdiff;h=04bb79d1f519ae190a

** Changed in: qemu
       Status: New => Fix Committed

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1631773

Title:
  hw/dma/pl080.c:354: possible typo ?

Status in QEMU:
  Fix Committed

Bug description:
  hw/dma/pl080.c:354:1: warning: V578 An odd bitwise operation detected:
  s->conf & (0x2 | 0x2). Consider verifying it.

  Source code is

         if (s->conf & (PL080_CONF_M1 | PL080_CONF_M1)) {

  Maybe better code

         if (s->conf & (PL080_CONF_M1 | PL080_CONF_M2)) {

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1631773/+subscriptions

[Qemu-devel] [Bug 1631773] Re: hw/dma/pl080.c:354: possible typo ?

[Thomas Huth]

Released with version 2.8.

** Changed in: qemu
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1631773

Title:
  hw/dma/pl080.c:354: possible typo ?

Status in QEMU:
  Fix Released

Bug description:
  hw/dma/pl080.c:354:1: warning: V578 An odd bitwise operation detected:
  s->conf & (0x2 | 0x2). Consider verifying it.

  Source code is

         if (s->conf & (PL080_CONF_M1 | PL080_CONF_M1)) {

  Maybe better code

         if (s->conf & (PL080_CONF_M1 | PL080_CONF_M2)) {

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1631773/+subscriptions