[PATCH] tc: f_u32: Fill in 'linkid' provided by user

[PATCH] tc: f_u32: Fill in 'linkid' provided by user

[Sushma Sitaram]

Currently, 'linkid' input by the user is parsed but 'handle' is appended to the netlink message.

# tc filter add dev enp1s0f1 protocol ip parent ffff: prio 99 u32 ht 800: \
	order 1 link 1: offset at 0 mask 0f00 shift 6 plus 0 eat match ip \
	protocol 6 ff

resulted in:
filter protocol ip pref 99 u32 fh 800::1 order 1 key ht 800 bkt 0
  match 00060000/00ff0000 at 8
    offset 0f00>>6 at 0  eat

This patch results in:
filter protocol ip pref 99 u32 fh 800::1 order 1 key ht 800 bkt 0 link 1:
  match 00060000/00ff0000 at 8
    offset 0f00>>6 at 0  eat


Signed-off-by Sushma Sitaram: Sushma Sitaram <sushma.sitaram@intel.com>
---
 tc/f_u32.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tc/f_u32.c b/tc/f_u32.c
index 0ad7ed2..92c1fcd 100644
--- a/tc/f_u32.c
+++ b/tc/f_u32.c
@@ -1071,7 +1071,7 @@ static int u32_parse_opt(struct filter_util *qu, char *handle,
 				fprintf(stderr, "\"link\" must be a hash table.\n");
 				return -1;
 			}
-			addattr_l(n, MAX_MSG, TCA_U32_LINK, &handle, 4);
+			addattr_l(n, MAX_MSG, TCA_U32_LINK, &linkid, 4);
 		} else if (strcmp(*argv, "ht") == 0) {
 			unsigned int ht;
 

Re: [PATCH] tc: f_u32: Fill in 'linkid' provided by user

[Stephen Hemminger]

On Wed, 28 Sep 2016 11:30:16 -0700
Sushma Sitaram <sushma.sitaram@intel.com> wrote:

> Currently, 'linkid' input by the user is parsed but 'handle' is appended to the netlink message.
> 
> # tc filter add dev enp1s0f1 protocol ip parent ffff: prio 99 u32 ht 800: \
> 	order 1 link 1: offset at 0 mask 0f00 shift 6 plus 0 eat match ip \
> 	protocol 6 ff
> 
> resulted in:
> filter protocol ip pref 99 u32 fh 800::1 order 1 key ht 800 bkt 0
>   match 00060000/00ff0000 at 8
>     offset 0f00>>6 at 0  eat
> 
> This patch results in:
> filter protocol ip pref 99 u32 fh 800::1 order 1 key ht 800 bkt 0 link 1:
>   match 00060000/00ff0000 at 8
>     offset 0f00>>6 at 0  eat
> 
> 
> Signed-off-by Sushma Sitaram: Sushma Sitaram <sushma.sitaram@intel.com>

Applied (for 4.8).