All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>,
	intel-gfx@lists.freedesktop.org, stable@vger.kernel.org,
	Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/gen9: unconditionally apply the memory bandwidth WA
Date: Tue, 11 Oct 2016 13:10:13 +0200	[thread overview]
Message-ID: <20161011111013.GA10805@kroah.com> (raw)
In-Reply-To: <87a8ebqhpq.fsf@intel.com>

On Tue, Oct 11, 2016 at 01:54:09PM +0300, Jani Nikula wrote:
> On Tue, 11 Oct 2016, Greg KH <greg@kroah.com> wrote:
> > On Tue, Oct 11, 2016 at 10:34:14AM +0300, Jani Nikula wrote:
> >> On Mon, 10 Oct 2016, Paulo Zanoni <paulo.r.zanoni@intel.com> wrote:
> >> The patch is a bit on the large side for stable. 100 lines with context
> >> is the rule.
> >
> > Huh?  It's only 49 line of changes:
> >
> >> >  drivers/gpu/drm/i915/intel_pm.c | 49 ++++++++++++++++++++++++++++++++++-------
> >> >  1 file changed, 41 insertions(+), 8 deletions(-)
> >
> > That's fine for stable, we take i915 stable patches much bigger than
> > that all the time :)
> 
> Oh, I thought the rule was "100 lines, with context", but I certainly
> won't argue! Never mind! ;)

It's the "official" rule, yes, but really, context of the patch itself
(i.e. what it does), is the key thing.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org,
	Paulo Zanoni <paulo.r.zanoni@intel.com>,
	stable@vger.kernel.org,
	Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Subject: Re: [PATCH 1/2] drm/i915/gen9: unconditionally apply the memory bandwidth WA
Date: Tue, 11 Oct 2016 13:10:13 +0200	[thread overview]
Message-ID: <20161011111013.GA10805@kroah.com> (raw)
In-Reply-To: <87a8ebqhpq.fsf@intel.com>

On Tue, Oct 11, 2016 at 01:54:09PM +0300, Jani Nikula wrote:
> On Tue, 11 Oct 2016, Greg KH <greg@kroah.com> wrote:
> > On Tue, Oct 11, 2016 at 10:34:14AM +0300, Jani Nikula wrote:
> >> On Mon, 10 Oct 2016, Paulo Zanoni <paulo.r.zanoni@intel.com> wrote:
> >> The patch is a bit on the large side for stable. 100 lines with context
> >> is the rule.
> >
> > Huh?  It's only 49 line of changes:
> >
> >> >  drivers/gpu/drm/i915/intel_pm.c | 49 ++++++++++++++++++++++++++++++++++-------
> >> >  1 file changed, 41 insertions(+), 8 deletions(-)
> >
> > That's fine for stable, we take i915 stable patches much bigger than
> > that all the time :)
> 
> Oh, I thought the rule was "100 lines, with context", but I certainly
> won't argue! Never mind! ;)

It's the "official" rule, yes, but really, context of the patch itself
(i.e. what it does), is the key thing.

thanks,

greg k-h
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-10-11 11:10 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-10 20:30 [PATCH 1/2] drm/i915/gen9: unconditionally apply the memory bandwidth WA Paulo Zanoni
2016-10-10 20:30 ` [PATCH 2/2] drm/i915/gen9: look for adjusted_mode in the SAGV check for interlaced Paulo Zanoni
2016-10-10 20:55   ` Lyude Paul
2016-10-10 20:34 ` [PATCH 1/2] drm/i915/gen9: unconditionally apply the memory bandwidth WA Lyude Paul
2016-10-10 20:46   ` Zanoni, Paulo R
2016-10-10 20:55     ` Lyude Paul
2016-10-10 20:55       ` Lyude Paul
2016-10-11 18:25       ` Paulo Zanoni
2016-10-11 18:25         ` Paulo Zanoni
2016-10-14 21:45         ` Lyude
2016-10-10 21:19 ` ✗ Fi.CI.BAT: warning for series starting with [1/2] " Patchwork
2016-10-11  7:34 ` [Intel-gfx] [PATCH 1/2] " Jani Nikula
2016-10-11  7:34   ` Jani Nikula
2016-10-11 10:31   ` Greg KH
2016-10-11 10:54     ` Jani Nikula
2016-10-11 10:54       ` Jani Nikula
2016-10-11 11:10       ` Greg KH [this message]
2016-10-11 11:10         ` Greg KH
2016-10-11 19:19 ` ✗ Fi.CI.BAT: warning for series starting with [1/2] drm/i915/gen9: unconditionally apply the memory bandwidth WA (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161011111013.GA10805@kroah.com \
    --to=greg@kroah.com \
    --cc=dhinakaran.pandiyan@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=paulo.r.zanoni@intel.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.