All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] arm64: dts: zx: Change gic node to fix boot failure
@ 2016-10-12  2:14 Jun Nie
  2016-10-12  2:14 ` [PATCH 2/2] arm64: dts: zx: Add clock controller nodes Jun Nie
  2016-10-12  2:37 ` [PATCH 1/2] arm64: dts: zx: Change gic node to fix boot failure Shawn Guo
  0 siblings, 2 replies; 4+ messages in thread
From: Jun Nie @ 2016-10-12  2:14 UTC (permalink / raw)
  To: linux-arm-kernel

GICR for multiple CPU can be described with start address and stride,
or with multiple address. Current multiple address and stride are
both used. Fix it.

Signed-off-by: Jun Nie <jun.nie@linaro.org>
---
 arch/arm64/boot/dts/zte/zx296718.dtsi | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/zte/zx296718.dtsi b/arch/arm64/boot/dts/zte/zx296718.dtsi
index a223066..6b239a3 100644
--- a/arch/arm64/boot/dts/zte/zx296718.dtsi
+++ b/arch/arm64/boot/dts/zte/zx296718.dtsi
@@ -239,16 +239,11 @@
 		compatible = "arm,gic-v3";
 		#interrupt-cells = <3>;
 		#address-cells = <0>;
-		#redistributor-regions = <6>;
-		redistributor-stride = <0x0 0x40000>;
+		#redistributor-regions = <1>;
+		redistributor-stride = <0x20000>;
 		interrupt-controller;
 		reg = <0x02a00000 0x10000>,
-		      <0x02b00000 0x20000>,
-		      <0x02b20000 0x20000>,
-		      <0x02b40000 0x20000>,
-		      <0x02b60000 0x20000>,
-		      <0x02b80000 0x20000>,
-		      <0x02ba0000 0x20000>;
+		      <0x02b00000 0xc0000>;
 		interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
 	};
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] arm64: dts: zx: Add clock controller nodes
  2016-10-12  2:14 [PATCH 1/2] arm64: dts: zx: Change gic node to fix boot failure Jun Nie
@ 2016-10-12  2:14 ` Jun Nie
  2016-10-12  2:39   ` Shawn Guo
  2016-10-12  2:37 ` [PATCH 1/2] arm64: dts: zx: Change gic node to fix boot failure Shawn Guo
  1 sibling, 1 reply; 4+ messages in thread
From: Jun Nie @ 2016-10-12  2:14 UTC (permalink / raw)
  To: linux-arm-kernel

Add clock controller nodes, including one top controller
two low speed controllers and one audio controller.

Signed-off-by: Jun Nie <jun.nie@linaro.org>
---
 arch/arm64/boot/dts/zte/zx296718.dtsi | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/arch/arm64/boot/dts/zte/zx296718.dtsi b/arch/arm64/boot/dts/zte/zx296718.dtsi
index 6b239a3..33e42d5 100644
--- a/arch/arm64/boot/dts/zte/zx296718.dtsi
+++ b/arch/arm64/boot/dts/zte/zx296718.dtsi
@@ -279,9 +279,33 @@
 			dma-requests = <32>;
 		};
 
+		lsp0crm: clock-controller at 01420000 {
+			compatible = "zte,zx296718-lsp0crm";
+			reg = <0x01420000 0x1000>;
+			#clock-cells = <1>;
+		};
+
+		lsp1crm: clock-controller at 01430000 {
+			compatible = "zte,zx296718-lsp1crm";
+			reg = <0x01430000 0x1000>;
+			#clock-cells = <1>;
+		};
+
+		topcrm: clock-controller at 01461000 {
+			compatible = "zte,zx296718-topcrm";
+			reg = <0x01461000 0x1000>;
+			#clock-cells = <1>;
+		};
+
 		sysctrl: sysctrl at 1463000 {
 			compatible = "zte,zx296718-sysctrl", "syscon";
 			reg = <0x1463000 0x1000>;
 		};
+
+		audiocrm: clock-controller at 01480000 {
+			compatible = "zte,zx296718-audiocrm";
+			reg = <0x01480000 0x1000>;
+			#clock-cells = <1>;
+		};
 	};
 };
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 1/2] arm64: dts: zx: Change gic node to fix boot failure
  2016-10-12  2:14 [PATCH 1/2] arm64: dts: zx: Change gic node to fix boot failure Jun Nie
  2016-10-12  2:14 ` [PATCH 2/2] arm64: dts: zx: Add clock controller nodes Jun Nie
@ 2016-10-12  2:37 ` Shawn Guo
  1 sibling, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2016-10-12  2:37 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Oct 12, 2016 at 10:14:15AM +0800, Jun Nie wrote:
> GICR for multiple CPU can be described with start address and stride,
> or with multiple address. Current multiple address and stride are
> both used. Fix it.

I think we need to tell the full story about this boot failure in commit
log, i.e. it boots fine on v4.8-rc and fails on linux-next because of
the mm/vmalloc.c changes.

Shawn

> 
> Signed-off-by: Jun Nie <jun.nie@linaro.org>
> ---
>  arch/arm64/boot/dts/zte/zx296718.dtsi | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/zte/zx296718.dtsi b/arch/arm64/boot/dts/zte/zx296718.dtsi
> index a223066..6b239a3 100644
> --- a/arch/arm64/boot/dts/zte/zx296718.dtsi
> +++ b/arch/arm64/boot/dts/zte/zx296718.dtsi
> @@ -239,16 +239,11 @@
>  		compatible = "arm,gic-v3";
>  		#interrupt-cells = <3>;
>  		#address-cells = <0>;
> -		#redistributor-regions = <6>;
> -		redistributor-stride = <0x0 0x40000>;
> +		#redistributor-regions = <1>;
> +		redistributor-stride = <0x20000>;
>  		interrupt-controller;
>  		reg = <0x02a00000 0x10000>,
> -		      <0x02b00000 0x20000>,
> -		      <0x02b20000 0x20000>,
> -		      <0x02b40000 0x20000>,
> -		      <0x02b60000 0x20000>,
> -		      <0x02b80000 0x20000>,
> -		      <0x02ba0000 0x20000>;
> +		      <0x02b00000 0xc0000>;
>  		interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
>  	};
>  
> -- 
> 1.9.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/2] arm64: dts: zx: Add clock controller nodes
  2016-10-12  2:14 ` [PATCH 2/2] arm64: dts: zx: Add clock controller nodes Jun Nie
@ 2016-10-12  2:39   ` Shawn Guo
  0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2016-10-12  2:39 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Oct 12, 2016 at 10:14:16AM +0800, Jun Nie wrote:
> Add clock controller nodes, including one top controller
> two low speed controllers and one audio controller.
> 
> Signed-off-by: Jun Nie <jun.nie@linaro.org>
> ---
>  arch/arm64/boot/dts/zte/zx296718.dtsi | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/zte/zx296718.dtsi b/arch/arm64/boot/dts/zte/zx296718.dtsi
> index 6b239a3..33e42d5 100644
> --- a/arch/arm64/boot/dts/zte/zx296718.dtsi
> +++ b/arch/arm64/boot/dts/zte/zx296718.dtsi
> @@ -279,9 +279,33 @@
>  			dma-requests = <32>;
>  		};
>  
> +		lsp0crm: clock-controller at 01420000 {

Please drop the leading zeros from unit-address in node name.

Shawn

> +			compatible = "zte,zx296718-lsp0crm";
> +			reg = <0x01420000 0x1000>;
> +			#clock-cells = <1>;
> +		};
> +
> +		lsp1crm: clock-controller at 01430000 {
> +			compatible = "zte,zx296718-lsp1crm";
> +			reg = <0x01430000 0x1000>;
> +			#clock-cells = <1>;
> +		};
> +
> +		topcrm: clock-controller at 01461000 {
> +			compatible = "zte,zx296718-topcrm";
> +			reg = <0x01461000 0x1000>;
> +			#clock-cells = <1>;
> +		};
> +
>  		sysctrl: sysctrl at 1463000 {
>  			compatible = "zte,zx296718-sysctrl", "syscon";
>  			reg = <0x1463000 0x1000>;
>  		};
> +
> +		audiocrm: clock-controller at 01480000 {
> +			compatible = "zte,zx296718-audiocrm";
> +			reg = <0x01480000 0x1000>;
> +			#clock-cells = <1>;
> +		};
>  	};
>  };
> -- 
> 1.9.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-10-12  2:39 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-12  2:14 [PATCH 1/2] arm64: dts: zx: Change gic node to fix boot failure Jun Nie
2016-10-12  2:14 ` [PATCH 2/2] arm64: dts: zx: Add clock controller nodes Jun Nie
2016-10-12  2:39   ` Shawn Guo
2016-10-12  2:37 ` [PATCH 1/2] arm64: dts: zx: Change gic node to fix boot failure Shawn Guo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.