* [bug report] rxrpc: Add IPv6 support
@ 2016-10-12 6:11 Dan Carpenter
2016-10-12 7:26 ` David Howells
2016-10-12 8:31 ` Dan Carpenter
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2016-10-12 6:11 UTC (permalink / raw)
To: kernel-janitors
Hello David Howells,
The patch 75b54cb57ca3: "rxrpc: Add IPv6 support" from Sep 13, 2016,
leads to the following static checker warning:
net/rxrpc/peer_object.c:196 rxrpc_assess_MTU_size()
warn: 'dst' isn't an ERR_PTR
net/rxrpc/peer_object.c
193 fl6->fl6_dport = htons(7001);
194 fl6->fl6_sport = htons(7000);
195 dst = ip6_route_output(&init_net, NULL, fl6);
196 if (IS_ERR(dst)) {
^^^^^^^^^^^
Maybe you want to check dst->error?
197 _leave(" [route err %ld]", PTR_ERR(dst));
198 return;
199 }
200 break;
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [bug report] rxrpc: Add IPv6 support
2016-10-12 6:11 [bug report] rxrpc: Add IPv6 support Dan Carpenter
@ 2016-10-12 7:26 ` David Howells
2016-10-12 8:31 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: David Howells @ 2016-10-12 7:26 UTC (permalink / raw)
To: kernel-janitors
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> 196 if (IS_ERR(dst)) {
> ^^^^^^^^^^^
> Maybe you want to check dst->error?
Hmmm... Why don't I see this when I run checker, I wonder?
David
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [bug report] rxrpc: Add IPv6 support
2016-10-12 6:11 [bug report] rxrpc: Add IPv6 support Dan Carpenter
2016-10-12 7:26 ` David Howells
@ 2016-10-12 8:31 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2016-10-12 8:31 UTC (permalink / raw)
To: kernel-janitors
On Wed, Oct 12, 2016 at 08:26:01AM +0100, David Howells wrote:
> Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> > 196 if (IS_ERR(dst)) {
> > ^^^^^^^^^^^
> > Maybe you want to check dst->error?
>
> Hmmm... Why don't I see this when I run checker, I wonder?
>
I haven't released this one because people do all kinds of nonsense
checks for IS_ERR() out of paranoia.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-12 8:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-12 6:11 [bug report] rxrpc: Add IPv6 support Dan Carpenter
2016-10-12 7:26 ` David Howells
2016-10-12 8:31 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.