* [patch] gpio: stmpe: || vs && typo
@ 2016-10-12 6:25 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2016-10-12 6:25 UTC (permalink / raw)
To: Linus Walleij, Patrice Chotard
Cc: Alexandre Courbot, linux-gpio, kernel-janitors
&& was obviously intended here.
Fixes: 6936e1f88d23 ('gpio: stmpe: Write int status register only when needed')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpio/gpio-stmpe.c b/drivers/gpio/gpio-stmpe.c
index e7d422a..5b00427 100644
--- a/drivers/gpio/gpio-stmpe.c
+++ b/drivers/gpio/gpio-stmpe.c
@@ -409,7 +409,7 @@ static irqreturn_t stmpe_gpio_irq(int irq, void *dev)
* 801/1801/1600, bits are cleared when read.
* Edge detect register is not present on 801/1600/1801
*/
- if (stmpe->partnum != STMPE801 || stmpe->partnum != STMPE1600 ||
+ if (stmpe->partnum != STMPE801 && stmpe->partnum != STMPE1600 &&
stmpe->partnum != STMPE1801) {
stmpe_reg_write(stmpe, statmsbreg + i, status[i]);
stmpe_reg_write(stmpe,
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [patch] gpio: stmpe: || vs && typo
@ 2016-10-12 6:25 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2016-10-12 6:25 UTC (permalink / raw)
To: Linus Walleij, Patrice Chotard
Cc: Alexandre Courbot, linux-gpio, kernel-janitors
&& was obviously intended here.
Fixes: 6936e1f88d23 ('gpio: stmpe: Write int status register only when needed')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpio/gpio-stmpe.c b/drivers/gpio/gpio-stmpe.c
index e7d422a..5b00427 100644
--- a/drivers/gpio/gpio-stmpe.c
+++ b/drivers/gpio/gpio-stmpe.c
@@ -409,7 +409,7 @@ static irqreturn_t stmpe_gpio_irq(int irq, void *dev)
* 801/1801/1600, bits are cleared when read.
* Edge detect register is not present on 801/1600/1801
*/
- if (stmpe->partnum != STMPE801 || stmpe->partnum != STMPE1600 ||
+ if (stmpe->partnum != STMPE801 && stmpe->partnum != STMPE1600 &&
stmpe->partnum != STMPE1801) {
stmpe_reg_write(stmpe, statmsbreg + i, status[i]);
stmpe_reg_write(stmpe,
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [patch] gpio: stmpe: || vs && typo
2016-10-12 6:25 ` Dan Carpenter
@ 2016-10-12 7:10 ` Patrice Chotard
-1 siblings, 0 replies; 6+ messages in thread
From: Patrice Chotard @ 2016-10-12 7:10 UTC (permalink / raw)
To: Dan Carpenter, Linus Walleij
Cc: Alexandre Courbot, linux-gpio, kernel-janitors
Hi Dan
On 10/12/2016 08:25 AM, Dan Carpenter wrote:
> && was obviously intended here.
>
> Fixes: 6936e1f88d23 ('gpio: stmpe: Write int status register only when needed')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpio/gpio-stmpe.c b/drivers/gpio/gpio-stmpe.c
> index e7d422a..5b00427 100644
> --- a/drivers/gpio/gpio-stmpe.c
> +++ b/drivers/gpio/gpio-stmpe.c
> @@ -409,7 +409,7 @@ static irqreturn_t stmpe_gpio_irq(int irq, void *dev)
> * 801/1801/1600, bits are cleared when read.
> * Edge detect register is not present on 801/1600/1801
> */
> - if (stmpe->partnum != STMPE801 || stmpe->partnum != STMPE1600 ||
> + if (stmpe->partnum != STMPE801 && stmpe->partnum != STMPE1600 &&
> stmpe->partnum != STMPE1801) {
> stmpe_reg_write(stmpe, statmsbreg + i, status[i]);
> stmpe_reg_write(stmpe,
>
Well spotted ;-)
Acked-by: Patrice Chotard <patrice.chotard@st.com>
Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] gpio: stmpe: || vs && typo
@ 2016-10-12 7:10 ` Patrice Chotard
0 siblings, 0 replies; 6+ messages in thread
From: Patrice Chotard @ 2016-10-12 7:10 UTC (permalink / raw)
To: Dan Carpenter, Linus Walleij
Cc: Alexandre Courbot, linux-gpio, kernel-janitors
Hi Dan
On 10/12/2016 08:25 AM, Dan Carpenter wrote:
> && was obviously intended here.
>
> Fixes: 6936e1f88d23 ('gpio: stmpe: Write int status register only when needed')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpio/gpio-stmpe.c b/drivers/gpio/gpio-stmpe.c
> index e7d422a..5b00427 100644
> --- a/drivers/gpio/gpio-stmpe.c
> +++ b/drivers/gpio/gpio-stmpe.c
> @@ -409,7 +409,7 @@ static irqreturn_t stmpe_gpio_irq(int irq, void *dev)
> * 801/1801/1600, bits are cleared when read.
> * Edge detect register is not present on 801/1600/1801
> */
> - if (stmpe->partnum != STMPE801 || stmpe->partnum != STMPE1600 ||
> + if (stmpe->partnum != STMPE801 && stmpe->partnum != STMPE1600 &&
> stmpe->partnum != STMPE1801) {
> stmpe_reg_write(stmpe, statmsbreg + i, status[i]);
> stmpe_reg_write(stmpe,
>
Well spotted ;-)
Acked-by: Patrice Chotard <patrice.chotard@st.com>
Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] gpio: stmpe: || vs && typo
2016-10-12 6:25 ` Dan Carpenter
@ 2016-10-12 8:43 ` Linus Walleij
-1 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2016-10-12 8:43 UTC (permalink / raw)
To: Dan Carpenter
Cc: Patrice Chotard, Alexandre Courbot, linux-gpio, kernel-janitors
On Wed, Oct 12, 2016 at 8:25 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> && was obviously intended here.
>
> Fixes: 6936e1f88d23 ('gpio: stmpe: Write int status register only when needed')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Patch applied with Patrice's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] gpio: stmpe: || vs && typo
@ 2016-10-12 8:43 ` Linus Walleij
0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2016-10-12 8:43 UTC (permalink / raw)
To: Dan Carpenter
Cc: Patrice Chotard, Alexandre Courbot, linux-gpio, kernel-janitors
On Wed, Oct 12, 2016 at 8:25 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> && was obviously intended here.
>
> Fixes: 6936e1f88d23 ('gpio: stmpe: Write int status register only when needed')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Patch applied with Patrice's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-10-12 8:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-12 6:25 [patch] gpio: stmpe: || vs && typo Dan Carpenter
2016-10-12 6:25 ` Dan Carpenter
2016-10-12 7:10 ` Patrice Chotard
2016-10-12 7:10 ` Patrice Chotard
2016-10-12 8:43 ` Linus Walleij
2016-10-12 8:43 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.