All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: Fix misplaced '\n' in printing the GPU error's RING_HEAD
@ 2016-10-12 11:22 Chris Wilson
  2016-10-12 13:03 ` ✗ Fi.CI.BAT: warning for " Patchwork
  2016-10-13  9:38 ` [PATCH] " Mika Kuoppala
  0 siblings, 2 replies; 4+ messages in thread
From: Chris Wilson @ 2016-10-12 11:22 UTC (permalink / raw)
  To: intel-gfx; +Cc: Mika Kuoppala

'\n' is supposed to be at the end of the line, not in the middle.

Fixes: cdb324bde570 ("drm/i915: Show bounds of active request in the ring...")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
---
 drivers/gpu/drm/i915/i915_gpu_error.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
index 2df4bc2af0bb..673750fc0d5b 100644
--- a/drivers/gpu/drm/i915/i915_gpu_error.c
+++ b/drivers/gpu/drm/i915/i915_gpu_error.c
@@ -368,7 +368,7 @@ static void error_print_engine(struct drm_i915_error_state_buf *m,
 {
 	err_printf(m, "%s command stream:\n", engine_str(ee->engine_id));
 	err_printf(m, "  START: 0x%08x\n", ee->start);
-	err_printf(m, "  HEAD:  0x%08x\n [0x%08x]", ee->head, ee->rq_head);
+	err_printf(m, "  HEAD:  0x%08x [0x%08x]\n", ee->head, ee->rq_head);
 	err_printf(m, "  TAIL:  0x%08x [0x%08x, 0x%08x]\n",
 		   ee->tail, ee->rq_post, ee->rq_tail);
 	err_printf(m, "  CTL:   0x%08x\n", ee->ctl);
-- 
2.9.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* ✗ Fi.CI.BAT: warning for drm/i915: Fix misplaced '\n' in printing the GPU error's RING_HEAD
  2016-10-12 11:22 [PATCH] drm/i915: Fix misplaced '\n' in printing the GPU error's RING_HEAD Chris Wilson
@ 2016-10-12 13:03 ` Patchwork
  2016-10-12 13:11   ` Saarinen, Jani
  2016-10-13  9:38 ` [PATCH] " Mika Kuoppala
  1 sibling, 1 reply; 4+ messages in thread
From: Patchwork @ 2016-10-12 13:03 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: Fix misplaced '\n' in printing the GPU error's RING_HEAD
URL   : https://patchwork.freedesktop.org/series/13639/
State : warning

== Summary ==

Series 13639v1 drm/i915: Fix misplaced '
' in printing the GPU error's RING_HEAD
https://patchwork.freedesktop.org/api/1.0/series/13639/revisions/1/mbox/

Test kms_flip:
        Subgroup basic-flip-vs-modeset:
                pass       -> DMESG-WARN (fi-skl-6770hq)
Test kms_pipe_crc_basic:
        Subgroup nonblocking-crc-pipe-b-frame-sequence:
                pass       -> DMESG-WARN (fi-ilk-650)
Test vgem_basic:
        Subgroup unload:
                skip       -> PASS       (fi-hsw-4770)

fi-bdw-5557u     total:248  pass:232  dwarn:0   dfail:0   fail:0   skip:16 
fi-bsw-n3050     total:248  pass:205  dwarn:0   dfail:0   fail:0   skip:43 
fi-bxt-t5700     total:248  pass:217  dwarn:0   dfail:0   fail:0   skip:31 
fi-byt-j1900     total:248  pass:213  dwarn:2   dfail:0   fail:1   skip:32 
fi-byt-n2820     total:248  pass:211  dwarn:0   dfail:0   fail:1   skip:36 
fi-hsw-4770      total:248  pass:225  dwarn:0   dfail:0   fail:0   skip:23 
fi-hsw-4770r     total:248  pass:225  dwarn:0   dfail:0   fail:0   skip:23 
fi-ilk-650       total:248  pass:184  dwarn:1   dfail:0   fail:2   skip:61 
fi-ivb-3520m     total:248  pass:222  dwarn:0   dfail:0   fail:0   skip:26 
fi-ivb-3770      total:248  pass:222  dwarn:0   dfail:0   fail:0   skip:26 
fi-kbl-7200u     total:248  pass:223  dwarn:0   dfail:0   fail:0   skip:25 
fi-skl-6260u     total:248  pass:233  dwarn:0   dfail:0   fail:0   skip:15 
fi-skl-6700hq    total:248  pass:225  dwarn:0   dfail:0   fail:0   skip:23 
fi-skl-6700k     total:248  pass:222  dwarn:1   dfail:0   fail:0   skip:25 
fi-skl-6770hq    total:248  pass:230  dwarn:2   dfail:0   fail:1   skip:15 
fi-snb-2520m     total:248  pass:211  dwarn:0   dfail:0   fail:0   skip:37 
fi-snb-2600      total:248  pass:210  dwarn:0   dfail:0   fail:0   skip:38 

Results at /archive/results/CI_IGT_test/Patchwork_2683/

46271d41e30090d7fc996e8f5abde6a59f51038b drm-intel-nightly: 2016y-10m-12d-11h-06m-41s UTC integration manifest
35edc31 drm/i915: Fix misplaced '\n' in printing the GPU error's RING_HEAD

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: ✗ Fi.CI.BAT: warning for drm/i915: Fix misplaced '\n' in printing the GPU error's RING_HEAD
  2016-10-12 13:03 ` ✗ Fi.CI.BAT: warning for " Patchwork
@ 2016-10-12 13:11   ` Saarinen, Jani
  0 siblings, 0 replies; 4+ messages in thread
From: Saarinen, Jani @ 2016-10-12 13:11 UTC (permalink / raw)
  To: intel-gfx, Chris Wilson

> Test kms_flip:
>         Subgroup basic-flip-vs-modeset:
>                 pass       -> DMESG-WARN (fi-skl-6770hq)
[  468.807117] [drm:skl_set_cdclk [i915]] *ERROR* failed to inform PCU about cdclk change
[  468.816844] [drm:intel_cpu_fifo_underrun_irq_handler [i915]] *ERROR* CPU pipe C FIFO underrun

> Test kms_pipe_crc_basic:
>         Subgroup nonblocking-crc-pipe-b-frame-sequence:
>                 pass       -> DMESG-WARN (fi-ilk-650)
[  445.727655] [drm:intel_pch_fifo_underrun_irq_handler [i915]] *ERROR* PCH transcoder B FIFO underrun
[  445.727682] [drm:intel_cpu_fifo_underrun_irq_handler [i915]] *ERROR* CPU pipe B FIFO underrun

> Test vgem_basic:
>         Subgroup unload:
>                 skip       -> PASS       (fi-hsw-4770)
> 
> fi-bdw-5557u     total:248  pass:232  dwarn:0   dfail:0   fail:0   skip:16
> fi-bsw-n3050     total:248  pass:205  dwarn:0   dfail:0   fail:0   skip:43
> fi-bxt-t5700     total:248  pass:217  dwarn:0   dfail:0   fail:0   skip:31
> fi-byt-j1900     total:248  pass:213  dwarn:2   dfail:0   fail:1   skip:32
> fi-byt-n2820     total:248  pass:211  dwarn:0   dfail:0   fail:1   skip:36
> fi-hsw-4770      total:248  pass:225  dwarn:0   dfail:0   fail:0   skip:23
> fi-hsw-4770r     total:248  pass:225  dwarn:0   dfail:0   fail:0   skip:23
> fi-ilk-650       total:248  pass:184  dwarn:1   dfail:0   fail:2   skip:61
> fi-ivb-3520m     total:248  pass:222  dwarn:0   dfail:0   fail:0   skip:26
> fi-ivb-3770      total:248  pass:222  dwarn:0   dfail:0   fail:0   skip:26
> fi-kbl-7200u     total:248  pass:223  dwarn:0   dfail:0   fail:0   skip:25
> fi-skl-6260u     total:248  pass:233  dwarn:0   dfail:0   fail:0   skip:15
> fi-skl-6700hq    total:248  pass:225  dwarn:0   dfail:0   fail:0   skip:23
> fi-skl-6700k     total:248  pass:222  dwarn:1   dfail:0   fail:0   skip:25
> fi-skl-6770hq    total:248  pass:230  dwarn:2   dfail:0   fail:1   skip:15
> fi-snb-2520m     total:248  pass:211  dwarn:0   dfail:0   fail:0   skip:37
> fi-snb-2600      total:248  pass:210  dwarn:0   dfail:0   fail:0   skip:38
> 
> Results at /archive/results/CI_IGT_test/Patchwork_2683/
> 
> 46271d41e30090d7fc996e8f5abde6a59f51038b drm-intel-nightly: 2016y-10m-
> 12d-11h-06m-41s UTC integration manifest
> 35edc31 drm/i915: Fix misplaced '\n' in printing the GPU error's RING_HEAD
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx


Jani Saarinen
Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/i915: Fix misplaced '\n' in printing the GPU error's RING_HEAD
  2016-10-12 11:22 [PATCH] drm/i915: Fix misplaced '\n' in printing the GPU error's RING_HEAD Chris Wilson
  2016-10-12 13:03 ` ✗ Fi.CI.BAT: warning for " Patchwork
@ 2016-10-13  9:38 ` Mika Kuoppala
  1 sibling, 0 replies; 4+ messages in thread
From: Mika Kuoppala @ 2016-10-13  9:38 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx

Chris Wilson <chris@chris-wilson.co.uk> writes:

> '\n' is supposed to be at the end of the line, not in the middle.
>
> Fixes: cdb324bde570 ("drm/i915: Show bounds of active request in the ring...")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@intel.com>

Oopsie.

Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>

> ---
>  drivers/gpu/drm/i915/i915_gpu_error.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
> index 2df4bc2af0bb..673750fc0d5b 100644
> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
> @@ -368,7 +368,7 @@ static void error_print_engine(struct drm_i915_error_state_buf *m,
>  {
>  	err_printf(m, "%s command stream:\n", engine_str(ee->engine_id));
>  	err_printf(m, "  START: 0x%08x\n", ee->start);
> -	err_printf(m, "  HEAD:  0x%08x\n [0x%08x]", ee->head, ee->rq_head);
> +	err_printf(m, "  HEAD:  0x%08x [0x%08x]\n", ee->head, ee->rq_head);
>  	err_printf(m, "  TAIL:  0x%08x [0x%08x, 0x%08x]\n",
>  		   ee->tail, ee->rq_post, ee->rq_tail);
>  	err_printf(m, "  CTL:   0x%08x\n", ee->ctl);
> -- 
> 2.9.3
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-10-13  9:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-12 11:22 [PATCH] drm/i915: Fix misplaced '\n' in printing the GPU error's RING_HEAD Chris Wilson
2016-10-12 13:03 ` ✗ Fi.CI.BAT: warning for " Patchwork
2016-10-12 13:11   ` Saarinen, Jani
2016-10-13  9:38 ` [PATCH] " Mika Kuoppala

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.