* [patch] Staging: lustre: indent an if statement
@ 2016-10-13 8:52 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2016-10-13 8:52 UTC (permalink / raw)
To: lustre-devel
This if statement wasn't intended.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/staging/lustre/lustre/obdclass/cl_object.c b/drivers/staging/lustre/lustre/obdclass/cl_object.c
index 3199dd4..a102c36 100644
--- a/drivers/staging/lustre/lustre/obdclass/cl_object.c
+++ b/drivers/staging/lustre/lustre/obdclass/cl_object.c
@@ -335,7 +335,7 @@ int cl_object_getstripe(const struct lu_env *env, struct cl_object *obj,
if (obj->co_ops->coo_getstripe) {
result = obj->co_ops->coo_getstripe(env, obj, uarg);
if (result)
- break;
+ break;
}
}
return result;
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [lustre-devel] [patch] Staging: lustre: indent an if statement
@ 2016-10-13 8:52 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2016-10-13 8:52 UTC (permalink / raw)
To: lustre-devel
This if statement wasn't intended.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/staging/lustre/lustre/obdclass/cl_object.c b/drivers/staging/lustre/lustre/obdclass/cl_object.c
index 3199dd4..a102c36 100644
--- a/drivers/staging/lustre/lustre/obdclass/cl_object.c
+++ b/drivers/staging/lustre/lustre/obdclass/cl_object.c
@@ -335,7 +335,7 @@ int cl_object_getstripe(const struct lu_env *env, struct cl_object *obj,
if (obj->co_ops->coo_getstripe) {
result = obj->co_ops->coo_getstripe(env, obj, uarg);
if (result)
- break;
+ break;
}
}
return result;
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [patch] Staging: lustre: indent an if statement
2016-10-13 8:52 ` [lustre-devel] " Dan Carpenter
@ 2016-10-13 22:38 ` James Simmons
-1 siblings, 0 replies; 8+ messages in thread
From: James Simmons @ 2016-10-13 22:38 UTC (permalink / raw)
To: lustre-devel
> This if statement wasn't intended.
Acked-by: James Simmons <jsimmons@infradead.org>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/staging/lustre/lustre/obdclass/cl_object.c b/drivers/staging/lustre/lustre/obdclass/cl_object.c
> index 3199dd4..a102c36 100644
> --- a/drivers/staging/lustre/lustre/obdclass/cl_object.c
> +++ b/drivers/staging/lustre/lustre/obdclass/cl_object.c
> @@ -335,7 +335,7 @@ int cl_object_getstripe(const struct lu_env *env, struct cl_object *obj,
> if (obj->co_ops->coo_getstripe) {
> result = obj->co_ops->coo_getstripe(env, obj, uarg);
> if (result)
> - break;
> + break;
> }
> }
> return result;
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [lustre-devel] [patch] Staging: lustre: indent an if statement
@ 2016-10-13 22:38 ` James Simmons
0 siblings, 0 replies; 8+ messages in thread
From: James Simmons @ 2016-10-13 22:38 UTC (permalink / raw)
To: lustre-devel
> This if statement wasn't intended.
Acked-by: James Simmons <jsimmons@infradead.org>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/staging/lustre/lustre/obdclass/cl_object.c b/drivers/staging/lustre/lustre/obdclass/cl_object.c
> index 3199dd4..a102c36 100644
> --- a/drivers/staging/lustre/lustre/obdclass/cl_object.c
> +++ b/drivers/staging/lustre/lustre/obdclass/cl_object.c
> @@ -335,7 +335,7 @@ int cl_object_getstripe(const struct lu_env *env, struct cl_object *obj,
> if (obj->co_ops->coo_getstripe) {
> result = obj->co_ops->coo_getstripe(env, obj, uarg);
> if (result)
> - break;
> + break;
> }
> }
> return result;
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [lustre-devel] [patch] Staging: lustre: indent an if statement
2016-10-13 22:38 ` [lustre-devel] " James Simmons
@ 2016-10-14 10:36 ` Martin Hecht
-1 siblings, 0 replies; 8+ messages in thread
From: Martin Hecht @ 2016-10-14 10:36 UTC (permalink / raw)
To: lustre-devel
[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]
On 10/14/2016 12:38 AM, James Simmons wrote:
>> This if statement wasn't intended.
just to be sure: in conjunction with the subject of the mail this should
read "indented" instead of "intended", right?
- otherwise this would result in a slightly different patch...
> Acked-by: James Simmons <jsimmons@infradead.org>
>
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>
>> diff --git a/drivers/staging/lustre/lustre/obdclass/cl_object.c b/drivers/staging/lustre/lustre/obdclass/cl_object.c
>> index 3199dd4..a102c36 100644
>> --- a/drivers/staging/lustre/lustre/obdclass/cl_object.c
>> +++ b/drivers/staging/lustre/lustre/obdclass/cl_object.c
>> @@ -335,7 +335,7 @@ int cl_object_getstripe(const struct lu_env *env, struct cl_object *obj,
>> if (obj->co_ops->coo_getstripe) {
>> result = obj->co_ops->coo_getstripe(env, obj, uarg);
>> if (result)
>> - break;
>> + break;
>> }
>> }
>> return result;
>>
> _______________________________________________
> lustre-devel mailing list
> lustre-devel@lists.lustre.org
> http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 2252 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* [lustre-devel] [patch] Staging: lustre: indent an if statement
@ 2016-10-14 10:36 ` Martin Hecht
0 siblings, 0 replies; 8+ messages in thread
From: Martin Hecht @ 2016-10-14 10:36 UTC (permalink / raw)
To: lustre-devel
On 10/14/2016 12:38 AM, James Simmons wrote:
>> This if statement wasn't intended.
just to be sure: in conjunction with the subject of the mail this should
read "indented" instead of "intended", right?
- otherwise this would result in a slightly different patch...
> Acked-by: James Simmons <jsimmons@infradead.org>
>
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>
>> diff --git a/drivers/staging/lustre/lustre/obdclass/cl_object.c b/drivers/staging/lustre/lustre/obdclass/cl_object.c
>> index 3199dd4..a102c36 100644
>> --- a/drivers/staging/lustre/lustre/obdclass/cl_object.c
>> +++ b/drivers/staging/lustre/lustre/obdclass/cl_object.c
>> @@ -335,7 +335,7 @@ int cl_object_getstripe(const struct lu_env *env, struct cl_object *obj,
>> if (obj->co_ops->coo_getstripe) {
>> result = obj->co_ops->coo_getstripe(env, obj, uarg);
>> if (result)
>> - break;
>> + break;
>> }
>> }
>> return result;
>>
> _______________________________________________
> lustre-devel mailing list
> lustre-devel at lists.lustre.org
> http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 2252 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.lustre.org/pipermail/lustre-devel-lustre.org/attachments/20161014/2f94191f/attachment.bin>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [lustre-devel] [patch] Staging: lustre: indent an if statement
2016-10-14 10:36 ` Martin Hecht
@ 2016-10-14 11:52 ` Dan Carpenter
-1 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2016-10-14 11:52 UTC (permalink / raw)
To: lustre-devel
On Fri, Oct 14, 2016 at 12:36:25PM +0200, Martin Hecht wrote:
> On 10/14/2016 12:38 AM, James Simmons wrote:
> >> This if statement wasn't intended.
> just to be sure: in conjunction with the subject of the mail this should
> read "indented" instead of "intended", right?
Yes, yes. I should just avoid both words from now on because my fingers
constantly get mixed up.
Greg already applied this so it's too late to send a v2.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 8+ messages in thread
* [lustre-devel] [patch] Staging: lustre: indent an if statement
@ 2016-10-14 11:52 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2016-10-14 11:52 UTC (permalink / raw)
To: lustre-devel
On Fri, Oct 14, 2016 at 12:36:25PM +0200, Martin Hecht wrote:
> On 10/14/2016 12:38 AM, James Simmons wrote:
> >> This if statement wasn't intended.
> just to be sure: in conjunction with the subject of the mail this should
> read "indented" instead of "intended", right?
Yes, yes. I should just avoid both words from now on because my fingers
constantly get mixed up.
Greg already applied this so it's too late to send a v2.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-10-14 11:52 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-13 8:52 [patch] Staging: lustre: indent an if statement Dan Carpenter
2016-10-13 8:52 ` [lustre-devel] " Dan Carpenter
2016-10-13 22:38 ` James Simmons
2016-10-13 22:38 ` [lustre-devel] " James Simmons
2016-10-14 10:36 ` Martin Hecht
2016-10-14 10:36 ` Martin Hecht
2016-10-14 11:52 ` Dan Carpenter
2016-10-14 11:52 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.