* [Buildroot] [PATCH 1/2] dependencies: check for MakeMaker Perl module
@ 2016-07-06 22:43 Romain Naour
2016-07-06 22:43 ` [Buildroot] [PATCH 2/2] dependencies: check for Math BigInt/BigRat " Romain Naour
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Romain Naour @ 2016-07-06 22:43 UTC (permalink / raw)
To: buildroot
ExtUtils::MakeMaker is one of the Perl Core modules usually packaged in
Perl package for a Debian/Ubuntu based system.
For a Fedora based system, each Perl Core modules have their own RPM
package. So install only Perl package is not enough.
Fixes:
>>> host-libxml-parser-perl 2.41 Configuring
[...]
perl `which perl` Makefile.PL
Can't locate ExtUtils/MakeMaker.pm in @INC (you may need to install the ExtUtils::MakeMaker module)
Add a new Perl module check in dependency.sh.
Signed-off-by: Romain Naour <romain.naour@gmail.com>
Cc: Fran?ois Perrad <francois.perrad@gadz.org>
---
support/dependencies/dependencies.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/support/dependencies/dependencies.sh b/support/dependencies/dependencies.sh
index 3146401..5832cf3 100755
--- a/support/dependencies/dependencies.sh
+++ b/support/dependencies/dependencies.sh
@@ -238,6 +238,7 @@ fi
# Check that the Perl installation is complete enough for Buildroot.
required_perl_modules="Data::Dumper" # Needed to build host-autoconf
+required_perl_modules="$required_perl_modules ExtUtils::MakeMaker" # Used by host-libxml-parser-perl
required_perl_modules="$required_perl_modules Thread::Queue" # Used by host-automake
# This variable will keep the modules that are missing in your system.
--
2.5.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 2/2] dependencies: check for Math BigInt/BigRat Perl module
2016-07-06 22:43 [Buildroot] [PATCH 1/2] dependencies: check for MakeMaker Perl module Romain Naour
@ 2016-07-06 22:43 ` Romain Naour
2016-07-07 9:57 ` Thomas Petazzoni
2016-10-16 10:13 ` Thomas Petazzoni
2016-10-16 10:06 ` [Buildroot] [PATCH 1/2] dependencies: check for MakeMaker " Arnout Vandecappelle
2016-10-16 10:13 ` Thomas Petazzoni
2 siblings, 2 replies; 7+ messages in thread
From: Romain Naour @ 2016-07-06 22:43 UTC (permalink / raw)
To: buildroot
As for MakeMaker Perl module, add a check for Math BigInt/BigRat Perl
Core module.
Fixes:
Waf: Entering directory `output/build/mpv-0.17.0/build'
[ 1/198] Compiling version.sh
[ 12/198] Processing ebml_types.h: demux/ebml.c demux/demux_mkv.c -> build/ebml_types.h
[ 13/198] Compiling demux/ebml.c
Can't locate Math/BigRat.pm in @INC (you may need to install the Math::BigRat module)
Waf: Entering directory `output/build/mpv-0.17.0/build'
[ 1/198] Compiling version.sh
[ 2/198] Compiling TOOLS/osxbundle/mpv.app/Contents/Resources/icon.icns
[ 3/198] Compiling video/out/x11_icon.bin
[ 4/198] Compiling etc/input.conf
[ 5/198] Compiling sub/osd_font.otf
[ 6/198] Compiling video/out/opengl/nnedi3_weights.bin
[ 7/198] Compiling player/lua/defaults.lua
[ 8/198] Compiling player/lua/assdraw.lua
[ 9/198] Compiling player/lua/options.lua
[ 10/198] Compiling player/lua/osc.lua
[ 11/198] Compiling player/lua/ytdl_hook.lua
[ 12/198] Processing ebml_types.h: demux/ebml.c demux/demux_mkv.c -> build/ebml_types.h
[ 13/198] Compiling demux/ebml.c
[ 14/198] Compiling DOCS/man/mpv.rst
Can't locate Math/BigInt.pm in @INC (you may need to install the Math::BigInt module)
Signed-off-by: Romain Naour <romain.naour@gmail.com>
Cc: Fran?ois Perrad <francois.perrad@gadz.org>
---
support/dependencies/dependencies.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/support/dependencies/dependencies.sh b/support/dependencies/dependencies.sh
index 5832cf3..40e83d4 100755
--- a/support/dependencies/dependencies.sh
+++ b/support/dependencies/dependencies.sh
@@ -239,6 +239,8 @@ fi
# Check that the Perl installation is complete enough for Buildroot.
required_perl_modules="Data::Dumper" # Needed to build host-autoconf
required_perl_modules="$required_perl_modules ExtUtils::MakeMaker" # Used by host-libxml-parser-perl
+required_perl_modules="$required_perl_modules Math::BigInt" # Used by mpv
+required_perl_modules="$required_perl_modules Math::BigRat" # Used by mpv
required_perl_modules="$required_perl_modules Thread::Queue" # Used by host-automake
# This variable will keep the modules that are missing in your system.
--
2.5.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 2/2] dependencies: check for Math BigInt/BigRat Perl module
2016-07-06 22:43 ` [Buildroot] [PATCH 2/2] dependencies: check for Math BigInt/BigRat " Romain Naour
@ 2016-07-07 9:57 ` Thomas Petazzoni
2016-07-07 10:11 ` Romain Naour
2016-10-16 10:13 ` Thomas Petazzoni
1 sibling, 1 reply; 7+ messages in thread
From: Thomas Petazzoni @ 2016-07-07 9:57 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 7 Jul 2016 00:43:32 +0200, Romain Naour wrote:
> diff --git a/support/dependencies/dependencies.sh b/support/dependencies/dependencies.sh
> index 5832cf3..40e83d4 100755
> --- a/support/dependencies/dependencies.sh
> +++ b/support/dependencies/dependencies.sh
> @@ -239,6 +239,8 @@ fi
> # Check that the Perl installation is complete enough for Buildroot.
> required_perl_modules="Data::Dumper" # Needed to build host-autoconf
> required_perl_modules="$required_perl_modules ExtUtils::MakeMaker" # Used by host-libxml-parser-perl
> +required_perl_modules="$required_perl_modules Math::BigInt" # Used by mpv
> +required_perl_modules="$required_perl_modules Math::BigRat" # Used by mpv
> required_perl_modules="$required_perl_modules Thread::Queue" # Used by host-automake
Should the addition of those Perl modules be conditional on the mpv
package being enabled? I'm not sure, just wondering.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 2/2] dependencies: check for Math BigInt/BigRat Perl module
2016-07-07 9:57 ` Thomas Petazzoni
@ 2016-07-07 10:11 ` Romain Naour
0 siblings, 0 replies; 7+ messages in thread
From: Romain Naour @ 2016-07-07 10:11 UTC (permalink / raw)
To: buildroot
Hi Thomas,
Le 07/07/2016 ? 11:57, Thomas Petazzoni a ?crit :
> Hello,
>
> On Thu, 7 Jul 2016 00:43:32 +0200, Romain Naour wrote:
>
>> diff --git a/support/dependencies/dependencies.sh b/support/dependencies/dependencies.sh
>> index 5832cf3..40e83d4 100755
>> --- a/support/dependencies/dependencies.sh
>> +++ b/support/dependencies/dependencies.sh
>> @@ -239,6 +239,8 @@ fi
>> # Check that the Perl installation is complete enough for Buildroot.
>> required_perl_modules="Data::Dumper" # Needed to build host-autoconf
>> required_perl_modules="$required_perl_modules ExtUtils::MakeMaker" # Used by host-libxml-parser-perl
>> +required_perl_modules="$required_perl_modules Math::BigInt" # Used by mpv
>> +required_perl_modules="$required_perl_modules Math::BigRat" # Used by mpv
>> required_perl_modules="$required_perl_modules Thread::Queue" # Used by host-automake
>
> Should the addition of those Perl modules be conditional on the mpv
> package being enabled? I'm not sure, just wondering.
Yes, I hesitated doing so, but these modules are pretty small.
I haven't a strong opinion...
Best regards,
Romain
>
> Thomas
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/2] dependencies: check for MakeMaker Perl module
2016-07-06 22:43 [Buildroot] [PATCH 1/2] dependencies: check for MakeMaker Perl module Romain Naour
2016-07-06 22:43 ` [Buildroot] [PATCH 2/2] dependencies: check for Math BigInt/BigRat " Romain Naour
@ 2016-10-16 10:06 ` Arnout Vandecappelle
2016-10-16 10:13 ` Thomas Petazzoni
2 siblings, 0 replies; 7+ messages in thread
From: Arnout Vandecappelle @ 2016-10-16 10:06 UTC (permalink / raw)
To: buildroot
On 07-07-16 00:43, Romain Naour wrote:
> ExtUtils::MakeMaker is one of the Perl Core modules usually packaged in
> Perl package for a Debian/Ubuntu based system.
> For a Fedora based system, each Perl Core modules have their own RPM
> package. So install only Perl package is not enough.
>
> Fixes:
>>>> host-libxml-parser-perl 2.41 Configuring
> [...]
> perl `which perl` Makefile.PL
> Can't locate ExtUtils/MakeMaker.pm in @INC (you may need to install the ExtUtils::MakeMaker module)
>
> Add a new Perl module check in dependency.sh.
>
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Fran?ois Perrad <francois.perrad@gadz.org>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Regards,
Arnout
> ---
> support/dependencies/dependencies.sh | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/support/dependencies/dependencies.sh b/support/dependencies/dependencies.sh
> index 3146401..5832cf3 100755
> --- a/support/dependencies/dependencies.sh
> +++ b/support/dependencies/dependencies.sh
> @@ -238,6 +238,7 @@ fi
>
> # Check that the Perl installation is complete enough for Buildroot.
> required_perl_modules="Data::Dumper" # Needed to build host-autoconf
> +required_perl_modules="$required_perl_modules ExtUtils::MakeMaker" # Used by host-libxml-parser-perl
> required_perl_modules="$required_perl_modules Thread::Queue" # Used by host-automake
>
> # This variable will keep the modules that are missing in your system.
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/2] dependencies: check for MakeMaker Perl module
2016-07-06 22:43 [Buildroot] [PATCH 1/2] dependencies: check for MakeMaker Perl module Romain Naour
2016-07-06 22:43 ` [Buildroot] [PATCH 2/2] dependencies: check for Math BigInt/BigRat " Romain Naour
2016-10-16 10:06 ` [Buildroot] [PATCH 1/2] dependencies: check for MakeMaker " Arnout Vandecappelle
@ 2016-10-16 10:13 ` Thomas Petazzoni
2 siblings, 0 replies; 7+ messages in thread
From: Thomas Petazzoni @ 2016-10-16 10:13 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 7 Jul 2016 00:43:31 +0200, Romain Naour wrote:
> ExtUtils::MakeMaker is one of the Perl Core modules usually packaged in
> Perl package for a Debian/Ubuntu based system.
> For a Fedora based system, each Perl Core modules have their own RPM
> package. So install only Perl package is not enough.
>
> Fixes:
> >>> host-libxml-parser-perl 2.41 Configuring
> [...]
> perl `which perl` Makefile.PL
> Can't locate ExtUtils/MakeMaker.pm in @INC (you may need to install the ExtUtils::MakeMaker module)
>
> Add a new Perl module check in dependency.sh.
>
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Fran?ois Perrad <francois.perrad@gadz.org>
> ---
> support/dependencies/dependencies.sh | 1 +
> 1 file changed, 1 insertion(+)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 2/2] dependencies: check for Math BigInt/BigRat Perl module
2016-07-06 22:43 ` [Buildroot] [PATCH 2/2] dependencies: check for Math BigInt/BigRat " Romain Naour
2016-07-07 9:57 ` Thomas Petazzoni
@ 2016-10-16 10:13 ` Thomas Petazzoni
1 sibling, 0 replies; 7+ messages in thread
From: Thomas Petazzoni @ 2016-10-16 10:13 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 7 Jul 2016 00:43:32 +0200, Romain Naour wrote:
> As for MakeMaker Perl module, add a check for Math BigInt/BigRat Perl
> Core module.
>
> Fixes:
> Waf: Entering directory `output/build/mpv-0.17.0/build'
> [ 1/198] Compiling version.sh
> [ 12/198] Processing ebml_types.h: demux/ebml.c demux/demux_mkv.c -> build/ebml_types.h
> [ 13/198] Compiling demux/ebml.c
> Can't locate Math/BigRat.pm in @INC (you may need to install the Math::BigRat module)
>
> Waf: Entering directory `output/build/mpv-0.17.0/build'
> [ 1/198] Compiling version.sh
> [ 2/198] Compiling TOOLS/osxbundle/mpv.app/Contents/Resources/icon.icns
> [ 3/198] Compiling video/out/x11_icon.bin
> [ 4/198] Compiling etc/input.conf
> [ 5/198] Compiling sub/osd_font.otf
> [ 6/198] Compiling video/out/opengl/nnedi3_weights.bin
> [ 7/198] Compiling player/lua/defaults.lua
> [ 8/198] Compiling player/lua/assdraw.lua
> [ 9/198] Compiling player/lua/options.lua
> [ 10/198] Compiling player/lua/osc.lua
> [ 11/198] Compiling player/lua/ytdl_hook.lua
> [ 12/198] Processing ebml_types.h: demux/ebml.c demux/demux_mkv.c -> build/ebml_types.h
> [ 13/198] Compiling demux/ebml.c
> [ 14/198] Compiling DOCS/man/mpv.rst
> Can't locate Math/BigInt.pm in @INC (you may need to install the Math::BigInt module)
>
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Fran?ois Perrad <francois.perrad@gadz.org>
> ---
> support/dependencies/dependencies.sh | 2 ++
> 1 file changed, 2 insertions(+)
Applied, after making those Perl modules only required when mpv is
enabled.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-10-16 10:13 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-06 22:43 [Buildroot] [PATCH 1/2] dependencies: check for MakeMaker Perl module Romain Naour
2016-07-06 22:43 ` [Buildroot] [PATCH 2/2] dependencies: check for Math BigInt/BigRat " Romain Naour
2016-07-07 9:57 ` Thomas Petazzoni
2016-07-07 10:11 ` Romain Naour
2016-10-16 10:13 ` Thomas Petazzoni
2016-10-16 10:06 ` [Buildroot] [PATCH 1/2] dependencies: check for MakeMaker " Arnout Vandecappelle
2016-10-16 10:13 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.