* [PATCH 0/2] rds: logging neatening
@ 2016-10-15 18:53 Joe Perches
2016-10-15 18:53 ` [PATCH 1/2] rds: Remove unused rds_conn_error Joe Perches
2016-10-15 18:53 ` [PATCH 2/2] rds: Remove duplicate prefix from rds_conn_path_error use Joe Perches
0 siblings, 2 replies; 12+ messages in thread
From: Joe Perches @ 2016-10-15 18:53 UTC (permalink / raw)
To: netdev, linux-rdma, rds-devel
Cc: Santosh Shilimkar, David S. Miller, linux-kernel
Joe Perches (2):
rds: Remove unused rds_conn_error
rds: Remove duplicate prefix from rds_conn_path_error use
net/rds/connection.c | 15 ---------------
net/rds/rds.h | 4 ----
net/rds/threads.c | 3 +--
3 files changed, 1 insertion(+), 21 deletions(-)
--
2.10.0.rc2.1.g053435c
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 1/2] rds: Remove unused rds_conn_error
2016-10-15 18:53 [PATCH 0/2] rds: logging neatening Joe Perches
@ 2016-10-15 18:53 ` Joe Perches
2016-10-15 19:00 ` [rds-devel] " Sowmini Varadhan
` (2 more replies)
2016-10-15 18:53 ` [PATCH 2/2] rds: Remove duplicate prefix from rds_conn_path_error use Joe Perches
1 sibling, 3 replies; 12+ messages in thread
From: Joe Perches @ 2016-10-15 18:53 UTC (permalink / raw)
To: Santosh Shilimkar
Cc: David S. Miller, netdev, linux-rdma, rds-devel, linux-kernel
This macro's last use was removed in commit d769ef81d5b59
("RDS: Update rds_conn_shutdown to work with rds_conn_path")
so make the macro and the __rds_conn_error function definition
and declaration disappear.
Signed-off-by: Joe Perches <joe@perches.com>
---
net/rds/connection.c | 15 ---------------
net/rds/rds.h | 4 ----
2 files changed, 19 deletions(-)
diff --git a/net/rds/connection.c b/net/rds/connection.c
index f5058559bb08..13f459dad4ef 100644
--- a/net/rds/connection.c
+++ b/net/rds/connection.c
@@ -689,21 +689,6 @@ void rds_conn_connect_if_down(struct rds_connection *conn)
}
EXPORT_SYMBOL_GPL(rds_conn_connect_if_down);
-/*
- * An error occurred on the connection
- */
-void
-__rds_conn_error(struct rds_connection *conn, const char *fmt, ...)
-{
- va_list ap;
-
- va_start(ap, fmt);
- vprintk(fmt, ap);
- va_end(ap);
-
- rds_conn_drop(conn);
-}
-
void
__rds_conn_path_error(struct rds_conn_path *cp, const char *fmt, ...)
{
diff --git a/net/rds/rds.h b/net/rds/rds.h
index fd0bccb2f9f9..25532a46602f 100644
--- a/net/rds/rds.h
+++ b/net/rds/rds.h
@@ -683,10 +683,6 @@ void rds_for_each_conn_info(struct socket *sock, unsigned int len,
struct rds_info_lengths *lens,
int (*visitor)(struct rds_connection *, void *),
size_t item_len);
-__printf(2, 3)
-void __rds_conn_error(struct rds_connection *conn, const char *, ...);
-#define rds_conn_error(conn, fmt...) \
- __rds_conn_error(conn, KERN_WARNING "RDS: " fmt)
__printf(2, 3)
void __rds_conn_path_error(struct rds_conn_path *cp, const char *, ...);
--
2.10.0.rc2.1.g053435c
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/2] rds: Remove duplicate prefix from rds_conn_path_error use
2016-10-15 18:53 [PATCH 0/2] rds: logging neatening Joe Perches
2016-10-15 18:53 ` [PATCH 1/2] rds: Remove unused rds_conn_error Joe Perches
@ 2016-10-15 18:53 ` Joe Perches
[not found] ` <832b0d2c1b31c10db7692f65f1ba77e779db15e1.1476557523.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2016-10-17 15:07 ` David Miller
1 sibling, 2 replies; 12+ messages in thread
From: Joe Perches @ 2016-10-15 18:53 UTC (permalink / raw)
To: Santosh Shilimkar
Cc: David S. Miller, netdev, linux-rdma, rds-devel, linux-kernel
rds_conn_path_error already prefixes "RDS:" to the output.
Signed-off-by: Joe Perches <joe@perches.com>
---
net/rds/threads.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/rds/threads.c b/net/rds/threads.c
index e42df11bf30a..e36e333a0aa0 100644
--- a/net/rds/threads.c
+++ b/net/rds/threads.c
@@ -171,8 +171,7 @@ void rds_connect_worker(struct work_struct *work)
RDS_CONN_DOWN))
rds_queue_reconnect(cp);
else
- rds_conn_path_error(cp,
- "RDS: connect failed\n");
+ rds_conn_path_error(cp, "connect failed\n");
}
}
}
--
2.10.0.rc2.1.g053435c
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [rds-devel] [PATCH 2/2] rds: Remove duplicate prefix from rds_conn_path_error use
2016-10-15 18:53 ` [PATCH 2/2] rds: Remove duplicate prefix from rds_conn_path_error use Joe Perches
@ 2016-10-15 19:00 ` Sowmini Varadhan
2016-10-17 15:07 ` David Miller
1 sibling, 0 replies; 12+ messages in thread
From: Sowmini Varadhan @ 2016-10-15 19:00 UTC (permalink / raw)
To: Joe Perches
Cc: Santosh Shilimkar, linux-rdma-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA, rds-devel-N0ozoZBvEnrZJqsBc5GL+g,
David S. Miller, linux-kernel-u79uwXL29TY76Z2rM5mHXA
On (10/15/16 11:53), Joe Perches wrote:
>
> rds_conn_path_error already prefixes "RDS:" to the output.
>
> Signed-off-by: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
Acked-by: Sowmini Varadhan <sowmini.varadhan-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [rds-devel] [PATCH 2/2] rds: Remove duplicate prefix from rds_conn_path_error use
@ 2016-10-15 19:00 ` Sowmini Varadhan
0 siblings, 0 replies; 12+ messages in thread
From: Sowmini Varadhan @ 2016-10-15 19:00 UTC (permalink / raw)
To: Joe Perches
Cc: Santosh Shilimkar, linux-rdma, netdev, rds-devel,
David S. Miller, linux-kernel
On (10/15/16 11:53), Joe Perches wrote:
>
> rds_conn_path_error already prefixes "RDS:" to the output.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [rds-devel] [PATCH 1/2] rds: Remove unused rds_conn_error
2016-10-15 18:53 ` [PATCH 1/2] rds: Remove unused rds_conn_error Joe Perches
@ 2016-10-15 19:00 ` Sowmini Varadhan
[not found] ` <01fddf3af8f7757d0e79e4f25d7eb8b246e3d695.1476557523.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2016-10-17 15:07 ` David Miller
2 siblings, 0 replies; 12+ messages in thread
From: Sowmini Varadhan @ 2016-10-15 19:00 UTC (permalink / raw)
To: Joe Perches
Cc: Santosh Shilimkar, linux-rdma, netdev, rds-devel,
David S. Miller, linux-kernel
On (10/15/16 11:53), Joe Perches wrote:
> This macro's last use was removed in commit d769ef81d5b59
> ("RDS: Update rds_conn_shutdown to work with rds_conn_path")
> so make the macro and the __rds_conn_error function definition
> and declaration disappear.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] rds: Remove unused rds_conn_error
2016-10-15 18:53 ` [PATCH 1/2] rds: Remove unused rds_conn_error Joe Perches
@ 2016-10-15 19:38 ` Santosh Shilimkar
[not found] ` <01fddf3af8f7757d0e79e4f25d7eb8b246e3d695.1476557523.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2016-10-17 15:07 ` David Miller
2 siblings, 0 replies; 12+ messages in thread
From: Santosh Shilimkar @ 2016-10-15 19:38 UTC (permalink / raw)
To: Joe Perches
Cc: David S. Miller, netdev-u79uwXL29TY76Z2rM5mHXA,
linux-rdma-u79uwXL29TY76Z2rM5mHXA,
rds-devel-N0ozoZBvEnrZJqsBc5GL+g,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On 10/15/2016 11:53 AM, Joe Perches wrote:
> This macro's last use was removed in commit d769ef81d5b59
> ("RDS: Update rds_conn_shutdown to work with rds_conn_path")
> so make the macro and the __rds_conn_error function definition
> and declaration disappear.
>
> Signed-off-by: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
> ---
Had same patch along with few more in the queue but
didn't find time of late to get it on the list.
Thanks for both patches.
Acked-by: Santosh Shilimkar <santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] rds: Remove unused rds_conn_error
@ 2016-10-15 19:38 ` Santosh Shilimkar
0 siblings, 0 replies; 12+ messages in thread
From: Santosh Shilimkar @ 2016-10-15 19:38 UTC (permalink / raw)
To: Joe Perches; +Cc: David S. Miller, netdev, linux-rdma, rds-devel, linux-kernel
On 10/15/2016 11:53 AM, Joe Perches wrote:
> This macro's last use was removed in commit d769ef81d5b59
> ("RDS: Update rds_conn_shutdown to work with rds_conn_path")
> so make the macro and the __rds_conn_error function definition
> and declaration disappear.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
Had same patch along with few more in the queue but
didn't find time of late to get it on the list.
Thanks for both patches.
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] rds: Remove duplicate prefix from rds_conn_path_error use
2016-10-15 18:53 ` [PATCH 2/2] rds: Remove duplicate prefix from rds_conn_path_error use Joe Perches
@ 2016-10-15 19:38 ` Santosh Shilimkar
2016-10-17 15:07 ` David Miller
1 sibling, 0 replies; 12+ messages in thread
From: Santosh Shilimkar @ 2016-10-15 19:38 UTC (permalink / raw)
To: Joe Perches
Cc: David S. Miller, netdev-u79uwXL29TY76Z2rM5mHXA,
linux-rdma-u79uwXL29TY76Z2rM5mHXA,
rds-devel-N0ozoZBvEnrZJqsBc5GL+g,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On 10/15/2016 11:53 AM, Joe Perches wrote:
> rds_conn_path_error already prefixes "RDS:" to the output.
>
> Signed-off-by: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
> ---
Acked-by: Santosh Shilimkar <santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] rds: Remove duplicate prefix from rds_conn_path_error use
@ 2016-10-15 19:38 ` Santosh Shilimkar
0 siblings, 0 replies; 12+ messages in thread
From: Santosh Shilimkar @ 2016-10-15 19:38 UTC (permalink / raw)
To: Joe Perches; +Cc: David S. Miller, netdev, linux-rdma, rds-devel, linux-kernel
On 10/15/2016 11:53 AM, Joe Perches wrote:
> rds_conn_path_error already prefixes "RDS:" to the output.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] rds: Remove unused rds_conn_error
2016-10-15 18:53 ` [PATCH 1/2] rds: Remove unused rds_conn_error Joe Perches
2016-10-15 19:00 ` [rds-devel] " Sowmini Varadhan
[not found] ` <01fddf3af8f7757d0e79e4f25d7eb8b246e3d695.1476557523.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
@ 2016-10-17 15:07 ` David Miller
2 siblings, 0 replies; 12+ messages in thread
From: David Miller @ 2016-10-17 15:07 UTC (permalink / raw)
To: joe; +Cc: santosh.shilimkar, netdev, linux-rdma, rds-devel, linux-kernel
From: Joe Perches <joe@perches.com>
Date: Sat, 15 Oct 2016 11:53:21 -0700
> This macro's last use was removed in commit d769ef81d5b59
> ("RDS: Update rds_conn_shutdown to work with rds_conn_path")
> so make the macro and the __rds_conn_error function definition
> and declaration disappear.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] rds: Remove duplicate prefix from rds_conn_path_error use
2016-10-15 18:53 ` [PATCH 2/2] rds: Remove duplicate prefix from rds_conn_path_error use Joe Perches
[not found] ` <832b0d2c1b31c10db7692f65f1ba77e779db15e1.1476557523.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
@ 2016-10-17 15:07 ` David Miller
1 sibling, 0 replies; 12+ messages in thread
From: David Miller @ 2016-10-17 15:07 UTC (permalink / raw)
To: joe; +Cc: santosh.shilimkar, netdev, linux-rdma, rds-devel, linux-kernel
From: Joe Perches <joe@perches.com>
Date: Sat, 15 Oct 2016 11:53:22 -0700
> rds_conn_path_error already prefixes "RDS:" to the output.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2016-10-17 15:07 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-15 18:53 [PATCH 0/2] rds: logging neatening Joe Perches
2016-10-15 18:53 ` [PATCH 1/2] rds: Remove unused rds_conn_error Joe Perches
2016-10-15 19:00 ` [rds-devel] " Sowmini Varadhan
[not found] ` <01fddf3af8f7757d0e79e4f25d7eb8b246e3d695.1476557523.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2016-10-15 19:38 ` Santosh Shilimkar
2016-10-15 19:38 ` Santosh Shilimkar
2016-10-17 15:07 ` David Miller
2016-10-15 18:53 ` [PATCH 2/2] rds: Remove duplicate prefix from rds_conn_path_error use Joe Perches
[not found] ` <832b0d2c1b31c10db7692f65f1ba77e779db15e1.1476557523.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2016-10-15 19:00 ` [rds-devel] " Sowmini Varadhan
2016-10-15 19:00 ` Sowmini Varadhan
2016-10-15 19:38 ` Santosh Shilimkar
2016-10-15 19:38 ` Santosh Shilimkar
2016-10-17 15:07 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.