* [PATCH] MIPS: Use generic asm/unaligned.h
@ 2016-10-17 14:56 ` Paul Burton
0 siblings, 0 replies; 4+ messages in thread
From: Paul Burton @ 2016-10-17 14:56 UTC (permalink / raw)
To: linux-mips; +Cc: Paul Burton, Ralf Baechle
The MIPS-specific asm/unaligned.h provides nothing that the generic
version doesn't - it simply uses MIPS-specific endianness macros in
place of generic ones & lacks support for
CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS. Remove it & switch to using the
generic version to remove duplication.
Signed-off-by: Paul Burton <paul.burton@imgtec.com>
Cc: linux-mips@linux-mips.org
Cc: Ralf Baechle <ralf@linux-mips.org>
---
arch/mips/include/asm/Kbuild | 1 +
arch/mips/include/asm/unaligned.h | 28 ----------------------------
2 files changed, 1 insertion(+), 28 deletions(-)
delete mode 100644 arch/mips/include/asm/unaligned.h
diff --git a/arch/mips/include/asm/Kbuild b/arch/mips/include/asm/Kbuild
index 9740066..96b5be5 100644
--- a/arch/mips/include/asm/Kbuild
+++ b/arch/mips/include/asm/Kbuild
@@ -17,6 +17,7 @@ generic-y += sections.h
generic-y += segment.h
generic-y += serial.h
generic-y += trace_clock.h
+generic-y += unaligned.h
generic-y += user.h
generic-y += word-at-a-time.h
generic-y += xor.h
diff --git a/arch/mips/include/asm/unaligned.h b/arch/mips/include/asm/unaligned.h
deleted file mode 100644
index 42f66c3..0000000
--- a/arch/mips/include/asm/unaligned.h
+++ /dev/null
@@ -1,28 +0,0 @@
-/*
- * This file is subject to the terms and conditions of the GNU General Public
- * License. See the file "COPYING" in the main directory of this archive
- * for more details.
- *
- * Copyright (C) 2007 Ralf Baechle (ralf@linux-mips.org)
- */
-#ifndef _ASM_MIPS_UNALIGNED_H
-#define _ASM_MIPS_UNALIGNED_H
-
-#include <linux/compiler.h>
-#if defined(__MIPSEB__)
-# include <linux/unaligned/be_struct.h>
-# include <linux/unaligned/le_byteshift.h>
-# define get_unaligned __get_unaligned_be
-# define put_unaligned __put_unaligned_be
-#elif defined(__MIPSEL__)
-# include <linux/unaligned/le_struct.h>
-# include <linux/unaligned/be_byteshift.h>
-# define get_unaligned __get_unaligned_le
-# define put_unaligned __put_unaligned_le
-#else
-# error "MIPS, but neither __MIPSEB__, nor __MIPSEL__???"
-#endif
-
-# include <linux/unaligned/generic.h>
-
-#endif /* _ASM_MIPS_UNALIGNED_H */
--
2.10.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] MIPS: Use generic asm/unaligned.h
@ 2016-10-17 14:56 ` Paul Burton
0 siblings, 0 replies; 4+ messages in thread
From: Paul Burton @ 2016-10-17 14:56 UTC (permalink / raw)
To: linux-mips; +Cc: Paul Burton, Ralf Baechle
The MIPS-specific asm/unaligned.h provides nothing that the generic
version doesn't - it simply uses MIPS-specific endianness macros in
place of generic ones & lacks support for
CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS. Remove it & switch to using the
generic version to remove duplication.
Signed-off-by: Paul Burton <paul.burton@imgtec.com>
Cc: linux-mips@linux-mips.org
Cc: Ralf Baechle <ralf@linux-mips.org>
---
arch/mips/include/asm/Kbuild | 1 +
arch/mips/include/asm/unaligned.h | 28 ----------------------------
2 files changed, 1 insertion(+), 28 deletions(-)
delete mode 100644 arch/mips/include/asm/unaligned.h
diff --git a/arch/mips/include/asm/Kbuild b/arch/mips/include/asm/Kbuild
index 9740066..96b5be5 100644
--- a/arch/mips/include/asm/Kbuild
+++ b/arch/mips/include/asm/Kbuild
@@ -17,6 +17,7 @@ generic-y += sections.h
generic-y += segment.h
generic-y += serial.h
generic-y += trace_clock.h
+generic-y += unaligned.h
generic-y += user.h
generic-y += word-at-a-time.h
generic-y += xor.h
diff --git a/arch/mips/include/asm/unaligned.h b/arch/mips/include/asm/unaligned.h
deleted file mode 100644
index 42f66c3..0000000
--- a/arch/mips/include/asm/unaligned.h
+++ /dev/null
@@ -1,28 +0,0 @@
-/*
- * This file is subject to the terms and conditions of the GNU General Public
- * License. See the file "COPYING" in the main directory of this archive
- * for more details.
- *
- * Copyright (C) 2007 Ralf Baechle (ralf@linux-mips.org)
- */
-#ifndef _ASM_MIPS_UNALIGNED_H
-#define _ASM_MIPS_UNALIGNED_H
-
-#include <linux/compiler.h>
-#if defined(__MIPSEB__)
-# include <linux/unaligned/be_struct.h>
-# include <linux/unaligned/le_byteshift.h>
-# define get_unaligned __get_unaligned_be
-# define put_unaligned __put_unaligned_be
-#elif defined(__MIPSEL__)
-# include <linux/unaligned/le_struct.h>
-# include <linux/unaligned/be_byteshift.h>
-# define get_unaligned __get_unaligned_le
-# define put_unaligned __put_unaligned_le
-#else
-# error "MIPS, but neither __MIPSEB__, nor __MIPSEL__???"
-#endif
-
-# include <linux/unaligned/generic.h>
-
-#endif /* _ASM_MIPS_UNALIGNED_H */
--
2.10.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] MIPS: Use generic asm/unaligned.h
@ 2016-10-17 16:34 ` James Hogan
0 siblings, 0 replies; 4+ messages in thread
From: James Hogan @ 2016-10-17 16:34 UTC (permalink / raw)
To: Paul Burton; +Cc: linux-mips, Ralf Baechle
[-- Attachment #1: Type: text/plain, Size: 2455 bytes --]
On Mon, Oct 17, 2016 at 03:56:21PM +0100, Paul Burton wrote:
> The MIPS-specific asm/unaligned.h provides nothing that the generic
> version doesn't - it simply uses MIPS-specific endianness macros in
> place of generic ones & lacks support for
> CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS. Remove it & switch to using the
> generic version to remove duplication.
>
> Signed-off-by: Paul Burton <paul.burton@imgtec.com>
> Cc: linux-mips@linux-mips.org
> Cc: Ralf Baechle <ralf@linux-mips.org>
Reviewed-by: James Hogan <james.hogan@imgtec.com>
Cheers
James
> ---
>
> arch/mips/include/asm/Kbuild | 1 +
> arch/mips/include/asm/unaligned.h | 28 ----------------------------
> 2 files changed, 1 insertion(+), 28 deletions(-)
> delete mode 100644 arch/mips/include/asm/unaligned.h
>
> diff --git a/arch/mips/include/asm/Kbuild b/arch/mips/include/asm/Kbuild
> index 9740066..96b5be5 100644
> --- a/arch/mips/include/asm/Kbuild
> +++ b/arch/mips/include/asm/Kbuild
> @@ -17,6 +17,7 @@ generic-y += sections.h
> generic-y += segment.h
> generic-y += serial.h
> generic-y += trace_clock.h
> +generic-y += unaligned.h
> generic-y += user.h
> generic-y += word-at-a-time.h
> generic-y += xor.h
> diff --git a/arch/mips/include/asm/unaligned.h b/arch/mips/include/asm/unaligned.h
> deleted file mode 100644
> index 42f66c3..0000000
> --- a/arch/mips/include/asm/unaligned.h
> +++ /dev/null
> @@ -1,28 +0,0 @@
> -/*
> - * This file is subject to the terms and conditions of the GNU General Public
> - * License. See the file "COPYING" in the main directory of this archive
> - * for more details.
> - *
> - * Copyright (C) 2007 Ralf Baechle (ralf@linux-mips.org)
> - */
> -#ifndef _ASM_MIPS_UNALIGNED_H
> -#define _ASM_MIPS_UNALIGNED_H
> -
> -#include <linux/compiler.h>
> -#if defined(__MIPSEB__)
> -# include <linux/unaligned/be_struct.h>
> -# include <linux/unaligned/le_byteshift.h>
> -# define get_unaligned __get_unaligned_be
> -# define put_unaligned __put_unaligned_be
> -#elif defined(__MIPSEL__)
> -# include <linux/unaligned/le_struct.h>
> -# include <linux/unaligned/be_byteshift.h>
> -# define get_unaligned __get_unaligned_le
> -# define put_unaligned __put_unaligned_le
> -#else
> -# error "MIPS, but neither __MIPSEB__, nor __MIPSEL__???"
> -#endif
> -
> -# include <linux/unaligned/generic.h>
> -
> -#endif /* _ASM_MIPS_UNALIGNED_H */
> --
> 2.10.0
>
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MIPS: Use generic asm/unaligned.h
@ 2016-10-17 16:34 ` James Hogan
0 siblings, 0 replies; 4+ messages in thread
From: James Hogan @ 2016-10-17 16:34 UTC (permalink / raw)
To: Paul Burton; +Cc: linux-mips, Ralf Baechle
[-- Attachment #1: Type: text/plain, Size: 2455 bytes --]
On Mon, Oct 17, 2016 at 03:56:21PM +0100, Paul Burton wrote:
> The MIPS-specific asm/unaligned.h provides nothing that the generic
> version doesn't - it simply uses MIPS-specific endianness macros in
> place of generic ones & lacks support for
> CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS. Remove it & switch to using the
> generic version to remove duplication.
>
> Signed-off-by: Paul Burton <paul.burton@imgtec.com>
> Cc: linux-mips@linux-mips.org
> Cc: Ralf Baechle <ralf@linux-mips.org>
Reviewed-by: James Hogan <james.hogan@imgtec.com>
Cheers
James
> ---
>
> arch/mips/include/asm/Kbuild | 1 +
> arch/mips/include/asm/unaligned.h | 28 ----------------------------
> 2 files changed, 1 insertion(+), 28 deletions(-)
> delete mode 100644 arch/mips/include/asm/unaligned.h
>
> diff --git a/arch/mips/include/asm/Kbuild b/arch/mips/include/asm/Kbuild
> index 9740066..96b5be5 100644
> --- a/arch/mips/include/asm/Kbuild
> +++ b/arch/mips/include/asm/Kbuild
> @@ -17,6 +17,7 @@ generic-y += sections.h
> generic-y += segment.h
> generic-y += serial.h
> generic-y += trace_clock.h
> +generic-y += unaligned.h
> generic-y += user.h
> generic-y += word-at-a-time.h
> generic-y += xor.h
> diff --git a/arch/mips/include/asm/unaligned.h b/arch/mips/include/asm/unaligned.h
> deleted file mode 100644
> index 42f66c3..0000000
> --- a/arch/mips/include/asm/unaligned.h
> +++ /dev/null
> @@ -1,28 +0,0 @@
> -/*
> - * This file is subject to the terms and conditions of the GNU General Public
> - * License. See the file "COPYING" in the main directory of this archive
> - * for more details.
> - *
> - * Copyright (C) 2007 Ralf Baechle (ralf@linux-mips.org)
> - */
> -#ifndef _ASM_MIPS_UNALIGNED_H
> -#define _ASM_MIPS_UNALIGNED_H
> -
> -#include <linux/compiler.h>
> -#if defined(__MIPSEB__)
> -# include <linux/unaligned/be_struct.h>
> -# include <linux/unaligned/le_byteshift.h>
> -# define get_unaligned __get_unaligned_be
> -# define put_unaligned __put_unaligned_be
> -#elif defined(__MIPSEL__)
> -# include <linux/unaligned/le_struct.h>
> -# include <linux/unaligned/be_byteshift.h>
> -# define get_unaligned __get_unaligned_le
> -# define put_unaligned __put_unaligned_le
> -#else
> -# error "MIPS, but neither __MIPSEB__, nor __MIPSEL__???"
> -#endif
> -
> -# include <linux/unaligned/generic.h>
> -
> -#endif /* _ASM_MIPS_UNALIGNED_H */
> --
> 2.10.0
>
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-17 16:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-17 14:56 [PATCH] MIPS: Use generic asm/unaligned.h Paul Burton
2016-10-17 14:56 ` Paul Burton
2016-10-17 16:34 ` James Hogan
2016-10-17 16:34 ` James Hogan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.