[Qemu-devel] [PATCH 0/2] tests: A few check-qom-proplist fixes

[Qemu-devel] [PATCH 0/2] tests: A few check-qom-proplist fixes

[Eduardo Habkost]

A few fixes on check-qom-proplist that will ensure we test both
class properties and object properties, and catch errors when
registering properties in test code.

Eduardo Habkost (2):
  tests: check-qom-proplist: Remove "bv" class property from class
  tests: check-qom-proplist: Use &error_abort to catch errors

 tests/check-qom-proplist.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

-- 
2.7.4

[Qemu-devel] [PATCH 1/2] tests: check-qom-proplist: Remove "bv" class property from class

[Eduardo Habkost]

The object_property_add_bool() call in dummy_init() was always
failing because there was a "bv" class property already. Remove
the class property so both object properties and class properties
are covered by the test code.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 tests/check-qom-proplist.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/tests/check-qom-proplist.c b/tests/check-qom-proplist.c
index a16cefc..693dc4c 100644
--- a/tests/check-qom-proplist.c
+++ b/tests/check-qom-proplist.c
@@ -129,10 +129,6 @@ static void dummy_init(Object *obj)
 
 static void dummy_class_init(ObjectClass *cls, void *data)
 {
-    object_class_property_add_bool(cls, "bv",
-                                   dummy_get_bv,
-                                   dummy_set_bv,
-                                   NULL);
     object_class_property_add_str(cls, "sv",
                                   dummy_get_sv,
                                   dummy_set_sv,
-- 
2.7.4

[Qemu-devel] [PATCH 2/2] tests: check-qom-proplist: Use &error_abort to catch errors

[Eduardo Habkost]

Use &error_abort so we don't ignore any errors on the property
registration calls.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 tests/check-qom-proplist.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/check-qom-proplist.c b/tests/check-qom-proplist.c
index 693dc4c..a92acc9 100644
--- a/tests/check-qom-proplist.c
+++ b/tests/check-qom-proplist.c
@@ -123,7 +123,7 @@ static void dummy_init(Object *obj)
     object_property_add_bool(obj, "bv",
                              dummy_get_bv,
                              dummy_set_bv,
-                             NULL);
+                             &error_abort);
 }
 
 
@@ -132,13 +132,13 @@ static void dummy_class_init(ObjectClass *cls, void *data)
     object_class_property_add_str(cls, "sv",
                                   dummy_get_sv,
                                   dummy_set_sv,
-                                  NULL);
+                                  &error_abort);
     object_class_property_add_enum(cls, "av",
                                    "DummyAnimal",
                                    dummy_animal_map,
                                    dummy_get_av,
                                    dummy_set_av,
-                                   NULL);
+                                   &error_abort);
 }
 
 
-- 
2.7.4

Re: [Qemu-devel] [PATCH 1/2] tests: check-qom-proplist: Remove "bv" class property from class

[Daniel P. Berrange]

On Tue, Oct 11, 2016 at 09:37:46AM -0300, Eduardo Habkost wrote:
> The object_property_add_bool() call in dummy_init() was always
> failing because there was a "bv" class property already. Remove
> the class property so both object properties and class properties
> are covered by the test code.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  tests/check-qom-proplist.c | 4 ----
>  1 file changed, 4 deletions(-)

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|

Re: [Qemu-devel] [PATCH 2/2] tests: check-qom-proplist: Use &error_abort to catch errors

[Daniel P. Berrange]

On Tue, Oct 11, 2016 at 09:37:47AM -0300, Eduardo Habkost wrote:
> Use &error_abort so we don't ignore any errors on the property
> registration calls.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  tests/check-qom-proplist.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|

Re: [Qemu-devel] [PATCH 0/2] tests: A few check-qom-proplist fixes

[Eduardo Habkost]

Ping?

Markus, do you want to merge this through your tree?

On Tue, Oct 11, 2016 at 09:37:45AM -0300, Eduardo Habkost wrote:
> A few fixes on check-qom-proplist that will ensure we test both
> class properties and object properties, and catch errors when
> registering properties in test code.
> 
> Eduardo Habkost (2):
>   tests: check-qom-proplist: Remove "bv" class property from class
>   tests: check-qom-proplist: Use &error_abort to catch errors
> 
>  tests/check-qom-proplist.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
> 
> -- 
> 2.7.4
> 

-- 
Eduardo

Re: [Qemu-devel] [PATCH 0/2] tests: A few check-qom-proplist fixes

[Andreas Färber]

Am 17.10.2016 um 23:02 schrieb Eduardo Habkost:
> Ping?
> 
> Markus, do you want to merge this through your tree?
> 
> On Tue, Oct 11, 2016 at 09:37:45AM -0300, Eduardo Habkost wrote:
>> A few fixes on check-qom-proplist that will ensure we test both
>> class properties and object properties, and catch errors when
>> registering properties in test code.
>>
>> Eduardo Habkost (2):
>>   tests: check-qom-proplist: Remove "bv" class property from class

This part I didn't quite understand from looking at the patch, but...

>>   tests: check-qom-proplist: Use &error_abort to catch errors

For this one:

Reviewed-by: Andreas Färber <afaerber@suse.de>

Regards,
Andreas

>>  tests/check-qom-proplist.c | 10 +++-------
>>  1 file changed, 3 insertions(+), 7 deletions(-)

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

Re: [Qemu-devel] [PATCH 0/2] tests: A few check-qom-proplist fixes

[Eduardo Habkost]

On Tue, Oct 18, 2016 at 12:07:30AM +0200, Andreas Färber wrote:
> Am 17.10.2016 um 23:02 schrieb Eduardo Habkost:
> > Ping?
> > 
> > Markus, do you want to merge this through your tree?
> > 
> > On Tue, Oct 11, 2016 at 09:37:45AM -0300, Eduardo Habkost wrote:
> >> A few fixes on check-qom-proplist that will ensure we test both
> >> class properties and object properties, and catch errors when
> >> registering properties in test code.
> >>
> >> Eduardo Habkost (2):
> >>   tests: check-qom-proplist: Remove "bv" class property from class
> 
> This part I didn't quite understand from looking at the patch, but...

The "bv" property was being registered twice (as class property
and as instance property). The instance property registration was
always failing because of that.

One of them has to go away. I decided to remove the class
property because this allows the test code to cover both instance
properties ("bv") and class properties ("sv").

> 
> >>   tests: check-qom-proplist: Use &error_abort to catch errors
> 
> For this one:
> 
> Reviewed-by: Andreas Färber <afaerber@suse.de>

Thanks!

-- 
Eduardo

Re: [Qemu-devel] [PATCH 0/2] tests: A few check-qom-proplist fixes

[Eduardo Habkost]

Pinging again.

On Mon, Oct 17, 2016 at 07:02:37PM -0200, Eduardo Habkost wrote:
> Ping?
> 
> Markus, do you want to merge this through your tree?
> 
> On Tue, Oct 11, 2016 at 09:37:45AM -0300, Eduardo Habkost wrote:
> > A few fixes on check-qom-proplist that will ensure we test both
> > class properties and object properties, and catch errors when
> > registering properties in test code.
> > 
> > Eduardo Habkost (2):
> >   tests: check-qom-proplist: Remove "bv" class property from class
> >   tests: check-qom-proplist: Use &error_abort to catch errors
> > 
> >  tests/check-qom-proplist.c | 10 +++-------
> >  1 file changed, 3 insertions(+), 7 deletions(-)
> > 
> > -- 
> > 2.7.4
> > 
> 
> -- 
> Eduardo
> 

-- 
Eduardo

Re: [Qemu-devel] [PATCH 0/2] tests: A few check-qom-proplist fixes

[Markus Armbruster]

Eduardo Habkost <ehabkost@redhat.com> writes:

> A few fixes on check-qom-proplist that will ensure we test both
> class properties and object properties, and catch errors when
> registering properties in test code.

Series
Reviewed-by: Markus Armbruster <armbru@redhat.com>

Excessively long delay considering how simple these patches are.  My
apologies.