* [Buildroot] [PATCH] qt5base: fix misspelling of "directfb"
@ 2016-10-18 2:09 Matt Kraai
2016-10-18 9:45 ` Thomas Petazzoni
0 siblings, 1 reply; 4+ messages in thread
From: Matt Kraai @ 2016-10-18 2:09 UTC (permalink / raw)
To: buildroot
---
package/qt5/qt5base/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/qt5/qt5base/Config.in b/package/qt5/qt5base/Config.in
index 64a7f65..6933523 100644
--- a/package/qt5/qt5base/Config.in
+++ b/package/qt5/qt5base/Config.in
@@ -180,7 +180,7 @@ config BR2_PACKAGE_QT5BASE_DIRECTFB
bool "directfb support"
depends on BR2_PACKAGE_DIRECTFB
-comment "directfb backend if directb is enabled"
+comment "directfb backend if directfb is enabled"
depends on !BR2_PACKAGE_DIRECTFB
config BR2_PACKAGE_QT5BASE_XCB
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] qt5base: fix misspelling of "directfb"
2016-10-18 2:09 [Buildroot] [PATCH] qt5base: fix misspelling of "directfb" Matt Kraai
@ 2016-10-18 9:45 ` Thomas Petazzoni
2016-10-18 13:47 ` Matt Kraai
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2016-10-18 9:45 UTC (permalink / raw)
To: buildroot
Hello,
On Mon, 17 Oct 2016 19:09:56 -0700, Matt Kraai wrote:
> -comment "directfb backend if directb is enabled"
> +comment "directfb backend if directfb is enabled"
> depends on !BR2_PACKAGE_DIRECTFB
Thanks, but this sentence in fact doesn't make a lot of sense. It
should be something like:
directfb backend needs directfb to be enabled
Or perhaps no comment at all because it's completely obvious that to
use DirectFB functionality, you need DirectFB.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] qt5base: fix misspelling of "directfb"
2016-10-18 9:45 ` Thomas Petazzoni
@ 2016-10-18 13:47 ` Matt Kraai
2016-10-18 13:51 ` Thomas Petazzoni
0 siblings, 1 reply; 4+ messages in thread
From: Matt Kraai @ 2016-10-18 13:47 UTC (permalink / raw)
To: buildroot
Hi,
On Tue, Oct 18, 2016 at 11:45:56AM +0200, Thomas Petazzoni wrote:
> On Mon, 17 Oct 2016 19:09:56 -0700, Matt Kraai wrote:
>
> > -comment "directfb backend if directb is enabled"
> > +comment "directfb backend if directfb is enabled"
> > depends on !BR2_PACKAGE_DIRECTFB
>
> Thanks, but this sentence in fact doesn't make a lot of sense. It
> should be something like:
>
> directfb backend needs directfb to be enabled
>
> Or perhaps no comment at all because it's completely obvious that to
> use DirectFB functionality, you need DirectFB.
If the comment is removed, then there is no indication that a directfb
backend is available if directfb is disabled. That's inconsistent
with the handling of the other backends, which have the following
comments if they're not available:
* X.org XCB backend available if X.org is enabled
* eglfs backend available if OpenGL and EGL are enabled
Should I still remove the comment? Or make the message consistent
with the other backends (i.e., "directfb backend available if directfb
is enabled")?
--
Matt https://ftbfs.org/~kraai/
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] qt5base: fix misspelling of "directfb"
2016-10-18 13:47 ` Matt Kraai
@ 2016-10-18 13:51 ` Thomas Petazzoni
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2016-10-18 13:51 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 18 Oct 2016 06:47:54 -0700, Matt Kraai wrote:
> If the comment is removed, then there is no indication that a directfb
> backend is available if directfb is disabled. That's inconsistent
> with the handling of the other backends, which have the following
> comments if they're not available:
>
> * X.org XCB backend available if X.org is enabled
> * eglfs backend available if OpenGL and EGL are enabled
Indeed.
> Should I still remove the comment? Or make the message consistent
> with the other backends (i.e., "directfb backend available if directfb
> is enabled")?
Let's keep the comment, just adjusted.
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-18 13:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-18 2:09 [Buildroot] [PATCH] qt5base: fix misspelling of "directfb" Matt Kraai
2016-10-18 9:45 ` Thomas Petazzoni
2016-10-18 13:47 ` Matt Kraai
2016-10-18 13:51 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.