Re: drivers/tty/serial/max310x doesn't support latest UART revision of MAX14830

Re: drivers/tty/serial/max310x doesn't support latest UART revision of MAX14830

[gregkh]

On Wed, Oct 19, 2016 at 08:12:13AM +0000, Roberto Manuel SARA wrote:
> Confidentiality Warning: This message and any
> attachments are intended only for the use of the intended recipient(s), are
> confidential, and may be privileged. If you are not the intended recipient, you
> are hereby notified that any review, retransmission, conversion to hard copy,
> copying, circulation or other use of this message and any attachments is
> strictly prohibited. If you are not the intended recipient, please notify the
> sender immediately by return e-mail, and delete this message and any
> attachments from your system. Thank-you.

I am not allowed to respond to such emails as it is not compatible with
doing work in the open for Linux.  Please remove and I will be glad to
reply.

thanks,

greg k-h

Re: drivers/tty/serial/max310x doesn't support latest UART revision of MAX14830

[Uwe Kleine-König]

On Wed, Oct 19, 2016 at 10:18:59AM +0200, gregkh@linuxfoundation.org wrote:
> On Wed, Oct 19, 2016 at 08:12:13AM +0000, Roberto Manuel SARA wrote:
> > Confidentiality Warning: This message and any
> > attachments are intended only for the use of the intended recipient(s), are
> > confidential, and may be privileged. If you are not the intended recipient, you
> > are hereby notified that any review, retransmission, conversion to hard copy,
> > copying, circulation or other use of this message and any attachments is
> > strictly prohibited. If you are not the intended recipient, please notify the
> > sender immediately by return e-mail, and delete this message and any
> > attachments from your system. Thank-you.
> 
> I am not allowed to respond to such emails as it is not compatible with
> doing work in the open for Linux.  Please remove and I will be glad to
> reply.

INAL, but from a logical POV: When this mail was sent to a public
mailing list, everyone could consider itself being an "intended
recipient" which would lift all limitations. :-)

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Re: drivers/tty/serial/max310x doesn't support latest UART revision of MAX14830

[gregkh]

On Wed, Oct 19, 2016 at 05:03:44PM +0200, Uwe Kleine-König wrote:
> On Wed, Oct 19, 2016 at 10:18:59AM +0200, gregkh@linuxfoundation.org wrote:
> > On Wed, Oct 19, 2016 at 08:12:13AM +0000, Roberto Manuel SARA wrote:
> > > Confidentiality Warning: This message and any
> > > attachments are intended only for the use of the intended recipient(s), are
> > > confidential, and may be privileged. If you are not the intended recipient, you
> > > are hereby notified that any review, retransmission, conversion to hard copy,
> > > copying, circulation or other use of this message and any attachments is
> > > strictly prohibited. If you are not the intended recipient, please notify the
> > > sender immediately by return e-mail, and delete this message and any
> > > attachments from your system. Thank-you.
> > 
> > I am not allowed to respond to such emails as it is not compatible with
> > doing work in the open for Linux.  Please remove and I will be glad to
> > reply.
> 
> INAL, but from a logical POV: When this mail was sent to a public
> mailing list, everyone could consider itself being an "intended
> recipient" which would lift all limitations. :-)

Not according to my lawyer, who is one, and whom I trust better than
random people claiming not to be one :)

thanks,

greg k-h

Re: drivers/tty/serial/max310x doesn't support latest UART revision of MAX14830

[Greg KH]

On Wed, Oct 19, 2016 at 10:53:24AM +0200, Roberto Sara wrote:
> Sorry, 4.4 is the latest I can get for this embedded system. 
> A quick check online shows that 4.8.2 has the same value and detection routine.

Great, can you send a patch please?

greg k-h

Re: drivers/tty/serial/max310x doesn't support latest UART revision of MAX14830

[Greg KH]

On Wed, Oct 19, 2016 at 10:25:41AM +0200, Roberto Sara wrote:
> Kernel 4.4.22

That's pretty old and obsolete, can you try 4.8?

> MAX310x_REV_MASK has a value of 0xfc which only allows for UART revisions of
> 0xb0 to 0xb3.
> 
> The latest MAX14830 UARTS have revision number 0xb4.  The data sheet only
> states that revisions start at 0xb0.
> 
> I suggest a change of MAX310x_REV_MASK to 0xf8, which will allow revisions up
> to 0xb7

Great, can you send a patch that you have tested to work properly?

thanks,

greg k-h