All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Christoph Hellwig <hch@lst.de>
Cc: Andy Lutomirski <luto@amacapital.net>,
	Andrew Morton <akpm@linux-foundation.org>,
	joelaf@google.com, jszhang@marvell.com, joaodias@google.com,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	linux-rt-users@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/6] mm: mark all calls into the vmalloc subsystem as potentially sleeping
Date: Wed, 19 Oct 2016 20:43:33 +0100	[thread overview]
Message-ID: <20161019194333.GD19173@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <20161019163112.GA31091@lst.de>

On Wed, Oct 19, 2016 at 06:31:12PM +0200, Christoph Hellwig wrote:
> On Wed, Oct 19, 2016 at 08:34:40AM -0700, Andy Lutomirski wrote:
> > 
> > It would be quite awkward for a task stack to get freed from a
> > sleepable context, because the obvious sleepable context is the task
> > itself, and it still needs its stack.  This was true even in the old
> > regime when task stacks were freed from RCU context.
> > 
> > But vfree has a magic automatic deferral mechanism.  Couldn't you make
> > the non-deferred case might_sleep()?
> 
> But it's only magic from interrupt context..
> 
> Chris, does this patch make virtually mapped stack work for you again?

So far, so good. No warns from anyone else.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Christoph Hellwig <hch@lst.de>
Cc: Andy Lutomirski <luto@amacapital.net>,
	Andrew Morton <akpm@linux-foundation.org>,
	joelaf@google.com, jszhang@marvell.com, joaodias@google.com,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	linux-rt-users@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/6] mm: mark all calls into the vmalloc subsystem as potentially sleeping
Date: Wed, 19 Oct 2016 20:43:33 +0100	[thread overview]
Message-ID: <20161019194333.GD19173@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <20161019163112.GA31091@lst.de>

On Wed, Oct 19, 2016 at 06:31:12PM +0200, Christoph Hellwig wrote:
> On Wed, Oct 19, 2016 at 08:34:40AM -0700, Andy Lutomirski wrote:
> > 
> > It would be quite awkward for a task stack to get freed from a
> > sleepable context, because the obvious sleepable context is the task
> > itself, and it still needs its stack.  This was true even in the old
> > regime when task stacks were freed from RCU context.
> > 
> > But vfree has a magic automatic deferral mechanism.  Couldn't you make
> > the non-deferred case might_sleep()?
> 
> But it's only magic from interrupt context..
> 
> Chris, does this patch make virtually mapped stack work for you again?

So far, so good. No warns from anyone else.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2016-10-19 19:43 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-18  6:56 [RFC] reduce latency in __purge_vmap_area_lazy Christoph Hellwig
2016-10-18  6:56 ` Christoph Hellwig
2016-10-18  6:56 ` [PATCH 1/6] mm: refactor __purge_vmap_area_lazy Christoph Hellwig
2016-10-18  6:56   ` Christoph Hellwig
2016-10-18  6:56 ` [PATCH 2/6] mm: mark all calls into the vmalloc subsystem as potentially sleeping Christoph Hellwig
2016-10-18  6:56   ` Christoph Hellwig
2016-10-18 10:33   ` Chris Wilson
2016-10-18 10:33     ` Chris Wilson
2016-10-18 10:38     ` Christoph Hellwig
2016-10-18 10:38       ` Christoph Hellwig
2016-10-19 11:15   ` Chris Wilson
2016-10-19 11:15     ` Chris Wilson
2016-10-19 13:05     ` Christoph Hellwig
2016-10-19 13:05       ` Christoph Hellwig
2016-10-19 15:34       ` Andy Lutomirski
2016-10-19 15:34         ` Andy Lutomirski
2016-10-19 16:31         ` Christoph Hellwig
2016-10-19 16:31           ` Christoph Hellwig
2016-10-19 19:43           ` Chris Wilson [this message]
2016-10-19 19:43             ` Chris Wilson
2016-10-21  0:32           ` Joel Fernandes
2016-10-21  0:32             ` Joel Fernandes
2016-11-08 13:24     ` Joel Fernandes
2016-11-08 13:24       ` Joel Fernandes
2016-11-08 14:32       ` Andrey Ryabinin
2016-11-08 14:32         ` Andrey Ryabinin
2016-10-18  6:56 ` [PATCH 3/6] mm: remove free_unmap_vmap_area_noflush Christoph Hellwig
2016-10-18  6:56   ` Christoph Hellwig
2016-10-18  6:56 ` [PATCH 4/6] mm: remove free_unmap_vmap_area_addr Christoph Hellwig
2016-10-18  6:56   ` Christoph Hellwig
2016-10-21  0:46   ` Joel Fernandes
2016-10-21  0:46     ` Joel Fernandes
2016-10-21  1:58     ` Nicholas Piggin
2016-10-21  1:58       ` Nicholas Piggin
2016-10-18  6:56 ` [PATCH 5/6] mm: turn vmap_purge_lock into a mutex Christoph Hellwig
2016-10-18  6:56   ` Christoph Hellwig
2016-10-18  6:56 ` [PATCH 6/6] mm: add preempt points into __purge_vmap_area_lazy Christoph Hellwig
2016-10-18  6:56   ` Christoph Hellwig
2016-10-18 20:56   ` Steven Rostedt
2016-10-18 20:56     ` Steven Rostedt
2016-10-18 21:01     ` Steven Rostedt
2016-10-18 21:01       ` Steven Rostedt
2016-10-18 10:40 ` [RFC] reduce latency in __purge_vmap_area_lazy Nicholas Piggin
2016-10-18 10:40   ` Nicholas Piggin
2016-10-18 11:21 ` Jisheng Zhang
2016-10-18 11:21   ` Jisheng Zhang
2016-10-18 11:21   ` Jisheng Zhang
2016-10-21  1:08 ` Joel Fernandes
2016-10-21  1:08   ` Joel Fernandes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161019194333.GD19173@nuc-i3427.alporthouse.com \
    --to=chris@chris-wilson.co.uk \
    --cc=akpm@linux-foundation.org \
    --cc=hch@lst.de \
    --cc=joaodias@google.com \
    --cc=joelaf@google.com \
    --cc=jszhang@marvell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=luto@amacapital.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.