* [PATCH] padata: Remove unused but set variables
@ 2016-10-17 10:16 Tobias Klauser
2016-10-21 9:00 ` Steffen Klassert
0 siblings, 1 reply; 3+ messages in thread
From: Tobias Klauser @ 2016-10-17 10:16 UTC (permalink / raw)
To: Steffen Klassert; +Cc: linux-crypto, linux-kernel
Remove the unused but set variable pinst in padata_parallel_worker to
fix the following warning when building with 'W=1':
kernel/padata.c: In function ‘padata_parallel_worker’:
kernel/padata.c:68:26: warning: variable ‘pinst’ set but not used [-Wunused-but-set-variable]
Also remove the now unused variable pd which is only used to set pinst.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
kernel/padata.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/kernel/padata.c b/kernel/padata.c
index 7848f0566403..05316c9f32da 100644
--- a/kernel/padata.c
+++ b/kernel/padata.c
@@ -64,15 +64,11 @@ static int padata_cpu_hash(struct parallel_data *pd)
static void padata_parallel_worker(struct work_struct *parallel_work)
{
struct padata_parallel_queue *pqueue;
- struct parallel_data *pd;
- struct padata_instance *pinst;
LIST_HEAD(local_list);
local_bh_disable();
pqueue = container_of(parallel_work,
struct padata_parallel_queue, work);
- pd = pqueue->pd;
- pinst = pd->pinst;
spin_lock(&pqueue->parallel.lock);
list_replace_init(&pqueue->parallel.list, &local_list);
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] padata: Remove unused but set variables
2016-10-17 10:16 [PATCH] padata: Remove unused but set variables Tobias Klauser
@ 2016-10-21 9:00 ` Steffen Klassert
2016-10-25 3:38 ` Herbert Xu
0 siblings, 1 reply; 3+ messages in thread
From: Steffen Klassert @ 2016-10-21 9:00 UTC (permalink / raw)
To: Tobias Klauser; +Cc: linux-crypto, linux-kernel
On Mon, Oct 17, 2016 at 12:16:08PM +0200, Tobias Klauser wrote:
> Remove the unused but set variable pinst in padata_parallel_worker to
> fix the following warning when building with 'W=1':
>
> kernel/padata.c: In function ‘padata_parallel_worker’:
> kernel/padata.c:68:26: warning: variable ‘pinst’ set but not used [-Wunused-but-set-variable]
>
> Also remove the now unused variable pd which is only used to set pinst.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Acked-by: Steffen Klassert <steffen.klassert@secunet.com>
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] padata: Remove unused but set variables
2016-10-21 9:00 ` Steffen Klassert
@ 2016-10-25 3:38 ` Herbert Xu
0 siblings, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2016-10-25 3:38 UTC (permalink / raw)
To: Steffen Klassert; +Cc: tklauser, linux-crypto, linux-kernel
Steffen Klassert <steffen.klassert@secunet.com> wrote:
> On Mon, Oct 17, 2016 at 12:16:08PM +0200, Tobias Klauser wrote:
>> Remove the unused but set variable pinst in padata_parallel_worker to
>> fix the following warning when building with 'W=1':
>>
>> kernel/padata.c: In function ‘padata_parallel_worker’:
>> kernel/padata.c:68:26: warning: variable ‘pinst’ set but not used [-Wunused-but-set-variable]
>>
>> Also remove the now unused variable pd which is only used to set pinst.
>>
>> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
>
> Acked-by: Steffen Klassert <steffen.klassert@secunet.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-25 3:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-17 10:16 [PATCH] padata: Remove unused but set variables Tobias Klauser
2016-10-21 9:00 ` Steffen Klassert
2016-10-25 3:38 ` Herbert Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.