All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Jan Dakinevich <jan.dakinevich@gmail.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com, kernellwp@gmail.com
Subject: Re: [PATCH 1/2] KVM: VMX: clean up declaration of VPID/EPT invalidation types
Date: Fri, 21 Oct 2016 21:40:29 +0200	[thread overview]
Message-ID: <20161021194029.GB29131@potion> (raw)
In-Reply-To: <1476830705-19269-1-git-send-email-jan.dakinevich@gmail.com>

2016-10-19 01:45+0300, Jan Dakinevich:
>  - Remove VMX_EPT_EXTENT_INDIVIDUAL_ADDR, since there is no such type of
>    EPT invalidation
> 
>  - Rename VMX_VPID_EXTENT_ALL_CONTEXT to VMX_VPID_EXTENT_GLOBAL_CONTEXT
>    for consitency: all-context VPID invalidation is referenced  by
>    "global" keyword in all other places of code

SDM names this invalidation as "all contexts" and global translations
have a different meaning, so I would keep it, for clarity.

We already use the other meaning in SINGLE_CONTEXT_RETAINING_GLOBALS and
for example INVPCID has type for "all contexts, including globals" and
"all contexts, excluding globals", so we will have to really distinguish
global and global at some point ...

>  - Add missing VPID types names
> 
> Signed-off-by: Jan Dakinevich <jan.dakinevich@gmail.com>
> ---

      parent reply	other threads:[~2016-10-21 19:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-18 22:45 [PATCH 1/2] KVM: VMX: clean up declaration of VPID/EPT invalidation types Jan Dakinevich
2016-10-18 22:45 ` [PATCH 2/2] KVM: nVMX: invvpid handling improvements Jan Dakinevich
2016-10-21 20:02   ` Radim Krčmář
2016-10-25  8:08     ` Ladi Prosek
2016-10-25 13:40       ` Radim Krčmář
2016-10-25 13:57         ` Ladi Prosek
2016-10-25 13:58           ` Paolo Bonzini
2016-10-25 13:36     ` Paolo Bonzini
2016-10-21 19:40 ` Radim Krčmář [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161021194029.GB29131@potion \
    --to=rkrcmar@redhat.com \
    --cc=jan.dakinevich@gmail.com \
    --cc=kernellwp@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.