[PATCH 0/2] drm/i915/gvt: fix compilation errors in gtt.c

[PATCH 0/2] drm/i915/gvt: fix compilation errors in gtt.c

[Jérémy Lefaure]

This series fixes 2 compilations errors in gvt/gtt.c on 32-bits platform:
 [PATCH 1/2] drm/i915/gvt: fix bad 32 bit shift in gtt
 [PATCH 2/2] drm/i915/gvt: fix an error string format

The file gtt.c still does not compile because of shifting errors. Should the 32
bits architecture be supported ?
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH 1/2] drm/i915/gvt: fix bad 32 bit shift in gtt

[Jérémy Lefaure]

Since ioread32 returns a 32-bit value, it is impossible to left-shift
this value by 32 bits (it produces a compilation error). Casting the
return value of ioread32 fix this issue.

Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>
---
 drivers/gpu/drm/i915/gvt/gtt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c
index 29de179..d560898 100644
--- a/drivers/gpu/drm/i915/gvt/gtt.c
+++ b/drivers/gpu/drm/i915/gvt/gtt.c
@@ -274,7 +274,7 @@ static u64 read_pte64(struct drm_i915_private *dev_priv, unsigned long index)
 	pte = readq(addr);
 #else
 	pte = ioread32(addr);
-	pte |= ioread32(addr + 4) << 32;
+	pte |= (u64)ioread32(addr + 4) << 32;
 #endif
 	return pte;
 }
-- 
2.10.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH 2/2] drm/i915/gvt: fix an error string format

[Jérémy Lefaure]

It is better to use %p format for void pointers instead of casting them
because a void* is not necessary a 64 bits value.

Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>
---
 drivers/gpu/drm/i915/gvt/gtt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c
index d560898..df92086 100644
--- a/drivers/gpu/drm/i915/gvt/gtt.c
+++ b/drivers/gpu/drm/i915/gvt/gtt.c
@@ -1942,7 +1942,7 @@ bool intel_gvt_create_scratch_page(struct intel_vgpu *vgpu)
 	mfn = intel_gvt_hypervisor_virt_to_mfn(vaddr);
 
 	if (mfn == INTEL_GVT_INVALID_ADDR) {
-		gvt_err("fail to translate vaddr:0x%llx\n", (u64)vaddr);
+		gvt_err("fail to translate vaddr: 0x%p\n", vaddr);
 		__free_page(gtt->scratch_page);
 		gtt->scratch_page = NULL;
 		return -ENXIO;
-- 
2.10.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.BAT: warning for drm/i915/gvt: fix compilation errors in gtt.c

[Patchwork]

== Series Details ==

Series: drm/i915/gvt: fix compilation errors in gtt.c
URL   : https://patchwork.freedesktop.org/series/14165/
State : warning

== Summary ==

Series 14165v1 drm/i915/gvt: fix compilation errors in gtt.c
https://patchwork.freedesktop.org/api/1.0/series/14165/revisions/1/mbox/

Test kms_pipe_crc_basic:
        Subgroup nonblocking-crc-pipe-a-frame-sequence:
                pass       -> DMESG-WARN (fi-ivb-3770)
        Subgroup suspend-read-crc-pipe-c:
                dmesg-warn -> PASS       (fi-skl-6770hq)

fi-bdw-5557u     total:246  pass:231  dwarn:0   dfail:0   fail:0   skip:15 
fi-bsw-n3050     total:246  pass:204  dwarn:0   dfail:0   fail:0   skip:42 
fi-bxt-t5700     total:246  pass:216  dwarn:0   dfail:0   fail:0   skip:30 
fi-byt-j1900     total:246  pass:215  dwarn:0   dfail:0   fail:0   skip:31 
fi-byt-n2820     total:246  pass:211  dwarn:0   dfail:0   fail:0   skip:35 
fi-hsw-4770      total:246  pass:224  dwarn:0   dfail:0   fail:0   skip:22 
fi-hsw-4770r     total:246  pass:224  dwarn:0   dfail:0   fail:0   skip:22 
fi-ilk-650       total:246  pass:185  dwarn:0   dfail:0   fail:1   skip:60 
fi-ivb-3520m     total:246  pass:221  dwarn:0   dfail:0   fail:0   skip:25 
fi-ivb-3770      total:246  pass:220  dwarn:1   dfail:0   fail:0   skip:25 
fi-kbl-7200u     total:246  pass:222  dwarn:0   dfail:0   fail:0   skip:24 
fi-skl-6260u     total:246  pass:232  dwarn:0   dfail:0   fail:0   skip:14 
fi-skl-6700hq    total:246  pass:219  dwarn:4   dfail:0   fail:0   skip:23 
fi-skl-6700k     total:246  pass:222  dwarn:1   dfail:0   fail:0   skip:23 
fi-skl-6770hq    total:246  pass:232  dwarn:0   dfail:0   fail:0   skip:14 
fi-snb-2520m     total:246  pass:210  dwarn:0   dfail:0   fail:0   skip:36 
fi-snb-2600      total:246  pass:209  dwarn:0   dfail:0   fail:0   skip:37 

Results at /archive/results/CI_IGT_test/Patchwork_2788/

0af2197c61d3de189a02e400fb9cb8a900361b18 drm-intel-nightly: 2016y-10m-21d-13h-15m-26s UTC integration manifest
f59d3e7 drm/i915/gvt: fix an error string format
51d5f3e drm/i915/gvt: fix bad 32 bit shift in gtt

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/2] drm/i915/gvt: fix compilation errors in gtt.c

[Zhenyu Wang]

[-- Attachment #1.1: Type: text/plain, Size: 561 bytes --]

On 2016.10.20 18:05:56 -0400, Jérémy Lefaure wrote:
> This series fixes 2 compilations errors in gvt/gtt.c on 32-bits platform:
>  [PATCH 1/2] drm/i915/gvt: fix bad 32 bit shift in gtt
>  [PATCH 2/2] drm/i915/gvt: fix an error string format
> 
> The file gtt.c still does not compile because of shifting errors. Should the 32
> bits architecture be supported ?

Hi, we don't have 32bit platform support now, so will depend on 64bit kernel only.

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 163 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/2] drm/i915/gvt: fix compilation errors in gtt.c

[Jérémy Lefaure]

On Mon, 24 Oct 2016 10:36:58 +0800
Zhenyu Wang <zhenyuw@linux.intel.com> wrote:

> On 2016.10.20 18:05:56 -0400, Jérémy Lefaure wrote:
> > This series fixes 2 compilations errors in gvt/gtt.c on 32-bits platform:
> >  [PATCH 1/2] drm/i915/gvt: fix bad 32 bit shift in gtt
> >  [PATCH 2/2] drm/i915/gvt: fix an error string format
> > 
> > The file gtt.c still does not compile because of shifting errors. Should the 32
> > bits architecture be supported ?  
> 
> Hi, we don't have 32bit platform support now, so will depend on 64bit kernel only.
> 
Ok, that was I thought. Do my patches are valid anyway ? At least the
1st ?

Thanks !
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/2] drm/i915/gvt: fix compilation errors in gtt.c

[Zhenyu Wang]

[-- Attachment #1.1: Type: text/plain, Size: 919 bytes --]

On 2016.10.24 15:33:34 -0400, Jérémy Lefaure wrote:
> On Mon, 24 Oct 2016 10:36:58 +0800
> Zhenyu Wang <zhenyuw@linux.intel.com> wrote:
> 
> > On 2016.10.20 18:05:56 -0400, Jérémy Lefaure wrote:
> > > This series fixes 2 compilations errors in gvt/gtt.c on 32-bits platform:
> > >  [PATCH 1/2] drm/i915/gvt: fix bad 32 bit shift in gtt
> > >  [PATCH 2/2] drm/i915/gvt: fix an error string format
> > > 
> > > The file gtt.c still does not compile because of shifting errors. Should the 32
> > > bits architecture be supported ?  
> > 
> > Hi, we don't have 32bit platform support now, so will depend on 64bit kernel only.
> > 
> Ok, that was I thought. Do my patches are valid anyway ? At least the
> 1st ?
> 

yes, I'll pick up these although not enough for fixing 32bit compiling.

thanks

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 163 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx