All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] mmc: add the device name in debugging message for supplying vmmc
@ 2016-10-24  6:22 Jaehoon Chung
  2016-10-24  8:51 ` Peng Fan
  0 siblings, 1 reply; 3+ messages in thread
From: Jaehoon Chung @ 2016-10-24  6:22 UTC (permalink / raw)
  To: u-boot

If vmmc didn't supply, we didn't know which card didn't supply vmmc.
And changed from "put" to "debug".

Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
---
 drivers/mmc/mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
index 320413a..4380c7c 100644
--- a/drivers/mmc/mmc.c
+++ b/drivers/mmc/mmc.c
@@ -1595,7 +1595,7 @@ static int mmc_power_init(struct mmc *mmc)
 	ret = device_get_supply_regulator(mmc->dev, "vmmc-supply",
 					  &vmmc_supply);
 	if (ret) {
-		puts("No vmmc supply\n");
+		debug("%s: No vmmc supply\n", mmc->dev->name);
 		return 0;
 	}
 
-- 
2.10.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] mmc: add the device name in debugging message for supplying vmmc
  2016-10-24  6:22 [U-Boot] [PATCH] mmc: add the device name in debugging message for supplying vmmc Jaehoon Chung
@ 2016-10-24  8:51 ` Peng Fan
  2016-10-26  2:03   ` Jaehoon Chung
  0 siblings, 1 reply; 3+ messages in thread
From: Peng Fan @ 2016-10-24  8:51 UTC (permalink / raw)
  To: u-boot

Hi Chung,
On Mon, Oct 24, 2016 at 03:22:22PM +0900, Jaehoon Chung wrote:
>If vmmc didn't supply, we didn't know which card didn't supply vmmc.
>And changed from "put" to "debug".
>
>Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>

Reviewed-by: Peng Fan <peng.fan@nxp.com>

Regards,
Peng.

>---
> drivers/mmc/mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
>index 320413a..4380c7c 100644
>--- a/drivers/mmc/mmc.c
>+++ b/drivers/mmc/mmc.c
>@@ -1595,7 +1595,7 @@ static int mmc_power_init(struct mmc *mmc)
> 	ret = device_get_supply_regulator(mmc->dev, "vmmc-supply",
> 					  &vmmc_supply);
> 	if (ret) {
>-		puts("No vmmc supply\n");
>+		debug("%s: No vmmc supply\n", mmc->dev->name);
> 		return 0;
> 	}
> 
>-- 
>2.10.1
>
>_______________________________________________
>U-Boot mailing list
>U-Boot at lists.denx.de
>http://lists.denx.de/mailman/listinfo/u-boot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] mmc: add the device name in debugging message for supplying vmmc
  2016-10-24  8:51 ` Peng Fan
@ 2016-10-26  2:03   ` Jaehoon Chung
  0 siblings, 0 replies; 3+ messages in thread
From: Jaehoon Chung @ 2016-10-26  2:03 UTC (permalink / raw)
  To: u-boot

On 10/24/2016 05:51 PM, Peng Fan wrote:
> Hi Chung,
> On Mon, Oct 24, 2016 at 03:22:22PM +0900, Jaehoon Chung wrote:
>> If vmmc didn't supply, we didn't know which card didn't supply vmmc.
>> And changed from "put" to "debug".
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> 
> Reviewed-by: Peng Fan <peng.fan@nxp.com>

Applied on u-boot-mmc. Thanks.

Best Regards,
Jaehoon Chung

> 
> Regards,
> Peng.
> 
>> ---
>> drivers/mmc/mmc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
>> index 320413a..4380c7c 100644
>> --- a/drivers/mmc/mmc.c
>> +++ b/drivers/mmc/mmc.c
>> @@ -1595,7 +1595,7 @@ static int mmc_power_init(struct mmc *mmc)
>> 	ret = device_get_supply_regulator(mmc->dev, "vmmc-supply",
>> 					  &vmmc_supply);
>> 	if (ret) {
>> -		puts("No vmmc supply\n");
>> +		debug("%s: No vmmc supply\n", mmc->dev->name);
>> 		return 0;
>> 	}
>>
>> -- 
>> 2.10.1
>>
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
> 
> 
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-10-26  2:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-24  6:22 [U-Boot] [PATCH] mmc: add the device name in debugging message for supplying vmmc Jaehoon Chung
2016-10-24  8:51 ` Peng Fan
2016-10-26  2:03   ` Jaehoon Chung

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.