All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Cree <mcree@orcon.net.nz>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Russell King - ARM Linux <linux@armlinux.org.uk>,
	linux-arm-kernel@lists.infradead.org,
	linux-arch <linux-arch@vger.kernel.org>,
	linux-api <linux-api@vger.kernel.org>,
	linux-alpha@vger.kernel.org
Subject: Re: [PATCH 2/3] ARM: convert to generated system call tables
Date: Tue, 25 Oct 2016 22:12:10 +1300	[thread overview]
Message-ID: <20161025091210.rjfhvq4mqtuquei5@tower> (raw)
In-Reply-To: <3851270.xZRcP9hae0@wuerfel>

On Fri, Oct 21, 2016 at 03:06:45PM +0200, Arnd Bergmann wrote:
> I see your point, but I think there are serious issues with the current
> approach as well:
> 
> - a lot of the less common architectures just don't get updated
>   in time, out of 22 architectures that don't use asm-generic/unistd.h,
>   only 12 have pwritev2 in linux-next, and only three have pkey_mprotect
> 
> - some architectures that add all syscalls sometimes make a mistake
>   and forget one, e.g. alpha apparently never added __NR_bpf, but it
>   did add the later __NR_execveat.

__NR_bpf was not forgotten on Alpha.  It was not wired up because
extra architecture support is needed which has not been implemented.

But maybe we should just wire it up to sys_ni_syscall in the meantime
so a syscall number is reserved for it, and user space can call it to
get -ENOSYS returned.

Cheers
Michael.

WARNING: multiple messages have this Message-ID (diff)
From: mcree@orcon.net.nz (Michael Cree)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: convert to generated system call tables
Date: Tue, 25 Oct 2016 22:12:10 +1300	[thread overview]
Message-ID: <20161025091210.rjfhvq4mqtuquei5@tower> (raw)
In-Reply-To: <3851270.xZRcP9hae0@wuerfel>

On Fri, Oct 21, 2016 at 03:06:45PM +0200, Arnd Bergmann wrote:
> I see your point, but I think there are serious issues with the current
> approach as well:
> 
> - a lot of the less common architectures just don't get updated
>   in time, out of 22 architectures that don't use asm-generic/unistd.h,
>   only 12 have pwritev2 in linux-next, and only three have pkey_mprotect
> 
> - some architectures that add all syscalls sometimes make a mistake
>   and forget one, e.g. alpha apparently never added __NR_bpf, but it
>   did add the later __NR_execveat.

__NR_bpf was not forgotten on Alpha.  It was not wired up because
extra architecture support is needed which has not been implemented.

But maybe we should just wire it up to sys_ni_syscall in the meantime
so a syscall number is reserved for it, and user space can call it to
get -ENOSYS returned.

Cheers
Michael.

  parent reply	other threads:[~2016-10-25  9:12 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-18 19:31 [PATCH 2/3] ARM: convert to generated system call tables Russell King
2016-10-19 15:30 ` Arnd Bergmann
2016-10-19 15:53   ` Russell King - ARM Linux
2016-10-21 13:06     ` Arnd Bergmann
2016-10-21 13:06       ` Arnd Bergmann
2016-10-21 13:37       ` Russell King - ARM Linux
2016-10-21 13:37         ` Russell King - ARM Linux
2016-10-21 13:37         ` Russell King - ARM Linux
     [not found]         ` <20161021133708.GA1041-l+eeeJia6m9URfEZ8mYm6t73F7V6hmMc@public.gmane.org>
2016-10-21 15:18           ` Arnd Bergmann
2016-10-21 15:18             ` Arnd Bergmann
2016-10-21 15:18             ` Arnd Bergmann
2016-10-21 15:48             ` Russell King - ARM Linux
2016-10-21 15:48               ` Russell King - ARM Linux
2016-10-21 15:48               ` Russell King - ARM Linux
     [not found]               ` <20161021154856.GC1041-l+eeeJia6m9URfEZ8mYm6t73F7V6hmMc@public.gmane.org>
2016-10-21 16:48                 ` Joseph Myers
2016-10-21 16:48                   ` Joseph Myers
2016-10-21 16:48                   ` Joseph Myers
     [not found]                   ` <alpine.DEB.2.20.1610211641430.27636-9YEB1lltEqivcGRMvF24k2I39yigxGEX@public.gmane.org>
2016-10-21 16:57                     ` Russell King - ARM Linux
2016-10-21 16:57                       ` Russell King - ARM Linux
2016-10-21 16:57                       ` Russell King - ARM Linux
2016-10-21 20:35               ` Arnd Bergmann
2016-10-21 20:35                 ` Arnd Bergmann
2016-10-22 20:23                 ` Robert Jarzmik
2016-10-22 20:23                   ` Robert Jarzmik
2016-10-22 20:23                   ` Robert Jarzmik
2016-10-24  9:25                   ` Geert Uytterhoeven
2016-10-24  9:25                     ` Geert Uytterhoeven
     [not found]                     ` <CAMuHMdVy_h6Uss9bwVK5hGD42bXeEBcBsBDwCpx_eYnT9r+=Lw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-26 20:14                       ` Robert Jarzmik
2016-10-26 20:14                         ` Robert Jarzmik
2016-10-26 20:14                         ` Robert Jarzmik
2016-10-24  9:29       ` Geert Uytterhoeven
2016-10-24  9:29         ` Geert Uytterhoeven
2016-10-24  9:29         ` Geert Uytterhoeven
2016-10-25  9:12       ` Michael Cree [this message]
2016-10-25  9:12         ` Michael Cree
2016-10-25 10:28         ` Arnd Bergmann
2016-10-25 10:28           ` Arnd Bergmann
2016-10-25 10:28           ` Arnd Bergmann
2016-10-25 17:03           ` Richard Henderson
2016-10-25 17:03             ` Richard Henderson
2016-10-25 17:03             ` Richard Henderson
2016-10-25 17:09           ` Geert Uytterhoeven
2016-10-25 17:09             ` Geert Uytterhoeven
2016-10-25 17:09             ` Geert Uytterhoeven
2016-10-26  7:04           ` Michael Cree
2016-10-26  7:04             ` Michael Cree
2016-10-26  9:12             ` bpf on Alpha [was Re: [PATCH 2/3] ARM: convert to generated system call tables] Michael Cree
2016-10-26  9:12               ` Michael Cree
2016-10-26  9:12               ` Michael Cree

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161025091210.rjfhvq4mqtuquei5@tower \
    --to=mcree@orcon.net.nz \
    --cc=arnd@arndb.de \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.