* [PATCH] i2c: xgene: Avoid dma_buffer overrun
@ 2016-10-10 17:13 Hoan Tran
2016-10-24 22:30 ` Hoan Tran
2016-10-25 9:50 ` Wolfram Sang
0 siblings, 2 replies; 3+ messages in thread
From: Hoan Tran @ 2016-10-10 17:13 UTC (permalink / raw)
To: Wolfram Sang, linux-i2c
Cc: linux-kernel, Phil Endecott, Loc Ho, tnhuynh, patches, Hoan Tran
SMBus block command uses the first byte of buffer for the data length.
The dma_buffer should be increased by 1 to avoid the overrun issue.
Reported-by: Phil Endecott <phil_gjouf_endecott@chezphil.org>
Signed-off-by: Hoan Tran <hotran@apm.com>
---
drivers/i2c/busses/i2c-xgene-slimpro.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-xgene-slimpro.c b/drivers/i2c/busses/i2c-xgene-slimpro.c
index 4233f56..3c38029 100644
--- a/drivers/i2c/busses/i2c-xgene-slimpro.c
+++ b/drivers/i2c/busses/i2c-xgene-slimpro.c
@@ -105,7 +105,7 @@ struct slimpro_i2c_dev {
struct mbox_chan *mbox_chan;
struct mbox_client mbox_client;
struct completion rd_complete;
- u8 dma_buffer[I2C_SMBUS_BLOCK_MAX];
+ u8 dma_buffer[I2C_SMBUS_BLOCK_MAX + 1]; /* dma_buffer[0] is used for length */
u32 *resp_msg;
};
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: xgene: Avoid dma_buffer overrun
2016-10-10 17:13 [PATCH] i2c: xgene: Avoid dma_buffer overrun Hoan Tran
@ 2016-10-24 22:30 ` Hoan Tran
2016-10-25 9:50 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Hoan Tran @ 2016-10-24 22:30 UTC (permalink / raw)
To: Wolfram Sang, linux-i2c
Cc: lkml, Phil Endecott, Loc Ho, Tin Huynh, patches, Hoan Tran
On Mon, Oct 10, 2016 at 10:13 AM, Hoan Tran <hotran@apm.com> wrote:
> SMBus block command uses the first byte of buffer for the data length.
> The dma_buffer should be increased by 1 to avoid the overrun issue.
>
> Reported-by: Phil Endecott <phil_gjouf_endecott@chezphil.org>
> Signed-off-by: Hoan Tran <hotran@apm.com>
> ---
> drivers/i2c/busses/i2c-xgene-slimpro.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-xgene-slimpro.c b/drivers/i2c/busses/i2c-xgene-slimpro.c
> index 4233f56..3c38029 100644
> --- a/drivers/i2c/busses/i2c-xgene-slimpro.c
> +++ b/drivers/i2c/busses/i2c-xgene-slimpro.c
> @@ -105,7 +105,7 @@ struct slimpro_i2c_dev {
> struct mbox_chan *mbox_chan;
> struct mbox_client mbox_client;
> struct completion rd_complete;
> - u8 dma_buffer[I2C_SMBUS_BLOCK_MAX];
> + u8 dma_buffer[I2C_SMBUS_BLOCK_MAX + 1]; /* dma_buffer[0] is used for length */
> u32 *resp_msg;
> };
>
> --
> 1.9.1
>
Any comments on this patch.
Thanks
Hoan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: xgene: Avoid dma_buffer overrun
2016-10-10 17:13 [PATCH] i2c: xgene: Avoid dma_buffer overrun Hoan Tran
2016-10-24 22:30 ` Hoan Tran
@ 2016-10-25 9:50 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2016-10-25 9:50 UTC (permalink / raw)
To: Hoan Tran
Cc: linux-i2c, linux-kernel, Phil Endecott, Loc Ho, tnhuynh, patches
[-- Attachment #1: Type: text/plain, Size: 373 bytes --]
On Mon, Oct 10, 2016 at 10:13:10AM -0700, Hoan Tran wrote:
> SMBus block command uses the first byte of buffer for the data length.
> The dma_buffer should be increased by 1 to avoid the overrun issue.
>
> Reported-by: Phil Endecott <phil_gjouf_endecott@chezphil.org>
> Signed-off-by: Hoan Tran <hotran@apm.com>
Added stable and applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-25 9:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-10 17:13 [PATCH] i2c: xgene: Avoid dma_buffer overrun Hoan Tran
2016-10-24 22:30 ` Hoan Tran
2016-10-25 9:50 ` Wolfram Sang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.