From: Oleg Nesterov <oleg@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Andy Lutomirski <luto@amacapital.net>,
Roman Pen <roman.penyaev@profitbricks.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Tejun Heo <tj@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/1] kthread: allocate kthread structure using kmalloc
Date: Wed, 26 Oct 2016 17:51:56 +0200 [thread overview]
Message-ID: <20161026155155.GA28832@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1610261650260.4983@nanos>
On 10/26, Thomas Gleixner wrote:
>
> On Wed, 26 Oct 2016, Oleg Nesterov wrote:
> > +static inline void set_kthread_struct(void *kthread)
> > +{
> > + /*
> > + * We abuse ->set_child_tid to avoid the new member and because it
> > + * can't be wrongly copied by copy_process(). We also rely on fact
> > + * that the caller can't exec, so PF_KTHREAD can't be cleared.
> > + */
> > + current->set_child_tid = (__force void __user *)kthread;
>
> Can we pretty please avoid this type casting? We only have 5 places using
> set_child_tid. So we can really make it a proper union
Yes, I thought about anonymous union too, the only problem is that
it will need more comments ;)
And I agree with other nits, will redo/resend tomorrow.
Thanks!
Oleg.
next prev parent reply other threads:[~2016-10-26 15:53 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 11:05 [PATCH v3 1/1] kthread: allocate kthread structure using kmalloc Roman Pen
2016-10-25 14:03 ` Oleg Nesterov
2016-10-25 15:43 ` Oleg Nesterov
2016-10-25 16:08 ` Roman Penyaev
2016-10-25 16:17 ` Oleg Nesterov
2016-10-25 16:52 ` Andy Lutomirski
2016-10-26 14:14 ` Oleg Nesterov
2016-10-26 14:57 ` Thomas Gleixner
2016-10-26 15:51 ` Oleg Nesterov [this message]
2016-10-26 18:31 ` Thomas Gleixner
2016-10-28 16:11 ` [PATCH 0/2] kthread: make struct kthread kmalloc'ed Oleg Nesterov
2016-10-28 16:11 ` [PATCH 1/2] " Oleg Nesterov
2016-10-28 18:48 ` Thomas Gleixner
2016-10-28 16:12 ` [PATCH 2/2] Revert "kthread: Pin the stack via try_get_task_stack()/put_task_stack() in to_live_kthread() function" Oleg Nesterov
2016-10-28 18:49 ` Thomas Gleixner
2016-10-28 18:44 ` [PATCH 0/2] kthread: make struct kthread kmalloc'ed Thomas Gleixner
2016-10-31 20:07 ` [PATCH 0/2] kthread: kill to_live_kthread() Oleg Nesterov
2016-10-31 20:07 ` [PATCH 1/2] kthread: don't use to_live_kthread() in kthread_stop() Oleg Nesterov
2016-11-09 7:58 ` Thomas Gleixner
2016-10-31 20:08 ` [PATCH 2/2] kthread: don't use to_live_kthread() in kthread_park() and kthread_unpark() Oleg Nesterov
2016-11-09 8:45 ` Thomas Gleixner
2016-11-09 17:27 ` Oleg Nesterov
2016-11-10 17:19 ` [PATCH 0/1] kthread: don't abuse kthread_create_on_cpu() in __kthread_create_worker() Oleg Nesterov
2016-11-10 17:20 ` [PATCH 1/1] " Oleg Nesterov
2016-11-14 11:12 ` Petr Mladek
2016-11-14 11:09 ` [PATCH 0/1] " Petr Mladek
2016-11-07 18:23 ` [PATCH 0/2] kthread: kill to_live_kthread() Andy Lutomirski
2016-10-26 16:13 ` [PATCH v3 1/1] kthread: allocate kthread structure using kmalloc Oleg Nesterov
2016-10-27 2:56 ` Josh Poimboeuf
2016-10-27 13:10 ` Oleg Nesterov
2016-10-25 15:46 ` Roman Penyaev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161026155155.GA28832@redhat.com \
--to=oleg@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=roman.penyaev@profitbricks.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.