All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next] ethernet: fix min/max MTU typos
@ 2016-10-24 12:42 Stefan Richter
  2016-10-25  3:07 ` Jarod Wilson
  2016-10-27 20:19 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Stefan Richter @ 2016-10-24 12:42 UTC (permalink / raw)
  To: David S. Miller; +Cc: netdev, Jarod Wilson, Thomas Falcon, linux-kernel

Fixes: d894be57ca92('ethernet: use net core MTU range checking in more drivers')
CC: Jarod Wilson <jarod@redhat.com>
CC: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
 drivers/net/ethernet/broadcom/sb1250-mac.c | 2 +-
 drivers/net/ethernet/ibm/ibmveth.c         | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/sb1250-mac.c b/drivers/net/ethernet/broadcom/sb1250-mac.c
index cb312e4c89f4..435a2e4739d1 100644
--- a/drivers/net/ethernet/broadcom/sb1250-mac.c
+++ b/drivers/net/ethernet/broadcom/sb1250-mac.c
@@ -2219,7 +2219,7 @@ static int sbmac_init(struct platform_device *pldev, long long base)
 
 	dev->netdev_ops = &sbmac_netdev_ops;
 	dev->watchdog_timeo = TX_TIMEOUT;
-	dev->max_mtu = 0;
+	dev->min_mtu = 0;
 	dev->max_mtu = ENET_PACKET_SIZE;
 
 	netif_napi_add(dev, &sc->napi, sbmac_poll, 16);
diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c
index 29c05d0d79a9..4a81c892fc31 100644
--- a/drivers/net/ethernet/ibm/ibmveth.c
+++ b/drivers/net/ethernet/ibm/ibmveth.c
@@ -1549,7 +1549,7 @@ static int ibmveth_probe(struct vio_dev *dev, const struct vio_device_id *id)
 	}
 
 	netdev->min_mtu = IBMVETH_MIN_MTU;
-	netdev->min_mtu = ETH_MAX_MTU;
+	netdev->max_mtu = ETH_MAX_MTU;
 
 	memcpy(netdev->dev_addr, mac_addr_p, ETH_ALEN);
 
-- 
Stefan Richter
-======----- =-=- ==---
http://arcgraph.de/sr/

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] ethernet: fix min/max MTU typos
  2016-10-24 12:42 [PATCH net-next] ethernet: fix min/max MTU typos Stefan Richter
@ 2016-10-25  3:07 ` Jarod Wilson
  2016-10-27 20:19 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Jarod Wilson @ 2016-10-25  3:07 UTC (permalink / raw)
  To: Stefan Richter; +Cc: David S. Miller, netdev, Thomas Falcon, linux-kernel

On Mon, Oct 24, 2016 at 02:42:26PM +0200, Stefan Richter wrote:
> Fixes: d894be57ca92('ethernet: use net core MTU range checking in more drivers')
> CC: Jarod Wilson <jarod@redhat.com>
> CC: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Wuf. Thank you, Stefan. Way too many bleeding eyeball hours staring at all
those changes.

Acked-by: Jarod Wilson <jarod@redhat.com>

-- 
Jarod Wilson
jarod@redhat.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] ethernet: fix min/max MTU typos
  2016-10-24 12:42 [PATCH net-next] ethernet: fix min/max MTU typos Stefan Richter
  2016-10-25  3:07 ` Jarod Wilson
@ 2016-10-27 20:19 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-10-27 20:19 UTC (permalink / raw)
  To: stefanr; +Cc: netdev, jarod, tlfalcon, linux-kernel

From: Stefan Richter <stefanr@s5r6.in-berlin.de>
Date: Mon, 24 Oct 2016 14:42:26 +0200

> Fixes: d894be57ca92('ethernet: use net core MTU range checking in more drivers')
> CC: Jarod Wilson <jarod@redhat.com>
> CC: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Applied.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-10-27 20:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-24 12:42 [PATCH net-next] ethernet: fix min/max MTU typos Stefan Richter
2016-10-25  3:07 ` Jarod Wilson
2016-10-27 20:19 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.