* [PATCH v2] ARM: dts: witherspoon: add Epson RX8900CE RTC module
@ 2016-10-26 6:55 Chris Smart
2016-10-27 0:18 ` Joel Stanley
2016-10-27 0:49 ` [PATCH v3] " Chris Smart
0 siblings, 2 replies; 4+ messages in thread
From: Chris Smart @ 2016-10-26 6:55 UTC (permalink / raw)
To: openbmc
This commit adds the relevant device tree entry for the Epson RX8900CE
RTC module on the I2C bus.
Note that there are two options that we may need to set.
If there is no connected battery:
epson,vdet-disable;
If there is no trickle charge diode:
epson,vdet-disable;
These are currently left commented out in the commit.
Signed-off-by: Chris Smart <chris@distroguy.com>
---
Changes since v1:
- fixed up the entry for rtc@32
arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
index 328a9c4e189e..19a91a207530 100644
--- a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
@@ -148,7 +148,19 @@
/* TPM */
/* 9552 */
+
/* RTC */
+ rtc@32 {
+ compatible = "epson,rx8900"
+ reg = <0x32>;
+ /*
+ * If no battery, set this:
+ * epson,vdet-disable;
+ * If no trickle charge diode, set this:
+ * epson,vdet-disable;
+ */
+ };
+
/* EEPROM */
eeprom@51 {
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] ARM: dts: witherspoon: add Epson RX8900CE RTC module
2016-10-26 6:55 [PATCH v2] ARM: dts: witherspoon: add Epson RX8900CE RTC module Chris Smart
@ 2016-10-27 0:18 ` Joel Stanley
2016-10-27 0:42 ` Chris Smart
2016-10-27 0:49 ` [PATCH v3] " Chris Smart
1 sibling, 1 reply; 4+ messages in thread
From: Joel Stanley @ 2016-10-27 0:18 UTC (permalink / raw)
To: Chris Smart; +Cc: OpenBMC Maillist
Hey Chris,
On Wed, Oct 26, 2016 at 5:25 PM, Chris Smart <chris@distroguy.com> wrote:
> /* RTC */
> + rtc@32 {
> + compatible = "epson,rx8900"
> + reg = <0x32>;
Did you try building this?
Cheers,
Joel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] ARM: dts: witherspoon: add Epson RX8900CE RTC module
2016-10-27 0:18 ` Joel Stanley
@ 2016-10-27 0:42 ` Chris Smart
0 siblings, 0 replies; 4+ messages in thread
From: Chris Smart @ 2016-10-27 0:42 UTC (permalink / raw)
To: Joel Stanley; +Cc: OpenBMC Maillist
On Thu, Oct 27, 2016 at 10:48:01AM +1030, Joel Stanley wrote:
>Hey Chris,
>
>On Wed, Oct 26, 2016 at 5:25 PM, Chris Smart <chris@distroguy.com> wrote:
>> /* RTC */
>> + rtc@32 {
>> + compatible = "epson,rx8900"
>> + reg = <0x32>;
>
>Did you try building this?
>
My bad, v3 incoming.
-c
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v3] ARM: dts: witherspoon: add Epson RX8900CE RTC module
2016-10-26 6:55 [PATCH v2] ARM: dts: witherspoon: add Epson RX8900CE RTC module Chris Smart
2016-10-27 0:18 ` Joel Stanley
@ 2016-10-27 0:49 ` Chris Smart
1 sibling, 0 replies; 4+ messages in thread
From: Chris Smart @ 2016-10-27 0:49 UTC (permalink / raw)
To: openbmc
This commit adds the relevant device tree entry for the Epson RX8900CE
RTC module on the I2C bus.
Note that there are two options that we may need to set.
If there is no connected battery:
epson,vdet-disable;
If there is no trickle charge diode:
epson,vdet-disable;
These are currently left commented out in the commit.
Signed-off-by: Chris Smart <chris@distroguy.com>
---
Changes since v1:
- fixed up the entry for rtc@32
Changes since v2:
- fix up code formatting
Tested with kernel config from openbmc meta-ast2500 yocto, compiled
with:
ARCH=arm CROSS_COMPILE=arm-linux-gnu- make -j$(nproc) dtbs
arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
index 328a9c4e189e..2972c6279183 100644
--- a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
@@ -148,7 +148,19 @@
/* TPM */
/* 9552 */
+
/* RTC */
+ rtc@32 {
+ compatible = "epson,rx8900";
+ reg = <0x32>;
+ /*
+ * If no battery, set this:
+ * epson,vdet-disable;
+ * If no trickle charge diode, set this:
+ * epson,vdet-disable;
+ */
+ };
+
/* EEPROM */
eeprom@51 {
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-27 0:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-26 6:55 [PATCH v2] ARM: dts: witherspoon: add Epson RX8900CE RTC module Chris Smart
2016-10-27 0:18 ` Joel Stanley
2016-10-27 0:42 ` Chris Smart
2016-10-27 0:49 ` [PATCH v3] " Chris Smart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.