* [PATCH] crypto: acomp: export all scomp interfaces
@ 2016-10-27 14:09 Arnd Bergmann
2016-10-27 21:03 ` Giovanni Cabiddu
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2016-10-27 14:09 UTC (permalink / raw)
To: Herbert Xu
Cc: Arnd Bergmann, David S. Miller, Giovanni Cabiddu, linux-crypto,
linux-kernel
The newly added scomp/acomp interface has a couple of functions
that should be exported to allow linking the two drivers
as loadable modules:
ERROR: "crypto_acomp_scomp_free_ctx" [crypto/acompress.ko] undefined!
ERROR: "crypto_acomp_scomp_alloc_ctx" [crypto/acompress.ko] undefined!
ERROR: "crypto_init_scomp_ops_async" [crypto/acompress.ko] undefined!
Alternatively, both of them could be combined into one loadable module.
Fixes: 1ab53a77b772 ("crypto: acomp - add driver-side scomp interface")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
crypto/scompress.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/crypto/scompress.c b/crypto/scompress.c
index 35e396d154b7..1f9cdcddb2ce 100644
--- a/crypto/scompress.c
+++ b/crypto/scompress.c
@@ -267,6 +267,7 @@ int crypto_init_scomp_ops_async(struct crypto_tfm *tfm)
return 0;
}
+EXPORT_SYMBOL_GPL(crypto_init_scomp_ops_async);
struct acomp_req *crypto_acomp_scomp_alloc_ctx(struct acomp_req *req)
{
@@ -286,6 +287,7 @@ struct acomp_req *crypto_acomp_scomp_alloc_ctx(struct acomp_req *req)
return req;
}
+EXPORT_SYMBOL_GPL(crypto_acomp_scomp_alloc_ctx);
void crypto_acomp_scomp_free_ctx(struct acomp_req *req)
{
@@ -298,6 +300,7 @@ void crypto_acomp_scomp_free_ctx(struct acomp_req *req)
if (ctx)
crypto_scomp_free_ctx(scomp, ctx);
}
+EXPORT_SYMBOL_GPL(crypto_acomp_scomp_free_ctx);
static const struct crypto_type crypto_scomp_type = {
.extsize = crypto_alg_extsize,
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: acomp: export all scomp interfaces
2016-10-27 14:09 [PATCH] crypto: acomp: export all scomp interfaces Arnd Bergmann
@ 2016-10-27 21:03 ` Giovanni Cabiddu
2016-10-28 10:36 ` Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: Giovanni Cabiddu @ 2016-10-27 21:03 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Herbert Xu, David S. Miller, linux-crypto, linux-kernel
Hi Arnd,
On Thu, Oct 27, 2016 at 04:09:49PM +0200, Arnd Bergmann wrote:
> The newly added scomp/acomp interface has a couple of functions
> that should be exported to allow linking the two drivers
> as loadable modules:
>
> ERROR: "crypto_acomp_scomp_free_ctx" [crypto/acompress.ko] undefined!
> ERROR: "crypto_acomp_scomp_alloc_ctx" [crypto/acompress.ko] undefined!
> ERROR: "crypto_init_scomp_ops_async" [crypto/acompress.ko] undefined!
These functions were not exported on purpose. They should not be called
by other modules.
> Alternatively, both of them could be combined into one loadable module.
I think this is the correct approach. Here is a patch with an
alternative fix: https://patchwork.kernel.org/patch/9396503/
Thanks,
--
Giovanni
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: acomp: export all scomp interfaces
2016-10-27 21:03 ` Giovanni Cabiddu
@ 2016-10-28 10:36 ` Arnd Bergmann
0 siblings, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2016-10-28 10:36 UTC (permalink / raw)
To: Giovanni Cabiddu; +Cc: Herbert Xu, David S. Miller, linux-crypto, linux-kernel
On Thursday, October 27, 2016 10:03:29 PM CEST Giovanni Cabiddu wrote:
> Hi Arnd,
>
> On Thu, Oct 27, 2016 at 04:09:49PM +0200, Arnd Bergmann wrote:
> > The newly added scomp/acomp interface has a couple of functions
> > that should be exported to allow linking the two drivers
> > as loadable modules:
> >
> > ERROR: "crypto_acomp_scomp_free_ctx" [crypto/acompress.ko] undefined!
> > ERROR: "crypto_acomp_scomp_alloc_ctx" [crypto/acompress.ko] undefined!
> > ERROR: "crypto_init_scomp_ops_async" [crypto/acompress.ko] undefined!
> These functions were not exported on purpose. They should not be called
> by other modules.
>
> > Alternatively, both of them could be combined into one loadable module.
> I think this is the correct approach. Here is a patch with an
> alternative fix: https://patchwork.kernel.org/patch/9396503/
Yes, your patch is exactly what I had in mind as the alternative,
looks good to me.
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-28 10:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-27 14:09 [PATCH] crypto: acomp: export all scomp interfaces Arnd Bergmann
2016-10-27 21:03 ` Giovanni Cabiddu
2016-10-28 10:36 ` Arnd Bergmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.