* [PATCH] ceph: include linux/crush/mapper.h in crush/mapper.c
@ 2016-10-28 11:23 Tobias Klauser
2016-11-07 18:38 ` Ilya Dryomov
0 siblings, 1 reply; 2+ messages in thread
From: Tobias Klauser @ 2016-10-28 11:23 UTC (permalink / raw)
To: Ilya Dryomov, Yan, Zheng, Sage Weil; +Cc: ceph-devel
Include linux/crush/mapper.h in crush/mapper.c to get the prototypes of
crush_find_rule and crush_do_rule which are defined there. This fixes
the following GCC warnings when building with 'W=1':
net/ceph/crush/mapper.c:40:5: warning: no previous prototype for ‘crush_find_rule’ [-Wmissing-prototypes]
net/ceph/crush/mapper.c:793:5: warning: no previous prototype for ‘crush_do_rule’ [-Wmissing-prototypes]
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
net/ceph/crush/mapper.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/ceph/crush/mapper.c b/net/ceph/crush/mapper.c
index a421e905331a..407bd146ba9e 100644
--- a/net/ceph/crush/mapper.c
+++ b/net/ceph/crush/mapper.c
@@ -17,6 +17,7 @@
# include <linux/kernel.h>
# include <linux/crush/crush.h>
# include <linux/crush/hash.h>
+# include <linux/crush/mapper.h>
#else
# include "crush_compat.h"
# include "crush.h"
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ceph: include linux/crush/mapper.h in crush/mapper.c
2016-10-28 11:23 [PATCH] ceph: include linux/crush/mapper.h in crush/mapper.c Tobias Klauser
@ 2016-11-07 18:38 ` Ilya Dryomov
0 siblings, 0 replies; 2+ messages in thread
From: Ilya Dryomov @ 2016-11-07 18:38 UTC (permalink / raw)
To: Tobias Klauser; +Cc: Yan, Zheng, Sage Weil, Ceph Development
On Fri, Oct 28, 2016 at 1:23 PM, Tobias Klauser <tklauser@distanz.ch> wrote:
> Include linux/crush/mapper.h in crush/mapper.c to get the prototypes of
> crush_find_rule and crush_do_rule which are defined there. This fixes
> the following GCC warnings when building with 'W=1':
>
> net/ceph/crush/mapper.c:40:5: warning: no previous prototype for ‘crush_find_rule’ [-Wmissing-prototypes]
> net/ceph/crush/mapper.c:793:5: warning: no previous prototype for ‘crush_do_rule’ [-Wmissing-prototypes]
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---
> net/ceph/crush/mapper.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/ceph/crush/mapper.c b/net/ceph/crush/mapper.c
> index a421e905331a..407bd146ba9e 100644
> --- a/net/ceph/crush/mapper.c
> +++ b/net/ceph/crush/mapper.c
> @@ -17,6 +17,7 @@
> # include <linux/kernel.h>
> # include <linux/crush/crush.h>
> # include <linux/crush/hash.h>
> +# include <linux/crush/mapper.h>
> #else
> # include "crush_compat.h"
> # include "crush.h"
Applied.
Thanks,
Ilya
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-07 18:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-28 11:23 [PATCH] ceph: include linux/crush/mapper.h in crush/mapper.c Tobias Klauser
2016-11-07 18:38 ` Ilya Dryomov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.