* [PATCHv2 net] sctp: return back transport in __sctp_rcv_init_lookup
@ 2016-10-30 16:42 ` Xin Long
0 siblings, 0 replies; 12+ messages in thread
From: Xin Long @ 2016-10-30 16:42 UTC (permalink / raw)
To: network dev, linux-sctp
Cc: davem, Marcelo Ricardo Leitner, Vlad Yasevich, Neil Horman
Prior to this patch, it used a local variable to save the transport that is
looked up by __sctp_lookup_association(), and didn't return it back. But in
sctp_rcv, it is used to initialize chunk->transport. So when hitting this,
even if it found the transport, it was still initializing chunk->transport
with null instead.
This patch is to return the transport back through transport pointer
that is from __sctp_rcv_lookup_harder().
Signed-off-by: Xin Long <lucien.xin@gmail.com>
---
net/sctp/input.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/sctp/input.c b/net/sctp/input.c
index a2ea1d1..8e0bc58 100644
--- a/net/sctp/input.c
+++ b/net/sctp/input.c
@@ -1021,7 +1021,6 @@ static struct sctp_association *__sctp_rcv_init_lookup(struct net *net,
struct sctphdr *sh = sctp_hdr(skb);
union sctp_params params;
sctp_init_chunk_t *init;
- struct sctp_transport *transport;
struct sctp_af *af;
/*
@@ -1052,7 +1051,7 @@ static struct sctp_association *__sctp_rcv_init_lookup(struct net *net,
af->from_addr_param(paddr, params.addr, sh->source, 0);
- asoc = __sctp_lookup_association(net, laddr, paddr, &transport);
+ asoc = __sctp_lookup_association(net, laddr, paddr, transportp);
if (asoc)
return asoc;
}
--
2.1.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCHv2 net] sctp: return back transport in __sctp_rcv_init_lookup
@ 2016-10-30 16:42 ` Xin Long
0 siblings, 0 replies; 12+ messages in thread
From: Xin Long @ 2016-10-30 16:42 UTC (permalink / raw)
To: network dev, linux-sctp
Cc: davem, Marcelo Ricardo Leitner, Vlad Yasevich, Neil Horman
Prior to this patch, it used a local variable to save the transport that is
looked up by __sctp_lookup_association(), and didn't return it back. But in
sctp_rcv, it is used to initialize chunk->transport. So when hitting this,
even if it found the transport, it was still initializing chunk->transport
with null instead.
This patch is to return the transport back through transport pointer
that is from __sctp_rcv_lookup_harder().
Signed-off-by: Xin Long <lucien.xin@gmail.com>
---
net/sctp/input.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/sctp/input.c b/net/sctp/input.c
index a2ea1d1..8e0bc58 100644
--- a/net/sctp/input.c
+++ b/net/sctp/input.c
@@ -1021,7 +1021,6 @@ static struct sctp_association *__sctp_rcv_init_lookup(struct net *net,
struct sctphdr *sh = sctp_hdr(skb);
union sctp_params params;
sctp_init_chunk_t *init;
- struct sctp_transport *transport;
struct sctp_af *af;
/*
@@ -1052,7 +1051,7 @@ static struct sctp_association *__sctp_rcv_init_lookup(struct net *net,
af->from_addr_param(paddr, params.addr, sh->source, 0);
- asoc = __sctp_lookup_association(net, laddr, paddr, &transport);
+ asoc = __sctp_lookup_association(net, laddr, paddr, transportp);
if (asoc)
return asoc;
}
--
2.1.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCHv2 net] sctp: return back transport in __sctp_rcv_init_lookup
2016-10-30 16:42 ` Xin Long
@ 2016-10-31 10:51 ` Marcelo Ricardo Leitner
-1 siblings, 0 replies; 12+ messages in thread
From: Marcelo Ricardo Leitner @ 2016-10-31 10:51 UTC (permalink / raw)
To: Xin Long; +Cc: network dev, linux-sctp, davem, Vlad Yasevich, Neil Horman
On Mon, Oct 31, 2016 at 12:42:35AM +0800, Xin Long wrote:
> Prior to this patch, it used a local variable to save the transport that is
> looked up by __sctp_lookup_association(), and didn't return it back. But in
> sctp_rcv, it is used to initialize chunk->transport. So when hitting this,
> even if it found the transport, it was still initializing chunk->transport
> with null instead.
>
> This patch is to return the transport back through transport pointer
> that is from __sctp_rcv_lookup_harder().
>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
> ---
Patch looks good now but you have to either repost the entire series
altogether, or repost the series to remove this patch from it.
Marcelo
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCHv2 net] sctp: return back transport in __sctp_rcv_init_lookup
@ 2016-10-31 10:51 ` Marcelo Ricardo Leitner
0 siblings, 0 replies; 12+ messages in thread
From: Marcelo Ricardo Leitner @ 2016-10-31 10:51 UTC (permalink / raw)
To: Xin Long; +Cc: network dev, linux-sctp, davem, Vlad Yasevich, Neil Horman
On Mon, Oct 31, 2016 at 12:42:35AM +0800, Xin Long wrote:
> Prior to this patch, it used a local variable to save the transport that is
> looked up by __sctp_lookup_association(), and didn't return it back. But in
> sctp_rcv, it is used to initialize chunk->transport. So when hitting this,
> even if it found the transport, it was still initializing chunk->transport
> with null instead.
>
> This patch is to return the transport back through transport pointer
> that is from __sctp_rcv_lookup_harder().
>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
> ---
Patch looks good now but you have to either repost the entire series
altogether, or repost the series to remove this patch from it.
Marcelo
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCHv2 net] sctp: return back transport in __sctp_rcv_init_lookup
2016-10-31 10:51 ` Marcelo Ricardo Leitner
@ 2016-10-31 12:25 ` Xin Long
-1 siblings, 0 replies; 12+ messages in thread
From: Xin Long @ 2016-10-31 12:25 UTC (permalink / raw)
To: Marcelo Ricardo Leitner
Cc: network dev, linux-sctp, davem, Vlad Yasevich, Neil Horman
On Mon, Oct 31, 2016 at 6:51 PM, Marcelo Ricardo Leitner
<marcelo.leitner@gmail.com> wrote:
> On Mon, Oct 31, 2016 at 12:42:35AM +0800, Xin Long wrote:
>> Prior to this patch, it used a local variable to save the transport that is
>> looked up by __sctp_lookup_association(), and didn't return it back. But in
>> sctp_rcv, it is used to initialize chunk->transport. So when hitting this,
>> even if it found the transport, it was still initializing chunk->transport
>> with null instead.
>>
>> This patch is to return the transport back through transport pointer
>> that is from __sctp_rcv_lookup_harder().
>>
>> Signed-off-by: Xin Long <lucien.xin@gmail.com>
>> ---
>
> Patch looks good now but you have to either repost the entire series
> altogether, or repost the series to remove this patch from it.
Ah, sorry, will repost the entire series altogether.
>
> Marcelo
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCHv2 net] sctp: return back transport in __sctp_rcv_init_lookup
@ 2016-10-31 12:25 ` Xin Long
0 siblings, 0 replies; 12+ messages in thread
From: Xin Long @ 2016-10-31 12:25 UTC (permalink / raw)
To: Marcelo Ricardo Leitner
Cc: network dev, linux-sctp, davem, Vlad Yasevich, Neil Horman
On Mon, Oct 31, 2016 at 6:51 PM, Marcelo Ricardo Leitner
<marcelo.leitner@gmail.com> wrote:
> On Mon, Oct 31, 2016 at 12:42:35AM +0800, Xin Long wrote:
>> Prior to this patch, it used a local variable to save the transport that is
>> looked up by __sctp_lookup_association(), and didn't return it back. But in
>> sctp_rcv, it is used to initialize chunk->transport. So when hitting this,
>> even if it found the transport, it was still initializing chunk->transport
>> with null instead.
>>
>> This patch is to return the transport back through transport pointer
>> that is from __sctp_rcv_lookup_harder().
>>
>> Signed-off-by: Xin Long <lucien.xin@gmail.com>
>> ---
>
> Patch looks good now but you have to either repost the entire series
> altogether, or repost the series to remove this patch from it.
Ah, sorry, will repost the entire series altogether.
>
> Marcelo
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCHv2 net] sctp: return back transport in __sctp_rcv_init_lookup
2016-10-30 16:42 ` Xin Long
@ 2016-10-31 19:53 ` David Miller
-1 siblings, 0 replies; 12+ messages in thread
From: David Miller @ 2016-10-31 19:53 UTC (permalink / raw)
To: lucien.xin; +Cc: netdev, linux-sctp, marcelo.leitner, vyasevich, nhorman
From: Xin Long <lucien.xin@gmail.com>
Date: Mon, 31 Oct 2016 00:42:35 +0800
> Prior to this patch, it used a local variable to save the transport that is
> looked up by __sctp_lookup_association(), and didn't return it back. But in
> sctp_rcv, it is used to initialize chunk->transport. So when hitting this,
> even if it found the transport, it was still initializing chunk->transport
> with null instead.
>
> This patch is to return the transport back through transport pointer
> that is from __sctp_rcv_lookup_harder().
>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
So do I apply this to 'net'? If so I'd like to see explicit ACKs.
Thanks.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCHv2 net] sctp: return back transport in __sctp_rcv_init_lookup
@ 2016-10-31 19:53 ` David Miller
0 siblings, 0 replies; 12+ messages in thread
From: David Miller @ 2016-10-31 19:53 UTC (permalink / raw)
To: lucien.xin; +Cc: netdev, linux-sctp, marcelo.leitner, vyasevich, nhorman
From: Xin Long <lucien.xin@gmail.com>
Date: Mon, 31 Oct 2016 00:42:35 +0800
> Prior to this patch, it used a local variable to save the transport that is
> looked up by __sctp_lookup_association(), and didn't return it back. But in
> sctp_rcv, it is used to initialize chunk->transport. So when hitting this,
> even if it found the transport, it was still initializing chunk->transport
> with null instead.
>
> This patch is to return the transport back through transport pointer
> that is from __sctp_rcv_lookup_harder().
>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
So do I apply this to 'net'? If so I'd like to see explicit ACKs.
Thanks.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCHv2 net] sctp: return back transport in __sctp_rcv_init_lookup
2016-10-31 19:53 ` David Miller
@ 2016-10-31 20:13 ` marcelo.leitner
-1 siblings, 0 replies; 12+ messages in thread
From: marcelo.leitner @ 2016-10-31 20:13 UTC (permalink / raw)
To: David Miller; +Cc: lucien.xin, netdev, linux-sctp, vyasevich, nhorman
On Mon, Oct 31, 2016 at 03:53:48PM -0400, David Miller wrote:
> From: Xin Long <lucien.xin@gmail.com>
> Date: Mon, 31 Oct 2016 00:42:35 +0800
>
> > Prior to this patch, it used a local variable to save the transport that is
> > looked up by __sctp_lookup_association(), and didn't return it back. But in
> > sctp_rcv, it is used to initialize chunk->transport. So when hitting this,
> > even if it found the transport, it was still initializing chunk->transport
> > with null instead.
> >
> > This patch is to return the transport back through transport pointer
> > that is from __sctp_rcv_lookup_harder().
> >
> > Signed-off-by: Xin Long <lucien.xin@gmail.com>
>
> So do I apply this to 'net'? If so I'd like to see explicit ACKs.
>
> Thanks.
No. Xin reposted the patchset with this patch updated instead, so please
ignore this one. Thanks.
Patchset named: [PATCHv2 net 0/3] sctp: a bunch of fixes by holding transport
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCHv2 net] sctp: return back transport in __sctp_rcv_init_lookup
@ 2016-10-31 20:13 ` marcelo.leitner
0 siblings, 0 replies; 12+ messages in thread
From: marcelo.leitner @ 2016-10-31 20:13 UTC (permalink / raw)
To: David Miller; +Cc: lucien.xin, netdev, linux-sctp, vyasevich, nhorman
On Mon, Oct 31, 2016 at 03:53:48PM -0400, David Miller wrote:
> From: Xin Long <lucien.xin@gmail.com>
> Date: Mon, 31 Oct 2016 00:42:35 +0800
>
> > Prior to this patch, it used a local variable to save the transport that is
> > looked up by __sctp_lookup_association(), and didn't return it back. But in
> > sctp_rcv, it is used to initialize chunk->transport. So when hitting this,
> > even if it found the transport, it was still initializing chunk->transport
> > with null instead.
> >
> > This patch is to return the transport back through transport pointer
> > that is from __sctp_rcv_lookup_harder().
> >
> > Signed-off-by: Xin Long <lucien.xin@gmail.com>
>
> So do I apply this to 'net'? If so I'd like to see explicit ACKs.
>
> Thanks.
No. Xin reposted the patchset with this patch updated instead, so please
ignore this one. Thanks.
Patchset named: [PATCHv2 net 0/3] sctp: a bunch of fixes by holding transport
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCHv2 net] sctp: return back transport in __sctp_rcv_init_lookup
2016-10-31 20:13 ` marcelo.leitner
@ 2016-10-31 20:30 ` David Miller
-1 siblings, 0 replies; 12+ messages in thread
From: David Miller @ 2016-10-31 20:30 UTC (permalink / raw)
To: marcelo.leitner; +Cc: lucien.xin, netdev, linux-sctp, vyasevich, nhorman
From: marcelo.leitner@gmail.com
Date: Mon, 31 Oct 2016 18:13:02 -0200
> On Mon, Oct 31, 2016 at 03:53:48PM -0400, David Miller wrote:
>> From: Xin Long <lucien.xin@gmail.com>
>> Date: Mon, 31 Oct 2016 00:42:35 +0800
>>
>> > Prior to this patch, it used a local variable to save the transport that is
>> > looked up by __sctp_lookup_association(), and didn't return it back. But in
>> > sctp_rcv, it is used to initialize chunk->transport. So when hitting this,
>> > even if it found the transport, it was still initializing chunk->transport
>> > with null instead.
>> >
>> > This patch is to return the transport back through transport pointer
>> > that is from __sctp_rcv_lookup_harder().
>> >
>> > Signed-off-by: Xin Long <lucien.xin@gmail.com>
>>
>> So do I apply this to 'net'? If so I'd like to see explicit ACKs.
>>
>> Thanks.
>
> No. Xin reposted the patchset with this patch updated instead, so please
> ignore this one. Thanks.
>
> Patchset named: [PATCHv2 net 0/3] sctp: a bunch of fixes by holding transport
I got this now, thanks.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCHv2 net] sctp: return back transport in __sctp_rcv_init_lookup
@ 2016-10-31 20:30 ` David Miller
0 siblings, 0 replies; 12+ messages in thread
From: David Miller @ 2016-10-31 20:30 UTC (permalink / raw)
To: marcelo.leitner; +Cc: lucien.xin, netdev, linux-sctp, vyasevich, nhorman
From: marcelo.leitner@gmail.com
Date: Mon, 31 Oct 2016 18:13:02 -0200
> On Mon, Oct 31, 2016 at 03:53:48PM -0400, David Miller wrote:
>> From: Xin Long <lucien.xin@gmail.com>
>> Date: Mon, 31 Oct 2016 00:42:35 +0800
>>
>> > Prior to this patch, it used a local variable to save the transport that is
>> > looked up by __sctp_lookup_association(), and didn't return it back. But in
>> > sctp_rcv, it is used to initialize chunk->transport. So when hitting this,
>> > even if it found the transport, it was still initializing chunk->transport
>> > with null instead.
>> >
>> > This patch is to return the transport back through transport pointer
>> > that is from __sctp_rcv_lookup_harder().
>> >
>> > Signed-off-by: Xin Long <lucien.xin@gmail.com>
>>
>> So do I apply this to 'net'? If so I'd like to see explicit ACKs.
>>
>> Thanks.
>
> No. Xin reposted the patchset with this patch updated instead, so please
> ignore this one. Thanks.
>
> Patchset named: [PATCHv2 net 0/3] sctp: a bunch of fixes by holding transport
I got this now, thanks.
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2016-10-31 20:30 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-30 16:42 [PATCHv2 net] sctp: return back transport in __sctp_rcv_init_lookup Xin Long
2016-10-30 16:42 ` Xin Long
2016-10-31 10:51 ` Marcelo Ricardo Leitner
2016-10-31 10:51 ` Marcelo Ricardo Leitner
2016-10-31 12:25 ` Xin Long
2016-10-31 12:25 ` Xin Long
2016-10-31 19:53 ` David Miller
2016-10-31 19:53 ` David Miller
2016-10-31 20:13 ` marcelo.leitner
2016-10-31 20:13 ` marcelo.leitner
2016-10-31 20:30 ` David Miller
2016-10-31 20:30 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.