All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
	Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	<rtc-linux@googlegroups.com>
Subject: [PATCH 1/3] rtc: make rtc-lib explicitly non-modular
Date: Mon, 31 Oct 2016 14:55:25 -0400	[thread overview]
Message-ID: <20161031185527.20279-2-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <20161031185527.20279-1-paul.gortmaker@windriver.com>

The Kconfig currently controlling compilation of this code is:

drivers/rtc/Kconfig:config RTC_LIB
drivers/rtc/Kconfig:    bool

...meaning that it currently is not being built as a module by anyone.

Lets remove the couple traces of modular infrastructure use, so that
when reading the driver there is no doubt it is builtin-only.

We delete the MODULE_LICENSE tag since all that information
is already contained at the top of the file in the comments.

We don't replace module.h with init.h since the file doesn't need that.
However we do add export.h since the file uses EXPORT_SYMBOL.

Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: rtc-linux@googlegroups.com
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 drivers/rtc/rtc-lib.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/rtc/rtc-lib.c b/drivers/rtc/rtc-lib.c
index e6bfb9c42a10..1ae7da5cfc60 100644
--- a/drivers/rtc/rtc-lib.c
+++ b/drivers/rtc/rtc-lib.c
@@ -11,7 +11,7 @@
  * published by the Free Software Foundation.
 */
 
-#include <linux/module.h>
+#include <linux/export.h>
 #include <linux/rtc.h>
 
 static const unsigned char rtc_days_in_month[] = {
@@ -148,5 +148,3 @@ struct rtc_time rtc_ktime_to_tm(ktime_t kt)
 	return ret;
 }
 EXPORT_SYMBOL_GPL(rtc_ktime_to_tm);
-
-MODULE_LICENSE("GPL");
-- 
2.10.1

WARNING: multiple messages have this Message-ID (diff)
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
	Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	<rtc-linux@googlegroups.com>
Subject: [rtc-linux] [PATCH 1/3] rtc: make rtc-lib explicitly non-modular
Date: Mon, 31 Oct 2016 14:55:25 -0400	[thread overview]
Message-ID: <20161031185527.20279-2-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <20161031185527.20279-1-paul.gortmaker@windriver.com>

The Kconfig currently controlling compilation of this code is:

drivers/rtc/Kconfig:config RTC_LIB
drivers/rtc/Kconfig:    bool

...meaning that it currently is not being built as a module by anyone.

Lets remove the couple traces of modular infrastructure use, so that
when reading the driver there is no doubt it is builtin-only.

We delete the MODULE_LICENSE tag since all that information
is already contained at the top of the file in the comments.

We don't replace module.h with init.h since the file doesn't need that.
However we do add export.h since the file uses EXPORT_SYMBOL.

Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: rtc-linux@googlegroups.com
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 drivers/rtc/rtc-lib.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/rtc/rtc-lib.c b/drivers/rtc/rtc-lib.c
index e6bfb9c42a10..1ae7da5cfc60 100644
--- a/drivers/rtc/rtc-lib.c
+++ b/drivers/rtc/rtc-lib.c
@@ -11,7 +11,7 @@
  * published by the Free Software Foundation.
 */
 
-#include <linux/module.h>
+#include <linux/export.h>
 #include <linux/rtc.h>
 
 static const unsigned char rtc_days_in_month[] = {
@@ -148,5 +148,3 @@ struct rtc_time rtc_ktime_to_tm(ktime_t kt)
 	return ret;
 }
 EXPORT_SYMBOL_GPL(rtc_ktime_to_tm);
-
-MODULE_LICENSE("GPL");
-- 
2.10.1

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

  reply	other threads:[~2016-10-31 18:57 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-31 18:55 [PATCH 0/3] rtc: remove modular usage from non-modular code Paul Gortmaker
2016-10-31 18:55 ` Paul Gortmaker
2016-10-31 18:55 ` [rtc-linux] " Paul Gortmaker
2016-10-31 18:55 ` Paul Gortmaker [this message]
2016-10-31 18:55   ` [rtc-linux] [PATCH 1/3] rtc: make rtc-lib explicitly non-modular Paul Gortmaker
2016-10-31 18:55 ` [PATCH 2/3] rtc: sparc: make starfire " Paul Gortmaker
2016-10-31 18:55   ` Paul Gortmaker
2016-10-31 18:55   ` [rtc-linux] " Paul Gortmaker
2016-11-20 21:29   ` David Miller
2016-11-20 21:29     ` David Miller
2016-11-20 21:29     ` [rtc-linux] " David Miller
2016-11-20 21:38     ` Alexandre Belloni
2016-11-20 21:38       ` Alexandre Belloni
2016-11-20 21:38       ` [rtc-linux] " Alexandre Belloni
2016-10-31 18:55 ` [PATCH 3/3] rtc: sparc: make sun4v " Paul Gortmaker
2016-10-31 18:55   ` Paul Gortmaker
2016-10-31 18:55   ` [rtc-linux] " Paul Gortmaker
2016-11-20 21:29   ` David Miller
2016-11-20 21:29     ` David Miller
2016-11-20 21:29     ` [rtc-linux] " David Miller
2016-11-04 22:30 ` [PATCH 0/3] rtc: remove modular usage from non-modular code Alexandre Belloni
2016-11-04 22:30   ` Alexandre Belloni
2016-11-04 22:30   ` [rtc-linux] " Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161031185527.20279-2-paul.gortmaker@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.