* [PATCH] net: qcom/emac: use correct value for SGMII_LN_UCDR_SO_GAIN_MODE0
@ 2016-10-31 23:18 Timur Tabi
2016-11-01 16:14 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Timur Tabi @ 2016-10-31 23:18 UTC (permalink / raw)
To: David Miller, netdev
The documentation says that SGMII_LN_UCDR_SO_GAIN_MODE0 should be
set to 0, not 6, on the Qualcomm Technologies QDF2432.
Signed-off-by: Timur Tabi <timur@codeaurora.org>
---
drivers/net/ethernet/qualcomm/emac/emac-sgmii.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/qualcomm/emac/emac-sgmii.c b/drivers/net/ethernet/qualcomm/emac/emac-sgmii.c
index 8b3e6c3..3edb5a5 100644
--- a/drivers/net/ethernet/qualcomm/emac/emac-sgmii.c
+++ b/drivers/net/ethernet/qualcomm/emac/emac-sgmii.c
@@ -421,7 +421,7 @@ static const struct emac_reg_write sgmii_v2_laned[] = {
/* CDR Settings */
{EMAC_SGMII_LN_UCDR_FO_GAIN_MODE0,
UCDR_STEP_BY_TWO_MODE0 | UCDR_xO_GAIN_MODE(10)},
- {EMAC_SGMII_LN_UCDR_SO_GAIN_MODE0, UCDR_xO_GAIN_MODE(6)},
+ {EMAC_SGMII_LN_UCDR_SO_GAIN_MODE0, UCDR_xO_GAIN_MODE(0)},
{EMAC_SGMII_LN_UCDR_SO_CONFIG, UCDR_ENABLE | UCDR_SO_SATURATION(12)},
/* TX/RX Settings */
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: qcom/emac: use correct value for SGMII_LN_UCDR_SO_GAIN_MODE0
2016-10-31 23:18 [PATCH] net: qcom/emac: use correct value for SGMII_LN_UCDR_SO_GAIN_MODE0 Timur Tabi
@ 2016-11-01 16:14 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-11-01 16:14 UTC (permalink / raw)
To: timur; +Cc: netdev
From: Timur Tabi <timur@codeaurora.org>
Date: Mon, 31 Oct 2016 18:18:42 -0500
> The documentation says that SGMII_LN_UCDR_SO_GAIN_MODE0 should be
> set to 0, not 6, on the Qualcomm Technologies QDF2432.
>
> Signed-off-by: Timur Tabi <timur@codeaurora.org>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-01 16:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-31 23:18 [PATCH] net: qcom/emac: use correct value for SGMII_LN_UCDR_SO_GAIN_MODE0 Timur Tabi
2016-11-01 16:14 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.