All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] libf2fs: avoid build warning
@ 2016-11-01  4:25 Jaegeuk Kim
  0 siblings, 0 replies; only message in thread
From: Jaegeuk Kim @ 2016-11-01  4:25 UTC (permalink / raw)
  To: linux-f2fs-devel; +Cc: Jaegeuk Kim

This avoids the below warnings.

libf2fs_zoned.c:39:8: warning: ignoring return value of 'fscanf', declared with attribute warn_unused_result [-Wunused-result]
fscanf(file, "%s", str);
      ^
libf2fs_zoned.c: In function 'f2fs_get_zone_blocks':
libf2fs_zoned.c:72:8: warning: ignoring return value of 'fscanf', declared with attribute warn_unused_result [-Wunused-result]
fscanf(file, "%s", str);
      ^

Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
 lib/libf2fs_zoned.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/lib/libf2fs_zoned.c b/lib/libf2fs_zoned.c
index 4ef4f1d..93b48f1 100644
--- a/lib/libf2fs_zoned.c
+++ b/lib/libf2fs_zoned.c
@@ -26,6 +26,7 @@ void f2fs_get_zoned_model()
 {
 	char str[128];
 	FILE *file;
+	int res;
 
 	/* Check that this is a zoned block device */
 	snprintf(str, sizeof(str),
@@ -36,9 +37,12 @@ void f2fs_get_zoned_model()
 		goto not_zoned;
 
 	memset(str, 0, sizeof(str));
-	fscanf(file, "%s", str);
+	res = fscanf(file, "%s", str);
 	fclose(file);
 
+	if (res != 1)
+		goto not_zoned;
+
 	if (strcmp(str, "host-aware") == 0) {
 		c.zoned_model = F2FS_ZONED_HA;
 		return;
@@ -57,6 +61,7 @@ int f2fs_get_zone_blocks()
 	uint64_t sectors;
 	char str[128];
 	FILE *file;
+	int res;
 
 	/* Get zone size */
 	c.zone_blocks = 0;
@@ -69,9 +74,12 @@ int f2fs_get_zone_blocks()
 		return -1;
 
 	memset(str, 0, sizeof(str));
-	fscanf(file, "%s", str);
+	res = fscanf(file, "%s", str);
 	fclose(file);
 
+	if (res != 1)
+		return -1;
+
 	sectors = atol(str);
 	if (!sectors)
 		return -1;
-- 
2.8.3


------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2016-11-01  4:25 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-01  4:25 [PATCH] libf2fs: avoid build warning Jaegeuk Kim

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.