From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org, Rob Herring <robh@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Gabriele Paoloni <gabriele.paoloni@huawei.com>,
Jon Mason <jonmason@broadcom.com>, Ray Jui <rjui@broadcom.com>,
Shawn Lin <shawn.lin@rock-chips.com>,
Wenrui Li <wenrui.li@rock-chips.com>,
Scott Branden <sbranden@broadcom.com>,
Zhou Wang <wangzhou1@hisilicon.com>,
Tanmay Inamdar <tinamdar@apm.com>,
Greg Ungerer <gerg@uclinux.org>,
Thierry Reding <treding@nvidia.com>
Subject: Re: [PATCH] PCI: Warn on possible RW1C corruption for sub-32 bit config writes
Date: Tue, 1 Nov 2016 09:34:35 +0000 [thread overview]
Message-ID: <20161101093435.GO1041@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20161031213902.6340.96123.stgit@bhelgaas-glaptop.roam.corp.google.com>
On Mon, Oct 31, 2016 at 04:39:02PM -0500, Bjorn Helgaas wrote:
> Hardware that supports only 32-bit config writes is not spec-compliant.
> For example, if software performs a 16-bit write, we must do a 32-bit read,
> merge in the 16 bits we intend to write, followed by a 32-bit write. If
> the 16 bits we *don't* intend to write happen to have any RW1C (write-one-
> to-clear) bits set, we just inadvertently cleared something we shouldn't
> have.
>
> Add a rate-limited warning when we do sub-32 bit config writes. Remove
> similar probe-time warnings from some of the affected host bridge drivers.
Yay, I've been on about this for ages...
Enthusiastically-Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2016-11-01 9:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-31 21:39 [PATCH] PCI: Warn on possible RW1C corruption for sub-32 bit config writes Bjorn Helgaas
2016-11-01 9:34 ` Russell King - ARM Linux [this message]
2016-11-01 9:59 ` Shawn Lin
2016-11-02 17:45 ` Thierry Reding
2016-11-10 17:27 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161101093435.GO1041@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=bhelgaas@google.com \
--cc=gabriele.paoloni@huawei.com \
--cc=gerg@uclinux.org \
--cc=heiko@sntech.de \
--cc=jonmason@broadcom.com \
--cc=linux-pci@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=sbranden@broadcom.com \
--cc=shawn.lin@rock-chips.com \
--cc=tinamdar@apm.com \
--cc=treding@nvidia.com \
--cc=wangzhou1@hisilicon.com \
--cc=wenrui.li@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.