All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/sun4i: Propagate error to the caller
@ 2016-11-04  6:13 ` Christophe JAILLET
  0 siblings, 0 replies; 13+ messages in thread
From: Christophe JAILLET @ 2016-11-04  6:13 UTC (permalink / raw)
  To: maxime.ripard, wens, airlied
  Cc: dri-devel, linux-arm-kernel, linux-kernel, kernel-janitors,
	Christophe JAILLET

If 'sun4i_layers_init()' returns an error, propagate it instead of
returning -EINVAL unconditionally.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/gpu/drm/sun4i/sun4i_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c
index 628712e6edd6..ee4e5f987b6f 100644
--- a/drivers/gpu/drm/sun4i/sun4i_drv.c
+++ b/drivers/gpu/drm/sun4i/sun4i_drv.c
@@ -145,7 +145,7 @@ static int sun4i_drv_bind(struct device *dev)
 	drv->layers = sun4i_layers_init(drm);
 	if (IS_ERR(drv->layers)) {
 		dev_err(drm->dev, "Couldn't create the planes\n");
-		ret = -EINVAL;
+		ret = PTR_ERR(drv->layers);
 		goto free_drm;
 	}
 
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 13+ messages in thread
* [PATCH] drm/sun4i: Propagate error to the caller
@ 2016-11-04  6:13 ` Christophe JAILLET
  0 siblings, 0 replies; 13+ messages in thread
From: Christophe JAILLET @ 2016-11-04  6:13 UTC (permalink / raw)
  To: maxime.ripard, wens, airlied
  Cc: dri-devel, linux-arm-kernel, linux-kernel, kernel-janitors,
	Christophe JAILLET

If 'sun4i_layers_init()' returns an error, propagate it instead of
returning -EINVAL unconditionally.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/gpu/drm/sun4i/sun4i_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c
index 628712e6edd6..ee4e5f987b6f 100644
--- a/drivers/gpu/drm/sun4i/sun4i_drv.c
+++ b/drivers/gpu/drm/sun4i/sun4i_drv.c
@@ -145,7 +145,7 @@ static int sun4i_drv_bind(struct device *dev)
 	drv->layers = sun4i_layers_init(drm);
 	if (IS_ERR(drv->layers)) {
 		dev_err(drm->dev, "Couldn't create the planes\n");
-		ret = -EINVAL;
+		ret = PTR_ERR(drv->layers);
 		goto free_drm;
 	}
 
-- 
2.9.3


^ permalink raw reply related	[flat|nested] 13+ messages in thread
* [PATCH] drm/sun4i: Propagate error to the caller
@ 2016-11-04  6:13 ` Christophe JAILLET
  0 siblings, 0 replies; 13+ messages in thread
From: Christophe JAILLET @ 2016-11-04  6:13 UTC (permalink / raw)
  To: linux-arm-kernel

If 'sun4i_layers_init()' returns an error, propagate it instead of
returning -EINVAL unconditionally.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/gpu/drm/sun4i/sun4i_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/sun4i/sun4i_drv.c b/drivers/gpu/drm/sun4i/sun4i_drv.c
index 628712e6edd6..ee4e5f987b6f 100644
--- a/drivers/gpu/drm/sun4i/sun4i_drv.c
+++ b/drivers/gpu/drm/sun4i/sun4i_drv.c
@@ -145,7 +145,7 @@ static int sun4i_drv_bind(struct device *dev)
 	drv->layers = sun4i_layers_init(drm);
 	if (IS_ERR(drv->layers)) {
 		dev_err(drm->dev, "Couldn't create the planes\n");
-		ret = -EINVAL;
+		ret = PTR_ERR(drv->layers);
 		goto free_drm;
 	}
 
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 13+ messages in thread
* Re: [PATCH] drm/sun4i: Propagate error to the caller
  2016-11-04  6:13 ` Christophe JAILLET
  (?)
@ 2016-11-04  7:48   ` Maxime Ripard
  -1 siblings, 0 replies; 13+ messages in thread
From: Maxime Ripard @ 2016-11-04  7:48 UTC (permalink / raw)
  To: Christophe JAILLET
  Cc: wens, airlied, dri-devel, linux-arm-kernel, linux-kernel,
	kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

On Fri, Nov 04, 2016 at 07:13:52AM +0100, Christophe JAILLET wrote:
> If 'sun4i_layers_init()' returns an error, propagate it instead of
> returning -EINVAL unconditionally.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Applied, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH] drm/sun4i: Propagate error to the caller
@ 2016-11-04  7:48   ` Maxime Ripard
  0 siblings, 0 replies; 13+ messages in thread
From: Maxime Ripard @ 2016-11-04  7:48 UTC (permalink / raw)
  To: Christophe JAILLET
  Cc: wens, airlied, dri-devel, linux-arm-kernel, linux-kernel,
	kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

On Fri, Nov 04, 2016 at 07:13:52AM +0100, Christophe JAILLET wrote:
> If 'sun4i_layers_init()' returns an error, propagate it instead of
> returning -EINVAL unconditionally.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Applied, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread
* [PATCH] drm/sun4i: Propagate error to the caller
@ 2016-11-04  7:48   ` Maxime Ripard
  0 siblings, 0 replies; 13+ messages in thread
From: Maxime Ripard @ 2016-11-04  7:48 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, Nov 04, 2016 at 07:13:52AM +0100, Christophe JAILLET wrote:
> If 'sun4i_layers_init()' returns an error, propagate it instead of
> returning -EINVAL unconditionally.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Applied, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161104/873dafd5/attachment.sig>

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH] drm/sun4i: Propagate error to the caller
  2016-11-04  6:13 ` Christophe JAILLET
  (?)
  (?)
@ 2016-11-07  1:19   ` Gustavo Padovan
  -1 siblings, 0 replies; 13+ messages in thread
From: Gustavo Padovan @ 2016-11-07  1:19 UTC (permalink / raw)
  To: Christophe JAILLET
  Cc: maxime.ripard, wens, airlied, kernel-janitors, linux-arm-kernel,
	dri-devel, linux-kernel

Hi Christophe,

2016-11-04 Christophe JAILLET <christophe.jaillet@wanadoo.fr>:

> If 'sun4i_layers_init()' returns an error, propagate it instead of
> returning -EINVAL unconditionally.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/gpu/drm/sun4i/sun4i_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

Gustavo

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH] drm/sun4i: Propagate error to the caller
@ 2016-11-07  1:19   ` Gustavo Padovan
  0 siblings, 0 replies; 13+ messages in thread
From: Gustavo Padovan @ 2016-11-07  1:19 UTC (permalink / raw)
  To: Christophe JAILLET
  Cc: kernel-janitors, linux-kernel, dri-devel, wens, maxime.ripard,
	linux-arm-kernel

Hi Christophe,

2016-11-04 Christophe JAILLET <christophe.jaillet@wanadoo.fr>:

> If 'sun4i_layers_init()' returns an error, propagate it instead of
> returning -EINVAL unconditionally.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/gpu/drm/sun4i/sun4i_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

Gustavo

^ permalink raw reply	[flat|nested] 13+ messages in thread
* [PATCH] drm/sun4i: Propagate error to the caller
@ 2016-11-07  1:19   ` Gustavo Padovan
  0 siblings, 0 replies; 13+ messages in thread
From: Gustavo Padovan @ 2016-11-07  1:19 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Christophe,

2016-11-04 Christophe JAILLET <christophe.jaillet@wanadoo.fr>:

> If 'sun4i_layers_init()' returns an error, propagate it instead of
> returning -EINVAL unconditionally.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/gpu/drm/sun4i/sun4i_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

Gustavo

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH] drm/sun4i: Propagate error to the caller
@ 2016-11-07  1:19   ` Gustavo Padovan
  0 siblings, 0 replies; 13+ messages in thread
From: Gustavo Padovan @ 2016-11-07  1:19 UTC (permalink / raw)
  To: Christophe JAILLET
  Cc: kernel-janitors, linux-kernel, dri-devel, wens, maxime.ripard,
	linux-arm-kernel

Hi Christophe,

2016-11-04 Christophe JAILLET <christophe.jaillet@wanadoo.fr>:

> If 'sun4i_layers_init()' returns an error, propagate it instead of
> returning -EINVAL unconditionally.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/gpu/drm/sun4i/sun4i_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

Gustavo
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH] drm/sun4i: Propagate error to the caller
  2016-11-07  1:19   ` Gustavo Padovan
  (?)
@ 2016-11-07 15:10     ` Maxime Ripard
  -1 siblings, 0 replies; 13+ messages in thread
From: Maxime Ripard @ 2016-11-07 15:10 UTC (permalink / raw)
  To: Gustavo Padovan, Christophe JAILLET, wens, airlied,
	kernel-janitors, linux-arm-kernel, dri-devel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 657 bytes --]

On Mon, Nov 07, 2016 at 10:19:57AM +0900, Gustavo Padovan wrote:
> Hi Christophe,
> 
> 2016-11-04 Christophe JAILLET <christophe.jaillet@wanadoo.fr>:
> 
> > If 'sun4i_layers_init()' returns an error, propagate it instead of
> > returning -EINVAL unconditionally.
> > 
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> > ---
> >  drivers/gpu/drm/sun4i/sun4i_drv.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

Applied, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH] drm/sun4i: Propagate error to the caller
@ 2016-11-07 15:10     ` Maxime Ripard
  0 siblings, 0 replies; 13+ messages in thread
From: Maxime Ripard @ 2016-11-07 15:10 UTC (permalink / raw)
  To: Gustavo Padovan, Christophe JAILLET, wens, airlied,
	kernel-janitors, linux-arm-kernel, dri-devel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 657 bytes --]

On Mon, Nov 07, 2016 at 10:19:57AM +0900, Gustavo Padovan wrote:
> Hi Christophe,
> 
> 2016-11-04 Christophe JAILLET <christophe.jaillet@wanadoo.fr>:
> 
> > If 'sun4i_layers_init()' returns an error, propagate it instead of
> > returning -EINVAL unconditionally.
> > 
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> > ---
> >  drivers/gpu/drm/sun4i/sun4i_drv.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

Applied, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread
* [PATCH] drm/sun4i: Propagate error to the caller
@ 2016-11-07 15:10     ` Maxime Ripard
  0 siblings, 0 replies; 13+ messages in thread
From: Maxime Ripard @ 2016-11-07 15:10 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Nov 07, 2016 at 10:19:57AM +0900, Gustavo Padovan wrote:
> Hi Christophe,
> 
> 2016-11-04 Christophe JAILLET <christophe.jaillet@wanadoo.fr>:
> 
> > If 'sun4i_layers_init()' returns an error, propagate it instead of
> > returning -EINVAL unconditionally.
> > 
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> > ---
> >  drivers/gpu/drm/sun4i/sun4i_drv.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

Applied, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161107/310f8f7b/attachment-0001.sig>

^ permalink raw reply	[flat|nested] 13+ messages in thread
end of thread, other threads:[~2016-11-07 15:10 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-04  6:13 [PATCH] drm/sun4i: Propagate error to the caller Christophe JAILLET
2016-11-04  6:13 ` Christophe JAILLET
2016-11-04  6:13 ` Christophe JAILLET
2016-11-04  7:48 ` Maxime Ripard
2016-11-04  7:48   ` Maxime Ripard
2016-11-04  7:48   ` Maxime Ripard
2016-11-07  1:19 ` Gustavo Padovan
2016-11-07  1:19   ` Gustavo Padovan
2016-11-07  1:19   ` Gustavo Padovan
2016-11-07  1:19   ` Gustavo Padovan
2016-11-07 15:10   ` Maxime Ripard
2016-11-07 15:10     ` Maxime Ripard
2016-11-07 15:10     ` Maxime Ripard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.