* [PATCH] powerpc/oops: fix pr_cont() issues in instruction dump
@ 2016-11-04 6:20 Andrew Donnellan
2016-11-22 0:38 ` Michael Ellerman
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Donnellan @ 2016-11-04 6:20 UTC (permalink / raw)
To: linuxppc-dev, mpe
Since the KERN_CONT changes, the current code in show_instructions() prints
out a whole bunch of unnecessary newlines. Change occurrences of
printk("\n") to pr_cont("\n"). While we're here, change all the other
cases of printk(KERN_CONT ...) to pr_cont() as well.
Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
---
Based off mpe's earlier pr_cont() fixes series
---
arch/powerpc/kernel/process.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
index ea6fe2e..749fb41 100644
--- a/arch/powerpc/kernel/process.c
+++ b/arch/powerpc/kernel/process.c
@@ -1215,7 +1215,7 @@ static void show_instructions(struct pt_regs *regs)
int instr;
if (!(i % 8))
- printk("\n");
+ pr_cont("\n");
#if !defined(CONFIG_BOOKE)
/* If executing with the IMMU off, adjust pc rather
@@ -1227,18 +1227,18 @@ static void show_instructions(struct pt_regs *regs)
if (!__kernel_text_address(pc) ||
probe_kernel_address((unsigned int __user *)pc, instr)) {
- printk(KERN_CONT "XXXXXXXX ");
+ pr_cont("XXXXXXXX ");
} else {
if (regs->nip == pc)
- printk(KERN_CONT "<%08x> ", instr);
+ pr_cont("<%08x> ", instr);
else
- printk(KERN_CONT "%08x ", instr);
+ pr_cont("%08x ", instr);
}
pc += sizeof(int);
}
- printk("\n");
+ pr_cont("\n");
}
struct regbit {
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com IBM Australia Limited
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: powerpc/oops: fix pr_cont() issues in instruction dump
2016-11-04 6:20 [PATCH] powerpc/oops: fix pr_cont() issues in instruction dump Andrew Donnellan
@ 2016-11-22 0:38 ` Michael Ellerman
0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2016-11-22 0:38 UTC (permalink / raw)
To: Andrew Donnellan, linuxppc-dev
On Fri, 2016-11-04 at 06:20:40 UTC, Andrew Donnellan wrote:
> Since the KERN_CONT changes, the current code in show_instructions() prints
> out a whole bunch of unnecessary newlines. Change occurrences of
> printk("\n") to pr_cont("\n"). While we're here, change all the other
> cases of printk(KERN_CONT ...) to pr_cont() as well.
>
> Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/2ffd04dee0dacff36c03a02434965a
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-22 0:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-04 6:20 [PATCH] powerpc/oops: fix pr_cont() issues in instruction dump Andrew Donnellan
2016-11-22 0:38 ` Michael Ellerman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.