* [RFC PATCH] ARM: dts: add panel and tcon nodes to Allwinner A33 Q8 tablet dts
@ 2016-11-06 11:11 ` Icenowy Zheng
0 siblings, 0 replies; 10+ messages in thread
From: Icenowy Zheng @ 2016-11-06 11:11 UTC (permalink / raw)
To: Maxime Ripard, Chen-Yu Tsai, Hans de Goede
Cc: Rob Herring, Mark Rutland, Russell King,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw, Icenowy Zheng
All A33 Q8 tablets features a LCD panel, with a resolution of either
800x480 or 1024x600.
Add "bone" device nodes to the device tree.
Signed-off-by: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>
---
Maybe it will be better to add them to sun8i-q8-reference-tablet.dtsi, as
these pin configurations are part of reference design of both A23 and A33,
not only restricted to Q8.
The DTS file is tested by me, after cherry-picks this patch from Chen-Yu Tsai:
https://github.com/wens/linux/commit/2823b887a289fbee5f97f3c6b45ed6c74a6368c6
And add these commands to my U-Boot boot command:
fdt addr 0x43000000
fdt resize
fdt set /panel compatible "urt,umsh-8596md-t"
fdt set /panel status "okay"
fdt set /display-engine status "okay"
fdt set /soc@01c00000/lcd-controller@01c0c000 status "okay"
arch/arm/boot/dts/sun8i-a33-q8-tablet.dts | 44 +++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)
diff --git a/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts b/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts
index b0bc236..871a20c 100644
--- a/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts
+++ b/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts
@@ -47,4 +47,48 @@
/ {
model = "Q8 A33 Tablet";
compatible = "allwinner,q8-a33", "allwinner,sun8i-a33";
+
+ panel: panel {
+ /* compatible should be set according to the panel */
+ pinctrl-names = "default";
+ pinctrl-0 = <&lcd_en_q8>;
+ backlight = <&backlight>;
+ enable-gpios = <&pio 7 7 GPIO_ACTIVE_HIGH>; /* PH7 */
+ power-supply = <®_dc1sw>;
+ status = "disabled";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ panel_input: endpoint@0 {
+ reg = <0>;
+ remote-endpoint = <&tcon0_out_lcd>;
+ };
+ };
+ };
+};
+
+&tcon0 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&lcd_rgb666_pins>;
+};
+
+&tcon0_out {
+ tcon0_out_lcd: endpoint@0 {
+ reg = <0>;
+ remote-endpoint = <&panel_input>;
+ };
+};
+
+&pio {
+ lcd_en_q8: lcd_en@0 {
+ allwinner,pins = "PH7";
+ allwinner,function = "gpio_out";
+ allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+ allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+ };
};
--
2.10.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [RFC PATCH] ARM: dts: add panel and tcon nodes to Allwinner A33 Q8 tablet dts
@ 2016-11-06 11:11 ` Icenowy Zheng
0 siblings, 0 replies; 10+ messages in thread
From: Icenowy Zheng @ 2016-11-06 11:11 UTC (permalink / raw)
To: linux-arm-kernel
All A33 Q8 tablets features a LCD panel, with a resolution of either
800x480 or 1024x600.
Add "bone" device nodes to the device tree.
Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
---
Maybe it will be better to add them to sun8i-q8-reference-tablet.dtsi, as
these pin configurations are part of reference design of both A23 and A33,
not only restricted to Q8.
The DTS file is tested by me, after cherry-picks this patch from Chen-Yu Tsai:
https://github.com/wens/linux/commit/2823b887a289fbee5f97f3c6b45ed6c74a6368c6
And add these commands to my U-Boot boot command:
fdt addr 0x43000000
fdt resize
fdt set /panel compatible "urt,umsh-8596md-t"
fdt set /panel status "okay"
fdt set /display-engine status "okay"
fdt set /soc at 01c00000/lcd-controller at 01c0c000 status "okay"
arch/arm/boot/dts/sun8i-a33-q8-tablet.dts | 44 +++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)
diff --git a/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts b/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts
index b0bc236..871a20c 100644
--- a/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts
+++ b/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts
@@ -47,4 +47,48 @@
/ {
model = "Q8 A33 Tablet";
compatible = "allwinner,q8-a33", "allwinner,sun8i-a33";
+
+ panel: panel {
+ /* compatible should be set according to the panel */
+ pinctrl-names = "default";
+ pinctrl-0 = <&lcd_en_q8>;
+ backlight = <&backlight>;
+ enable-gpios = <&pio 7 7 GPIO_ACTIVE_HIGH>; /* PH7 */
+ power-supply = <®_dc1sw>;
+ status = "disabled";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port at 0 {
+ reg = <0>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ panel_input: endpoint at 0 {
+ reg = <0>;
+ remote-endpoint = <&tcon0_out_lcd>;
+ };
+ };
+ };
+};
+
+&tcon0 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&lcd_rgb666_pins>;
+};
+
+&tcon0_out {
+ tcon0_out_lcd: endpoint at 0 {
+ reg = <0>;
+ remote-endpoint = <&panel_input>;
+ };
+};
+
+&pio {
+ lcd_en_q8: lcd_en at 0 {
+ allwinner,pins = "PH7";
+ allwinner,function = "gpio_out";
+ allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+ allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+ };
};
--
2.10.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [RFC PATCH] ARM: dts: add panel and tcon nodes to Allwinner A33 Q8 tablet dts
@ 2016-11-06 14:27 ` Hans de Goede
0 siblings, 0 replies; 10+ messages in thread
From: Hans de Goede @ 2016-11-06 14:27 UTC (permalink / raw)
To: Icenowy Zheng, Maxime Ripard, Chen-Yu Tsai
Cc: Rob Herring, Mark Rutland, Russell King, devicetree,
linux-arm-kernel, linux-kernel, linux-sunxi
Hi,
On 06-11-16 12:11, Icenowy Zheng wrote:
> All A33 Q8 tablets features a LCD panel, with a resolution of either
> 800x480 or 1024x600.
>
> Add "bone" device nodes to the device tree.
Bone ?
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
He, as discussed in the other thread since sun8i-a33-q8-tablet.dts
is used for both 800x480 and 1024x600 versions we really need to
introduce new sun8i-a33-q8-tablet-800x600.dts and
sun8i-a33-q8-tablet-1024x600.dts files, which include
sun8i-a33-q8-tablet.dts and then add just the panel bits; and patch
newer u-boots to use those instead.
This way people who stick with an old u-boot will just not get
the drm driver, rather then all of a sudden getting a wrong
resolution.
Icenowy, can you please also submit a matching u-boot patch
(both the new dts file, as well as updating the defconfig you
use to the new dts file)?
Regards,
Hans
> ---
>
> Maybe it will be better to add them to sun8i-q8-reference-tablet.dtsi, as
> these pin configurations are part of reference design of both A23 and A33,
> not only restricted to Q8.
>
> The DTS file is tested by me, after cherry-picks this patch from Chen-Yu Tsai:
> https://github.com/wens/linux/commit/2823b887a289fbee5f97f3c6b45ed6c74a6368c6
>
> And add these commands to my U-Boot boot command:
>
> fdt addr 0x43000000
> fdt resize
> fdt set /panel compatible "urt,umsh-8596md-t"
> fdt set /panel status "okay"
> fdt set /display-engine status "okay"
> fdt set /soc@01c00000/lcd-controller@01c0c000 status "okay"
>
> arch/arm/boot/dts/sun8i-a33-q8-tablet.dts | 44 +++++++++++++++++++++++++++++++
> 1 file changed, 44 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts b/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts
> index b0bc236..871a20c 100644
> --- a/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts
> +++ b/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts
> @@ -47,4 +47,48 @@
> / {
> model = "Q8 A33 Tablet";
> compatible = "allwinner,q8-a33", "allwinner,sun8i-a33";
> +
> + panel: panel {
> + /* compatible should be set according to the panel */
> + pinctrl-names = "default";
> + pinctrl-0 = <&lcd_en_q8>;
> + backlight = <&backlight>;
> + enable-gpios = <&pio 7 7 GPIO_ACTIVE_HIGH>; /* PH7 */
> + power-supply = <®_dc1sw>;
> + status = "disabled";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + panel_input: endpoint@0 {
> + reg = <0>;
> + remote-endpoint = <&tcon0_out_lcd>;
> + };
> + };
> + };
> +};
> +
> +&tcon0 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&lcd_rgb666_pins>;
> +};
> +
> +&tcon0_out {
> + tcon0_out_lcd: endpoint@0 {
> + reg = <0>;
> + remote-endpoint = <&panel_input>;
> + };
> +};
> +
> +&pio {
> + lcd_en_q8: lcd_en@0 {
> + allwinner,pins = "PH7";
> + allwinner,function = "gpio_out";
> + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> + };
> };
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [RFC PATCH] ARM: dts: add panel and tcon nodes to Allwinner A33 Q8 tablet dts
@ 2016-11-06 14:27 ` Hans de Goede
0 siblings, 0 replies; 10+ messages in thread
From: Hans de Goede @ 2016-11-06 14:27 UTC (permalink / raw)
To: Icenowy Zheng, Maxime Ripard, Chen-Yu Tsai
Cc: Rob Herring, Mark Rutland, Russell King,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw
Hi,
On 06-11-16 12:11, Icenowy Zheng wrote:
> All A33 Q8 tablets features a LCD panel, with a resolution of either
> 800x480 or 1024x600.
>
> Add "bone" device nodes to the device tree.
Bone ?
>
> Signed-off-by: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>
He, as discussed in the other thread since sun8i-a33-q8-tablet.dts
is used for both 800x480 and 1024x600 versions we really need to
introduce new sun8i-a33-q8-tablet-800x600.dts and
sun8i-a33-q8-tablet-1024x600.dts files, which include
sun8i-a33-q8-tablet.dts and then add just the panel bits; and patch
newer u-boots to use those instead.
This way people who stick with an old u-boot will just not get
the drm driver, rather then all of a sudden getting a wrong
resolution.
Icenowy, can you please also submit a matching u-boot patch
(both the new dts file, as well as updating the defconfig you
use to the new dts file)?
Regards,
Hans
> ---
>
> Maybe it will be better to add them to sun8i-q8-reference-tablet.dtsi, as
> these pin configurations are part of reference design of both A23 and A33,
> not only restricted to Q8.
>
> The DTS file is tested by me, after cherry-picks this patch from Chen-Yu Tsai:
> https://github.com/wens/linux/commit/2823b887a289fbee5f97f3c6b45ed6c74a6368c6
>
> And add these commands to my U-Boot boot command:
>
> fdt addr 0x43000000
> fdt resize
> fdt set /panel compatible "urt,umsh-8596md-t"
> fdt set /panel status "okay"
> fdt set /display-engine status "okay"
> fdt set /soc@01c00000/lcd-controller@01c0c000 status "okay"
>
> arch/arm/boot/dts/sun8i-a33-q8-tablet.dts | 44 +++++++++++++++++++++++++++++++
> 1 file changed, 44 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts b/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts
> index b0bc236..871a20c 100644
> --- a/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts
> +++ b/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts
> @@ -47,4 +47,48 @@
> / {
> model = "Q8 A33 Tablet";
> compatible = "allwinner,q8-a33", "allwinner,sun8i-a33";
> +
> + panel: panel {
> + /* compatible should be set according to the panel */
> + pinctrl-names = "default";
> + pinctrl-0 = <&lcd_en_q8>;
> + backlight = <&backlight>;
> + enable-gpios = <&pio 7 7 GPIO_ACTIVE_HIGH>; /* PH7 */
> + power-supply = <®_dc1sw>;
> + status = "disabled";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + panel_input: endpoint@0 {
> + reg = <0>;
> + remote-endpoint = <&tcon0_out_lcd>;
> + };
> + };
> + };
> +};
> +
> +&tcon0 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&lcd_rgb666_pins>;
> +};
> +
> +&tcon0_out {
> + tcon0_out_lcd: endpoint@0 {
> + reg = <0>;
> + remote-endpoint = <&panel_input>;
> + };
> +};
> +
> +&pio {
> + lcd_en_q8: lcd_en@0 {
> + allwinner,pins = "PH7";
> + allwinner,function = "gpio_out";
> + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> + };
> };
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [RFC PATCH] ARM: dts: add panel and tcon nodes to Allwinner A33 Q8 tablet dts
@ 2016-11-06 14:27 ` Hans de Goede
0 siblings, 0 replies; 10+ messages in thread
From: Hans de Goede @ 2016-11-06 14:27 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On 06-11-16 12:11, Icenowy Zheng wrote:
> All A33 Q8 tablets features a LCD panel, with a resolution of either
> 800x480 or 1024x600.
>
> Add "bone" device nodes to the device tree.
Bone ?
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
He, as discussed in the other thread since sun8i-a33-q8-tablet.dts
is used for both 800x480 and 1024x600 versions we really need to
introduce new sun8i-a33-q8-tablet-800x600.dts and
sun8i-a33-q8-tablet-1024x600.dts files, which include
sun8i-a33-q8-tablet.dts and then add just the panel bits; and patch
newer u-boots to use those instead.
This way people who stick with an old u-boot will just not get
the drm driver, rather then all of a sudden getting a wrong
resolution.
Icenowy, can you please also submit a matching u-boot patch
(both the new dts file, as well as updating the defconfig you
use to the new dts file)?
Regards,
Hans
> ---
>
> Maybe it will be better to add them to sun8i-q8-reference-tablet.dtsi, as
> these pin configurations are part of reference design of both A23 and A33,
> not only restricted to Q8.
>
> The DTS file is tested by me, after cherry-picks this patch from Chen-Yu Tsai:
> https://github.com/wens/linux/commit/2823b887a289fbee5f97f3c6b45ed6c74a6368c6
>
> And add these commands to my U-Boot boot command:
>
> fdt addr 0x43000000
> fdt resize
> fdt set /panel compatible "urt,umsh-8596md-t"
> fdt set /panel status "okay"
> fdt set /display-engine status "okay"
> fdt set /soc at 01c00000/lcd-controller at 01c0c000 status "okay"
>
> arch/arm/boot/dts/sun8i-a33-q8-tablet.dts | 44 +++++++++++++++++++++++++++++++
> 1 file changed, 44 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts b/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts
> index b0bc236..871a20c 100644
> --- a/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts
> +++ b/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts
> @@ -47,4 +47,48 @@
> / {
> model = "Q8 A33 Tablet";
> compatible = "allwinner,q8-a33", "allwinner,sun8i-a33";
> +
> + panel: panel {
> + /* compatible should be set according to the panel */
> + pinctrl-names = "default";
> + pinctrl-0 = <&lcd_en_q8>;
> + backlight = <&backlight>;
> + enable-gpios = <&pio 7 7 GPIO_ACTIVE_HIGH>; /* PH7 */
> + power-supply = <®_dc1sw>;
> + status = "disabled";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port at 0 {
> + reg = <0>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + panel_input: endpoint at 0 {
> + reg = <0>;
> + remote-endpoint = <&tcon0_out_lcd>;
> + };
> + };
> + };
> +};
> +
> +&tcon0 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&lcd_rgb666_pins>;
> +};
> +
> +&tcon0_out {
> + tcon0_out_lcd: endpoint at 0 {
> + reg = <0>;
> + remote-endpoint = <&panel_input>;
> + };
> +};
> +
> +&pio {
> + lcd_en_q8: lcd_en at 0 {
> + allwinner,pins = "PH7";
> + allwinner,function = "gpio_out";
> + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> + };
> };
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [RFC PATCH] ARM: dts: add panel and tcon nodes to Allwinner A33 Q8 tablet dts
2016-11-06 14:27 ` Hans de Goede
@ 2016-11-06 16:53 ` Icenowy Zheng
-1 siblings, 0 replies; 10+ messages in thread
From: Icenowy Zheng @ 2016-11-06 16:53 UTC (permalink / raw)
To: Hans de Goede, Maxime Ripard, Chen-Yu Tsai
Cc: Rob Herring, Mark Rutland, Russell King,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw
06.11.2016, 22:27, "Hans de Goede" <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>:
> Hi,
>
> On 06-11-16 12:11, Icenowy Zheng wrote:
>> All A33 Q8 tablets features a LCD panel, with a resolution of either
>> 800x480 or 1024x600.
>>
>> Add "bone" device nodes to the device tree.
>
> Bone ?
>
>> Signed-off-by: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>
>
> He, as discussed in the other thread since sun8i-a33-q8-tablet.dts
> is used for both 800x480 and 1024x600 versions we really need to
> introduce new sun8i-a33-q8-tablet-800x600.dts and
> sun8i-a33-q8-tablet-1024x600.dts files, which include
> sun8i-a33-q8-tablet.dts and then add just the panel bits; and patch
> newer u-boots to use those instead.
>
> This way people who stick with an old u-boot will just not get
> the drm driver, rather then all of a sudden getting a wrong
> resolution.
>
> Icenowy, can you please also submit a matching u-boot patch
> (both the new dts file, as well as updating the defconfig you
> use to the new dts file)?
Could you choose a compatible for 1024x600 variant?
(Since I have never such a Q8 tablet)
>
> Regards,
>
> Hans
>
>> ---
>>
>> Maybe it will be better to add them to sun8i-q8-reference-tablet.dtsi, as
>> these pin configurations are part of reference design of both A23 and A33,
>> not only restricted to Q8.
>>
>> The DTS file is tested by me, after cherry-picks this patch from Chen-Yu Tsai:
>> https://github.com/wens/linux/commit/2823b887a289fbee5f97f3c6b45ed6c74a6368c6
>>
>> And add these commands to my U-Boot boot command:
>>
>> fdt addr 0x43000000
>> fdt resize
>> fdt set /panel compatible "urt,umsh-8596md-t"
>> fdt set /panel status "okay"
>> fdt set /display-engine status "okay"
>> fdt set /soc@01c00000/lcd-controller@01c0c000 status "okay"
>>
>> arch/arm/boot/dts/sun8i-a33-q8-tablet.dts | 44 +++++++++++++++++++++++++++++++
>> 1 file changed, 44 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts b/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts
>> index b0bc236..871a20c 100644
>> --- a/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts
>> +++ b/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts
>> @@ -47,4 +47,48 @@
>> / {
>> model = "Q8 A33 Tablet";
>> compatible = "allwinner,q8-a33", "allwinner,sun8i-a33";
>> +
>> + panel: panel {
>> + /* compatible should be set according to the panel */
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&lcd_en_q8>;
>> + backlight = <&backlight>;
>> + enable-gpios = <&pio 7 7 GPIO_ACTIVE_HIGH>; /* PH7 */
>> + power-supply = <®_dc1sw>;
>> + status = "disabled";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + port@0 {
>> + reg = <0>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + panel_input: endpoint@0 {
>> + reg = <0>;
>> + remote-endpoint = <&tcon0_out_lcd>;
>> + };
>> + };
>> + };
>> +};
>> +
>> +&tcon0 {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&lcd_rgb666_pins>;
>> +};
>> +
>> +&tcon0_out {
>> + tcon0_out_lcd: endpoint@0 {
>> + reg = <0>;
>> + remote-endpoint = <&panel_input>;
>> + };
>> +};
>> +
>> +&pio {
>> + lcd_en_q8: lcd_en@0 {
>> + allwinner,pins = "PH7";
>> + allwinner,function = "gpio_out";
>> + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
>> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
>> + };
>> };
--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [RFC PATCH] ARM: dts: add panel and tcon nodes to Allwinner A33 Q8 tablet dts
@ 2016-11-06 16:53 ` Icenowy Zheng
0 siblings, 0 replies; 10+ messages in thread
From: Icenowy Zheng @ 2016-11-06 16:53 UTC (permalink / raw)
To: linux-arm-kernel
06.11.2016, 22:27, "Hans de Goede" <hdegoede@redhat.com>:
> Hi,
>
> On 06-11-16 12:11, Icenowy Zheng wrote:
>> ?All A33 Q8 tablets features a LCD panel, with a resolution of either
>> ?800x480 or 1024x600.
>>
>> ?Add "bone" device nodes to the device tree.
>
> Bone ?
>
>> ?Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
>
> He, as discussed in the other thread since sun8i-a33-q8-tablet.dts
> is used for both 800x480 and 1024x600 versions we really need to
> introduce new sun8i-a33-q8-tablet-800x600.dts and
> sun8i-a33-q8-tablet-1024x600.dts files, which include
> sun8i-a33-q8-tablet.dts and then add just the panel bits; and patch
> newer u-boots to use those instead.
>
> This way people who stick with an old u-boot will just not get
> the drm driver, rather then all of a sudden getting a wrong
> resolution.
>
> Icenowy, can you please also submit a matching u-boot patch
> (both the new dts file, as well as updating the defconfig you
> ??use to the new dts file)?
Could you choose a compatible for 1024x600 variant?
(Since I have never such a Q8 tablet)
>
> Regards,
>
> Hans
>
>> ?---
>>
>> ?Maybe it will be better to add them to sun8i-q8-reference-tablet.dtsi, as
>> ?these pin configurations are part of reference design of both A23 and A33,
>> ?not only restricted to Q8.
>>
>> ?The DTS file is tested by me, after cherry-picks this patch from Chen-Yu Tsai:
>> ?https://github.com/wens/linux/commit/2823b887a289fbee5f97f3c6b45ed6c74a6368c6
>>
>> ?And add these commands to my U-Boot boot command:
>>
>> ?fdt addr 0x43000000
>> ?fdt resize
>> ?fdt set /panel compatible "urt,umsh-8596md-t"
>> ?fdt set /panel status "okay"
>> ?fdt set /display-engine status "okay"
>> ?fdt set /soc at 01c00000/lcd-controller at 01c0c000 status "okay"
>>
>> ??arch/arm/boot/dts/sun8i-a33-q8-tablet.dts | 44 +++++++++++++++++++++++++++++++
>> ??1 file changed, 44 insertions(+)
>>
>> ?diff --git a/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts b/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts
>> ?index b0bc236..871a20c 100644
>> ?--- a/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts
>> ?+++ b/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts
>> ?@@ -47,4 +47,48 @@
>> ??/ {
>> ??????????model = "Q8 A33 Tablet";
>> ??????????compatible = "allwinner,q8-a33", "allwinner,sun8i-a33";
>> ?+
>> ?+ panel: panel {
>> ?+ /* compatible should be set according to the panel */
>> ?+ pinctrl-names = "default";
>> ?+ pinctrl-0 = <&lcd_en_q8>;
>> ?+ backlight = <&backlight>;
>> ?+ enable-gpios = <&pio 7 7 GPIO_ACTIVE_HIGH>; /* PH7 */
>> ?+ power-supply = <®_dc1sw>;
>> ?+ status = "disabled";
>> ?+ #address-cells = <1>;
>> ?+ #size-cells = <0>;
>> ?+
>> ?+ port at 0 {
>> ?+ reg = <0>;
>> ?+ #address-cells = <1>;
>> ?+ #size-cells = <0>;
>> ?+
>> ?+ panel_input: endpoint at 0 {
>> ?+ reg = <0>;
>> ?+ remote-endpoint = <&tcon0_out_lcd>;
>> ?+ };
>> ?+ };
>> ?+ };
>> ?+};
>> ?+
>> ?+&tcon0 {
>> ?+ pinctrl-names = "default";
>> ?+ pinctrl-0 = <&lcd_rgb666_pins>;
>> ?+};
>> ?+
>> ?+&tcon0_out {
>> ?+ tcon0_out_lcd: endpoint at 0 {
>> ?+ reg = <0>;
>> ?+ remote-endpoint = <&panel_input>;
>> ?+ };
>> ?+};
>> ?+
>> ?+&pio {
>> ?+ lcd_en_q8: lcd_en at 0 {
>> ?+ allwinner,pins = "PH7";
>> ?+ allwinner,function = "gpio_out";
>> ?+ allwinner,drive = <SUN4I_PINCTRL_10_MA>;
>> ?+ allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
>> ?+ };
>> ??};
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [linux-sunxi] Re: [RFC PATCH] ARM: dts: add panel and tcon nodes to Allwinner A33 Q8 tablet dts
@ 2016-11-07 9:26 ` Hans de Goede
0 siblings, 0 replies; 10+ messages in thread
From: Hans de Goede @ 2016-11-07 9:26 UTC (permalink / raw)
To: icenowy, Maxime Ripard, Chen-Yu Tsai
Cc: Rob Herring, Mark Rutland, Russell King, devicetree,
linux-arm-kernel, linux-kernel, linux-sunxi
Hi,
On 06-11-16 17:53, Icenowy Zheng wrote:
>
>
> 06.11.2016, 22:27, "Hans de Goede" <hdegoede@redhat.com>:
>> Hi,
>>
>> On 06-11-16 12:11, Icenowy Zheng wrote:
>>> All A33 Q8 tablets features a LCD panel, with a resolution of either
>>> 800x480 or 1024x600.
>>>
>>> Add "bone" device nodes to the device tree.
>>
>> Bone ?
>>
>>> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
>>
>> He, as discussed in the other thread since sun8i-a33-q8-tablet.dts
>> is used for both 800x480 and 1024x600 versions we really need to
>> introduce new sun8i-a33-q8-tablet-800x600.dts and
>> sun8i-a33-q8-tablet-1024x600.dts files, which include
>> sun8i-a33-q8-tablet.dts and then add just the panel bits; and patch
>> newer u-boots to use those instead.
>>
>> This way people who stick with an old u-boot will just not get
>> the drm driver, rather then all of a sudden getting a wrong
>> resolution.
>>
>> Icenowy, can you please also submit a matching u-boot patch
>> (both the new dts file, as well as updating the defconfig you
>> use to the new dts file)?
>
> Could you choose a compatible for 1024x600 variant?
Lets just add a sun8i-a33-q8-tablet-800x600.dts now and then
I will add a sun8i-a33-q8-tablet-1024x600.dts file later.
Regards,
Hans
>
> (Since I have never such a Q8 tablet)
>
>>
>> Regards,
>>
>> Hans
>>
>>> ---
>>>
>>> Maybe it will be better to add them to sun8i-q8-reference-tablet.dtsi, as
>>> these pin configurations are part of reference design of both A23 and A33,
>>> not only restricted to Q8.
>>>
>>> The DTS file is tested by me, after cherry-picks this patch from Chen-Yu Tsai:
>>> https://github.com/wens/linux/commit/2823b887a289fbee5f97f3c6b45ed6c74a6368c6
>>>
>>> And add these commands to my U-Boot boot command:
>>>
>>> fdt addr 0x43000000
>>> fdt resize
>>> fdt set /panel compatible "urt,umsh-8596md-t"
>>> fdt set /panel status "okay"
>>> fdt set /display-engine status "okay"
>>> fdt set /soc@01c00000/lcd-controller@01c0c000 status "okay"
>>>
>>> arch/arm/boot/dts/sun8i-a33-q8-tablet.dts | 44 +++++++++++++++++++++++++++++++
>>> 1 file changed, 44 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts b/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts
>>> index b0bc236..871a20c 100644
>>> --- a/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts
>>> +++ b/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts
>>> @@ -47,4 +47,48 @@
>>> / {
>>> model = "Q8 A33 Tablet";
>>> compatible = "allwinner,q8-a33", "allwinner,sun8i-a33";
>>> +
>>> + panel: panel {
>>> + /* compatible should be set according to the panel */
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&lcd_en_q8>;
>>> + backlight = <&backlight>;
>>> + enable-gpios = <&pio 7 7 GPIO_ACTIVE_HIGH>; /* PH7 */
>>> + power-supply = <®_dc1sw>;
>>> + status = "disabled";
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> +
>>> + port@0 {
>>> + reg = <0>;
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> +
>>> + panel_input: endpoint@0 {
>>> + reg = <0>;
>>> + remote-endpoint = <&tcon0_out_lcd>;
>>> + };
>>> + };
>>> + };
>>> +};
>>> +
>>> +&tcon0 {
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&lcd_rgb666_pins>;
>>> +};
>>> +
>>> +&tcon0_out {
>>> + tcon0_out_lcd: endpoint@0 {
>>> + reg = <0>;
>>> + remote-endpoint = <&panel_input>;
>>> + };
>>> +};
>>> +
>>> +&pio {
>>> + lcd_en_q8: lcd_en@0 {
>>> + allwinner,pins = "PH7";
>>> + allwinner,function = "gpio_out";
>>> + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
>>> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
>>> + };
>>> };
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Re: [RFC PATCH] ARM: dts: add panel and tcon nodes to Allwinner A33 Q8 tablet dts
@ 2016-11-07 9:26 ` Hans de Goede
0 siblings, 0 replies; 10+ messages in thread
From: Hans de Goede @ 2016-11-07 9:26 UTC (permalink / raw)
To: icenowy-ymACFijhrKM, Maxime Ripard, Chen-Yu Tsai
Cc: Rob Herring, Mark Rutland, Russell King,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw
Hi,
On 06-11-16 17:53, Icenowy Zheng wrote:
>
>
> 06.11.2016, 22:27, "Hans de Goede" <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>:
>> Hi,
>>
>> On 06-11-16 12:11, Icenowy Zheng wrote:
>>> All A33 Q8 tablets features a LCD panel, with a resolution of either
>>> 800x480 or 1024x600.
>>>
>>> Add "bone" device nodes to the device tree.
>>
>> Bone ?
>>
>>> Signed-off-by: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>
>>
>> He, as discussed in the other thread since sun8i-a33-q8-tablet.dts
>> is used for both 800x480 and 1024x600 versions we really need to
>> introduce new sun8i-a33-q8-tablet-800x600.dts and
>> sun8i-a33-q8-tablet-1024x600.dts files, which include
>> sun8i-a33-q8-tablet.dts and then add just the panel bits; and patch
>> newer u-boots to use those instead.
>>
>> This way people who stick with an old u-boot will just not get
>> the drm driver, rather then all of a sudden getting a wrong
>> resolution.
>>
>> Icenowy, can you please also submit a matching u-boot patch
>> (both the new dts file, as well as updating the defconfig you
>> use to the new dts file)?
>
> Could you choose a compatible for 1024x600 variant?
Lets just add a sun8i-a33-q8-tablet-800x600.dts now and then
I will add a sun8i-a33-q8-tablet-1024x600.dts file later.
Regards,
Hans
>
> (Since I have never such a Q8 tablet)
>
>>
>> Regards,
>>
>> Hans
>>
>>> ---
>>>
>>> Maybe it will be better to add them to sun8i-q8-reference-tablet.dtsi, as
>>> these pin configurations are part of reference design of both A23 and A33,
>>> not only restricted to Q8.
>>>
>>> The DTS file is tested by me, after cherry-picks this patch from Chen-Yu Tsai:
>>> https://github.com/wens/linux/commit/2823b887a289fbee5f97f3c6b45ed6c74a6368c6
>>>
>>> And add these commands to my U-Boot boot command:
>>>
>>> fdt addr 0x43000000
>>> fdt resize
>>> fdt set /panel compatible "urt,umsh-8596md-t"
>>> fdt set /panel status "okay"
>>> fdt set /display-engine status "okay"
>>> fdt set /soc@01c00000/lcd-controller@01c0c000 status "okay"
>>>
>>> arch/arm/boot/dts/sun8i-a33-q8-tablet.dts | 44 +++++++++++++++++++++++++++++++
>>> 1 file changed, 44 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts b/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts
>>> index b0bc236..871a20c 100644
>>> --- a/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts
>>> +++ b/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts
>>> @@ -47,4 +47,48 @@
>>> / {
>>> model = "Q8 A33 Tablet";
>>> compatible = "allwinner,q8-a33", "allwinner,sun8i-a33";
>>> +
>>> + panel: panel {
>>> + /* compatible should be set according to the panel */
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&lcd_en_q8>;
>>> + backlight = <&backlight>;
>>> + enable-gpios = <&pio 7 7 GPIO_ACTIVE_HIGH>; /* PH7 */
>>> + power-supply = <®_dc1sw>;
>>> + status = "disabled";
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> +
>>> + port@0 {
>>> + reg = <0>;
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> +
>>> + panel_input: endpoint@0 {
>>> + reg = <0>;
>>> + remote-endpoint = <&tcon0_out_lcd>;
>>> + };
>>> + };
>>> + };
>>> +};
>>> +
>>> +&tcon0 {
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&lcd_rgb666_pins>;
>>> +};
>>> +
>>> +&tcon0_out {
>>> + tcon0_out_lcd: endpoint@0 {
>>> + reg = <0>;
>>> + remote-endpoint = <&panel_input>;
>>> + };
>>> +};
>>> +
>>> +&pio {
>>> + lcd_en_q8: lcd_en@0 {
>>> + allwinner,pins = "PH7";
>>> + allwinner,function = "gpio_out";
>>> + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
>>> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
>>> + };
>>> };
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [linux-sunxi] Re: [RFC PATCH] ARM: dts: add panel and tcon nodes to Allwinner A33 Q8 tablet dts
@ 2016-11-07 9:26 ` Hans de Goede
0 siblings, 0 replies; 10+ messages in thread
From: Hans de Goede @ 2016-11-07 9:26 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On 06-11-16 17:53, Icenowy Zheng wrote:
>
>
> 06.11.2016, 22:27, "Hans de Goede" <hdegoede@redhat.com>:
>> Hi,
>>
>> On 06-11-16 12:11, Icenowy Zheng wrote:
>>> All A33 Q8 tablets features a LCD panel, with a resolution of either
>>> 800x480 or 1024x600.
>>>
>>> Add "bone" device nodes to the device tree.
>>
>> Bone ?
>>
>>> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
>>
>> He, as discussed in the other thread since sun8i-a33-q8-tablet.dts
>> is used for both 800x480 and 1024x600 versions we really need to
>> introduce new sun8i-a33-q8-tablet-800x600.dts and
>> sun8i-a33-q8-tablet-1024x600.dts files, which include
>> sun8i-a33-q8-tablet.dts and then add just the panel bits; and patch
>> newer u-boots to use those instead.
>>
>> This way people who stick with an old u-boot will just not get
>> the drm driver, rather then all of a sudden getting a wrong
>> resolution.
>>
>> Icenowy, can you please also submit a matching u-boot patch
>> (both the new dts file, as well as updating the defconfig you
>> use to the new dts file)?
>
> Could you choose a compatible for 1024x600 variant?
Lets just add a sun8i-a33-q8-tablet-800x600.dts now and then
I will add a sun8i-a33-q8-tablet-1024x600.dts file later.
Regards,
Hans
>
> (Since I have never such a Q8 tablet)
>
>>
>> Regards,
>>
>> Hans
>>
>>> ---
>>>
>>> Maybe it will be better to add them to sun8i-q8-reference-tablet.dtsi, as
>>> these pin configurations are part of reference design of both A23 and A33,
>>> not only restricted to Q8.
>>>
>>> The DTS file is tested by me, after cherry-picks this patch from Chen-Yu Tsai:
>>> https://github.com/wens/linux/commit/2823b887a289fbee5f97f3c6b45ed6c74a6368c6
>>>
>>> And add these commands to my U-Boot boot command:
>>>
>>> fdt addr 0x43000000
>>> fdt resize
>>> fdt set /panel compatible "urt,umsh-8596md-t"
>>> fdt set /panel status "okay"
>>> fdt set /display-engine status "okay"
>>> fdt set /soc at 01c00000/lcd-controller at 01c0c000 status "okay"
>>>
>>> arch/arm/boot/dts/sun8i-a33-q8-tablet.dts | 44 +++++++++++++++++++++++++++++++
>>> 1 file changed, 44 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts b/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts
>>> index b0bc236..871a20c 100644
>>> --- a/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts
>>> +++ b/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts
>>> @@ -47,4 +47,48 @@
>>> / {
>>> model = "Q8 A33 Tablet";
>>> compatible = "allwinner,q8-a33", "allwinner,sun8i-a33";
>>> +
>>> + panel: panel {
>>> + /* compatible should be set according to the panel */
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&lcd_en_q8>;
>>> + backlight = <&backlight>;
>>> + enable-gpios = <&pio 7 7 GPIO_ACTIVE_HIGH>; /* PH7 */
>>> + power-supply = <®_dc1sw>;
>>> + status = "disabled";
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> +
>>> + port at 0 {
>>> + reg = <0>;
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> +
>>> + panel_input: endpoint at 0 {
>>> + reg = <0>;
>>> + remote-endpoint = <&tcon0_out_lcd>;
>>> + };
>>> + };
>>> + };
>>> +};
>>> +
>>> +&tcon0 {
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&lcd_rgb666_pins>;
>>> +};
>>> +
>>> +&tcon0_out {
>>> + tcon0_out_lcd: endpoint at 0 {
>>> + reg = <0>;
>>> + remote-endpoint = <&panel_input>;
>>> + };
>>> +};
>>> +
>>> +&pio {
>>> + lcd_en_q8: lcd_en at 0 {
>>> + allwinner,pins = "PH7";
>>> + allwinner,function = "gpio_out";
>>> + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
>>> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
>>> + };
>>> };
>
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2016-11-07 9:26 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-06 11:11 [RFC PATCH] ARM: dts: add panel and tcon nodes to Allwinner A33 Q8 tablet dts Icenowy Zheng
2016-11-06 11:11 ` Icenowy Zheng
2016-11-06 14:27 ` Hans de Goede
2016-11-06 14:27 ` Hans de Goede
2016-11-06 14:27 ` Hans de Goede
[not found] ` <948897e3-12a2-b02c-ed26-929921ff04b2-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-11-06 16:53 ` Icenowy Zheng
2016-11-06 16:53 ` Icenowy Zheng
2016-11-07 9:26 ` [linux-sunxi] " Hans de Goede
2016-11-07 9:26 ` Hans de Goede
2016-11-07 9:26 ` Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.