* [PATCH] mm: remove extra newline from allocation stall warning
@ 2016-10-09 15:16 Tetsuo Handa
2016-10-10 7:21 ` Michal Hocko
0 siblings, 1 reply; 4+ messages in thread
From: Tetsuo Handa @ 2016-10-09 15:16 UTC (permalink / raw)
To: Michal Hocko; +Cc: linux-mm, Tetsuo Handa
Commit 63f53dea0c9866e9 ("mm: warn about allocations which stall for
too long") by error embedded "\n" in the format string, resulting in
strange output.
[ 722.876655] kworker/0:1: page alloction stalls for 160001ms, order:0
[ 722.876656] , mode:0x2400000(GFP_NOIO)
[ 722.876657] CPU: 0 PID: 6966 Comm: kworker/0:1 Not tainted 4.8.0+ #69
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
---
mm/page_alloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index ca423cc..828ee76 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -3653,7 +3653,7 @@ bool gfp_pfmemalloc_allowed(gfp_t gfp_mask)
/* Make sure we know about allocations which stall for too long */
if (time_after(jiffies, alloc_start + stall_timeout)) {
warn_alloc(gfp_mask,
- "page alloction stalls for %ums, order:%u\n",
+ "page alloction stalls for %ums, order:%u",
jiffies_to_msecs(jiffies-alloc_start), order);
stall_timeout += 10 * HZ;
}
--
1.8.3.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] mm: remove extra newline from allocation stall warning
2016-10-09 15:16 [PATCH] mm: remove extra newline from allocation stall warning Tetsuo Handa
@ 2016-10-10 7:21 ` Michal Hocko
2016-10-12 14:52 ` Michal Hocko
0 siblings, 1 reply; 4+ messages in thread
From: Michal Hocko @ 2016-10-10 7:21 UTC (permalink / raw)
To: Tetsuo Handa; +Cc: linux-mm
On Mon 10-10-16 00:16:59, Tetsuo Handa wrote:
> Commit 63f53dea0c9866e9 ("mm: warn about allocations which stall for
> too long") by error embedded "\n" in the format string, resulting in
> strange output.
>
> [ 722.876655] kworker/0:1: page alloction stalls for 160001ms, order:0
> [ 722.876656] , mode:0x2400000(GFP_NOIO)
> [ 722.876657] CPU: 0 PID: 6966 Comm: kworker/0:1 Not tainted 4.8.0+ #69
Ups, thanks for catching that.
> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Acked-by: Michal Hocko <mhocko@suse.com>
> ---
> mm/page_alloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index ca423cc..828ee76 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -3653,7 +3653,7 @@ bool gfp_pfmemalloc_allowed(gfp_t gfp_mask)
> /* Make sure we know about allocations which stall for too long */
> if (time_after(jiffies, alloc_start + stall_timeout)) {
> warn_alloc(gfp_mask,
> - "page alloction stalls for %ums, order:%u\n",
> + "page alloction stalls for %ums, order:%u",
> jiffies_to_msecs(jiffies-alloc_start), order);
> stall_timeout += 10 * HZ;
> }
> --
> 1.8.3.1
>
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mm: remove extra newline from allocation stall warning
2016-10-10 7:21 ` Michal Hocko
@ 2016-10-12 14:52 ` Michal Hocko
2016-11-06 4:50 ` Tetsuo Handa
0 siblings, 1 reply; 4+ messages in thread
From: Michal Hocko @ 2016-10-12 14:52 UTC (permalink / raw)
To: Tetsuo Handa; +Cc: linux-mm, Andrew Morton
Let's CC Andrew -
http://lkml.kernel.org/r/1476026219-7974-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp
On Mon 10-10-16 09:21:23, Michal Hocko wrote:
> On Mon 10-10-16 00:16:59, Tetsuo Handa wrote:
> > Commit 63f53dea0c9866e9 ("mm: warn about allocations which stall for
> > too long") by error embedded "\n" in the format string, resulting in
> > strange output.
> >
> > [ 722.876655] kworker/0:1: page alloction stalls for 160001ms, order:0
> > [ 722.876656] , mode:0x2400000(GFP_NOIO)
> > [ 722.876657] CPU: 0 PID: 6966 Comm: kworker/0:1 Not tainted 4.8.0+ #69
>
> Ups, thanks for catching that.
>
> > Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
>
> Acked-by: Michal Hocko <mhocko@suse.com>
>
> > ---
> > mm/page_alloc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> > index ca423cc..828ee76 100644
> > --- a/mm/page_alloc.c
> > +++ b/mm/page_alloc.c
> > @@ -3653,7 +3653,7 @@ bool gfp_pfmemalloc_allowed(gfp_t gfp_mask)
> > /* Make sure we know about allocations which stall for too long */
> > if (time_after(jiffies, alloc_start + stall_timeout)) {
> > warn_alloc(gfp_mask,
> > - "page alloction stalls for %ums, order:%u\n",
> > + "page alloction stalls for %ums, order:%u",
> > jiffies_to_msecs(jiffies-alloc_start), order);
> > stall_timeout += 10 * HZ;
> > }
> > --
> > 1.8.3.1
> >
>
> --
> Michal Hocko
> SUSE Labs
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mm: remove extra newline from allocation stall warning
2016-10-12 14:52 ` Michal Hocko
@ 2016-11-06 4:50 ` Tetsuo Handa
0 siblings, 0 replies; 4+ messages in thread
From: Tetsuo Handa @ 2016-11-06 4:50 UTC (permalink / raw)
To: akpm; +Cc: mhocko, linux-mm
I noticed a typo and folded into this patch.
Andrew, please replace mm-remove-extra-newline-from-allocation-stall-warning.patch .
----------
>From 1f6caf79022c20f47e4cee0a4d2d5114907e2714 Mon Sep 17 00:00:00 2001
From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Date: Sun, 6 Nov 2016 13:41:51 +0900
Subject: [PATCH v2] mm: remove extra newline from allocation stall warning
63f53dea0c9866e9 ("mm: warn about allocations which stall for too long")
by error embedded "\n" in the format string, resulting in strange output.
[ 722.876655] kworker/0:1: page alloction stalls for 160001ms, order:0
[ 722.876656] , mode:0x2400000(GFP_NOIO)
[ 722.876657] CPU: 0 PID: 6966 Comm: kworker/0:1 Not tainted 4.8.0+ #69
Link: http://lkml.kernel.org/r/1476026219-7974-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Acked-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/page_alloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 072d791..6de9440 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -3658,7 +3658,7 @@ bool gfp_pfmemalloc_allowed(gfp_t gfp_mask)
/* Make sure we know about allocations which stall for too long */
if (time_after(jiffies, alloc_start + stall_timeout)) {
warn_alloc(gfp_mask,
- "page alloction stalls for %ums, order:%u\n",
+ "page allocation stalls for %ums, order:%u",
jiffies_to_msecs(jiffies-alloc_start), order);
stall_timeout += 10 * HZ;
}
--
1.8.3.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-06 4:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-09 15:16 [PATCH] mm: remove extra newline from allocation stall warning Tetsuo Handa
2016-10-10 7:21 ` Michal Hocko
2016-10-12 14:52 ` Michal Hocko
2016-11-06 4:50 ` Tetsuo Handa
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.