[PATCH] This is a patch to the capi.c file that fixes one instance of the following error: ERROR: do not use assignment in if condition

[PATCH] This is a patch to the capi.c file that fixes one instance of the following error: ERROR: do not use assignment in if condition

[Naeil ZOUEIDI]

Staging: i4l: act200:

Signed-off-by: Naeil Zoueidi <naeilzoueidi@ubuntu.com>
---
 drivers/staging/i4l/act2000/capi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/i4l/act2000/capi.c b/drivers/staging/i4l/act2000/capi.c
index 62f5629..b494917 100644
--- a/drivers/staging/i4l/act2000/capi.c
+++ b/drivers/staging/i4l/act2000/capi.c
@@ -564,7 +564,8 @@ actcapi_data_b3_ind(act2000_card *card, struct sk_buff *skb) {
 	blocknr = msg->msg.data_b3_ind.blocknr;
 	skb_pull(skb, 19);
 	card->interface.rcvcallb_skb(card->myid, chan, skb);
-	if (!(skb = alloc_skb(11, GFP_ATOMIC))) {
+	skb = alloc_skb(11, GFP_ATOMIC;
+	if (!skb) {
 		printk(KERN_WARNING "actcapi: alloc_skb failed\n");
 		return 1;
 	}
-- 
2.10.1

Re: [PATCH] This is a patch to the capi.c file that fixes one instance of the following error: ERROR: do not use assignment in if condition

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 2132 bytes --]

Hi Naeil,

[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.9-rc4 next-20161028]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Naeil-ZOUEIDI/This-is-a-patch-to-the-capi-c-file-that-fixes-one-instance-of-the-following-error-ERROR-do-not-use-assignment-in-if-condition/20161106-165820
config: i386-randconfig-x077-201645 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All error/warnings (new ones prefixed by >>):

   drivers/staging/i4l/act2000/capi.c: In function 'actcapi_data_b3_ind':
>> drivers/staging/i4l/act2000/capi.c:571:32: error: expected ')' before ';' token
     skb = alloc_skb(11, GFP_ATOMIC;
                                   ^
>> drivers/staging/i4l/act2000/capi.c:586:1: error: expected ';' before '}' token
    }
    ^
>> drivers/staging/i4l/act2000/capi.c:586:1: warning: control reaches end of non-void function [-Wreturn-type]
    }
    ^

vim +571 drivers/staging/i4l/act2000/capi.c

   565			return 0;
   566		if (card->bch[chan].plci != plci)
   567			return 0;
   568		blocknr = msg->msg.data_b3_ind.blocknr;
   569		skb_pull(skb, 19);
   570		card->interface.rcvcallb_skb(card->myid, chan, skb);
 > 571		skb = alloc_skb(11, GFP_ATOMIC;
   572		if (!skb) {
   573			printk(KERN_WARNING "actcapi: alloc_skb failed\n");
   574			return 1;
   575		}
   576		msg = (actcapi_msg *)skb_put(skb, 11);
   577		msg->hdr.len = 11;
   578		msg->hdr.applicationID = 1;
   579		msg->hdr.cmd.cmd = 0x86;
   580		msg->hdr.cmd.subcmd = 0x03;
   581		msg->hdr.msgnum = actcapi_nextsmsg(card);
   582		msg->msg.data_b3_resp.ncci = ncci;
   583		msg->msg.data_b3_resp.blocknr = blocknr;
   584		ACTCAPI_QUEUE_TX;
   585		return 1;
 > 586	}
   587	
   588	/*
   589	 * Walk over ackq, unlink DATA_B3_REQ from it, if

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29790 bytes --]