All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] crypto: dh - Consistenly return negative error codes
@ 2016-11-08 23:48 Mat Martineau
  2016-11-13 11:29 ` Herbert Xu
  0 siblings, 1 reply; 2+ messages in thread
From: Mat Martineau @ 2016-11-08 23:48 UTC (permalink / raw)
  To: linux-crypto, herbert; +Cc: Mat Martineau, salvatore.benedetto

Fix the single instance where a positive EINVAL was returned.

Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
---
 crypto/dh.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/dh.c b/crypto/dh.c
index 9d19360..ddcb528 100644
--- a/crypto/dh.c
+++ b/crypto/dh.c
@@ -118,7 +118,7 @@ static int dh_compute_value(struct kpp_request *req)
 	if (req->src) {
 		base = mpi_read_raw_from_sgl(req->src, req->src_len);
 		if (!base) {
-			ret = EINVAL;
+			ret = -EINVAL;
 			goto err_free_val;
 		}
 	} else {
-- 
2.10.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] crypto: dh - Consistenly return negative error codes
  2016-11-08 23:48 [PATCH] crypto: dh - Consistenly return negative error codes Mat Martineau
@ 2016-11-13 11:29 ` Herbert Xu
  0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2016-11-13 11:29 UTC (permalink / raw)
  To: Mat Martineau; +Cc: linux-crypto, salvatore.benedetto

On Tue, Nov 08, 2016 at 03:48:22PM -0800, Mat Martineau wrote:
> Fix the single instance where a positive EINVAL was returned.
> 
> Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-11-13 11:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-08 23:48 [PATCH] crypto: dh - Consistenly return negative error codes Mat Martineau
2016-11-13 11:29 ` Herbert Xu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.