All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] vhost/vsock: Remove unused but set variable
@ 2016-11-11 13:26 Tobias Klauser
  2016-11-15 13:00 ` Stefan Hajnoczi
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Tobias Klauser @ 2016-11-11 13:26 UTC (permalink / raw)
  To: Stefan Hajnoczi, Michael S. Tsirkin, Jason Wang
  Cc: kvm, virtualization, netdev

Remove the unused but set variable vq in vhost_transport_send_pkt() to
fix the following GCC warning when building with 'W=1':

  drivers/vhost/vsock.c:198:26: warning: variable ‘vq’ set but not used

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
 drivers/vhost/vsock.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c
index e3b30ea9ece5..9c3c68b9a49e 100644
--- a/drivers/vhost/vsock.c
+++ b/drivers/vhost/vsock.c
@@ -195,7 +195,6 @@ static int
 vhost_transport_send_pkt(struct virtio_vsock_pkt *pkt)
 {
 	struct vhost_vsock *vsock;
-	struct vhost_virtqueue *vq;
 	int len = pkt->len;
 
 	/* Find the vhost_vsock according to guest context id  */
@@ -205,8 +204,6 @@ vhost_transport_send_pkt(struct virtio_vsock_pkt *pkt)
 		return -ENODEV;
 	}
 
-	vq = &vsock->vqs[VSOCK_VQ_RX];
-
 	if (pkt->reply)
 		atomic_inc(&vsock->queued_replies);
 
-- 
2.11.0.rc0.7.gbe5a750

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] vhost/vsock: Remove unused but set variable
  2016-11-11 13:26 [PATCH] vhost/vsock: Remove unused but set variable Tobias Klauser
@ 2016-11-15 13:00 ` Stefan Hajnoczi
  2016-11-15 13:00 ` Stefan Hajnoczi
  2016-12-15  4:54 ` Michael S. Tsirkin
  2 siblings, 0 replies; 5+ messages in thread
From: Stefan Hajnoczi @ 2016-11-15 13:00 UTC (permalink / raw)
  To: Tobias Klauser
  Cc: Michael S. Tsirkin, Jason Wang, kvm, virtualization, netdev

[-- Attachment #1: Type: text/plain, Size: 470 bytes --]

On Fri, Nov 11, 2016 at 02:26:31PM +0100, Tobias Klauser wrote:
> Remove the unused but set variable vq in vhost_transport_send_pkt() to
> fix the following GCC warning when building with 'W=1':
> 
>   drivers/vhost/vsock.c:198:26: warning: variable ‘vq’ set but not used
> 
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---
>  drivers/vhost/vsock.c | 3 ---
>  1 file changed, 3 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] vhost/vsock: Remove unused but set variable
  2016-11-11 13:26 [PATCH] vhost/vsock: Remove unused but set variable Tobias Klauser
  2016-11-15 13:00 ` Stefan Hajnoczi
@ 2016-11-15 13:00 ` Stefan Hajnoczi
  2016-12-15  4:54 ` Michael S. Tsirkin
  2 siblings, 0 replies; 5+ messages in thread
From: Stefan Hajnoczi @ 2016-11-15 13:00 UTC (permalink / raw)
  To: Tobias Klauser; +Cc: netdev, virtualization, kvm, Michael S. Tsirkin


[-- Attachment #1.1: Type: text/plain, Size: 470 bytes --]

On Fri, Nov 11, 2016 at 02:26:31PM +0100, Tobias Klauser wrote:
> Remove the unused but set variable vq in vhost_transport_send_pkt() to
> fix the following GCC warning when building with 'W=1':
> 
>   drivers/vhost/vsock.c:198:26: warning: variable ‘vq’ set but not used
> 
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---
>  drivers/vhost/vsock.c | 3 ---
>  1 file changed, 3 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

[-- Attachment #2: Type: text/plain, Size: 183 bytes --]

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] vhost/vsock: Remove unused but set variable
  2016-11-11 13:26 [PATCH] vhost/vsock: Remove unused but set variable Tobias Klauser
  2016-11-15 13:00 ` Stefan Hajnoczi
  2016-11-15 13:00 ` Stefan Hajnoczi
@ 2016-12-15  4:54 ` Michael S. Tsirkin
  2 siblings, 0 replies; 5+ messages in thread
From: Michael S. Tsirkin @ 2016-12-15  4:54 UTC (permalink / raw)
  To: Tobias Klauser; +Cc: netdev, kvm, Stefan Hajnoczi, virtualization

On Fri, Nov 11, 2016 at 02:26:31PM +0100, Tobias Klauser wrote:
> Remove the unused but set variable vq in vhost_transport_send_pkt() to
> fix the following GCC warning when building with 'W=1':
> 
>   drivers/vhost/vsock.c:198:26: warning: variable ‘vq’ set but not used
> 
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>

doesn't apply anymore.

> ---
>  drivers/vhost/vsock.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c
> index e3b30ea9ece5..9c3c68b9a49e 100644
> --- a/drivers/vhost/vsock.c
> +++ b/drivers/vhost/vsock.c
> @@ -195,7 +195,6 @@ static int
>  vhost_transport_send_pkt(struct virtio_vsock_pkt *pkt)
>  {
>  	struct vhost_vsock *vsock;
> -	struct vhost_virtqueue *vq;
>  	int len = pkt->len;
>  
>  	/* Find the vhost_vsock according to guest context id  */
> @@ -205,8 +204,6 @@ vhost_transport_send_pkt(struct virtio_vsock_pkt *pkt)
>  		return -ENODEV;
>  	}
>  
> -	vq = &vsock->vqs[VSOCK_VQ_RX];
> -
>  	if (pkt->reply)
>  		atomic_inc(&vsock->queued_replies);
>  
> -- 
> 2.11.0.rc0.7.gbe5a750
> 
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH] vhost/vsock: Remove unused but set variable
@ 2016-11-11 13:26 Tobias Klauser
  0 siblings, 0 replies; 5+ messages in thread
From: Tobias Klauser @ 2016-11-11 13:26 UTC (permalink / raw)
  To: Stefan Hajnoczi, Michael S. Tsirkin, Jason Wang
  Cc: netdev, kvm, virtualization

Remove the unused but set variable vq in vhost_transport_send_pkt() to
fix the following GCC warning when building with 'W=1':

  drivers/vhost/vsock.c:198:26: warning: variable ‘vq’ set but not used

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
 drivers/vhost/vsock.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c
index e3b30ea9ece5..9c3c68b9a49e 100644
--- a/drivers/vhost/vsock.c
+++ b/drivers/vhost/vsock.c
@@ -195,7 +195,6 @@ static int
 vhost_transport_send_pkt(struct virtio_vsock_pkt *pkt)
 {
 	struct vhost_vsock *vsock;
-	struct vhost_virtqueue *vq;
 	int len = pkt->len;
 
 	/* Find the vhost_vsock according to guest context id  */
@@ -205,8 +204,6 @@ vhost_transport_send_pkt(struct virtio_vsock_pkt *pkt)
 		return -ENODEV;
 	}
 
-	vq = &vsock->vqs[VSOCK_VQ_RX];
-
 	if (pkt->reply)
 		atomic_inc(&vsock->queued_replies);
 
-- 
2.11.0.rc0.7.gbe5a750


_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-12-15  4:54 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-11 13:26 [PATCH] vhost/vsock: Remove unused but set variable Tobias Klauser
2016-11-15 13:00 ` Stefan Hajnoczi
2016-11-15 13:00 ` Stefan Hajnoczi
2016-12-15  4:54 ` Michael S. Tsirkin
  -- strict thread matches above, loose matches on Subject: below --
2016-11-11 13:26 Tobias Klauser

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.