All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Reichel <sre@kernel.org>
To: Nicolae Rosia <Nicolae_Rosia@mentor.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	rtc-linux@googlegroups.com, linux-omap@vger.kernel.org,
	Tony Lindgren <tony@atomide.com>
Subject: [rtc-linux] Re: [PATCH 3/3] rtc: rtc-twl: use irq_of_parse_and_map helper
Date: Sat, 12 Nov 2016 12:20:10 +0100	[thread overview]
Message-ID: <20161112112009.34gwcedl57v77ng5@earth> (raw)
In-Reply-To: <1478945246-32056-4-git-send-email-Nicolae_Rosia@mentor.com>

[-- Attachment #1: Type: text/plain, Size: 892 bytes --]

Hi,

> Signed-off-by: Nicolae Rosia <Nicolae_Rosia@mentor.com>
> ---
>  drivers/rtc/Kconfig   | 2 +-
>  drivers/rtc/rtc-twl.c | 4 +++-
>  2 files changed, 4 insertions(+), 2 deletions(-)


This patch is missing long description. I would have patched it the
other way around. There is no reason to use irq_of_parse_and_map if
generic platform_get_irq can be used.

-- Sebastian

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Nicolae Rosia <Nicolae_Rosia-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
Cc: Alessandro Zummo
	<a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org>,
	Alexandre Belloni
	<alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH 3/3] rtc: rtc-twl: use irq_of_parse_and_map helper
Date: Sat, 12 Nov 2016 12:20:10 +0100	[thread overview]
Message-ID: <20161112112009.34gwcedl57v77ng5@earth> (raw)
In-Reply-To: <1478945246-32056-4-git-send-email-Nicolae_Rosia-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 953 bytes --]

Hi,

> Signed-off-by: Nicolae Rosia <Nicolae_Rosia-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
> ---
>  drivers/rtc/Kconfig   | 2 +-
>  drivers/rtc/rtc-twl.c | 4 +++-
>  2 files changed, 4 insertions(+), 2 deletions(-)


This patch is missing long description. I would have patched it the
other way around. There is no reason to use irq_of_parse_and_map if
generic platform_get_irq can be used.

-- Sebastian

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2016-11-12 11:20 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-12 10:07 [rtc-linux] [PATCH 0/3] rtc: rtc-twl: cleanup Nicolae Rosia
2016-11-12 10:07 ` Nicolae Rosia
2016-11-12 10:07 ` [rtc-linux] [PATCH 1/3] rtc: rtc-twl: kill static variables Nicolae Rosia
2016-11-12 10:07   ` Nicolae Rosia
2016-11-22 22:31   ` [rtc-linux] " Alexandre Belloni
2016-11-22 22:31     ` Alexandre Belloni
2016-11-23  8:39     ` [rtc-linux] " Nicolae Rosia
2016-11-23  8:39       ` Nicolae Rosia
2016-11-23  8:46       ` [rtc-linux] " Alexandre Belloni
2016-11-23  8:46         ` Alexandre Belloni
2016-11-23  8:57         ` [rtc-linux] " Nicolae Rosia
2016-11-23  8:57           ` Nicolae Rosia
2016-11-12 10:07 ` [rtc-linux] [PATCH 2/3] rtc: rtc-twl: make driver DT only Nicolae Rosia
2016-11-12 10:07   ` Nicolae Rosia
2016-11-22 22:33   ` [rtc-linux] " Alexandre Belloni
2016-11-22 22:33     ` Alexandre Belloni
2016-11-23  8:40     ` [rtc-linux] " Nicolae Rosia
2016-11-23  8:40       ` Nicolae Rosia
2016-11-12 10:07 ` [rtc-linux] [PATCH 3/3] rtc: rtc-twl: use irq_of_parse_and_map helper Nicolae Rosia
2016-11-12 10:07   ` Nicolae Rosia
2016-11-12 11:20   ` Sebastian Reichel [this message]
2016-11-12 11:20     ` Sebastian Reichel
2016-11-12 11:37     ` [rtc-linux] " Nicolae Rosia
2016-11-12 11:37       ` Nicolae Rosia
2016-11-12 17:58       ` [rtc-linux] " Tony Lindgren
2016-11-12 17:58         ` Tony Lindgren
2016-11-12 10:23 ` [rtc-linux] Re: [PATCH 0/3] rtc: rtc-twl: cleanup Nicolae Rosia
2016-11-12 10:23   ` Nicolae Rosia
2016-11-15  0:42   ` [rtc-linux] " Tony Lindgren
2016-11-15  0:42     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161112112009.34gwcedl57v77ng5@earth \
    --to=sre@kernel.org \
    --cc=Nicolae_Rosia@mentor.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=rtc-linux@googlegroups.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.