* [U-Boot] [PATCH] dfu: dfu_sf: Fix read offset
@ 2016-11-14 15:19 ` Phil Edworthy
2016-11-14 15:23 ` Fabio Estevam
2016-11-14 16:11 ` Lukasz Majewski
0 siblings, 2 replies; 3+ messages in thread
From: Phil Edworthy @ 2016-11-14 15:19 UTC (permalink / raw)
To: u-boot
The offset was applied to write, but not read, now its applied to
both.
Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
---
drivers/dfu/dfu_sf.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/dfu/dfu_sf.c b/drivers/dfu/dfu_sf.c
index 9702eee..b6d5fe2 100644
--- a/drivers/dfu/dfu_sf.c
+++ b/drivers/dfu/dfu_sf.c
@@ -20,7 +20,8 @@ static long dfu_get_medium_size_sf(struct dfu_entity *dfu)
static int dfu_read_medium_sf(struct dfu_entity *dfu, u64 offset, void *buf,
long *len)
{
- return spi_flash_read(dfu->data.sf.dev, offset, *len, buf);
+ return spi_flash_read(dfu->data.sf.dev, dfu->data.sf.start + offset,
+ *len, buf);
}
static u64 find_sector(struct dfu_entity *dfu, u64 start, u64 offset)
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] dfu: dfu_sf: Fix read offset
2016-11-14 15:19 ` [U-Boot] [PATCH] dfu: dfu_sf: Fix read offset Phil Edworthy
@ 2016-11-14 15:23 ` Fabio Estevam
2016-11-14 16:11 ` Lukasz Majewski
1 sibling, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2016-11-14 15:23 UTC (permalink / raw)
To: u-boot
On Mon, Nov 14, 2016 at 1:19 PM, Phil Edworthy
<phil.edworthy@renesas.com> wrote:
> The offset was applied to write, but not read, now its applied to
> both.
>
> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] dfu: dfu_sf: Fix read offset
2016-11-14 15:19 ` [U-Boot] [PATCH] dfu: dfu_sf: Fix read offset Phil Edworthy
2016-11-14 15:23 ` Fabio Estevam
@ 2016-11-14 16:11 ` Lukasz Majewski
1 sibling, 0 replies; 3+ messages in thread
From: Lukasz Majewski @ 2016-11-14 16:11 UTC (permalink / raw)
To: u-boot
Hi Phil,
> The offset was applied to write, but not read, now its applied to
> both.
>
> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
> ---
> drivers/dfu/dfu_sf.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dfu/dfu_sf.c b/drivers/dfu/dfu_sf.c
> index 9702eee..b6d5fe2 100644
> --- a/drivers/dfu/dfu_sf.c
> +++ b/drivers/dfu/dfu_sf.c
> @@ -20,7 +20,8 @@ static long dfu_get_medium_size_sf(struct
> dfu_entity *dfu) static int dfu_read_medium_sf(struct dfu_entity
> *dfu, u64 offset, void *buf, long *len)
> {
> - return spi_flash_read(dfu->data.sf.dev, offset, *len, buf);
> + return spi_flash_read(dfu->data.sf.dev, dfu->data.sf.start +
> offset,
> + *len, buf);
> }
>
> static u64 find_sector(struct dfu_entity *dfu, u64 start, u64 offset)
Acked-by: Lukasz Majewski <l.majewski@samsung.com>
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-14 16:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20161114151939epcas4p2c3224ca07d14a8e3ea909b4c63164769@epcas4p2.samsung.com>
2016-11-14 15:19 ` [U-Boot] [PATCH] dfu: dfu_sf: Fix read offset Phil Edworthy
2016-11-14 15:23 ` Fabio Estevam
2016-11-14 16:11 ` Lukasz Majewski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.