From: Namhyung Kim <namhyung@kernel.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: virtio-dev@lists.oasis-open.org, kvm@vger.kernel.org,
qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org,
LKML <linux-kernel@vger.kernel.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Anthony Liguori" <aliguori@amazon.com>,
"Anton Vorontsov" <anton@enomsg.org>,
"Colin Cross" <ccross@android.com>,
"Kees Cook" <keescook@chromium.org>,
"Tony Luck" <tony.luck@intel.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Ingo Molnar" <mingo@kernel.org>,
"Minchan Kim" <minchan@kernel.org>
Subject: Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver
Date: Tue, 15 Nov 2016 14:50:11 +0900 [thread overview]
Message-ID: <20161115055011.GB15992@danjae.aot.lge.com> (raw)
In-Reply-To: <20161115065658-mutt-send-email-mst@kernel.org>
On Tue, Nov 15, 2016 at 07:06:28AM +0200, Michael S. Tsirkin wrote:
> On Tue, Nov 15, 2016 at 01:50:21PM +0900, Namhyung Kim wrote:
> > On Thu, Nov 10, 2016 at 06:39:55PM +0200, Michael S. Tsirkin wrote:
> > [SNIP]
> > > > +struct virtio_pstore_fileinfo {
> > > > + __virtio64 id;
> > > > + __virtio32 count;
> > > > + __virtio16 type;
> > > > + __virtio16 unused;
> > > > + __virtio32 flags;
> > > > + __virtio32 len;
> > > > + __virtio64 time_sec;
> > > > + __virtio32 time_nsec;
> > > > + __virtio32 reserved;
> > > > +};
> > > > +
> > > > +struct virtio_pstore_config {
> > > > + __virtio32 bufsize;
> > > > +};
> > > > +
> > >
> > > What exactly does each field mean? I'm especially
> > > interested in time fields - maintaining a consistent
> > > time between host and guest is not a simple problem.
> >
> > These are required by pstore and will be used to create corresponding
> > files in the pstore filesystem. The time fields are for mtime and
> > ctime and, I think, it's just a hint for user and doesn't require
> > strict consistency.
>
> Pls add documentation. I would just drop hints for now.
Well, I'll add docmentation. But I think just dropping might not good
since they all have host time and it's helpful to know their relative
difference in guest.
Thanks,
Namhyung
WARNING: multiple messages have this Message-ID (diff)
From: Namhyung Kim <namhyung@kernel.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: virtio-dev@lists.oasis-open.org,
"Tony Luck" <tony.luck@intel.com>,
"Kees Cook" <keescook@chromium.org>,
kvm@vger.kernel.org, "Radim Krčmář" <rkrcmar@redhat.com>,
"Anton Vorontsov" <anton@enomsg.org>,
LKML <linux-kernel@vger.kernel.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
qemu-devel@nongnu.org, "Minchan Kim" <minchan@kernel.org>,
"Anthony Liguori" <aliguori@amazon.com>,
"Colin Cross" <ccross@android.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
virtualization@lists.linux-foundation.org,
"Ingo Molnar" <mingo@kernel.org>
Subject: Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver
Date: Tue, 15 Nov 2016 14:50:11 +0900 [thread overview]
Message-ID: <20161115055011.GB15992@danjae.aot.lge.com> (raw)
In-Reply-To: <20161115065658-mutt-send-email-mst@kernel.org>
On Tue, Nov 15, 2016 at 07:06:28AM +0200, Michael S. Tsirkin wrote:
> On Tue, Nov 15, 2016 at 01:50:21PM +0900, Namhyung Kim wrote:
> > On Thu, Nov 10, 2016 at 06:39:55PM +0200, Michael S. Tsirkin wrote:
> > [SNIP]
> > > > +struct virtio_pstore_fileinfo {
> > > > + __virtio64 id;
> > > > + __virtio32 count;
> > > > + __virtio16 type;
> > > > + __virtio16 unused;
> > > > + __virtio32 flags;
> > > > + __virtio32 len;
> > > > + __virtio64 time_sec;
> > > > + __virtio32 time_nsec;
> > > > + __virtio32 reserved;
> > > > +};
> > > > +
> > > > +struct virtio_pstore_config {
> > > > + __virtio32 bufsize;
> > > > +};
> > > > +
> > >
> > > What exactly does each field mean? I'm especially
> > > interested in time fields - maintaining a consistent
> > > time between host and guest is not a simple problem.
> >
> > These are required by pstore and will be used to create corresponding
> > files in the pstore filesystem. The time fields are for mtime and
> > ctime and, I think, it's just a hint for user and doesn't require
> > strict consistency.
>
> Pls add documentation. I would just drop hints for now.
Well, I'll add docmentation. But I think just dropping might not good
since they all have host time and it's helpful to know their relative
difference in guest.
Thanks,
Namhyung
WARNING: multiple messages have this Message-ID (diff)
From: Namhyung Kim <namhyung@kernel.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: virtio-dev@lists.oasis-open.org, kvm@vger.kernel.org,
qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org,
LKML <linux-kernel@vger.kernel.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Anthony Liguori" <aliguori@amazon.com>,
"Anton Vorontsov" <anton@enomsg.org>,
"Colin Cross" <ccross@android.com>,
"Kees Cook" <keescook@chromium.org>,
"Tony Luck" <tony.luck@intel.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Ingo Molnar" <mingo@kernel.org>,
"Minchan Kim" <minchan@kernel.org>
Subject: Re: [Qemu-devel] [PATCH 1/3] virtio: Basic implementation of virtio pstore driver
Date: Tue, 15 Nov 2016 14:50:11 +0900 [thread overview]
Message-ID: <20161115055011.GB15992@danjae.aot.lge.com> (raw)
In-Reply-To: <20161115065658-mutt-send-email-mst@kernel.org>
On Tue, Nov 15, 2016 at 07:06:28AM +0200, Michael S. Tsirkin wrote:
> On Tue, Nov 15, 2016 at 01:50:21PM +0900, Namhyung Kim wrote:
> > On Thu, Nov 10, 2016 at 06:39:55PM +0200, Michael S. Tsirkin wrote:
> > [SNIP]
> > > > +struct virtio_pstore_fileinfo {
> > > > + __virtio64 id;
> > > > + __virtio32 count;
> > > > + __virtio16 type;
> > > > + __virtio16 unused;
> > > > + __virtio32 flags;
> > > > + __virtio32 len;
> > > > + __virtio64 time_sec;
> > > > + __virtio32 time_nsec;
> > > > + __virtio32 reserved;
> > > > +};
> > > > +
> > > > +struct virtio_pstore_config {
> > > > + __virtio32 bufsize;
> > > > +};
> > > > +
> > >
> > > What exactly does each field mean? I'm especially
> > > interested in time fields - maintaining a consistent
> > > time between host and guest is not a simple problem.
> >
> > These are required by pstore and will be used to create corresponding
> > files in the pstore filesystem. The time fields are for mtime and
> > ctime and, I think, it's just a hint for user and doesn't require
> > strict consistency.
>
> Pls add documentation. I would just drop hints for now.
Well, I'll add docmentation. But I think just dropping might not good
since they all have host time and it's helpful to know their relative
difference in guest.
Thanks,
Namhyung
next prev parent reply other threads:[~2016-11-15 5:51 UTC|newest]
Thread overview: 125+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-20 8:07 [RFC/PATCHSET 0/3] virtio: Implement virtio pstore device (v3) Namhyung Kim
2016-08-20 8:07 ` [Qemu-devel] " Namhyung Kim
2016-08-20 8:07 ` Namhyung Kim
2016-08-20 8:07 ` [PATCH 1/3] virtio: Basic implementation of virtio pstore driver Namhyung Kim
2016-08-20 8:07 ` [Qemu-devel] " Namhyung Kim
2016-08-20 8:07 ` Namhyung Kim
2016-09-13 15:19 ` Michael S. Tsirkin
2016-09-13 15:19 ` [Qemu-devel] " Michael S. Tsirkin
2016-09-16 9:05 ` Namhyung Kim
2016-09-16 9:05 ` [Qemu-devel] " Namhyung Kim
2016-09-16 9:05 ` Namhyung Kim
2016-09-13 15:19 ` Michael S. Tsirkin
2016-11-10 16:39 ` Michael S. Tsirkin
2016-11-10 16:39 ` [Qemu-devel] " Michael S. Tsirkin
2016-11-15 4:50 ` Namhyung Kim
2016-11-15 4:50 ` Namhyung Kim
2016-11-15 4:50 ` [Qemu-devel] " Namhyung Kim
2016-11-15 5:06 ` Michael S. Tsirkin
2016-11-15 5:06 ` [Qemu-devel] " Michael S. Tsirkin
2016-11-15 5:06 ` Michael S. Tsirkin
2016-11-15 5:50 ` Namhyung Kim [this message]
2016-11-15 5:50 ` [Qemu-devel] " Namhyung Kim
2016-11-15 5:50 ` Namhyung Kim
2016-11-15 14:35 ` Michael S. Tsirkin
2016-11-15 14:35 ` [Qemu-devel] " Michael S. Tsirkin
2016-11-15 14:35 ` Michael S. Tsirkin
2016-11-15 9:57 ` Paolo Bonzini
2016-11-15 9:57 ` Paolo Bonzini
2016-11-15 9:57 ` [Qemu-devel] " Paolo Bonzini
2016-11-15 14:36 ` Namhyung Kim
2016-11-15 14:36 ` [Qemu-devel] " Namhyung Kim
2016-11-15 14:36 ` Namhyung Kim
2016-11-15 14:38 ` Paolo Bonzini
2016-11-15 14:38 ` Paolo Bonzini
2016-11-15 14:38 ` [Qemu-devel] " Paolo Bonzini
2016-11-16 7:04 ` Namhyung Kim
2016-11-16 7:04 ` [Qemu-devel] " Namhyung Kim
2016-11-16 7:04 ` Namhyung Kim
2016-11-16 12:10 ` Paolo Bonzini
2016-11-16 12:10 ` [Qemu-devel] " Paolo Bonzini
2016-11-16 12:10 ` Paolo Bonzini
2016-11-18 3:32 ` Namhyung Kim
2016-11-18 3:32 ` [Qemu-devel] " Namhyung Kim
2016-11-18 3:32 ` Namhyung Kim
2016-11-18 4:07 ` Michael S. Tsirkin
2016-11-18 4:07 ` [Qemu-devel] " Michael S. Tsirkin
2016-11-18 9:46 ` [virtio-dev] " Paolo Bonzini
2016-11-18 9:46 ` Paolo Bonzini
2016-11-18 9:46 ` [Qemu-devel] " Paolo Bonzini
2016-11-18 9:46 ` Paolo Bonzini
2016-11-18 4:07 ` Michael S. Tsirkin
2016-11-18 9:45 ` Paolo Bonzini
2016-11-18 9:45 ` Paolo Bonzini
2016-11-18 9:45 ` [Qemu-devel] " Paolo Bonzini
2016-11-10 16:39 ` Michael S. Tsirkin
2016-08-20 8:07 ` [PATCH 2/3] qemu: Implement virtio-pstore device Namhyung Kim
2016-08-20 8:07 ` [Qemu-devel] " Namhyung Kim
2016-08-24 22:00 ` Daniel P. Berrange
2016-08-24 22:00 ` [Qemu-devel] " Daniel P. Berrange
2016-08-24 22:00 ` Daniel P. Berrange
2016-08-26 4:48 ` Namhyung Kim
2016-08-26 4:48 ` [Qemu-devel] " Namhyung Kim
2016-08-26 4:48 ` Namhyung Kim
2016-08-26 12:27 ` Daniel P. Berrange
2016-08-26 12:27 ` [Qemu-devel] " Daniel P. Berrange
2016-08-26 12:27 ` Daniel P. Berrange
2016-09-13 15:57 ` Michael S. Tsirkin
2016-09-13 15:57 ` Michael S. Tsirkin
2016-09-13 15:57 ` [Qemu-devel] " Michael S. Tsirkin
2016-09-16 10:05 ` Namhyung Kim
2016-09-16 10:05 ` Namhyung Kim
2016-09-16 10:05 ` [Qemu-devel] " Namhyung Kim
2016-11-10 22:50 ` Michael S. Tsirkin
2016-11-10 22:50 ` [Qemu-devel] " Michael S. Tsirkin
2016-11-15 6:23 ` Namhyung Kim
2016-11-15 6:23 ` [Qemu-devel] " Namhyung Kim
2016-11-15 6:23 ` Namhyung Kim
2016-11-15 14:38 ` Michael S. Tsirkin
2016-11-15 14:38 ` [Qemu-devel] " Michael S. Tsirkin
2016-11-15 14:38 ` Michael S. Tsirkin
2016-11-10 22:50 ` Michael S. Tsirkin
2016-08-20 8:07 ` Namhyung Kim
2016-08-20 8:07 ` [PATCH 3/3] kvmtool: " Namhyung Kim
2016-08-20 8:07 ` [Qemu-devel] " Namhyung Kim
2016-08-20 8:07 ` Namhyung Kim
2016-08-23 10:25 ` [RFC/PATCHSET 0/3] virtio: Implement virtio pstore device (v3) Joel Fernandes
2016-08-23 15:20 ` Namhyung Kim
2016-08-23 15:20 ` [Qemu-devel] " Namhyung Kim
2016-08-24 7:10 ` Joel
2016-08-24 7:10 ` [Qemu-devel] " Joel
-- strict thread matches above, loose matches on Subject: below --
2016-09-04 14:38 [RFC/PATCHSET 0/3] virtio: Implement virtio pstore device (v5) Namhyung Kim
2016-09-04 14:38 ` [PATCH 1/3] virtio: Basic implementation of virtio pstore driver Namhyung Kim
2016-09-04 14:38 ` Namhyung Kim
2016-09-08 20:49 ` Kees Cook
2016-09-08 20:49 ` Kees Cook
2016-09-22 11:57 ` Stefan Hajnoczi
2016-09-22 11:57 ` Stefan Hajnoczi
2016-09-23 5:48 ` Namhyung Kim
2016-09-23 5:48 ` Namhyung Kim
2016-08-31 8:07 [RFC/PATCHSET 0/3] virtio: Implement virtio pstore device (v4) Namhyung Kim
2016-08-31 8:08 ` [PATCH 1/3] virtio: Basic implementation of virtio pstore driver Namhyung Kim
2016-08-31 8:08 ` Namhyung Kim
2016-08-31 14:54 ` Michael S. Tsirkin
2016-08-31 14:54 ` Michael S. Tsirkin
2016-09-01 0:03 ` Namhyung Kim
2016-09-01 0:03 ` Namhyung Kim
2016-07-18 4:37 [RFC/PATCHSET 0/3] virtio-pstore: Implement virtio pstore device Namhyung Kim
2016-07-18 4:37 ` [PATCH 1/3] virtio: Basic implementation of virtio pstore driver Namhyung Kim
2016-07-18 4:37 ` Namhyung Kim
2016-07-18 5:12 ` Kees Cook
2016-07-18 5:12 ` Kees Cook
2016-07-18 5:50 ` Namhyung Kim
2016-07-18 5:50 ` Namhyung Kim
2016-07-18 5:50 ` Namhyung Kim
2016-07-18 17:50 ` Kees Cook
2016-07-18 17:50 ` Kees Cook
2016-07-19 13:43 ` Namhyung Kim
2016-07-19 13:43 ` Namhyung Kim
2016-07-19 15:32 ` Namhyung Kim
2016-07-19 15:32 ` Namhyung Kim
2016-07-20 12:56 ` Namhyung Kim
2016-07-20 12:56 ` Namhyung Kim
2016-07-18 7:54 ` Cornelia Huck
2016-07-18 7:54 ` Cornelia Huck
2016-07-18 8:29 ` Namhyung Kim
2016-07-18 8:29 ` Namhyung Kim
2016-07-18 9:02 ` Cornelia Huck
2016-07-18 9:02 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161115055011.GB15992@danjae.aot.lge.com \
--to=namhyung@kernel.org \
--cc=aliguori@amazon.com \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=keescook@chromium.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=mingo@kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rkrcmar@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tony.luck@intel.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.