* [linux-next:master 5439/5763] fs/namespace.c:1185:9-10: WARNING: return of 0/1 in function 'path_is_mountpoint' with return type bool
@ 2016-11-14 23:58 kbuild test robot
2016-11-14 23:58 ` kbuild test robot
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2016-11-14 23:58 UTC (permalink / raw)
To: Ian Kent; +Cc: kbuild-all, Andrew Morton, Linux Memory Management List
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: b60de3eba5c3cf3a230c121def7c57aafa72c4f8
commit: 5910290273fdaf6dc1f6e8d4afdee5c5608b2b69 [5439/5763] vfs: add path_is_mountpoint() helper
coccinelle warnings: (new ones prefixed by >>)
>> fs/namespace.c:1185:9-10: WARNING: return of 0/1 in function 'path_is_mountpoint' with return type bool
>> fs/namespace.c:1199:9-10: WARNING: return of 0/1 in function 'path_is_mountpoint_rcu' with return type bool
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] vfs: fix boolreturn.cocci warnings
2016-11-14 23:58 [linux-next:master 5439/5763] fs/namespace.c:1185:9-10: WARNING: return of 0/1 in function 'path_is_mountpoint' with return type bool kbuild test robot
@ 2016-11-14 23:58 ` kbuild test robot
0 siblings, 0 replies; 3+ messages in thread
From: kbuild test robot @ 2016-11-14 23:58 UTC (permalink / raw)
To: Ian Kent
Cc: kbuild-all, Andrew Morton, Linux Memory Management List,
Alexander Viro, linux-fsdevel, linux-kernel
fs/namespace.c:1185:9-10: WARNING: return of 0/1 in function 'path_is_mountpoint' with return type bool
fs/namespace.c:1199:9-10: WARNING: return of 0/1 in function 'path_is_mountpoint_rcu' with return type bool
Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci
CC: Ian Kent <ikent@redhat.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
namespace.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -1182,7 +1182,7 @@ bool path_is_mountpoint(struct path *pat
bool res;
if (!d_mountpoint(path->dentry))
- return 0;
+ return false;
rcu_read_lock();
res = __path_is_mountpoint(path);
@@ -1196,7 +1196,7 @@ EXPORT_SYMBOL(path_is_mountpoint);
bool path_is_mountpoint_rcu(struct path *path)
{
if (!d_mountpoint(path->dentry))
- return 0;
+ return false;
return __path_is_mountpoint(path);
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] vfs: fix boolreturn.cocci warnings
@ 2016-11-14 23:58 ` kbuild test robot
0 siblings, 0 replies; 3+ messages in thread
From: kbuild test robot @ 2016-11-14 23:58 UTC (permalink / raw)
To: Ian Kent
Cc: kbuild-all, Andrew Morton, Linux Memory Management List,
Alexander Viro, linux-fsdevel, linux-kernel
fs/namespace.c:1185:9-10: WARNING: return of 0/1 in function 'path_is_mountpoint' with return type bool
fs/namespace.c:1199:9-10: WARNING: return of 0/1 in function 'path_is_mountpoint_rcu' with return type bool
Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci
CC: Ian Kent <ikent@redhat.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
namespace.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -1182,7 +1182,7 @@ bool path_is_mountpoint(struct path *pat
bool res;
if (!d_mountpoint(path->dentry))
- return 0;
+ return false;
rcu_read_lock();
res = __path_is_mountpoint(path);
@@ -1196,7 +1196,7 @@ EXPORT_SYMBOL(path_is_mountpoint);
bool path_is_mountpoint_rcu(struct path *path)
{
if (!d_mountpoint(path->dentry))
- return 0;
+ return false;
return __path_is_mountpoint(path);
}
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-14 23:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-14 23:58 [linux-next:master 5439/5763] fs/namespace.c:1185:9-10: WARNING: return of 0/1 in function 'path_is_mountpoint' with return type bool kbuild test robot
2016-11-14 23:58 ` [PATCH] vfs: fix boolreturn.cocci warnings kbuild test robot
2016-11-14 23:58 ` kbuild test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.