* [patch] ARM: socfpga: checking the wrong variable
@ 2016-11-15 9:54 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2016-11-15 9:54 UTC (permalink / raw)
To: Alan Tull; +Cc: Moritz Fischer, linux-kernel, kernel-janitors
This is a cut and paste bug. We had intended to check "sysmgr".
Fixes: e5f8efa5c8bf ("ARM: socfpga: fpga bridge driver support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/fpga/altera-fpga2sdram.c b/drivers/fpga/altera-fpga2sdram.c
index 7ab358e..d4eeb74 100644
--- a/drivers/fpga/altera-fpga2sdram.c
+++ b/drivers/fpga/altera-fpga2sdram.c
@@ -123,7 +123,7 @@ static int alt_fpga_bridge_probe(struct platform_device *pdev)
}
sysmgr = syscon_regmap_lookup_by_compatible("altr,sys-mgr");
- if (IS_ERR(priv->sdrctl)) {
+ if (IS_ERR(sysmgr)) {
dev_err(dev, "regmap for altr,sys-mgr lookup failed.\n");
return PTR_ERR(sysmgr);
}
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [patch] ARM: socfpga: checking the wrong variable
@ 2016-11-15 9:54 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2016-11-15 9:54 UTC (permalink / raw)
To: Alan Tull; +Cc: Moritz Fischer, linux-kernel, kernel-janitors
This is a cut and paste bug. We had intended to check "sysmgr".
Fixes: e5f8efa5c8bf ("ARM: socfpga: fpga bridge driver support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/fpga/altera-fpga2sdram.c b/drivers/fpga/altera-fpga2sdram.c
index 7ab358e..d4eeb74 100644
--- a/drivers/fpga/altera-fpga2sdram.c
+++ b/drivers/fpga/altera-fpga2sdram.c
@@ -123,7 +123,7 @@ static int alt_fpga_bridge_probe(struct platform_device *pdev)
}
sysmgr = syscon_regmap_lookup_by_compatible("altr,sys-mgr");
- if (IS_ERR(priv->sdrctl)) {
+ if (IS_ERR(sysmgr)) {
dev_err(dev, "regmap for altr,sys-mgr lookup failed.\n");
return PTR_ERR(sysmgr);
}
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [patch] ARM: socfpga: checking the wrong variable
2016-11-15 9:54 ` Dan Carpenter
@ 2016-11-15 15:37 ` Moritz Fischer
-1 siblings, 0 replies; 6+ messages in thread
From: Moritz Fischer @ 2016-11-15 15:37 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Alan Tull, Linux Kernel Mailing List, kernel-janitors
Hi Dan,
On Tue, Nov 15, 2016 at 1:54 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> This is a cut and paste bug. We had intended to check "sysmgr".
>
> Fixes: e5f8efa5c8bf ("ARM: socfpga: fpga bridge driver support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Moritz Fischer <moritz.fischer@ettus.com>
>
> diff --git a/drivers/fpga/altera-fpga2sdram.c b/drivers/fpga/altera-fpga2sdram.c
> index 7ab358e..d4eeb74 100644
> --- a/drivers/fpga/altera-fpga2sdram.c
> +++ b/drivers/fpga/altera-fpga2sdram.c
> @@ -123,7 +123,7 @@ static int alt_fpga_bridge_probe(struct platform_device *pdev)
> }
>
> sysmgr = syscon_regmap_lookup_by_compatible("altr,sys-mgr");
> - if (IS_ERR(priv->sdrctl)) {
> + if (IS_ERR(sysmgr)) {
> dev_err(dev, "regmap for altr,sys-mgr lookup failed.\n");
> return PTR_ERR(sysmgr);
> }
Thanks,
Moritz
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] ARM: socfpga: checking the wrong variable
@ 2016-11-15 15:37 ` Moritz Fischer
0 siblings, 0 replies; 6+ messages in thread
From: Moritz Fischer @ 2016-11-15 15:37 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Alan Tull, Linux Kernel Mailing List, kernel-janitors
Hi Dan,
On Tue, Nov 15, 2016 at 1:54 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> This is a cut and paste bug. We had intended to check "sysmgr".
>
> Fixes: e5f8efa5c8bf ("ARM: socfpga: fpga bridge driver support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Moritz Fischer <moritz.fischer@ettus.com>
>
> diff --git a/drivers/fpga/altera-fpga2sdram.c b/drivers/fpga/altera-fpga2sdram.c
> index 7ab358e..d4eeb74 100644
> --- a/drivers/fpga/altera-fpga2sdram.c
> +++ b/drivers/fpga/altera-fpga2sdram.c
> @@ -123,7 +123,7 @@ static int alt_fpga_bridge_probe(struct platform_device *pdev)
> }
>
> sysmgr = syscon_regmap_lookup_by_compatible("altr,sys-mgr");
> - if (IS_ERR(priv->sdrctl)) {
> + if (IS_ERR(sysmgr)) {
> dev_err(dev, "regmap for altr,sys-mgr lookup failed.\n");
> return PTR_ERR(sysmgr);
> }
Thanks,
Moritz
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] ARM: socfpga: checking the wrong variable
2016-11-15 15:37 ` Moritz Fischer
@ 2016-11-15 16:01 ` atull
-1 siblings, 0 replies; 6+ messages in thread
From: atull @ 2016-11-15 16:01 UTC (permalink / raw)
To: Moritz Fischer; +Cc: Dan Carpenter, Linux Kernel Mailing List, kernel-janitors
On Tue, 15 Nov 2016, Moritz Fischer wrote:
> Hi Dan,
> On Tue, Nov 15, 2016 at 1:54 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > This is a cut and paste bug. We had intended to check "sysmgr".
> >
> > Fixes: e5f8efa5c8bf ("ARM: socfpga: fpga bridge driver support")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Acked-by: Moritz Fischer <moritz.fischer@ettus.com>
Hi Dan,
Acked-by: Alan Tull <atull@opensource.altera.com>
Thanks for catching this!
Alan
>
> >
> > diff --git a/drivers/fpga/altera-fpga2sdram.c b/drivers/fpga/altera-fpga2sdram.c
> > index 7ab358e..d4eeb74 100644
> > --- a/drivers/fpga/altera-fpga2sdram.c
> > +++ b/drivers/fpga/altera-fpga2sdram.c
> > @@ -123,7 +123,7 @@ static int alt_fpga_bridge_probe(struct platform_device *pdev)
> > }
> >
> > sysmgr = syscon_regmap_lookup_by_compatible("altr,sys-mgr");
> > - if (IS_ERR(priv->sdrctl)) {
> > + if (IS_ERR(sysmgr)) {
> > dev_err(dev, "regmap for altr,sys-mgr lookup failed.\n");
> > return PTR_ERR(sysmgr);
> > }
>
> Thanks,
>
> Moritz
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] ARM: socfpga: checking the wrong variable
@ 2016-11-15 16:01 ` atull
0 siblings, 0 replies; 6+ messages in thread
From: atull @ 2016-11-15 16:01 UTC (permalink / raw)
To: Moritz Fischer; +Cc: Dan Carpenter, Linux Kernel Mailing List, kernel-janitors
On Tue, 15 Nov 2016, Moritz Fischer wrote:
> Hi Dan,
> On Tue, Nov 15, 2016 at 1:54 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > This is a cut and paste bug. We had intended to check "sysmgr".
> >
> > Fixes: e5f8efa5c8bf ("ARM: socfpga: fpga bridge driver support")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Acked-by: Moritz Fischer <moritz.fischer@ettus.com>
Hi Dan,
Acked-by: Alan Tull <atull@opensource.altera.com>
Thanks for catching this!
Alan
>
> >
> > diff --git a/drivers/fpga/altera-fpga2sdram.c b/drivers/fpga/altera-fpga2sdram.c
> > index 7ab358e..d4eeb74 100644
> > --- a/drivers/fpga/altera-fpga2sdram.c
> > +++ b/drivers/fpga/altera-fpga2sdram.c
> > @@ -123,7 +123,7 @@ static int alt_fpga_bridge_probe(struct platform_device *pdev)
> > }
> >
> > sysmgr = syscon_regmap_lookup_by_compatible("altr,sys-mgr");
> > - if (IS_ERR(priv->sdrctl)) {
> > + if (IS_ERR(sysmgr)) {
> > dev_err(dev, "regmap for altr,sys-mgr lookup failed.\n");
> > return PTR_ERR(sysmgr);
> > }
>
> Thanks,
>
> Moritz
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-11-15 16:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-15 9:54 [patch] ARM: socfpga: checking the wrong variable Dan Carpenter
2016-11-15 9:54 ` Dan Carpenter
2016-11-15 15:37 ` Moritz Fischer
2016-11-15 15:37 ` Moritz Fischer
2016-11-15 16:01 ` atull
2016-11-15 16:01 ` atull
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.