All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: Make scaler updates less chatty
@ 2016-11-17 10:00 Tvrtko Ursulin
  2016-11-17 11:45 ` ✓ Fi.CI.BAT: success for " Patchwork
  2016-11-17 13:06 ` [PATCH] " Paulo Zanoni
  0 siblings, 2 replies; 5+ messages in thread
From: Tvrtko Ursulin @ 2016-11-17 10:00 UTC (permalink / raw)
  To: Intel-gfx

From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

It looks to me skl_update_scaler will already log interesting
debug messages when the state transitions or there is an error.

In this case it feels we can remove the two unconditional
debug messages which happen immediately before calling
skl_update_scaler. This way we get rid of the sole debug
message when switching virtual terminals for example.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 drivers/gpu/drm/i915/intel_display.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 2ebb8b833395..cd5256c0b2d6 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -4727,13 +4727,8 @@ skl_update_scaler(struct intel_crtc_state *crtc_state, bool force_detach,
  */
 int skl_update_scaler_crtc(struct intel_crtc_state *state)
 {
-	struct intel_crtc *intel_crtc = to_intel_crtc(state->base.crtc);
 	const struct drm_display_mode *adjusted_mode = &state->base.adjusted_mode;
 
-	DRM_DEBUG_KMS("Updating scaler for [CRTC:%d:%s] scaler_user index %u.%u\n",
-		      intel_crtc->base.base.id, intel_crtc->base.name,
-		      intel_crtc->pipe, SKL_CRTC_INDEX);
-
 	return skl_update_scaler(state, !state->base.active, SKL_CRTC_INDEX,
 		&state->scaler_state.scaler_id, DRM_ROTATE_0,
 		state->pipe_src_w, state->pipe_src_h,
@@ -4754,7 +4749,6 @@ static int skl_update_scaler_plane(struct intel_crtc_state *crtc_state,
 				   struct intel_plane_state *plane_state)
 {
 
-	struct intel_crtc *intel_crtc = to_intel_crtc(crtc_state->base.crtc);
 	struct intel_plane *intel_plane =
 		to_intel_plane(plane_state->base.plane);
 	struct drm_framebuffer *fb = plane_state->base.fb;
@@ -4762,10 +4756,6 @@ static int skl_update_scaler_plane(struct intel_crtc_state *crtc_state,
 
 	bool force_detach = !fb || !plane_state->base.visible;
 
-	DRM_DEBUG_KMS("Updating scaler for [PLANE:%d:%s] scaler_user index %u.%u\n",
-		      intel_plane->base.base.id, intel_plane->base.name,
-		      intel_crtc->pipe, drm_plane_index(&intel_plane->base));
-
 	ret = skl_update_scaler(crtc_state, force_detach,
 				drm_plane_index(&intel_plane->base),
 				&plane_state->scaler_id,
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Make scaler updates less chatty
  2016-11-17 10:00 [PATCH] drm/i915: Make scaler updates less chatty Tvrtko Ursulin
@ 2016-11-17 11:45 ` Patchwork
  2016-11-17 14:04   ` Tvrtko Ursulin
  2016-11-17 13:06 ` [PATCH] " Paulo Zanoni
  1 sibling, 1 reply; 5+ messages in thread
From: Patchwork @ 2016-11-17 11:45 UTC (permalink / raw)
  To: Tvrtko Ursulin; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: Make scaler updates less chatty
URL   : https://patchwork.freedesktop.org/series/15481/
State : success

== Summary ==

Series 15481v1 drm/i915: Make scaler updates less chatty
https://patchwork.freedesktop.org/api/1.0/series/15481/revisions/1/mbox/


fi-bdw-5557u     total:244  pass:229  dwarn:0   dfail:0   fail:0   skip:15 
fi-bsw-n3050     total:244  pass:204  dwarn:0   dfail:0   fail:0   skip:40 
fi-byt-j1900     total:244  pass:216  dwarn:0   dfail:0   fail:0   skip:28 
fi-byt-n2820     total:244  pass:212  dwarn:0   dfail:0   fail:0   skip:32 
fi-hsw-4770      total:244  pass:224  dwarn:0   dfail:0   fail:0   skip:20 
fi-hsw-4770r     total:244  pass:224  dwarn:0   dfail:0   fail:0   skip:20 
fi-ilk-650       total:244  pass:191  dwarn:0   dfail:0   fail:0   skip:53 
fi-ivb-3520m     total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22 
fi-ivb-3770      total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22 
fi-kbl-7200u     total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22 
fi-skl-6260u     total:244  pass:230  dwarn:0   dfail:0   fail:0   skip:14 
fi-skl-6700hq    total:244  pass:223  dwarn:0   dfail:0   fail:0   skip:21 
fi-skl-6700k     total:244  pass:222  dwarn:1   dfail:0   fail:0   skip:21 
fi-skl-6770hq    total:244  pass:230  dwarn:0   dfail:0   fail:0   skip:14 
fi-snb-2520m     total:244  pass:212  dwarn:0   dfail:0   fail:0   skip:32 
fi-snb-2600      total:244  pass:211  dwarn:0   dfail:0   fail:0   skip:33 

ccd01198820ab7286f0b98f7b28dbf6ad29fa861 drm-intel-nightly: 2016y-11m-17d-10h-54m-57s UTC integration manifest
e7b42bc drm/i915: Make scaler updates less chatty

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3032/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Make scaler updates less chatty
  2016-11-17 10:00 [PATCH] drm/i915: Make scaler updates less chatty Tvrtko Ursulin
  2016-11-17 11:45 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2016-11-17 13:06 ` Paulo Zanoni
  2016-11-17 14:01   ` Maarten Lankhorst
  1 sibling, 1 reply; 5+ messages in thread
From: Paulo Zanoni @ 2016-11-17 13:06 UTC (permalink / raw)
  To: Tvrtko Ursulin, Intel-gfx

Em Qui, 2016-11-17 às 10:00 +0000, Tvrtko Ursulin escreveu:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> It looks to me skl_update_scaler will already log interesting
> debug messages when the state transitions or there is an error.
> 
> In this case it feels we can remove the two unconditional
> debug messages which happen immediately before calling
> skl_update_scaler. This way we get rid of the sole debug
> message when switching virtual terminals for example.

I also got annoyed by this at some point.

Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_display.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c
> b/drivers/gpu/drm/i915/intel_display.c
> index 2ebb8b833395..cd5256c0b2d6 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -4727,13 +4727,8 @@ skl_update_scaler(struct intel_crtc_state
> *crtc_state, bool force_detach,
>   */
>  int skl_update_scaler_crtc(struct intel_crtc_state *state)
>  {
> -	struct intel_crtc *intel_crtc = to_intel_crtc(state-
> >base.crtc);
>  	const struct drm_display_mode *adjusted_mode = &state-
> >base.adjusted_mode;
>  
> -	DRM_DEBUG_KMS("Updating scaler for [CRTC:%d:%s] scaler_user
> index %u.%u\n",
> -		      intel_crtc->base.base.id, intel_crtc-
> >base.name,
> -		      intel_crtc->pipe, SKL_CRTC_INDEX);
> -
>  	return skl_update_scaler(state, !state->base.active,
> SKL_CRTC_INDEX,
>  		&state->scaler_state.scaler_id, DRM_ROTATE_0,
>  		state->pipe_src_w, state->pipe_src_h,
> @@ -4754,7 +4749,6 @@ static int skl_update_scaler_plane(struct
> intel_crtc_state *crtc_state,
>  				   struct intel_plane_state
> *plane_state)
>  {
>  
> -	struct intel_crtc *intel_crtc = to_intel_crtc(crtc_state-
> >base.crtc);
>  	struct intel_plane *intel_plane =
>  		to_intel_plane(plane_state->base.plane);
>  	struct drm_framebuffer *fb = plane_state->base.fb;
> @@ -4762,10 +4756,6 @@ static int skl_update_scaler_plane(struct
> intel_crtc_state *crtc_state,
>  
>  	bool force_detach = !fb || !plane_state->base.visible;
>  
> -	DRM_DEBUG_KMS("Updating scaler for [PLANE:%d:%s] scaler_user
> index %u.%u\n",
> -		      intel_plane->base.base.id, intel_plane-
> >base.name,
> -		      intel_crtc->pipe,
> drm_plane_index(&intel_plane->base));
> -
>  	ret = skl_update_scaler(crtc_state, force_detach,
>  				drm_plane_index(&intel_plane->base),
>  				&plane_state->scaler_id,
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Make scaler updates less chatty
  2016-11-17 13:06 ` [PATCH] " Paulo Zanoni
@ 2016-11-17 14:01   ` Maarten Lankhorst
  0 siblings, 0 replies; 5+ messages in thread
From: Maarten Lankhorst @ 2016-11-17 14:01 UTC (permalink / raw)
  To: Paulo Zanoni, Tvrtko Ursulin, Intel-gfx

Op 17-11-16 om 14:06 schreef Paulo Zanoni:
> Em Qui, 2016-11-17 às 10:00 +0000, Tvrtko Ursulin escreveu:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> It looks to me skl_update_scaler will already log interesting
>> debug messages when the state transitions or there is an error.
>>
>> In this case it feels we can remove the two unconditional
>> debug messages which happen immediately before calling
>> skl_update_scaler. This way we get rid of the sole debug
>> message when switching virtual terminals for example.
> I also got annoyed by this at some point.
>
> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> ---
>>  drivers/gpu/drm/i915/intel_display.c | 10 ----------
>>  1 file changed, 10 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_display.c
>> b/drivers/gpu/drm/i915/intel_display.c
>> index 2ebb8b833395..cd5256c0b2d6 100644
>> --- a/drivers/gpu/drm/i915/intel_display.c
>> +++ b/drivers/gpu/drm/i915/intel_display.c
>> @@ -4727,13 +4727,8 @@ skl_update_scaler(struct intel_crtc_state
>> *crtc_state, bool force_detach,
>>   */
>>  int skl_update_scaler_crtc(struct intel_crtc_state *state)
>>  {
>> -	struct intel_crtc *intel_crtc = to_intel_crtc(state-
>>> base.crtc);
>>  	const struct drm_display_mode *adjusted_mode = &state-
>>> base.adjusted_mode;
>>  
>> -	DRM_DEBUG_KMS("Updating scaler for [CRTC:%d:%s] scaler_user
>> index %u.%u\n",
>> -		      intel_crtc->base.base.id, intel_crtc-
>>> base.name,
>> -		      intel_crtc->pipe, SKL_CRTC_INDEX);
>> -
>>  	return skl_update_scaler(state, !state->base.active,
>> SKL_CRTC_INDEX,
>>  		&state->scaler_state.scaler_id, DRM_ROTATE_0,
>>  		state->pipe_src_w, state->pipe_src_h,
>> @@ -4754,7 +4749,6 @@ static int skl_update_scaler_plane(struct
>> intel_crtc_state *crtc_state,
>>  				   struct intel_plane_state
>> *plane_state)
>>  {
>>  
>> -	struct intel_crtc *intel_crtc = to_intel_crtc(crtc_state-
>>> base.crtc);
>>  	struct intel_plane *intel_plane =
>>  		to_intel_plane(plane_state->base.plane);
>>  	struct drm_framebuffer *fb = plane_state->base.fb;
>> @@ -4762,10 +4756,6 @@ static int skl_update_scaler_plane(struct
>> intel_crtc_state *crtc_state,
>>  
>>  	bool force_detach = !fb || !plane_state->base.visible;
>>  
>> -	DRM_DEBUG_KMS("Updating scaler for [PLANE:%d:%s] scaler_user
>> index %u.%u\n",
>> -		      intel_plane->base.base.id, intel_plane-
>>> base.name,
>> -		      intel_crtc->pipe,
>> drm_plane_index(&intel_plane->base));
>> -
>>  	ret = skl_update_scaler(crtc_state, force_detach,
>>  				drm_plane_index(&intel_plane->base),
>>  				&plane_state->scaler_id,
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: ✓ Fi.CI.BAT: success for drm/i915: Make scaler updates less chatty
  2016-11-17 11:45 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2016-11-17 14:04   ` Tvrtko Ursulin
  0 siblings, 0 replies; 5+ messages in thread
From: Tvrtko Ursulin @ 2016-11-17 14:04 UTC (permalink / raw)
  To: intel-gfx, Tvrtko Ursulin


On 17/11/2016 11:45, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915: Make scaler updates less chatty
> URL   : https://patchwork.freedesktop.org/series/15481/
> State : success
>
> == Summary ==
>
> Series 15481v1 drm/i915: Make scaler updates less chatty
> https://patchwork.freedesktop.org/api/1.0/series/15481/revisions/1/mbox/
>
>
> fi-bdw-5557u     total:244  pass:229  dwarn:0   dfail:0   fail:0   skip:15
> fi-bsw-n3050     total:244  pass:204  dwarn:0   dfail:0   fail:0   skip:40
> fi-byt-j1900     total:244  pass:216  dwarn:0   dfail:0   fail:0   skip:28
> fi-byt-n2820     total:244  pass:212  dwarn:0   dfail:0   fail:0   skip:32
> fi-hsw-4770      total:244  pass:224  dwarn:0   dfail:0   fail:0   skip:20
> fi-hsw-4770r     total:244  pass:224  dwarn:0   dfail:0   fail:0   skip:20
> fi-ilk-650       total:244  pass:191  dwarn:0   dfail:0   fail:0   skip:53
> fi-ivb-3520m     total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22
> fi-ivb-3770      total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22
> fi-kbl-7200u     total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22
> fi-skl-6260u     total:244  pass:230  dwarn:0   dfail:0   fail:0   skip:14
> fi-skl-6700hq    total:244  pass:223  dwarn:0   dfail:0   fail:0   skip:21
> fi-skl-6700k     total:244  pass:222  dwarn:1   dfail:0   fail:0   skip:21
> fi-skl-6770hq    total:244  pass:230  dwarn:0   dfail:0   fail:0   skip:14
> fi-snb-2520m     total:244  pass:212  dwarn:0   dfail:0   fail:0   skip:32
> fi-snb-2600      total:244  pass:211  dwarn:0   dfail:0   fail:0   skip:33
>
> ccd01198820ab7286f0b98f7b28dbf6ad29fa861 drm-intel-nightly: 2016y-11m-17d-10h-54m-57s UTC integration manifest
> e7b42bc drm/i915: Make scaler updates less chatty

Merged to dinq, thanks for the review!

Was also acked by Maarten on IRC.

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-11-17 14:04 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-17 10:00 [PATCH] drm/i915: Make scaler updates less chatty Tvrtko Ursulin
2016-11-17 11:45 ` ✓ Fi.CI.BAT: success for " Patchwork
2016-11-17 14:04   ` Tvrtko Ursulin
2016-11-17 13:06 ` [PATCH] " Paulo Zanoni
2016-11-17 14:01   ` Maarten Lankhorst

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.