* [PATCH] drm/i915: Waterproof verification of gen9 forcewake table ranges
@ 2016-11-17 13:13 Tvrtko Ursulin
2016-11-17 13:21 ` Chris Wilson
2016-11-17 15:16 ` ✗ Fi.CI.BAT: warning for " Patchwork
0 siblings, 2 replies; 4+ messages in thread
From: Tvrtko Ursulin @ 2016-11-17 13:13 UTC (permalink / raw)
To: Intel-gfx
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
We have to make sure there are no holes in the table in Gen9.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/intel_uncore.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
index a0944dde7c41..deb8e9e6f9ea 100644
--- a/drivers/gpu/drm/i915/intel_uncore.c
+++ b/drivers/gpu/drm/i915/intel_uncore.c
@@ -647,6 +647,8 @@ intel_fw_table_check(struct drm_i915_private *dev_priv)
num_ranges = dev_priv->uncore.fw_domains_table_entries;
for (i = 0, prev = -1; i < num_ranges; i++, ranges++) {
+ WARN_ON_ONCE(IS_GEN9(dev_priv) &&
+ (prev + 1) != (s32)ranges->start);
WARN_ON_ONCE(prev >= (s32)ranges->start);
prev = ranges->start;
WARN_ON_ONCE(prev >= (s32)ranges->end);
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915: Waterproof verification of gen9 forcewake table ranges
2016-11-17 13:13 [PATCH] drm/i915: Waterproof verification of gen9 forcewake table ranges Tvrtko Ursulin
@ 2016-11-17 13:21 ` Chris Wilson
2016-11-17 15:16 ` ✗ Fi.CI.BAT: warning for " Patchwork
1 sibling, 0 replies; 4+ messages in thread
From: Chris Wilson @ 2016-11-17 13:21 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: Intel-gfx
On Thu, Nov 17, 2016 at 01:13:55PM +0000, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> We have to make sure there are no holes in the table in Gen9.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
That actually worked! ... Got any paracetamol? :)
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* ✗ Fi.CI.BAT: warning for drm/i915: Waterproof verification of gen9 forcewake table ranges
2016-11-17 13:13 [PATCH] drm/i915: Waterproof verification of gen9 forcewake table ranges Tvrtko Ursulin
2016-11-17 13:21 ` Chris Wilson
@ 2016-11-17 15:16 ` Patchwork
2016-11-17 15:38 ` Tvrtko Ursulin
1 sibling, 1 reply; 4+ messages in thread
From: Patchwork @ 2016-11-17 15:16 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Waterproof verification of gen9 forcewake table ranges
URL : https://patchwork.freedesktop.org/series/15496/
State : warning
== Summary ==
Series 15496v1 drm/i915: Waterproof verification of gen9 forcewake table ranges
https://patchwork.freedesktop.org/api/1.0/series/15496/revisions/1/mbox/
Test drv_module_reload_basic:
dmesg-warn -> PASS (fi-skl-6770hq)
Test kms_force_connector_basic:
Subgroup force-load-detect:
pass -> DMESG-WARN (fi-snb-2520m)
fi-bdw-5557u total:244 pass:229 dwarn:0 dfail:0 fail:0 skip:15
fi-bsw-n3050 total:244 pass:204 dwarn:0 dfail:0 fail:0 skip:40
fi-bxt-t5700 total:244 pass:216 dwarn:0 dfail:0 fail:0 skip:28
fi-byt-j1900 total:244 pass:216 dwarn:0 dfail:0 fail:0 skip:28
fi-byt-n2820 total:244 pass:212 dwarn:0 dfail:0 fail:0 skip:32
fi-hsw-4770 total:244 pass:224 dwarn:0 dfail:0 fail:0 skip:20
fi-hsw-4770r total:244 pass:224 dwarn:0 dfail:0 fail:0 skip:20
fi-ilk-650 total:244 pass:191 dwarn:0 dfail:0 fail:0 skip:53
fi-ivb-3520m total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22
fi-ivb-3770 total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22
fi-kbl-7200u total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22
fi-skl-6260u total:244 pass:230 dwarn:0 dfail:0 fail:0 skip:14
fi-skl-6700hq total:244 pass:223 dwarn:0 dfail:0 fail:0 skip:21
fi-skl-6700k total:244 pass:222 dwarn:1 dfail:0 fail:0 skip:21
fi-skl-6770hq total:244 pass:230 dwarn:0 dfail:0 fail:0 skip:14
fi-snb-2520m total:244 pass:211 dwarn:1 dfail:0 fail:0 skip:32
fi-snb-2600 total:244 pass:211 dwarn:0 dfail:0 fail:0 skip:33
0edb25a37b8f30bf40c9db5625b7401f7fc890e9 drm-intel-nightly: 2016y-11m-17d-14h-26m-31s UTC integration manifest
e4fe914 drm/i915: Waterproof verification of gen9 forcewake table ranges
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3036/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ✗ Fi.CI.BAT: warning for drm/i915: Waterproof verification of gen9 forcewake table ranges
2016-11-17 15:16 ` ✗ Fi.CI.BAT: warning for " Patchwork
@ 2016-11-17 15:38 ` Tvrtko Ursulin
0 siblings, 0 replies; 4+ messages in thread
From: Tvrtko Ursulin @ 2016-11-17 15:38 UTC (permalink / raw)
To: intel-gfx, Tvrtko Ursulin
On 17/11/2016 15:16, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915: Waterproof verification of gen9 forcewake table ranges
> URL : https://patchwork.freedesktop.org/series/15496/
> State : warning
>
> == Summary ==
>
> Series 15496v1 drm/i915: Waterproof verification of gen9 forcewake table ranges
> https://patchwork.freedesktop.org/api/1.0/series/15496/revisions/1/mbox/
>
> Test drv_module_reload_basic:
> dmesg-warn -> PASS (fi-skl-6770hq)
> Test kms_force_connector_basic:
> Subgroup force-load-detect:
> pass -> DMESG-WARN (fi-snb-2520m)
Just the EDID checksum issue:
https://bugs.freedesktop.org/show_bug.cgi?id=98625
> fi-bdw-5557u total:244 pass:229 dwarn:0 dfail:0 fail:0 skip:15
> fi-bsw-n3050 total:244 pass:204 dwarn:0 dfail:0 fail:0 skip:40
> fi-bxt-t5700 total:244 pass:216 dwarn:0 dfail:0 fail:0 skip:28
> fi-byt-j1900 total:244 pass:216 dwarn:0 dfail:0 fail:0 skip:28
> fi-byt-n2820 total:244 pass:212 dwarn:0 dfail:0 fail:0 skip:32
> fi-hsw-4770 total:244 pass:224 dwarn:0 dfail:0 fail:0 skip:20
> fi-hsw-4770r total:244 pass:224 dwarn:0 dfail:0 fail:0 skip:20
> fi-ilk-650 total:244 pass:191 dwarn:0 dfail:0 fail:0 skip:53
> fi-ivb-3520m total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22
> fi-ivb-3770 total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22
> fi-kbl-7200u total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22
> fi-skl-6260u total:244 pass:230 dwarn:0 dfail:0 fail:0 skip:14
> fi-skl-6700hq total:244 pass:223 dwarn:0 dfail:0 fail:0 skip:21
> fi-skl-6700k total:244 pass:222 dwarn:1 dfail:0 fail:0 skip:21
> fi-skl-6770hq total:244 pass:230 dwarn:0 dfail:0 fail:0 skip:14
> fi-snb-2520m total:244 pass:211 dwarn:1 dfail:0 fail:0 skip:32
> fi-snb-2600 total:244 pass:211 dwarn:0 dfail:0 fail:0 skip:33
>
> 0edb25a37b8f30bf40c9db5625b7401f7fc890e9 drm-intel-nightly: 2016y-11m-17d-14h-26m-31s UTC integration manifest
> e4fe914 drm/i915: Waterproof verification of gen9 forcewake table ranges
Merged to dinq, thanks for the review.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-17 15:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-17 13:13 [PATCH] drm/i915: Waterproof verification of gen9 forcewake table ranges Tvrtko Ursulin
2016-11-17 13:21 ` Chris Wilson
2016-11-17 15:16 ` ✗ Fi.CI.BAT: warning for " Patchwork
2016-11-17 15:38 ` Tvrtko Ursulin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.