* [[PATCH ddx]] intel: Adding Marketing names for Skylake, Kabylake and Apollolake/Broxton.
@ 2016-11-15 22:21 Rodrigo Vivi
2016-11-17 8:53 ` David Weinehall
0 siblings, 1 reply; 9+ messages in thread
From: Rodrigo Vivi @ 2016-11-15 22:21 UTC (permalink / raw)
To: intel-gfx; +Cc: Rodrigo Vivi
This commit adding all known marketing names for latest gen9 platforms.
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
README | 2 +-
man/intel.man | 2 +-
src/intel_module.c | 29 ++++++++++++++++++++++++++++-
3 files changed, 30 insertions(+), 3 deletions(-)
diff --git a/README b/README
index cf4d88d..e58477d 100644
--- a/README
+++ b/README
@@ -15,7 +15,7 @@ Intel graphics chipsets including:
G/Q33,G/Q35,G41,G/Q43,G/GM/Q45
PineView-M (Atom N400 series)
PineView-D (Atom D400/D500 series)
- Intel(R) HD Graphics: 2000-6000,
+ Intel(R) HD Graphics: 500-6000/P530/P555/P580,
Intel(R) Iris(TM) Graphics: 5100/6100, and
Intel(R) Iris(TM) Pro Graphics: 5200/6200/P6300.
diff --git a/man/intel.man b/man/intel.man
index 8da496e..16cc5d9 100644
--- a/man/intel.man
+++ b/man/intel.man
@@ -27,7 +27,7 @@ supports the i810, i810-DC100, i810e, i815, i830M, 845G, 852GM, 855GM,
865G, 915G, 915GM, 945G, 945GM, 965G, 965Q, 946GZ, 965GM, 945GME,
G33, Q33, Q35, G35, GM45, G45, Q45, G43, G41 chipsets, Pineview-M in
Atom N400 series, Pineview-D in Atom D400/D500 series,
-Intel(R) HD Graphics: 2000-6000,
+Intel(R) HD Graphics: 500-6000/P530/P555/P580,
Intel(R) Iris(TM) Graphics: 5100/6100, and
Intel(R) Iris(TM) Pro Graphics: 5200/6200/P6300.
diff --git a/src/intel_module.c b/src/intel_module.c
index e443c9e..86b4aae 100644
--- a/src/intel_module.c
+++ b/src/intel_module.c
@@ -272,6 +272,33 @@ static const SymTabRec intel_chipsets[] = {
{0x22b2, "HD Graphics"},
{0x22b3, "HD Graphics"},
+ /* Skylake */
+ {0x1902, "HD Graphics 510"},
+ {0x1906, "HD Graphics 510"},
+ {0x190B, "HD Graphics 510"},
+ {0x1912, "HD Graphics 530"},
+ {0x1916, "HD Graphics 520"},
+ {0x191B, "HD Graphics 530"},
+ {0x191D, "HD Graphics P530"},
+ {0x191E, "HD Graphics 515"},
+ {0x1921, "HD Graphics 520"},
+ {0x1926, "Iris Graphics 540"},
+ {0x1927, "Iris Graphics 550"},
+ {0x192B, "Iris Graphics 555"},
+ {0x192D, "Iris Graphics P555"},
+ {0x1932, "Iris Pro Graphics 580"},
+ {0x193A, "Iris Pro Graphics P580"},
+ {0x193B, "Iris Pro Graphics 580"},
+ {0x193D, "Iris Pro Graphics P580"},
+
+ /* Broxton (Apollolake) */
+ {0x5A84, "HD Graphics 505"},
+ {0x5A85, "HD Graphics 500"},
+
+ /* Kabylake */
+ {0x5916, "HD Graphics 620"},
+ {0x591E, "HD Graphics 615"},
+
/* When adding new identifiers, also update:
* 1. intel_identify()
* 2. man/intel.man
@@ -465,7 +492,7 @@ static void intel_identify(int flags)
if (unique != stack)
free(unique);
- xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) HD Graphics: 2000-6000\n");
+ xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) HD Graphics: 500-6000/P530/P555/P580\n");
xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) Iris(TM) Graphics: 5100, 6100\n");
xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) Iris(TM) Pro Graphics: 5200, 6200, P6300\n");
}
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [[PATCH ddx]] intel: Adding Marketing names for Skylake, Kabylake and Apollolake/Broxton.
2016-11-15 22:21 [[PATCH ddx]] intel: Adding Marketing names for Skylake, Kabylake and Apollolake/Broxton Rodrigo Vivi
@ 2016-11-17 8:53 ` David Weinehall
2016-11-17 19:06 ` Rodrigo Vivi
0 siblings, 1 reply; 9+ messages in thread
From: David Weinehall @ 2016-11-17 8:53 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: intel-gfx
On Tue, Nov 15, 2016 at 02:21:01PM -0800, Rodrigo Vivi wrote:
> This commit adding all known marketing names for latest gen9 platforms.
>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> README | 2 +-
> man/intel.man | 2 +-
> src/intel_module.c | 29 ++++++++++++++++++++++++++++-
> 3 files changed, 30 insertions(+), 3 deletions(-)
>
> diff --git a/README b/README
> index cf4d88d..e58477d 100644
> --- a/README
> +++ b/README
> @@ -15,7 +15,7 @@ Intel graphics chipsets including:
> G/Q33,G/Q35,G41,G/Q43,G/GM/Q45
> PineView-M (Atom N400 series)
> PineView-D (Atom D400/D500 series)
> - Intel(R) HD Graphics: 2000-6000,
> + Intel(R) HD Graphics: 500-6000/P530/P555/P580,
> Intel(R) Iris(TM) Graphics: 5100/6100, and
> Intel(R) Iris(TM) Pro Graphics: 5200/6200/P6300.
>
> diff --git a/man/intel.man b/man/intel.man
> index 8da496e..16cc5d9 100644
> --- a/man/intel.man
> +++ b/man/intel.man
> @@ -27,7 +27,7 @@ supports the i810, i810-DC100, i810e, i815, i830M, 845G, 852GM, 855GM,
> 865G, 915G, 915GM, 945G, 945GM, 965G, 965Q, 946GZ, 965GM, 945GME,
> G33, Q33, Q35, G35, GM45, G45, Q45, G43, G41 chipsets, Pineview-M in
> Atom N400 series, Pineview-D in Atom D400/D500 series,
> -Intel(R) HD Graphics: 2000-6000,
> +Intel(R) HD Graphics: 500-6000/P530/P555/P580,
> Intel(R) Iris(TM) Graphics: 5100/6100, and
> Intel(R) Iris(TM) Pro Graphics: 5200/6200/P6300.
>
> diff --git a/src/intel_module.c b/src/intel_module.c
> index e443c9e..86b4aae 100644
> --- a/src/intel_module.c
> +++ b/src/intel_module.c
> @@ -272,6 +272,33 @@ static const SymTabRec intel_chipsets[] = {
> {0x22b2, "HD Graphics"},
> {0x22b3, "HD Graphics"},
>
> + /* Skylake */
> + {0x1902, "HD Graphics 510"},
> + {0x1906, "HD Graphics 510"},
> + {0x190B, "HD Graphics 510"},
> + {0x1912, "HD Graphics 530"},
> + {0x1916, "HD Graphics 520"},
> + {0x191B, "HD Graphics 530"},
> + {0x191D, "HD Graphics P530"},
> + {0x191E, "HD Graphics 515"},
> + {0x1921, "HD Graphics 520"},
> + {0x1926, "Iris Graphics 540"},
> + {0x1927, "Iris Graphics 550"},
> + {0x192B, "Iris Graphics 555"},
> + {0x192D, "Iris Graphics P555"},
> + {0x1932, "Iris Pro Graphics 580"},
> + {0x193A, "Iris Pro Graphics P580"},
> + {0x193B, "Iris Pro Graphics 580"},
> + {0x193D, "Iris Pro Graphics P580"},
> +
> + /* Broxton (Apollolake) */
> + {0x5A84, "HD Graphics 505"},
> + {0x5A85, "HD Graphics 500"},
> +
> + /* Kabylake */
> + {0x5916, "HD Graphics 620"},
> + {0x591E, "HD Graphics 615"},
> +
> /* When adding new identifiers, also update:
> * 1. intel_identify()
> * 2. man/intel.man
> @@ -465,7 +492,7 @@ static void intel_identify(int flags)
> if (unique != stack)
> free(unique);
>
> - xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) HD Graphics: 2000-6000\n");
> + xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) HD Graphics: 500-6000/P530/P555/P580\n");
> xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) Iris(TM) Graphics: 5100, 6100\n");
> xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) Iris(TM) Pro Graphics: 5200, 6200, P6300\n");
You missed the Iris & Iris Pro models.
Also, might it make sense to use 5xx, P5xx instead?
Kind regards, David
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [[PATCH ddx]] intel: Adding Marketing names for Skylake, Kabylake and Apollolake/Broxton.
2016-11-17 8:53 ` David Weinehall
@ 2016-11-17 19:06 ` Rodrigo Vivi
2016-11-17 19:35 ` Chris Wilson
0 siblings, 1 reply; 9+ messages in thread
From: Rodrigo Vivi @ 2016-11-17 19:06 UTC (permalink / raw)
To: intel-gfx
On Thu, Nov 17, 2016 at 10:53:04AM +0200, David Weinehall wrote:
> On Tue, Nov 15, 2016 at 02:21:01PM -0800, Rodrigo Vivi wrote:
> > This commit adding all known marketing names for latest gen9 platforms.
> >
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > ---
> > README | 2 +-
> > man/intel.man | 2 +-
> > src/intel_module.c | 29 ++++++++++++++++++++++++++++-
> > 3 files changed, 30 insertions(+), 3 deletions(-)
> >
> > diff --git a/README b/README
> > index cf4d88d..e58477d 100644
> > --- a/README
> > +++ b/README
> > @@ -15,7 +15,7 @@ Intel graphics chipsets including:
> > G/Q33,G/Q35,G41,G/Q43,G/GM/Q45
> > PineView-M (Atom N400 series)
> > PineView-D (Atom D400/D500 series)
> > - Intel(R) HD Graphics: 2000-6000,
> > + Intel(R) HD Graphics: 500-6000/P530/P555/P580,
> > Intel(R) Iris(TM) Graphics: 5100/6100, and
> > Intel(R) Iris(TM) Pro Graphics: 5200/6200/P6300.
> >
> > diff --git a/man/intel.man b/man/intel.man
> > index 8da496e..16cc5d9 100644
> > --- a/man/intel.man
> > +++ b/man/intel.man
> > @@ -27,7 +27,7 @@ supports the i810, i810-DC100, i810e, i815, i830M, 845G, 852GM, 855GM,
> > 865G, 915G, 915GM, 945G, 945GM, 965G, 965Q, 946GZ, 965GM, 945GME,
> > G33, Q33, Q35, G35, GM45, G45, Q45, G43, G41 chipsets, Pineview-M in
> > Atom N400 series, Pineview-D in Atom D400/D500 series,
> > -Intel(R) HD Graphics: 2000-6000,
> > +Intel(R) HD Graphics: 500-6000/P530/P555/P580,
> > Intel(R) Iris(TM) Graphics: 5100/6100, and
> > Intel(R) Iris(TM) Pro Graphics: 5200/6200/P6300.
> >
> > diff --git a/src/intel_module.c b/src/intel_module.c
> > index e443c9e..86b4aae 100644
> > --- a/src/intel_module.c
> > +++ b/src/intel_module.c
> > @@ -272,6 +272,33 @@ static const SymTabRec intel_chipsets[] = {
> > {0x22b2, "HD Graphics"},
> > {0x22b3, "HD Graphics"},
> >
> > + /* Skylake */
> > + {0x1902, "HD Graphics 510"},
> > + {0x1906, "HD Graphics 510"},
> > + {0x190B, "HD Graphics 510"},
> > + {0x1912, "HD Graphics 530"},
> > + {0x1916, "HD Graphics 520"},
> > + {0x191B, "HD Graphics 530"},
> > + {0x191D, "HD Graphics P530"},
> > + {0x191E, "HD Graphics 515"},
> > + {0x1921, "HD Graphics 520"},
> > + {0x1926, "Iris Graphics 540"},
> > + {0x1927, "Iris Graphics 550"},
> > + {0x192B, "Iris Graphics 555"},
> > + {0x192D, "Iris Graphics P555"},
> > + {0x1932, "Iris Pro Graphics 580"},
> > + {0x193A, "Iris Pro Graphics P580"},
> > + {0x193B, "Iris Pro Graphics 580"},
> > + {0x193D, "Iris Pro Graphics P580"},
> > +
> > + /* Broxton (Apollolake) */
> > + {0x5A84, "HD Graphics 505"},
> > + {0x5A85, "HD Graphics 500"},
> > +
> > + /* Kabylake */
> > + {0x5916, "HD Graphics 620"},
> > + {0x591E, "HD Graphics 615"},
> > +
> > /* When adding new identifiers, also update:
> > * 1. intel_identify()
> > * 2. man/intel.man
> > @@ -465,7 +492,7 @@ static void intel_identify(int flags)
> > if (unique != stack)
> > free(unique);
> >
> > - xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) HD Graphics: 2000-6000\n");
> > + xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) HD Graphics: 500-6000/P530/P555/P580\n");
> > xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) Iris(TM) Graphics: 5100, 6100\n");
> > xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) Iris(TM) Pro Graphics: 5200, 6200, P6300\n");
>
> You missed the Iris & Iris Pro models.
Thanks
>
> Also, might it make sense to use 5xx, P5xx instead?
What about ont those generic lists we just kill all numbers and let just:
"
Intel(R) HD Graphics.
Intel(R) Iris(TM) Graphics.
Intel(R) Iris(TM) Pro Graphics.
'
?
Chris?
>
>
> Kind regards, David
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [[PATCH ddx]] intel: Adding Marketing names for Skylake, Kabylake and Apollolake/Broxton.
2016-11-17 19:06 ` Rodrigo Vivi
@ 2016-11-17 19:35 ` Chris Wilson
2016-11-17 21:03 ` Vivi, Rodrigo
0 siblings, 1 reply; 9+ messages in thread
From: Chris Wilson @ 2016-11-17 19:35 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: intel-gfx
On Thu, Nov 17, 2016 at 11:06:54AM -0800, Rodrigo Vivi wrote:
> On Thu, Nov 17, 2016 at 10:53:04AM +0200, David Weinehall wrote:
> > On Tue, Nov 15, 2016 at 02:21:01PM -0800, Rodrigo Vivi wrote:
> > > This commit adding all known marketing names for latest gen9 platforms.
> > >
> > > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > ---
> > > README | 2 +-
> > > man/intel.man | 2 +-
> > > src/intel_module.c | 29 ++++++++++++++++++++++++++++-
> > > 3 files changed, 30 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/README b/README
> > > index cf4d88d..e58477d 100644
> > > --- a/README
> > > +++ b/README
> > > @@ -15,7 +15,7 @@ Intel graphics chipsets including:
> > > G/Q33,G/Q35,G41,G/Q43,G/GM/Q45
> > > PineView-M (Atom N400 series)
> > > PineView-D (Atom D400/D500 series)
> > > - Intel(R) HD Graphics: 2000-6000,
> > > + Intel(R) HD Graphics: 500-6000/P530/P555/P580,
> > > Intel(R) Iris(TM) Graphics: 5100/6100, and
> > > Intel(R) Iris(TM) Pro Graphics: 5200/6200/P6300.
> > >
> > > diff --git a/man/intel.man b/man/intel.man
> > > index 8da496e..16cc5d9 100644
> > > --- a/man/intel.man
> > > +++ b/man/intel.man
> > > @@ -27,7 +27,7 @@ supports the i810, i810-DC100, i810e, i815, i830M, 845G, 852GM, 855GM,
> > > 865G, 915G, 915GM, 945G, 945GM, 965G, 965Q, 946GZ, 965GM, 945GME,
> > > G33, Q33, Q35, G35, GM45, G45, Q45, G43, G41 chipsets, Pineview-M in
> > > Atom N400 series, Pineview-D in Atom D400/D500 series,
> > > -Intel(R) HD Graphics: 2000-6000,
> > > +Intel(R) HD Graphics: 500-6000/P530/P555/P580,
> > > Intel(R) Iris(TM) Graphics: 5100/6100, and
> > > Intel(R) Iris(TM) Pro Graphics: 5200/6200/P6300.
> > >
> > > diff --git a/src/intel_module.c b/src/intel_module.c
> > > index e443c9e..86b4aae 100644
> > > --- a/src/intel_module.c
> > > +++ b/src/intel_module.c
> > > @@ -272,6 +272,33 @@ static const SymTabRec intel_chipsets[] = {
> > > {0x22b2, "HD Graphics"},
> > > {0x22b3, "HD Graphics"},
> > >
> > > + /* Skylake */
> > > + {0x1902, "HD Graphics 510"},
> > > + {0x1906, "HD Graphics 510"},
> > > + {0x190B, "HD Graphics 510"},
> > > + {0x1912, "HD Graphics 530"},
> > > + {0x1916, "HD Graphics 520"},
> > > + {0x191B, "HD Graphics 530"},
> > > + {0x191D, "HD Graphics P530"},
> > > + {0x191E, "HD Graphics 515"},
> > > + {0x1921, "HD Graphics 520"},
> > > + {0x1926, "Iris Graphics 540"},
> > > + {0x1927, "Iris Graphics 550"},
> > > + {0x192B, "Iris Graphics 555"},
> > > + {0x192D, "Iris Graphics P555"},
> > > + {0x1932, "Iris Pro Graphics 580"},
> > > + {0x193A, "Iris Pro Graphics P580"},
> > > + {0x193B, "Iris Pro Graphics 580"},
> > > + {0x193D, "Iris Pro Graphics P580"},
> > > +
> > > + /* Broxton (Apollolake) */
> > > + {0x5A84, "HD Graphics 505"},
> > > + {0x5A85, "HD Graphics 500"},
> > > +
> > > + /* Kabylake */
> > > + {0x5916, "HD Graphics 620"},
> > > + {0x591E, "HD Graphics 615"},
> > > +
> > > /* When adding new identifiers, also update:
> > > * 1. intel_identify()
> > > * 2. man/intel.man
> > > @@ -465,7 +492,7 @@ static void intel_identify(int flags)
> > > if (unique != stack)
> > > free(unique);
> > >
> > > - xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) HD Graphics: 2000-6000\n");
> > > + xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) HD Graphics: 500-6000/P530/P555/P580\n");
> > > xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) Iris(TM) Graphics: 5100, 6100\n");
> > > xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) Iris(TM) Pro Graphics: 5200, 6200, P6300\n");
> >
> > You missed the Iris & Iris Pro models.
>
> Thanks
>
> >
> > Also, might it make sense to use 5xx, P5xx instead?
>
> What about ont those generic lists we just kill all numbers and let just:
> "
> Intel(R) HD Graphics.
> Intel(R) Iris(TM) Graphics.
> Intel(R) Iris(TM) Pro Graphics.
> '
> ?
>
> Chris?
Seems reasonable, and as demonstrated in the past simply listing
everything becomes unwieldy, if not unfathomable, quickly.
I honestly don't think the listing here is the primary source for
compatibility info (since to get here means that the driver recognised
the chipset anyway). For that we can throw into the catch all case in
intel_identify().
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [[PATCH ddx]] intel: Adding Marketing names for Skylake, Kabylake and Apollolake/Broxton.
2016-11-17 19:35 ` Chris Wilson
@ 2016-11-17 21:03 ` Vivi, Rodrigo
2016-11-17 21:23 ` chris
0 siblings, 1 reply; 9+ messages in thread
From: Vivi, Rodrigo @ 2016-11-17 21:03 UTC (permalink / raw)
To: chris; +Cc: intel-gfx
On Thu, 2016-11-17 at 19:35 +0000, Chris Wilson wrote:
> On Thu, Nov 17, 2016 at 11:06:54AM -0800, Rodrigo Vivi wrote:
> > On Thu, Nov 17, 2016 at 10:53:04AM +0200, David Weinehall wrote:
> > > On Tue, Nov 15, 2016 at 02:21:01PM -0800, Rodrigo Vivi wrote:
> > > > This commit adding all known marketing names for latest gen9 platforms.
> > > >
> > > > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > > ---
> > > > README | 2 +-
> > > > man/intel.man | 2 +-
> > > > src/intel_module.c | 29 ++++++++++++++++++++++++++++-
> > > > 3 files changed, 30 insertions(+), 3 deletions(-)
> > > >
> > > > diff --git a/README b/README
> > > > index cf4d88d..e58477d 100644
> > > > --- a/README
> > > > +++ b/README
> > > > @@ -15,7 +15,7 @@ Intel graphics chipsets including:
> > > > G/Q33,G/Q35,G41,G/Q43,G/GM/Q45
> > > > PineView-M (Atom N400 series)
> > > > PineView-D (Atom D400/D500 series)
> > > > - Intel(R) HD Graphics: 2000-6000,
> > > > + Intel(R) HD Graphics: 500-6000/P530/P555/P580,
> > > > Intel(R) Iris(TM) Graphics: 5100/6100, and
> > > > Intel(R) Iris(TM) Pro Graphics: 5200/6200/P6300.
> > > >
> > > > diff --git a/man/intel.man b/man/intel.man
> > > > index 8da496e..16cc5d9 100644
> > > > --- a/man/intel.man
> > > > +++ b/man/intel.man
> > > > @@ -27,7 +27,7 @@ supports the i810, i810-DC100, i810e, i815, i830M, 845G, 852GM, 855GM,
> > > > 865G, 915G, 915GM, 945G, 945GM, 965G, 965Q, 946GZ, 965GM, 945GME,
> > > > G33, Q33, Q35, G35, GM45, G45, Q45, G43, G41 chipsets, Pineview-M in
> > > > Atom N400 series, Pineview-D in Atom D400/D500 series,
> > > > -Intel(R) HD Graphics: 2000-6000,
> > > > +Intel(R) HD Graphics: 500-6000/P530/P555/P580,
> > > > Intel(R) Iris(TM) Graphics: 5100/6100, and
> > > > Intel(R) Iris(TM) Pro Graphics: 5200/6200/P6300.
> > > >
> > > > diff --git a/src/intel_module.c b/src/intel_module.c
> > > > index e443c9e..86b4aae 100644
> > > > --- a/src/intel_module.c
> > > > +++ b/src/intel_module.c
> > > > @@ -272,6 +272,33 @@ static const SymTabRec intel_chipsets[] = {
> > > > {0x22b2, "HD Graphics"},
> > > > {0x22b3, "HD Graphics"},
> > > >
> > > > + /* Skylake */
> > > > + {0x1902, "HD Graphics 510"},
> > > > + {0x1906, "HD Graphics 510"},
> > > > + {0x190B, "HD Graphics 510"},
> > > > + {0x1912, "HD Graphics 530"},
> > > > + {0x1916, "HD Graphics 520"},
> > > > + {0x191B, "HD Graphics 530"},
> > > > + {0x191D, "HD Graphics P530"},
> > > > + {0x191E, "HD Graphics 515"},
> > > > + {0x1921, "HD Graphics 520"},
> > > > + {0x1926, "Iris Graphics 540"},
> > > > + {0x1927, "Iris Graphics 550"},
> > > > + {0x192B, "Iris Graphics 555"},
> > > > + {0x192D, "Iris Graphics P555"},
> > > > + {0x1932, "Iris Pro Graphics 580"},
> > > > + {0x193A, "Iris Pro Graphics P580"},
> > > > + {0x193B, "Iris Pro Graphics 580"},
> > > > + {0x193D, "Iris Pro Graphics P580"},
> > > > +
> > > > + /* Broxton (Apollolake) */
> > > > + {0x5A84, "HD Graphics 505"},
> > > > + {0x5A85, "HD Graphics 500"},
> > > > +
> > > > + /* Kabylake */
> > > > + {0x5916, "HD Graphics 620"},
> > > > + {0x591E, "HD Graphics 615"},
> > > > +
> > > > /* When adding new identifiers, also update:
> > > > * 1. intel_identify()
> > > > * 2. man/intel.man
> > > > @@ -465,7 +492,7 @@ static void intel_identify(int flags)
> > > > if (unique != stack)
> > > > free(unique);
> > > >
> > > > - xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) HD Graphics: 2000-6000\n");
> > > > + xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) HD Graphics: 500-6000/P530/P555/P580\n");
> > > > xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) Iris(TM) Graphics: 5100, 6100\n");
> > > > xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) Iris(TM) Pro Graphics: 5200, 6200, P6300\n");
> > >
> > > You missed the Iris & Iris Pro models.
> >
> > Thanks
> >
> > >
> > > Also, might it make sense to use 5xx, P5xx instead?
> >
> > What about ont those generic lists we just kill all numbers and let just:
> > "
> > Intel(R) HD Graphics.
> > Intel(R) Iris(TM) Graphics.
> > Intel(R) Iris(TM) Pro Graphics.
> > '
> > ?
> >
> > Chris?
>
> Seems reasonable, and as demonstrated in the past simply listing
> everything becomes unwieldy, if not unfathomable, quickly.
>
> I honestly don't think the listing here is the primary source for
> compatibility info
agree
> (since to get here means that the driver recognised
> the chipset anyway).
If it is already recognized at this intel_identify point, is it possible
to grab the device id and than run on that list and only print the know
market name?
or that is better to let there on detect function?
> For that we can throw into the catch all case in
> intel_identify().
What do you mean? throw all this list away? or really list everyone here
on intel_identify but remove the numbers from other plances?
> -Chris
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [[PATCH ddx]] intel: Adding Marketing names for Skylake, Kabylake and Apollolake/Broxton.
2016-11-17 21:03 ` Vivi, Rodrigo
@ 2016-11-17 21:23 ` chris
2016-11-17 22:46 ` [PATCH ddx 1/2] intel: Simplify new platform names Rodrigo Vivi
0 siblings, 1 reply; 9+ messages in thread
From: chris @ 2016-11-17 21:23 UTC (permalink / raw)
To: Vivi, Rodrigo; +Cc: intel-gfx
On Thu, Nov 17, 2016 at 09:03:42PM +0000, Vivi, Rodrigo wrote:
> On Thu, 2016-11-17 at 19:35 +0000, Chris Wilson wrote:
> > On Thu, Nov 17, 2016 at 11:06:54AM -0800, Rodrigo Vivi wrote:
> > > On Thu, Nov 17, 2016 at 10:53:04AM +0200, David Weinehall wrote:
> > > > On Tue, Nov 15, 2016 at 02:21:01PM -0800, Rodrigo Vivi wrote:
> > > > > This commit adding all known marketing names for latest gen9 platforms.
> > > > >
> > > > > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > > > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > > > ---
> > > > > README | 2 +-
> > > > > man/intel.man | 2 +-
> > > > > src/intel_module.c | 29 ++++++++++++++++++++++++++++-
> > > > > 3 files changed, 30 insertions(+), 3 deletions(-)
> > > > >
> > > > > diff --git a/README b/README
> > > > > index cf4d88d..e58477d 100644
> > > > > --- a/README
> > > > > +++ b/README
> > > > > @@ -15,7 +15,7 @@ Intel graphics chipsets including:
> > > > > G/Q33,G/Q35,G41,G/Q43,G/GM/Q45
> > > > > PineView-M (Atom N400 series)
> > > > > PineView-D (Atom D400/D500 series)
> > > > > - Intel(R) HD Graphics: 2000-6000,
> > > > > + Intel(R) HD Graphics: 500-6000/P530/P555/P580,
> > > > > Intel(R) Iris(TM) Graphics: 5100/6100, and
> > > > > Intel(R) Iris(TM) Pro Graphics: 5200/6200/P6300.
> > > > >
> > > > > diff --git a/man/intel.man b/man/intel.man
> > > > > index 8da496e..16cc5d9 100644
> > > > > --- a/man/intel.man
> > > > > +++ b/man/intel.man
> > > > > @@ -27,7 +27,7 @@ supports the i810, i810-DC100, i810e, i815, i830M, 845G, 852GM, 855GM,
> > > > > 865G, 915G, 915GM, 945G, 945GM, 965G, 965Q, 946GZ, 965GM, 945GME,
> > > > > G33, Q33, Q35, G35, GM45, G45, Q45, G43, G41 chipsets, Pineview-M in
> > > > > Atom N400 series, Pineview-D in Atom D400/D500 series,
> > > > > -Intel(R) HD Graphics: 2000-6000,
> > > > > +Intel(R) HD Graphics: 500-6000/P530/P555/P580,
> > > > > Intel(R) Iris(TM) Graphics: 5100/6100, and
> > > > > Intel(R) Iris(TM) Pro Graphics: 5200/6200/P6300.
> > > > >
> > > > > diff --git a/src/intel_module.c b/src/intel_module.c
> > > > > index e443c9e..86b4aae 100644
> > > > > --- a/src/intel_module.c
> > > > > +++ b/src/intel_module.c
> > > > > @@ -272,6 +272,33 @@ static const SymTabRec intel_chipsets[] = {
> > > > > {0x22b2, "HD Graphics"},
> > > > > {0x22b3, "HD Graphics"},
> > > > >
> > > > > + /* Skylake */
> > > > > + {0x1902, "HD Graphics 510"},
> > > > > + {0x1906, "HD Graphics 510"},
> > > > > + {0x190B, "HD Graphics 510"},
> > > > > + {0x1912, "HD Graphics 530"},
> > > > > + {0x1916, "HD Graphics 520"},
> > > > > + {0x191B, "HD Graphics 530"},
> > > > > + {0x191D, "HD Graphics P530"},
> > > > > + {0x191E, "HD Graphics 515"},
> > > > > + {0x1921, "HD Graphics 520"},
> > > > > + {0x1926, "Iris Graphics 540"},
> > > > > + {0x1927, "Iris Graphics 550"},
> > > > > + {0x192B, "Iris Graphics 555"},
> > > > > + {0x192D, "Iris Graphics P555"},
> > > > > + {0x1932, "Iris Pro Graphics 580"},
> > > > > + {0x193A, "Iris Pro Graphics P580"},
> > > > > + {0x193B, "Iris Pro Graphics 580"},
> > > > > + {0x193D, "Iris Pro Graphics P580"},
> > > > > +
> > > > > + /* Broxton (Apollolake) */
> > > > > + {0x5A84, "HD Graphics 505"},
> > > > > + {0x5A85, "HD Graphics 500"},
> > > > > +
> > > > > + /* Kabylake */
> > > > > + {0x5916, "HD Graphics 620"},
> > > > > + {0x591E, "HD Graphics 615"},
> > > > > +
> > > > > /* When adding new identifiers, also update:
> > > > > * 1. intel_identify()
> > > > > * 2. man/intel.man
> > > > > @@ -465,7 +492,7 @@ static void intel_identify(int flags)
> > > > > if (unique != stack)
> > > > > free(unique);
> > > > >
> > > > > - xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) HD Graphics: 2000-6000\n");
> > > > > + xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) HD Graphics: 500-6000/P530/P555/P580\n");
> > > > > xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) Iris(TM) Graphics: 5100, 6100\n");
> > > > > xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) Iris(TM) Pro Graphics: 5200, 6200, P6300\n");
> > > >
> > > > You missed the Iris & Iris Pro models.
> > >
> > > Thanks
> > >
> > > >
> > > > Also, might it make sense to use 5xx, P5xx instead?
> > >
> > > What about ont those generic lists we just kill all numbers and let just:
> > > "
> > > Intel(R) HD Graphics.
> > > Intel(R) Iris(TM) Graphics.
> > > Intel(R) Iris(TM) Pro Graphics.
> > > '
> > > ?
> > >
> > > Chris?
> >
> > Seems reasonable, and as demonstrated in the past simply listing
> > everything becomes unwieldy, if not unfathomable, quickly.
> >
> > I honestly don't think the listing here is the primary source for
> > compatibility info
>
> agree
>
> > (since to get here means that the driver recognised
> > the chipset anyway).
>
> If it is already recognized at this intel_identify point, is it possible
> to grab the device id and than run on that list and only print the know
> market name?
> or that is better to let there on detect function?
>
>
> > For that we can throw into the catch all case in
> > intel_identify().
>
> What do you mean? throw all this list away? or really list everyone here
> on intel_identify but remove the numbers from other plances?
Sorry, not intel_identify(), but intel_detect_chipset() prints the
exact marketing name if known. It's what to print when it is unknown
that worries me most.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH ddx 1/2] intel: Simplify new platform names.
2016-11-17 21:23 ` chris
@ 2016-11-17 22:46 ` Rodrigo Vivi
2016-11-17 22:46 ` [PATCH ddx 2/2] intel: Adding Marketing names for Skylake, Kabylake and Apollolake/Broxton Rodrigo Vivi
0 siblings, 1 reply; 9+ messages in thread
From: Rodrigo Vivi @ 2016-11-17 22:46 UTC (permalink / raw)
To: intel-gfx; +Cc: Rodrigo Vivi
Modern Intel (R) platforms with integrated graphics comes with common
names varying the range numbers. So instead of listing all supported
platforms let's start using the generic marketing strings without
the numbers.
And for the specific board we list it's actual marketing name if
available on detection.
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
README | 6 +++---
man/intel.man | 6 +++---
src/intel_module.c | 6 +++---
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/README b/README
index cf4d88d..348983b 100644
--- a/README
+++ b/README
@@ -15,9 +15,9 @@ Intel graphics chipsets including:
G/Q33,G/Q35,G41,G/Q43,G/GM/Q45
PineView-M (Atom N400 series)
PineView-D (Atom D400/D500 series)
- Intel(R) HD Graphics: 2000-6000,
- Intel(R) Iris(TM) Graphics: 5100/6100, and
- Intel(R) Iris(TM) Pro Graphics: 5200/6200/P6300.
+ Intel(R) HD Graphics,
+ Intel(R) Iris(TM) Graphics,
+ Intel(R) Iris(TM) Pro Graphics.
Where to get more information about the driver
----------------------------------------------
diff --git a/man/intel.man b/man/intel.man
index 8da496e..be398fb 100644
--- a/man/intel.man
+++ b/man/intel.man
@@ -27,9 +27,9 @@ supports the i810, i810-DC100, i810e, i815, i830M, 845G, 852GM, 855GM,
865G, 915G, 915GM, 945G, 945GM, 965G, 965Q, 946GZ, 965GM, 945GME,
G33, Q33, Q35, G35, GM45, G45, Q45, G43, G41 chipsets, Pineview-M in
Atom N400 series, Pineview-D in Atom D400/D500 series,
-Intel(R) HD Graphics: 2000-6000,
-Intel(R) Iris(TM) Graphics: 5100/6100, and
-Intel(R) Iris(TM) Pro Graphics: 5200/6200/P6300.
+Intel(R) HD Graphics,
+Intel(R) Iris(TM) Graphics,
+Intel(R) Iris(TM) Pro Graphics.
.SH CONFIGURATION DETAILS
Please refer to __xconfigfile__(__filemansuffix__) for general configuration
diff --git a/src/intel_module.c b/src/intel_module.c
index e443c9e..aeec685 100644
--- a/src/intel_module.c
+++ b/src/intel_module.c
@@ -465,9 +465,9 @@ static void intel_identify(int flags)
if (unique != stack)
free(unique);
- xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) HD Graphics: 2000-6000\n");
- xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) Iris(TM) Graphics: 5100, 6100\n");
- xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) Iris(TM) Pro Graphics: 5200, 6200, P6300\n");
+ xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) HD Graphics\n");
+ xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) Iris(TM) Graphics\n");
+ xf86Msg(X_INFO, INTEL_NAME ": Driver for Intel(R) Iris(TM) Pro Graphics\n");
}
static Bool intel_driver_func(ScrnInfoPtr pScrn,
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH ddx 2/2] intel: Adding Marketing names for Skylake, Kabylake and Apollolake/Broxton.
2016-11-17 22:46 ` [PATCH ddx 1/2] intel: Simplify new platform names Rodrigo Vivi
@ 2016-11-17 22:46 ` Rodrigo Vivi
2016-11-28 22:54 ` Rodrigo Vivi
0 siblings, 1 reply; 9+ messages in thread
From: Rodrigo Vivi @ 2016-11-17 22:46 UTC (permalink / raw)
To: intel-gfx; +Cc: Rodrigo Vivi
This commit adding all known marketing names for latest gen9 platforms.
v2: On top of simplified generic string names.
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
src/intel_module.c | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/src/intel_module.c b/src/intel_module.c
index aeec685..f15a4c0 100644
--- a/src/intel_module.c
+++ b/src/intel_module.c
@@ -272,6 +272,33 @@ static const SymTabRec intel_chipsets[] = {
{0x22b2, "HD Graphics"},
{0x22b3, "HD Graphics"},
+ /* Skylake */
+ {0x1902, "HD Graphics 510"},
+ {0x1906, "HD Graphics 510"},
+ {0x190B, "HD Graphics 510"},
+ {0x1912, "HD Graphics 530"},
+ {0x1916, "HD Graphics 520"},
+ {0x191B, "HD Graphics 530"},
+ {0x191D, "HD Graphics P530"},
+ {0x191E, "HD Graphics 515"},
+ {0x1921, "HD Graphics 520"},
+ {0x1926, "Iris Graphics 540"},
+ {0x1927, "Iris Graphics 550"},
+ {0x192B, "Iris Graphics 555"},
+ {0x192D, "Iris Graphics P555"},
+ {0x1932, "Iris Pro Graphics 580"},
+ {0x193A, "Iris Pro Graphics P580"},
+ {0x193B, "Iris Pro Graphics 580"},
+ {0x193D, "Iris Pro Graphics P580"},
+
+ /* Broxton (Apollolake) */
+ {0x5A84, "HD Graphics 505"},
+ {0x5A85, "HD Graphics 500"},
+
+ /* Kabylake */
+ {0x5916, "HD Graphics 620"},
+ {0x591E, "HD Graphics 615"},
+
/* When adding new identifiers, also update:
* 1. intel_identify()
* 2. man/intel.man
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH ddx 2/2] intel: Adding Marketing names for Skylake, Kabylake and Apollolake/Broxton.
2016-11-17 22:46 ` [PATCH ddx 2/2] intel: Adding Marketing names for Skylake, Kabylake and Apollolake/Broxton Rodrigo Vivi
@ 2016-11-28 22:54 ` Rodrigo Vivi
0 siblings, 0 replies; 9+ messages in thread
From: Rodrigo Vivi @ 2016-11-28 22:54 UTC (permalink / raw)
To: Rodrigo Vivi, Chris Wilson; +Cc: intel-gfx
Chris,
any comments?
what is still missing?
Thanks,
Rodrigo.
On Thu, Nov 17, 2016 at 2:46 PM, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> This commit adding all known marketing names for latest gen9 platforms.
>
> v2: On top of simplified generic string names.
>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> src/intel_module.c | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/src/intel_module.c b/src/intel_module.c
> index aeec685..f15a4c0 100644
> --- a/src/intel_module.c
> +++ b/src/intel_module.c
> @@ -272,6 +272,33 @@ static const SymTabRec intel_chipsets[] = {
> {0x22b2, "HD Graphics"},
> {0x22b3, "HD Graphics"},
>
> + /* Skylake */
> + {0x1902, "HD Graphics 510"},
> + {0x1906, "HD Graphics 510"},
> + {0x190B, "HD Graphics 510"},
> + {0x1912, "HD Graphics 530"},
> + {0x1916, "HD Graphics 520"},
> + {0x191B, "HD Graphics 530"},
> + {0x191D, "HD Graphics P530"},
> + {0x191E, "HD Graphics 515"},
> + {0x1921, "HD Graphics 520"},
> + {0x1926, "Iris Graphics 540"},
> + {0x1927, "Iris Graphics 550"},
> + {0x192B, "Iris Graphics 555"},
> + {0x192D, "Iris Graphics P555"},
> + {0x1932, "Iris Pro Graphics 580"},
> + {0x193A, "Iris Pro Graphics P580"},
> + {0x193B, "Iris Pro Graphics 580"},
> + {0x193D, "Iris Pro Graphics P580"},
> +
> + /* Broxton (Apollolake) */
> + {0x5A84, "HD Graphics 505"},
> + {0x5A85, "HD Graphics 500"},
> +
> + /* Kabylake */
> + {0x5916, "HD Graphics 620"},
> + {0x591E, "HD Graphics 615"},
> +
> /* When adding new identifiers, also update:
> * 1. intel_identify()
> * 2. man/intel.man
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-11-28 22:54 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-15 22:21 [[PATCH ddx]] intel: Adding Marketing names for Skylake, Kabylake and Apollolake/Broxton Rodrigo Vivi
2016-11-17 8:53 ` David Weinehall
2016-11-17 19:06 ` Rodrigo Vivi
2016-11-17 19:35 ` Chris Wilson
2016-11-17 21:03 ` Vivi, Rodrigo
2016-11-17 21:23 ` chris
2016-11-17 22:46 ` [PATCH ddx 1/2] intel: Simplify new platform names Rodrigo Vivi
2016-11-17 22:46 ` [PATCH ddx 2/2] intel: Adding Marketing names for Skylake, Kabylake and Apollolake/Broxton Rodrigo Vivi
2016-11-28 22:54 ` Rodrigo Vivi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.